[Flightgear-devel] patch: some code (warnings) cleanup
hello list,
if done some code cleanup included in the attached patch.
it includes:
- signeness corrections
- constructor initializer order fixes
- remove of some extras ';'
- initialization of uninitialized values
- remove of some unused variables
- complietion of some switch blocks over enums
i've reviewed only a part of the code, so maybe i will send some more
patches in the next days.
cu Markus
--
Markus Barenhoff - phone: +49-40-39991368 - cell: +49-173-7215776
Stellinger Chaussee 26c - D-22529 Hamburg - Germany - Earth
url: http://www.alios.org/ - mail: [EMAIL PROTECTED]
pgpkey: 0xAE7C7759 fp: 79 64 AA D9 B7 16 F5 06 6A 88 5F A9 4D 49 45 BB
Index: configure.ac
===
RCS file: /var/cvs/FlightGear-0.9/source/configure.ac,v
retrieving revision 1.119
diff -r1.119 configure.ac
345,346d344
int major, minor, micro;
Index: src/ATC/ATCDialog.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/ATC/ATCDialog.cxx,v
retrieving revision 1.31
diff -r1.31 ATCDialog.cxx
259c259
void FGATCDialog::PopupCallback(int num) {
---
void FGATCDialog::PopupCallback(unsigned int num) {
Index: src/ATC/ATCDialog.hxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/ATC/ATCDialog.hxx,v
retrieving revision 1.9
diff -r1.9 ATCDialog.hxx
75c75
void PopupCallback(int);
---
void PopupCallback(unsigned int);
Index: src/ATC/ground.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/ATC/ground.cxx,v
retrieving revision 1.24
diff -r1.24 ground.cxx
501c501
};
---
}
Index: src/Airports/groundnetwork.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/Airports/groundnetwork.cxx,v
retrieving revision 1.5
diff -r1.5 groundnetwork.cxx
125c125
};
---
}
146c146,147
};
---
}
207,208c208,210
double course, dist;
int index;
---
double dist;
int index = 0;
261d262
FGTaxiNode *lastNode = findNode(end);
359d359
int idx = (*i)-getIndex();
Index: src/Environment/environment.hxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/Environment/environment.hxx,v
retrieving revision 1.7
diff -r1.7 environment.hxx
135,137d134
double altitude_half_to_sun_m;
double altitude_tropo_top_m;
147a145,147
double altitude_half_to_sun_m;
double altitude_tropo_top_m;
Index: src/Environment/environment_ctrl.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/Environment/environment_ctrl.cxx,v
retrieving revision 1.46
diff -r1.46 environment_ctrl.cxx
327a328
last_apt(0),
335,336c336
_error_dt( 0.0 ),
last_apt(0)
---
_error_dt( 0.0 )
Index: src/Environment/fgclouds.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/Environment/fgclouds.cxx,v
retrieving revision 1.11
diff -r1.11 fgclouds.cxx
49,50d48
station_elevation_ft(0.0),
_controller( controller ),
52c50,52
last_scenario( none ),
---
_controller( controller ),
station_elevation_ft(0.0),
last_scenario( none ),
202d201
double wind_speed_kt = metar_root-getDoubleValue(wind-speed-kt);
215,216d213
bool cu_seen = false;
Index: src/FDM/Balloon/BalloonSim.cpp
===
RCS file: /var/cvs/FlightGear-0.9/source/src/FDM/Balloon/BalloonSim.cpp,v
retrieving revision 1.6
diff -r1.6 BalloonSim.cpp
205c205,206
sgVec3 fTotal, fFriction, fLift;
---
sgVec3 fTotal;
//sgVec3 fFriction, fLift;
Index: src/FDM/JSBSim/FGFDMExec.cpp
===
RCS file: /var/cvs/FlightGear-0.9/source/src/FDM/JSBSim/FGFDMExec.cpp,v
retrieving revision 1.18
diff -r1.18 FGFDMExec.cpp
295c295
for (int i=0; iOutputs.size(); i++) {
---
for (unsigned int i=0; iOutputs.size(); i++) {
548c548
for (int i=0; iPropertyCatalog.size(); i++) {
---
for (unsigned int i=0; iPropertyCatalog.size(); i++) {
707c707
for (int i=0; iOutputs.size(); i++) {
---
for (unsigned int i=0; iOutputs.size(); i++) {
716c716
for (int i=0; iOutputs.size(); i++) {
---
for (unsigned int i=0; iOutputs.size(); i++) {
Index: src/FDM/JSBSim/JSBSim.cxx
===
RCS file: /var/cvs/FlightGear-0.9/source/src/FDM/JSBSim/JSBSim.cxx,v
retrieving revision 1.39
diff -r1.39 JSBSim.cxx
321c321
for (int i=0; i Propulsion-GetNumEngines(); i++) {
---
for (unsigned int i=0; i Propulsion-GetNumEngines(); i++) {
411c411
double alt, slr, lat, lon;
---
double alt = 0.0f, slr = 0.0f, lat = 0.0f, lon = 0.0f;
Re: [Flightgear-devel] patch: some code (warnings) cleanup
* Markus Barenhoff -- Sunday 13 August 2006 14:52: if done some code cleanup included in the attached patch. Eew ... not a unified context diff. I'd be fine with most of this, except this: RCS file: /var/cvs/FlightGear-0.9/source/src/GUI/dialog.cxx,v retrieving revision 1.87 diff -r1.87 dialog.cxx 879c879 ALT = 0x4, --- ALT = 0x4 What's the problem with the trailing comma? It's there so that one can easily add more constants or move others around. This patch serves no purpose, other than to annoy developers. :-} Being able to compile all of sg/fgfs without compiler warnings would be nice and would make real problems stick out. Of course, different compilers will show different warnings, and some may only be avoidable with adding ugly code, but ... m. :-) - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Seahawk
Hi, Melchior has produced a nice addition to the Seahawk: the managed view. This adjusts the pilot's view to where he might look during manoeuvres. I have adjusted the g-effects (black/red-out and head shake) to suit. We think it makes a worthwhile enhancement to the realism of flying the Seahawk. It's in cvs now - enjoy. We welcome any comments that you might have. Vivian - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Bug in mp-visibility of planes?
HI Matthias, Mathias Fröhlich wrote: Maik, On Monday 31 July 2006 23:49, Maik Justus wrote: And there is another bug. If someone left the game, the plane is displayed on my computer for ever. Maybe it's possible to use a time flag, when the last position update for a plane was received. If this flag is older than a threshold, the plane could be deleted? yes, I have the same problem with the cvs version. For cvs I am using msvc express while 9.10 I used the compiled windows file. We did our best to reproduce your problems with current cvs HEAD on Windows. Without luck! :) That is: - Aircraft disappeared past 10 seconds if a multiplayer left the game. - A non existent model does not stop a new existing models from being displayed. Can you provide us more information about that? Greetings Mathias I still have this problem. Can you tell me, where in the source the 10 seconds timeout are tested? Then I can try, to find more detailed information. Thank you, Maik - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Bug in mp-visibility of planes?
Hi Maik, On Sunday 13 August 2006 21:15, Maik Justus wrote: I still have this problem. Can you tell me, where in the source the 10 seconds timeout are tested? Then I can try, to find more detailed information. That would be great! That happens around line 420 in src/MultiPlayer/multiplaymgr.cxx. Greetings Mathias - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] crash in groundnetwork
Hi Durk, On Saturday 12 August 2006 00:32, Durk Talsma wrote: Btw, where did you experience these problems (which airport), and how did they manifest themselves? Program crashes? I've been running recent versions of FlightGear using the EHAM groundnetwork, and hadn't seen any problem yet. It's possible that it's something that only shows up at KSFO (which I haven't tested so much yet). Yes that was at KSFO. Flightgear died just at startup in that code. We had active multiplayers enabled. BTW, I predict that if you used the routesStack.emty() guard, the progam was crashing in TaxiRoute.next(), because the (nodes.size() == (routes.size()) +1 condition was not met anymore. I did include a test for this condition, but since it was always true on my system, I commented it out. My estimate is that the solution is fairly easy, and I'll probably have something by Tuesday (I'll be out of town on the weekend). Thanks! Greetings Mathias - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Abrupt wind visibility changes with real weather fetch
Hi all, it occurred to me that a relatively simple solution to the abrupt wind and visibility changes we get when using real weather fetch would be to write the 'fetched' data to an 'incoming' weather branch in the property tree and then use nasal listeners on each leaf to interpolate the values. If the interpolation time were to be based on the aircraft speed it would give interpolation over distance, instead of a simple interpolation over time, which would probably be a bit more realistic. LeeE - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
