Re: [Flightgear-devel] [patch] Segfault bugfix
Clément I have just had another chance to do some tests. There are no more crashes on exit, reset or position-in-air. I can change sound devices. I hear your ATIS, but no music (911.00) or music. I will try with another aircraft later to see if that is the problem. Alan From: Clement de l'Hamaide Sent: Thursday, August 22, 2013 10:02 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] [patch] Segfault bugfix Alan, My precedent fix has certinaly solved your reset/reposition-in-air crash. guest/guest account is correct. You should be able to use the echo test by checking the checkbox Test once you have enabled FGCom, and so you should hear your echo. Is it working ? Another test you can do: open the radio dialog (F12) then set frequency 911.00MHz, now you should hear music. Is it working ? Last test, flying around Toulouse (LFBO), set frequency 123.125MHz, now you should hear my ATIS message. Is it working ? About crash at close, it seems to be only with Windows, I hope James will be able to do some test with his Windows machine. Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] [patch] Segfault bugfix
Hi all,
I've found a bug in the new integrated fgcom, which would cause a crash in
the following case:
1) start flightgear without fgcom activated (just the default cessna, at
KSFO)
2) Start the tutorial Straight in landing
3) Crash
I suspect it would crash on reset as well, but I haven't tested that
This small patch fixes it for me:
diff --git a/src/Network/fgcom.cxx b/src/Network/fgcom.cxx
index f57b75c..874d026 100644
--- a/src/Network/fgcom.cxx
+++ b/src/Network/fgcom.cxx
@@ -483,10 +483,12 @@ void FGCom::testMode(bool testMode)
if( _callComm0 == -1 )
SG_LOG( SG_IO, SG_ALERT, FGCom cannot call selected freq (test
mode) );
} else {
-iaxc_dump_call_number(_callComm0);
+/*
+ iaxc_dump_call_number(_callComm0);
iaxc_millisleep(IAX_DELAY);
_callComm0 = -1;
_enabled = true;
+*/
}
}
I'm not quite sure what the commented out code is supposed to do, but it
seems pretty harmless to comment it out. The crucial line is: _enabled =
true; This makes other code assume that IAXClient has been properly
initialised, which it hasn't, causing a null pointer deref inside IAXClient
later on.
Stefan
--
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [patch] Segfault bugfix
This is now fixed ! Thanks you for your report Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [patch] Segfault bugfix
Sorry, but FG crashes here when I do a position-in-air from the position menu. There is no problem when I Cmake with ENABLE_IAX not set. I have not set --enable-fgcom in my command line. Windows VS2010, 64 bit. Alan From: Clement de l'Hamaide Sent: Thursday, August 22, 2013 1:43 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] [patch] Segfault bugfix This is now fixed ! Thanks you for your report Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [patch] Segfault bugfix
Alan, Unfortunately I'm not able to reproduce the crash you describe here on Linux. Considering you use the last source code, I would wait that james set up his Windows machine to investigate this. Since you are a Windows user I would have some questions: - Does/ FGCom integrated is working for you ? You can try with a simple echo test - Are you able to enable/disable FGCom integrated at runtime ? - Does FG crashing when you Reset (File Reset) ? - Are you able to switch sound device in File Sound configuration with FGCom interated enabled ? (Hoping you have more than 1 sound device) - Does FG crashing at close (File Quit) ? All these test must be done with an uptodate fgdata and flightgear. Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [patch] Segfault bugfix
Clément The results of my tests are a bit confusing. FG crashes on File Quit. I can switch sound devices. The FGCom menu acts as described in the wiki, however I hear no sounds. Is the guest/guest account setting good for testing? Should I also set any radio frequencies or sound options? The first time that I tried reset and reposition-in-air, FG crashed, but I can not repeat this. Alan From: Clement de l'Hamaide Sent: Thursday, August 22, 2013 5:44 PM To: flightgear-devel@lists.sourceforge.net Subject: Re: [Flightgear-devel] [patch] Segfault bugfix Alan, Unfortunately I'm not able to reproduce the crash you describe here on Linux. Considering you use the last source code, I would wait that james set up his Windows machine to investigate this. Since you are a Windows user I would have some questions: - Does/ FGCom integrated is working for you ? You can try with a simple echo test - Are you able to enable/disable FGCom integrated at runtime ? - Does FG crashing when you Reset (File Reset) ? - Are you able to switch sound device in File Sound configuration with FGCom interated enabled ? (Hoping you have more than 1 sound device) - Does FG crashing at close (File Quit) ? All these test must be done with an uptodate fgdata and flightgear. Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] [patch] Segfault bugfix
Alan, My precedent fix has certinaly solved your reset/reposition-in-air crash. guest/guest account is correct. You should be able to use the echo test by checking the checkbox Test once you have enabled FGCom, and so you should hear your echo. Is it working ? Another test you can do: open the radio dialog (F12) then set frequency 911.00MHz, now you should hear music. Is it working ? Last test, flying around Toulouse (LFBO), set frequency 123.125MHz, now you should hear my ATIS message. Is it working ? About crash at close, it seems to be only with Windows, I hope James will be able to do some test with his Windows machine. Regards, Clément -- Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
