Re: [Flightgear-devel] A patch to prevent multiple loading AIModels on reset
Tatsuhiro Nishioka wrote: So here is my suggestion. First, we use my patch as a temporal fix just to prevent the fps drop. Second, we investigate a reasonable means of loading and unloading AIModels on reset (and remove my patch). Any opinions? Sounds good to me. Erik - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] A patch to prevent multiple loading AIModels on reset
Tatsuhiro Nishioka wrote: Hi forks, I've encountered a weird fps drop in resetting on Nimitz (with --carrier=Nimitz). It happens since AIBase loads AIModels on every reset, which should not. The same problem happened on 0.9.11-pre2 and I made a patch to fix it, but the patch was not applied to CVS/OSG version. I even didn't realize that it also happen on CVS/OSG but it actually does. Anyway, enclosed is a patch to fix this issue. Please check if it works and get it committed. Hmm, I see the problem but am not completely sure not loading the models again after a reset is the right way to fix it. Personally I think that the reset should have removed them from memory in the first place. Erik - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] A patch to prevent multiple loading AIModels on reset
Hi Erik, Great to hear your idea, which makes me want to investigate on this deeper. As you said, removing models at the beginning of reset, and then loading needed models again apparently looks better to me. However, it seems it takes longer for me to investigate on this since I'm not that familiar with model loadings. Thus, I want to ask Till and Tim to find a better means of handle this issue. I'll also sneak around the code to see what is the better way. It might also takes a bit while for the better way. Plus, Durk was kindly committed my patch. (thanks!) So here is my suggestion. First, we use my patch as a temporal fix just to prevent the fps drop. Second, we investigate a reasonable means of loading and unloading AIModels on reset (and remove my patch). Any opinions? Best, Tat p.s. Tim, I've tested what you said on IRC, and I think that running last two lines of FGAIBase::init on reset would be OK so far. My patch is gonna be useless by the time the better way is introduced, but I just want to let you know. On Aug 3, 2008, at 11:24 PM, Erik Hofman wrote: Tatsuhiro Nishioka wrote: Hi forks, I've encountered a weird fps drop in resetting on Nimitz (with --carrier=Nimitz). It happens since AIBase loads AIModels on every reset, which should not. The same problem happened on 0.9.11-pre2 and I made a patch to fix it, but the patch was not applied to CVS/OSG version. I even didn't realize that it also happen on CVS/OSG but it actually does. Anyway, enclosed is a patch to fix this issue. Please check if it works and get it committed. Hmm, I see the problem but am not completely sure not loading the models again after a reset is the right way to fix it. Personally I think that the reset should have removed them from memory in the first place. Erik - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/ ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] A patch to prevent multiple loading AIModels on reset
Hi forks, I've encountered a weird fps drop in resetting on Nimitz (with --carrier=Nimitz). It happens since AIBase loads AIModels on every reset, which should not. The same problem happened on 0.9.11-pre2 and I made a patch to fix it, but the patch was not applied to CVS/OSG version. I even didn't realize that it also happen on CVS/OSG but it actually does. Anyway, enclosed is a patch to fix this issue. Please check if it works and get it committed. Best, Tat p.s. FYI, you can see the patch I posted for 0.9.11-pre2 at: http://www.mail-archive.com/flightgear-devel@lists.sourceforge.net/msg14127.html AIModel-multiple-loading-fix.diff Description: Binary data - This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100url=/___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
