Re: [Flightgear-devel] MK VIII EGPWS emulation
Jean-Yves Lefort wrote : Feel free to commit; thanks for your work. Ok, the instrument itself is commited. Now I would like to have a formal acceptance from Syd Adams ( copied in the dest list of this mail ) before commiting the changes to the b1900d. Syd ? -Fred PS: I am out of town next week. -- Frédéric Bouvier http://frfoto.free.fr Photo gallery - album photo http://www.fotolia.fr/p/2278 Other photo gallery http://fgsd.sourceforge.net/ FlightGear Scenery Designer --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid0944bid$1720dat1642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Curtis L. Olson a écrit : Frederic Bouvier wrote: I am trying to integrate this contribution in the code base but after too much hours spent on this, I finally won't. Three reasons : - it doesn't compiles under MSVC, for obscure reason I don't understand. - there are a lot of files for the base package that are not strictly needed at run times : lots of .xcf files ( gimp source ), xml files that are not property files, xsl files. - it doesn't use the present convention of being included in a single directory : separated extern texture directory, Assembly (?) directory. So I left to others the choice of including it or not. This patch is not straightforward ( lots of template, imbrication level and inlines of all sort, including the use of function pointers to inline code ) and requires a lot of time to sort things out. Hi Fred, Thanks for taking such a detailed look at the source. As a general rule, we do our best to include contributions, but there are times where patches simply can't be applied in their current form. We feel bad about it, we hate to see wasted work, but it occasionally happens and can happen for a variety of reasons. I've seen everything from I didn't know what that section of code did so I deleted it, to this patch is mostly broke, but I expect you'll seek out, debug, and fix all the problems, all the way up to huge massive patches that touch darn near every file in the project in a variety of scary and hard to decipher ways. Gimp source isn't necessarily bad because it allows others to more easily edit the graphics, but they can burn a lot of space. Perhaps this developer would be willing to work with the core developers to make what ever changes are needed so the patch is acceptable (such as more closely following existing conventions and making code changes so we don't break any cross platform portability.) Hello Jean-Yves, Night bringing advice, I fixed the MSVC issues and also fixed other bugs reported by the compilers, or by segfaults I also moved the assembly directory inside the mk-viii directory to keep things encapsulated. My changes are in this file : http://frbouvi.free.fr/flightsim/mk-viii-fb.tar.gz If you agree with them, just tell me and I will commit them. Regards, -Fred --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid0944bid$1720dat1642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Curtis L. Olson wrote : I've seen everything from I didn't know what that section of code did so I deleted it, to this patch is mostly broke, but I expect you'll seek out, debug, and fix all the problems, all the way up to huge massive patches that touch darn near every file in the project in a variety of scary and hard to decipher ways. Do you refer to my last patch ? ;-) -Fred --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Frederic Bouvier wrote: Curtis L. Olson wrote : I've seen everything from I didn't know what that section of code did so I deleted it, to this patch is mostly broke, but I expect you'll seek out, debug, and fix all the problems, all the way up to huge massive patches that touch darn near every file in the project in a variety of scary and hard to decipher ways. Do you refer to my last patch ? ;-) If you are not sure if I'm referring to you, then I am probably not. :-) Curt. -- Curtis Olsonhttp://www.flightgear.org/~curt HumanFIRST Program http://www.humanfirst.umn.edu/ FlightGear Project http://www.flightgear.org Unique text:2f585eeea02e2c79d7b1d8c4963bae2d --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
On Wednesday 22 February 2006 23:49, Jean-Yves Lefort wrote: Did you checked with the author of the B1900D ( Syd Adams ? ) that your proposed change doesn't conflict with his current work, if any ? No. Someone will need to ask if he approves the b1900d changes. Is there any reason why this nice feature can't be added to CVS now? Syd can speak for himself, but I know he was aware of the work to produce the GPWS quite some time ago and didn't object then... Of course the B1900D is not the only possible candidate to benefit from such a device anyway. Just wanted to raise the issue again - it would seem a shame for the work done to be forgotten about and wasted... Cheers, AJ --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
I agree this should be added to the cvs A.S.A.P Justin Smithies On Friday 03 March 2006 17:17, AJ MacLeod wrote: On Wednesday 22 February 2006 23:49, Jean-Yves Lefort wrote: Did you checked with the author of the B1900D ( Syd Adams ? ) that your proposed change doesn't conflict with his current work, if any ? No. Someone will need to ask if he approves the b1900d changes. Is there any reason why this nice feature can't be added to CVS now? Syd can speak for himself, but I know he was aware of the work to produce the GPWS quite some time ago and didn't object then... Of course the B1900D is not the only possible candidate to benefit from such a device anyway. Just wanted to raise the issue again - it would seem a shame for the work done to be forgotten about and wasted... Cheers, AJ --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Our main cvs committer resigned and this is a pretty substantial patch and a large amount of work to apply and I just haven't had time. I went out of town twice in Feb. and I still am a long ways away from getting caught up from the backlog of those trips. The desire is there, but speaking for myself personally, not the time (yet.) Curt. Justin Smithies wrote: I agree this should be added to the cvs A.S.A.P Justin Smithies On Friday 03 March 2006 17:17, AJ MacLeod wrote: On Wednesday 22 February 2006 23:49, Jean-Yves Lefort wrote: Did you checked with the author of the B1900D ( Syd Adams ? ) that your proposed change doesn't conflict with his current work, if any ? No. Someone will need to ask if he approves the b1900d changes. Is there any reason why this nice feature can't be added to CVS now? Syd can speak for himself, but I know he was aware of the work to produce the GPWS quite some time ago and didn't object then... Of course the B1900D is not the only possible candidate to benefit from such a device anyway. Just wanted to raise the issue again - it would seem a shame for the work done to be forgotten about and wasted... Cheers, AJ --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Curtis Olsonhttp://www.flightgear.org/~curt HumanFIRST Program http://www.humanfirst.umn.edu/ FlightGear Project http://www.flightgear.org Unique text:2f585eeea02e2c79d7b1d8c4963bae2d --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Frederic Bouvier wrote: I am trying to integrate this contribution in the code base but after too much hours spent on this, I finally won't. Three reasons : - it doesn't compiles under MSVC, for obscure reason I don't understand. - there are a lot of files for the base package that are not strictly needed at run times : lots of .xcf files ( gimp source ), xml files that are not property files, xsl files. - it doesn't use the present convention of being included in a single directory : separated extern texture directory, Assembly (?) directory. So I left to others the choice of including it or not. This patch is not straightforward ( lots of template, imbrication level and inlines of all sort, including the use of function pointers to inline code ) and requires a lot of time to sort things out. Hi Fred, Thanks for taking such a detailed look at the source. As a general rule, we do our best to include contributions, but there are times where patches simply can't be applied in their current form. We feel bad about it, we hate to see wasted work, but it occasionally happens and can happen for a variety of reasons. I've seen everything from I didn't know what that section of code did so I deleted it, to this patch is mostly broke, but I expect you'll seek out, debug, and fix all the problems, all the way up to huge massive patches that touch darn near every file in the project in a variety of scary and hard to decipher ways. Gimp source isn't necessarily bad because it allows others to more easily edit the graphics, but they can burn a lot of space. Perhaps this developer would be willing to work with the core developers to make what ever changes are needed so the patch is acceptable (such as more closely following existing conventions and making code changes so we don't break any cross platform portability.) Thanks, Curt. -- Curtis Olsonhttp://www.flightgear.org/~curt HumanFIRST Program http://www.humanfirst.umn.edu/ FlightGear Project http://www.flightgear.org Unique text:2f585eeea02e2c79d7b1d8c4963bae2d --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Curtis maybe this could be added to the FG cvs as it could be used on other aircraft etc. What does everyone else think ? Regards, Justin Smithies On Wednesday 22 February 2006 16:37, Jean-Yves Lefort wrote: Hi, I have implemented a Honeywell MK VIII EGPWS emulation for FlightGear, available at http://people.freebsd.org/~jylefort/mk-viii.tgz The MK VIII is an Enhanced Ground Proximity Warning System aimed at regional turboprop and small turbofan aircrafts such as the Citation, Citation Bravo, B1900D, Beechcraft 99 and L410. Questions are welcome. PS: this is a repost of my original message dated January 31; maybe someone can tell me if this will go in or not? Thanks. --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
Justin Smithies wrote: Curtis maybe this could be added to the FG cvs as it could be used on other aircraft etc. What does everyone else think ? Agreed, but it's not a quick/trivial drop in patch and I'm just not going to have time to look at it today. I'm heading back out of town for the weekend starting Friday so I may not get a chance to look at it myself until next week sometime. This semester I'm getting killed at my day job. The month of May is the light at the end of my tunnel, unless someone wants to offer me a full time job doing FlightGear devel before then. Curt. -- Curtis Olsonhttp://www.flightgear.org/~curt HumanFIRST Program http://www.humanfirst.umn.edu/ FlightGear Project http://www.flightgear.org Unique text:2f585eeea02e2c79d7b1d8c4963bae2d --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] MK VIII EGPWS emulation
On Wed, 22 Feb 2006 22:02:47 +0100 Frederic Bouvier [EMAIL PROTECTED] wrote: Jean-Yves Lefort wrote : Hi, I have implemented a Honeywell MK VIII EGPWS emulation for FlightGear, available at http://people.freebsd.org/~jylefort/mk-viii.tgz The MK VIII is an Enhanced Ground Proximity Warning System aimed at regional turboprop and small turbofan aircrafts such as the Citation, Citation Bravo, B1900D, Beechcraft 99 and L410. Questions are welcome. PS: this is a repost of my original message dated January 31; maybe someone can tell me if this will go in or not? Thanks Did you checked with the author of the B1900D ( Syd Adams ? ) that your proposed change doesn't conflict with his current work, if any ? No. Someone will need to ask if he approves the b1900d changes. -- Jean-Yves Lefort [EMAIL PROTECTED] http://lefort.be.eu.org/ pgpegbuKbTylz.pgp Description: PGP signature
Re: [Flightgear-devel] MK VIII EGPWS emulation
Hi Jean-Yves, Jean-Yves Lefort wrote: Hi, I have implemented a Honeywell MK VIII EGPWS emulation for FlightGear, available at http://people.freebsd.org/~jylefort/mk-viii.tgz The MK VIII is an Enhanced Ground Proximity Warning System aimed at regional turboprop and small turbofan aircrafts such as the Citation, Citation Bravo, B1900D, Beechcraft 99 and L410. Questions are welcome. Now that the Festival support has been added, could you update the code to use that instead of the prerecorded sound files? After that I would like add it to CVS. Erik -- http://www.ehtw.info (Dutch)Future of Enschede Airport Twente http://www.ehofman.com/fgfs FlightGear Flight Simulator http://www.cafepress.com/fgfs_flightsim FlightGear Art --- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://sel.as-us.falkag.net/sel?cmd=lnkkid=103432bid=230486dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] MK VIII EGPWS emulation
Hi, I have implemented a Honeywell MK VIII EGPWS emulation for FlightGear, available at http://people.freebsd.org/~jylefort/mk-viii.tgz The MK VIII is an Enhanced Ground Proximity Warning System aimed at regional turboprop and small turbofan aircrafts such as the Citation, Citation Bravo, B1900D, Beechcraft 99 and L410. Questions are welcome. -- Jean-Yves Lefort [EMAIL PROTECTED] http://lefort.be.eu.org/ pgp9A2MTiElPm.pgp Description: PGP signature
