[Flightgear-devel] Re: CVS: FlightGear/src/Instrumentation wxradar.cxx,1.6,1.7 wxradar.hxx,1.4,1.5
Melchior Franz writes: Update of /var/cvs/FlightGear-0.9/FlightGear/src/Instrumentation In directory baron:/tmp/cvs-serv8740 Modified Files: wxradar.cxx wxradar.hxx Log Message: make headers include headers they depend on, don't rely on the c(xx) file to do that. (This is a requirement for header precompiling.) i don't understand what you mean by precompiling but making the header file include unnecessary headers is wrong. i looked at this particular case, and it's okay to forward declare a class and include the header file in the c++ source file. you actually want to do this as it minimizes the amount of recompilation in case the base header files changes. i suspect all your changes are unnecessary (this one really looks like it) so i suggest you revert them. --alex-- -- | I believe the moment is at hand when, by a paranoiac and active | | advance of the mind, it will be possible (simultaneously with | | automatism and other passive states) to systematize confusion | | and thus to help to discredit completely the world of reality. | --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Re: CVS: FlightGear/src/Instrumentation wxradar.cxx,1.6,1.7 wxradar.hxx,1.4,1.5
* Alex Romosan -- Monday 17 April 2006 16:15: i don't understand what you mean by precompiling http://en.wikipedia.org/wiki/Precompiled_header i looked at this particular case, and it's okay to forward declare a class and include the header file in the c++ source file. It's OK to forward declare classes that are referred to via *pointers*. But it is not OK to use class/type instances that are not known to the header, and relying on external code to make them known. How often would you say again changes plib/ssg.h? Per year? Once? 0.5 times? FYI: most of the fgfs code did it right already before my changes. Only some doesn't. so i suggest you revert them. Only if Curt or Erik ask me to. m. --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Re: CVS: FlightGear/src/Instrumentation wxradar.cxx,1.6,1.7 wxradar.hxx,1.4,1.5
Melchior FRANZ writes: It's OK to forward declare classes that are referred to via *pointers*. But it is not OK to use class/type instances that are not known to the header, and relying on external code to make them known. How often would you say again changes plib/ssg.h? Per year? Once? 0.5 times? the header itself might not change that often, but the time-stamp definitely changes every time you reinstall plib (because some other part got changed, and you recompiled it) and this will trigger needless recompilation. things are never that simple (and the header file dependency in flightgear/simgear is already messy enough as it is). if you feel like recompiling everything all the time, by all means, make as many changes as this as you want. what's the point of having fast computers if not to recompile code over and over again?! --alex-- -- | I believe the moment is at hand when, by a paranoiac and active | | advance of the mind, it will be possible (simultaneously with | | automatism and other passive states) to systematize confusion | | and thus to help to discredit completely the world of reality. | --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
[Flightgear-devel] Re: CVS: FlightGear/src/Instrumentation wxradar.cxx,1.6,1.7 wxradar.hxx,1.4,1.5
* Alex Romosan -- Monday 17 April 2006 16:50: Melchior FRANZ writes: It's OK to forward declare classes that are referred to via *pointers*. But it is not OK to use class/type instances that are not known to the header, and relying on external code to make them known. Again: C(++) code depending on headers == GOOD (that's the idea behind headers) headers depending on C(++) code == BAD (that's IMHO perverted and wrong) This doesn't even have anything to do with precompiled headers. It's bad design without them, too. But I'm not keen to fight such fights, even less with one-time-contributors. If the official opinion is that FlightGear shall not support precompiled headers, then I'll keep the remaining changes local on my disk. It's not the only change by far. m. --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid=110944bid=241720dat=121642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] Re: CVS: FlightGear/src/Instrumentation wxradar.cxx,1.6,1.7 wxradar.hxx,1.4,1.5
On Monday 17 April 2006 16:50, Alex Romosan wrote: the header itself might not change that often, but the time-stamp definitely changes every time you reinstall plib To avoid changing timestamps of unchanged files you can use export INSTALL='/usr/bin/install -p' ./configure --whatever at configury time. Greetings Mathias -- Mathias Fröhlich, email: [EMAIL PROTECTED] --- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnkkid0944bid$1720dat1642 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
