Re: [Flightgear-devel] spelling fix: compatability
On 22 Sep 2013, at 22:06, Markus Wanner mar...@bluegap.ch wrote: standard checking procedures on Debian revealed a spelling error: compatability occurs a couple of times in the sources. I'm a bit worried about the kt70-compatibility boolean flag, but corrected its spelling for the Debian release. Attached is a patch fixing all occurrences. Thanks, this is 100% my fault, I can't spell compatability. Compata… Err.. You get the idea :) (I've just realised I spell it wrong because I mentally think of it as 'compat - ability' - but that's not how the word is constructed. Anyway) And the kt70- flag is new, so we're pretty safe there. Thanks, James -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On Sun, 22 Sep 2013, Markus Wanner wrote: Hi, standard checking procedures on Debian revealed a spelling error: compatability occurs a couple of times in the sources. I'm a bit worried about the kt70-compatibility boolean flag, but corrected its spelling for the Debian release. Attached is a patch fixing all occurrences. Very good, except that one of the instances corrected is the name of a property tree node. Hence, fgdata is a dependency that may be affected too and needs to be checked. As James said this flag is pretty new, but there are still at least one occurrence in fgdata. Remember: Changes, however well meaning, need to analysed for consequences before being applied. Thank you. As for spelling, sometimes you just have to accept errors (if the fixing it is too expensive). Unix-like systems has lived well despite the creat() system call, after all :) In this case, correcting also in fgdata is feasible, though. Cheers, Anders -- --- Anders Gidenstam WWW: http://gitorious.org/anders-hangar http://www.gidenstam.org/FlightGear/ -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
Anders, On 09/23/2013 10:10 AM, Anders Gidenstam wrote: Very good, except that one of the instances corrected is the name of a property tree node. Hence, fgdata is a dependency that may be affected too and needs to be checked. Of course, I did a quick grep in the 2.12 fgdata, but didn't find anything relevant. (Navaids/ReadMe.FG226.txt was the only hit.) Remember: Changes, however well meaning, need to analysed for consequences before being applied. Thank you. Sure. That's why I report this upstream to check if the change is safe enough. As for spelling, sometimes you just have to accept errors (if the fixing it is too expensive). Unix-like systems has lived well despite the creat() system call, after all :) So far I though that was due to the need to save bytes, i.e. an intentional abbreviation. It certainly fits in with mknod(), fcntl(), et al. In this case, correcting also in fgdata is feasible, though. Good, looks like we prevented having to spell compatability for compatibility this time. ;-) Regards Markus signature.asc Description: OpenPGP digital signature -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On 23 Sep 2013, at 10:18, Markus Wanner mar...@bluegap.ch wrote: Of course, I did a quick grep in the 2.12 fgdata, but didn't find anything relevant. (Navaids/ReadMe.FG226.txt was the only hit.) The affected aircraft isn't in the base package, but /is/ in fgdata Git. So wearing the 'Debian maintainer' hat you did the right thing, but from the terms of flightgear patches, we check /all/ aircraft, not just those included in the base package. Regards, James -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On 09/23/2013 11:27 AM, James Turner wrote: The affected aircraft isn't in the base package, but /is/ in fgdata Git. So wearing the 'Debian maintainer' hat you did the right thing, but from the terms of flightgear patches, we check /all/ aircraft, not just those included in the base package. Oh, I see, thanks for explaining. Regards Markus signature.asc Description: OpenPGP digital signature -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On 23 Sep 2013, at 10:46, Markus Wanner mar...@bluegap.ch wrote: On 09/23/2013 11:27 AM, James Turner wrote: The affected aircraft isn't in the base package, but /is/ in fgdata Git. So wearing the 'Debian maintainer' hat you did the right thing, but from the terms of flightgear patches, we check /all/ aircraft, not just those included in the base package. Oh, I see, thanks for explaining. Actually, I spoke too soon - the ZLT-NT /is/ in the base package. I just check the official FLightGear-2.12.0 tar.bz and the ZLT-NT is there (good) and the reference to kt70-compatability is also there. So I'd suggest to check your files or workflow at your end, something strange is occurring. Regards, James -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
Any other aircraft that users might download which would fail if I patch this one as well? There may be aircraft outside official fgdata that need editing. Given that we've changed the property in-between releases, it would be good to mention it at http://wiki.flightgear.org/Aircraft_maintenance Cheers, Gijs -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On 09/23/2013 11:58 AM, James Turner wrote: Actually, I spoke too soon - the ZLT-NT /is/ in the base package. I just check the official FLightGear-2.12.0 tar.bz and the ZLT-NT is there (good) and the reference to kt70-compatability is also there. So I'd suggest to check your files or workflow at your end, something strange is occurring. Ah, sorry, I think I grepped the wrong tree (must have been 2.10). Finding this one file, now: Aircraft/ZLT-NT/Systems/instrumentation.xml Any other aircraft that users might download which would fail if I patch this one as well? Given that 2.12.0 was released with compatability, are you going to change this for a potential 2.12.1 or for 3.0? Regards Markus Wanner signature.asc Description: OpenPGP digital signature -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
On 23 Sep 2013, at 16:49, Markus Wanner mar...@bluegap.ch wrote: Any other aircraft that users might download which would fail if I patch this one as well? Given that 2.12.0 was released with compatability, are you going to change this for a potential 2.12.1 or for 3.0? I'd prefer to leave as-is for 2.12, and fix for 3.0 - there should only be a small number of aircraft affected I hope. Regards, James-- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] spelling fix: compatability
Markus, It's now fixed in next branch ;-) https://gitorious.org/fg/flightgear/commit/023c136d40cab24d994d29f2cd05e812ec3a8670 Thanks you Regards, Clément -- LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. http://pubads.g.doubleclick.net/gampad/clk?id=64545871iu=/4140/ostg.clktrk___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
