Re: [fossil-users] Using Markdown for tickets and in TH1
On Thu, 9 Jan 2014 12:24:10 +0100 Mark Janssen mpc.jans...@gmail.com wrote: Hi Mark, 1) Add a [markdown ] TH1 command to allow access to the included markdown parser from TH1 2) Slightly tweaked the markdown parser to not produce a p/p pair for strings with at most one newline 3) Changed the default ticket page templates to provide Markdown input using the already defined text/x-markdown mimetype Very nice add-on for Fossil. Thanks. Sincerely, Gour -- The embodied soul may be restricted from sense enjoyment, though the taste for sense objects remains. But, ceasing such engagements by experiencing a higher taste, he is fixed in consciousness. http://www.atmarama.net | Hlapicina (Croatia) | GPG: 52B5C810 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Small issue with ticket hook script
On Thu, Jan 9, 2014 at 7:49 PM, Mark Janssen mpc.jans...@gmail.com wrote:
On Thu, Jan 9, 2014 at 5:58 PM, Mark Janssen mpc.jans...@gmail.comwrote:
On Thu, Jan 9, 2014 at 5:31 PM, Jan Nijtmans jan.nijtm...@gmail.comwrote:
2014/1/9 Jan Nijtmans jan.nijtm...@gmail.com:
I have a different fix
in mind, I'll come back on that later.
http://fossil-scm.org/index.html/timeline?r=delay-ticket-hook
Does this work for you?
Regards,
Jan Nijtmans
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
No with this a ticket change from the web UI will not trigger the xfer
script.
With change below it works again is rc what you think it is at that part
in the code?
Sorry to keep replying to myself, but with latest version of
delay-ticket-hook
[e4af590ff9]http://www.fossil-scm.org/index.html/info/e4af590ff9 it
still doesn't work.
The cause is that in tkt.c the result logic is off. Below change fixes it:
--- src/tkt.c
+++ src/tkt.c
@@ -537,11 +537,11 @@
db_multi_exec(INSERT OR IGNORE INTO unclustered VALUES(%d);, rid);
}
manifest_crosslink_begin();
result = (manifest_crosslink(rid, pTicket, 0)==0);
assert( blob_is_reset(pTicket) );
- if( result ){
+ if( !result ){
result = manifest_crosslink_end(MC_PERMIT_HOOKS);
}else{
manifest_crosslink_end(0);
}
return result;
Mark
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Small issue with ticket hook script
2014/1/10 Mark Janssen mpc.jans...@gmail.com: Sorry to keep replying to myself, but with latest version of delay-ticket-hook [e4af590ff9] it still doesn't work. The cause is that in tkt.c the result logic is off. Below change fixes it: Yes, that's it! I saw Joe's fixes, but I still wasn't sure if that was enough to fix everything. The return value of manifest_crossling(), which is 0 for errors, always confuse me I'm not 100% sure that error-reporting is handled correctly everywhere, but it's getting close! A review by anyone else familiar wouldn't hurt either. Anyway, It will miss the 1.28 release, but it should be merge-able to trunk not too long after that. Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] fossil cut first charracter of the filename
On Fri, Jan 10, 2014 at 09:58:33AM +0200, Andrey Shtine wrote: Hello, Perhaps having fossil manage files outside its own root is not practical to implement/want, I don't know. And can be very confusing and dangerous. I suppose, in that case instead of this reaction: if I change the name of the directory, I don't get error, but the name of file is transformed: /test1# fossil add ../opt1/one.txt ADDED ne.txt there should be a nice message informing the user about the fact that adding a file from a upper directory is a bad idea. i think, it would be right to register current behaviour as a bug. You're right, it *was* a bug. That's why it got fix here: http://www.fossil-scm.org/index.html/info/c6f32a262d and it will be in the next release (1.28) that is about to be release. Regards -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On Thu, Jan 09, 2014 at 11:19:45AM -0500, Richard Hipp wrote:
On Thu, Jan 9, 2014 at 11:12 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote:
2014/1/9 Richard Hipp d...@sqlite.org:
Jan - would you like to start the branch-1.28 containing the SQLite
3.8.2
release?
http://fossil-scm.org/index.html/timeline?r=branch-1.28
Jan: tnx
Everybody: Please download, compile, and test the branch above. If there
are no issues reported, it will become the official 1.28 release.
* Final result: 27 errors out of 18957 tests
* Failures: merge-utf-24-23 merge-utf-24-32 merge5-10 merge5-50 merge5-72
merge5-90 merge5-91 merge5-100 merge5-101 merge5-102 merge5-110 merge5-120
merge5-121 merge5-122 merge5-123 merge5-130 merge5-131 merge5-132 merge5-133
merge5-134 merge5-135 merge5-136 merge5-140 merge5-141 merge5-142 th1-setting-5
th1-setting-6
on Linux 3.12.6-1-ARCH x86_64
with gcc version 4.8.2 20131219
from fossil 1f10199a09724a50 (1.28 branch tip)
Side note: failing tests do not print info on stderr (it all goes to stdout
from a 'make test' invocation POV)
Being able to run make test /dev/null 2 errs rm -f errs || ${PAGER:-more}
errs would be nice ;)
-M
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Small issue with ticket hook script
On Fri, Jan 10, 2014 at 11:46 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2014/1/10 Mark Janssen mpc.jans...@gmail.com: Sorry to keep replying to myself, but with latest version of delay-ticket-hook [e4af590ff9] it still doesn't work. The cause is that in tkt.c the result logic is off. Below change fixes it: Yes, that's it! I saw Joe's fixes, but I still wasn't sure if that was enough to fix everything. The return value of manifest_crossling(), which is 0 for errors, always confuse me I'm not 100% sure that error-reporting is handled correctly everywhere, but it's getting close! A review by anyone else familiar wouldn't hurt either. Anyway, It will miss the 1.28 release, but it should be merge-able to trunk not too long after that. Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users The 0 for error return of manifest_crosslink() tripped me up too. It took me way to long to spot why it wasn't working. Anyway with this change the ticket hooking works for my purposes. Thanks, Mark ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
more info: test-out @ http://phaeton.sdf-eu.org/fossil-1f10199a09724a50-test-out -M ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On Thu, Jan 09, 2014 at 11:19:45AM -0500, Richard Hipp wrote: Everybody: Please download, compile, and test the branch above. If there are no issues reported, it will become the official 1.28 release. for my info, when you say 'please test', do you mean 'run the test-suite from the build and report errors' or 'try to use it in practice' (or both)? I always do the latter; this is the first time I even run the test-suite. Michai ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On 10 January 2014 13:25, Michai Ramakers m.ramak...@gmail.com wrote: On Thu, Jan 09, 2014 at 11:19:45AM -0500, Richard Hipp wrote: Everybody: Please download, compile, and test the branch above. If there are no issues reported, it will become the official 1.28 release. for my info, when you say 'please test', do you mean 'run the test-suite from the build and report errors' or 'try to use it in practice' (or both)? I always do the latter; this is the first time I even run the test-suite. fwiw: * End of utf: 2 errors so far ** * Final result: 2 errors out of 18915 tests * Failures: merge-utf-24-23 merge-utf-24-32 michai@lime:/tmp/f/f$ uname -a NetBSD lime.LAN 6.0.1 NetBSD 6.0.1 (GENERIC) amd64 michai@lime:/tmp/f/f$ ./fossil version This is fossil version 1.28 [6e7e8fbe01] 2014-01-09 21:00:38 UTC (These are the same errors Jan Nijtmans reported in http://www.mail-archive.com/fossil-users@lists.fossil-scm.org/msg14301.html) Michai ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On Jan 10, 2014, at 13:30 , Michai Ramakers wrote: * End of utf: 2 errors so far ** * Final result: 2 errors out of 18915 tests * Failures: merge-utf-24-23 merge-utf-24-32 The same tests are failing on my machine: $ uname -a Darwin pc6.home 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun 7 16:32:41 PDT 2011; root:xnu-1504.15.3~1/RELEASE_X86_64 x86_64 $ ./fossil version This is fossil version 1.28 [1f10199a09] 2014-01-09 21:12:11 UTC Kind regards, Remigiusz Modrzejewski ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
Thank you. But those antique test cases don't really matter that much. (The test failures you are seeing are likely due to problems in the tests themselves, not problems in Fossil, though we will verify this prior to release.) I'm really interested in knowing whether or not the latest Fossil is working well for you in your daily activities and if you know of any bugs or problems with the latest Fossil that need to be addressed before we release. If you want some specific command to run in order to validate Fossil, please try these: fossil all rebuild fossil all test-integrity Let me know if either of these commands gives problems for any of your repositories. Thanks. On Fri, Jan 10, 2014 at 9:23 AM, Remigiusz Modrzejewski l...@maxnet.org.plwrote: On Jan 10, 2014, at 13:30 , Michai Ramakers wrote: * End of utf: 2 errors so far ** * Final result: 2 errors out of 18915 tests * Failures: merge-utf-24-23 merge-utf-24-32 The same tests are failing on my machine: $ uname -a Darwin pc6.home 10.8.0 Darwin Kernel Version 10.8.0: Tue Jun 7 16:32:41 PDT 2011; root:xnu-1504.15.3~1/RELEASE_X86_64 x86_64 $ ./fossil version This is fossil version 1.28 [1f10199a09] 2014-01-09 21:12:11 UTC Kind regards, Remigiusz Modrzejewski ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- D. Richard Hipp d...@sqlite.org ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On Jan 10, 2014, at 15:29 , Richard Hipp wrote: Thank you. But those antique test cases don't really matter that much. (The test failures you are seeing are likely due to problems in the tests themselves, not problems in Fossil, though we will verify this prior to release.) Well, an error in a test is still an error to fix. If you want some specific command to run in order to validate Fossil, please try these: fossil all rebuild fossil all test-integrity Let me know if either of these commands gives problems for any of your repositories. Thanks. Both worked perfectly. If I happen onto any real-world error, I will not neglect to cry out loud ;) Kind regards, Remigiusz Modrzejewski ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] 1.28 vdiff changes
Hello, the Changes page says for 1.28: - Enhancements to the /vdiff webpage for more difference display options. But what I see, is that it lost the 'Patch' option. What are exactly the additional display options? Thank you, Lluís ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] 1.28 vdiff changes
On Fri, Jan 10, 2014 at 04:19:19PM +0100, Lluís Batlle i Rossell wrote: Hello, the Changes page says for 1.28: - Enhancements to the /vdiff webpage for more difference display options. But what I see, is that it lost the 'Patch' option. What are exactly the additional display options? Possibility to hide the diffs or not according to the settings, just like the /info page. http://fossil-scm.org/index.html/info/74a4db258a -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] 1.28 vdiff changes
On Fri, Jan 10, 2014 at 10:24:12AM -0500, Martin Gagnon wrote: On Fri, Jan 10, 2014 at 04:19:19PM +0100, Lluís Batlle i Rossell wrote: Hello, the Changes page says for 1.28: - Enhancements to the /vdiff webpage for more difference display options. But what I see, is that it lost the 'Patch' option. What are exactly the additional display options? Possibility to hide the diffs or not according to the settings, just like the /info page. http://fossil-scm.org/index.html/info/74a4db258a Ah ok. Well... considering also the removal of Patch option, to me this translates almost to less options in vdiff. :) Maybe we could have the Patch back? ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] 1.28 vdiff changes
On Fri, Jan 10, 2014 at 04:28:18PM +0100, Lluís Batlle i Rossell wrote: On Fri, Jan 10, 2014 at 10:24:12AM -0500, Martin Gagnon wrote: On Fri, Jan 10, 2014 at 04:19:19PM +0100, Lluís Batlle i Rossell wrote: Hello, the Changes page says for 1.28: - Enhancements to the /vdiff webpage for more difference display options. But what I see, is that it lost the 'Patch' option. What are exactly the additional display options? Possibility to hide the diffs or not according to the settings, just like the /info page. http://fossil-scm.org/index.html/info/74a4db258a Ah ok. Well... considering also the removal of Patch option, to me this translates almost to less options in vdiff. :) Maybe we could have the Patch back? I don't know if it ever been on the /vdiff page... I just compile the version before the hide diff feature and patch was not there.. May be you confuse with the /info page that still have the patch button. -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
../configure --quietmake -s test|sed -ne '/Final result:/,$p' Cannot run this test within an open checkout Cannot run this test within an open checkout Cannot run this test within an open checkout * Final result: 2 errors out of 18915 tests * Failures: merge-utf-24-23 merge-utf-24-32 cp ../manifest* .fossil close mv manifest* ..make -s test|sed -ne '/Final result:/,$p' * Final result: 27 errors out of 18957 tests * Failures: merge-utf-24-23 merge-utf-24-32 merge5-10 merge5-50 merge5-72 merge5-90 merge5-91 merge5-100 merge5-101 merge5-102 merge5-110 merge5-120 merge5-121 merge5-122 merge5-123 merge5-130 merge5-131 merge5-132 merge5-133 merge5-134 merge5-135 merge5-136 merge5-140 merge5-141 merge5-142 th1-setting-5 th1-setting-6 uname -a Linux ** 3.2.0-56-generic #86-Ubuntu SMP Wed Oct 23 17:31:43 UTC 2013 i686 i686 i386 GNU/Linux Sergei ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
On Thu, Jan 09, 2014 at 05:25:04PM +0100, Jan Nijtmans wrote: [snip] I compiled/ran it on Cygwin64, and make test ended with: * Final result: 2 errors out of 18914 tests * Failures: merge-utf-24-23 merge-utf-24-32 [snip] Same thing here on OpenBSD 5.3 amd64... I've also made some real world test including the rebuild and test-integrity on few repos.. -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Version 1.28 release?
Thus said Sergei Gavrikov on Fri, 10 Jan 2014 19:56:54 +0300: * Failures: ... th1-setting-5 th1-setting-6 These two failures appear to be happening because they expect to find a setting (autosync == 1), but find something else. I believe this is because they operate on the current fossil repository which may or may not have the settings that were originally present when the test was drafted. This means that the test is not operating on a cleanly created fossil repository. Given that we cannot know what state any given repository is in, you probably need to create a new repository and run the tests from there. Something like: FDIR=/path/to/fossil FOSSIL=$FDIR/fossil $FOSSIL new /tmp/test.fossil mkdir /tmp/test; cd /tmp/test; $FOSSIL open /tmp/test.fossil tclsh $FDIR/test/tester.tcl $FOSSIL Or make a new clone of fossil when building/testing and use ``make test'' within that directory. Also, main.mk has this advisory: # WARNING. DANGER. Running the test suite modifies the repository the # build is done from, i.e. the checkout belongs to. Do not sync/push # the repository after running the tests. In the future, perhaps the tests need to be modified to create a new test.fossil from which to run the tests. I cannot tell what modifications might have been made to my clone of fossil, but the warning seems pretty dire---I wonder if that means I can no longer sync? Andy -- TAI64 timestamp: 400052d0bba0 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
