Re: [fossil-users] Suggestion about fossil commit
On Mon, Apr 14, 2014 at 12:47:11PM -0400, Martin Gagnon wrote: Le 14 avr. 2014 11:48, Stephan Beal sgb...@googlemail.com a écrit : But, in my defense, (and I just re-read it to be sure I didn't miss it) nowhere in the help documentation (FOSSIL HELP COMMIT) or the comment in the editor (# Enter commit message for this check-in. Lines beginning with # are ignored.) does it say, or even imply, that an empty comment is one of the reasons that will 'abort' the commit. LOL!!! If i'm not mistaken, svn does the same thing (but i haven't got an svn with changes to try it out at the moment). Possibly even git - most SCMs do not like the users to enter empty commit messages. Even the famous CVS does the same... s/famous/infamous/ -- Chad Perrin [ original content licensed OWL: http://owl.apotheon.org ] ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
That sounds like a bad idea to me. IMO, this is a case of good enough getting in the way of good as far as solutions to your annoyance. Off the top of my head, I can think of two workflow habits that may help you: 1) set up/turn on gpg signing, so you'll be required to sign commits before they're actually applied. 2) do not use -m, but let fossil through you into the default editor to type your commit message interactively. There are interesting articles on git commit messages that dovetails with this problem, too, which may add even further value [0] [1]. Currently, by default, I think we're not really setup to take advantage of the advice in the articles, but (to my mind) it sounds like a great place to be, and getting there (directly via canonical fossil, or libfossil or other tool) is really easy to imagine. -bch [0] http://stackoverflow.com/questions/15324900/standard-to-follow-when-writing-git-commit-messages [1] http://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message On Apr 13, 2014 4:41 PM, Stanislav Paskalev ksh...@gmail.com wrote: Hi fossil-devs, I often reuse a console to work with fossil as well as something else (e.g. compile, run tests, etc) Due to my trigger-happy fingers I've had quite a few cases where I inadvertently ran fossil commit -m .. from history when in reality I wanted to run my tests for example. Fossil could compare the current message against the latest checkin in the active branch and warn if they match. If this sounds fine - I can make and send a patch :) Regards, Stanislav Paskalev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
I often have the same problem for a different reason. I type “f cha” and “f com” so often that sometime instead of “f cha” I accidentally type “f com”. What I would like to have is an extra prompt, “Are you sure (y/N)?” with No default for commits. Since commits are irreversible, I think the extra prompt to safeguard against typing accidents will be welcome by most users without adding too much burden to each commit. Then again, it could also be activated via some setting so those who don’t want it can do without it. Tony P. From: Stanislav Paskalev Sent: Monday, April 14, 2014 2:41 AM To: Fossil SCM user's discussion Subject: [fossil-users] Suggestion about fossil commit Hi fossil-devs, I often reuse a console to work with fossil as well as something else (e.g. compile, run tests, etc) Due to my trigger-happy fingers I've had quite a few cases where I inadvertently ran fossil commit -m .. from history when in reality I wanted to run my tests for example. Fossil could compare the current message against the latest checkin in the active branch and warn if they match. If this sounds fine - I can make and send a patch :) Regards, Stanislav Paskalev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
WHAT? Oh, this is embarrassing... All this time I've been typing something (like the word 'ACCIDENT') in the editor thinking I have already started the commit process and I would complete the commit when I exit the editor, so I always typed something to know that this commit was a mistake. I didn't know that typing nothing would cancel the operation. But, in my defense, (and I just re-read it to be sure I didn't miss it) nowhere in the help documentation (FOSSIL HELP COMMIT) or the comment in the editor (# Enter commit message for this check-in. Lines beginning with # are ignored.) does it say, or even imply, that an empty comment is one of the reasons that will 'abort' the commit. LOL!!! Thanks. -Original Message- From: Martin Gagnon Sent: Monday, April 14, 2014 3:24 PM To: Fossil SCM user's discussion Subject: Re: [fossil-users] Suggestion about fossil commit On Mon, Apr 14, 2014 at 02:55:51PM +0300, Tony Papadimitriou wrote: I often have the same problem for a different reason. I type “f cha” and “f com” so often that sometime instead of “f cha” I accidentally type “f com”. What I would like to have is an extra prompt, “Are you sure (y/N)?” with No default for commits. Since commits are irreversible, I think the extra prompt to safeguard against typing accidents will be welcome by most users without adding too much burden to each commit. Then again, it could also be activated via some setting so those who don’t want it can do without it. Since fossil commit start an editor and having empty commit message give you a kind of Are you sure prompt already, how can you commit by mistake when typing f com instead of f cha ? It's not like you will type: f com -m some text when you were about to type f cha ... Regards. -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
On Mon, Apr 14, 2014 at 3:39 PM, Tony Papadimitriou to...@acm.org wrote: But, in my defense, (and I just re-read it to be sure I didn't miss it) nowhere in the help documentation (FOSSIL HELP COMMIT) or the comment in the editor (# Enter commit message for this check-in. Lines beginning with # are ignored.) does it say, or even imply, that an empty comment is one of the reasons that will 'abort' the commit. LOL!!! If i'm not mistaken, svn does the same thing (but i haven't got an svn with changes to try it out at the moment). Possibly even git - most SCMs do not like the users to enter empty commit messages. -- - stephan beal http://wanderinghorse.net/home/stephan/ http://gplus.to/sgbeal Freedom is sloppy. But since tyranny's the only guaranteed byproduct of those who insist on a perfect world, freedom will have to do. -- Bigby Wolf ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
Le 14 avr. 2014 11:48, Stephan Beal sgb...@googlemail.com a écrit : On Mon, Apr 14, 2014 at 3:39 PM, Tony Papadimitriou to...@acm.org wrote: But, in my defense, (and I just re-read it to be sure I didn't miss it) nowhere in the help documentation (FOSSIL HELP COMMIT) or the comment in the editor (# Enter commit message for this check-in. Lines beginning with # are ignored.) does it say, or even imply, that an empty comment is one of the reasons that will 'abort' the commit. LOL!!! If i'm not mistaken, svn does the same thing (but i haven't got an svn with changes to try it out at the moment). Possibly even git - most SCMs do not like the users to enter empty commit messages. Even the famous CVS does the same... -- Martin G. ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
On 4/14/14, Martin Gagnon eme...@gmail.com wrote: Le 14 avr. 2014 11:48, Stephan Beal sgb...@googlemail.com a écrit : On Mon, Apr 14, 2014 at 3:39 PM, Tony Papadimitriou to...@acm.org wrote: But, in my defense, (and I just re-read it to be sure I didn't miss it) nowhere in the help documentation (FOSSIL HELP COMMIT) or the comment in the editor (# Enter commit message for this check-in. Lines beginning with # are ignored.) does it say, or even imply, that an empty comment is one of the reasons that will 'abort' the commit. LOL!!! If i'm not mistaken, svn does the same thing (but i haven't got an svn with changes to try it out at the moment). Possibly even git - most SCMs do not like the users to enter empty commit messages. Even the famous CVS does the same... Our users shouldn't need CVS, SVN, etc experience to know this. I added documentation to clarify. -- Martin G. -- Brad Harder Method Logic Digital Consulting http://www.methodlogic.net/ http://twitter.com/bcharder ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
On 4/14/14, 9:31 PM, B Harder wrote: [...] Our users shouldn't need CVS, SVN, etc experience to know this. I added documentation to clarify. It might also be useful to add: # (To abort the commit, leave this file unchanged) ...to the commit message, too. -- ┌─── ｄｇ＠ｃｏｗｌａｒｋ．ｃｏｍ ─ http://www.cowlark.com ─ │ │ You cannot truly appreciate _Atlas Shrugged_ until you have read it │ in the original Klingon. --- Sea Wasp on r.a.sf.w signature.asc Description: OpenPGP digital signature ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
On 4/14/14, David Given d...@cowlark.com wrote: On 4/14/14, 9:31 PM, B Harder wrote: [...] Our users shouldn't need CVS, SVN, etc experience to know this. I added documentation to clarify. It might also be useful to add: # (To abort the commit, leave this file unchanged) ...to the commit message, too. +1, done. New_Version: 0484ccf2e9335e2f4c9914afabe7d66c28b0be99 -- Brad Harder Method Logic Digital Consulting http://twitter.com/bcharder ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
Thus said David Given on Mon, 14 Apr 2014 22:28:07 +0100: It might also be useful to add: # (To abort the commit, leave this file unchanged) I was about to point out that this wouldn't be a good idea when using merge --cherrypick because it actually automatically includes the original commit message from the checkin, but apparently Fossil is smart enough to figure out that even with an uncommented line in the commit message, it still treats it as an empty message unless you alter it! Impressive. Andy -- TAI64 timestamp: 4000534caa33 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
Thus said Andy Bradford on Mon, 14 Apr 2014 21:40:00 -0600: ... but apparently Fossil is smart enough to figure out that even with an uncommented line in the commit message, it still treats it as an empty message unless you alter it! Correction, unchanged, not empty. Andy -- TAI64 timestamp: 4000534caa95 ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
[fossil-users] Suggestion about fossil commit
Hi fossil-devs, I often reuse a console to work with fossil as well as something else (e.g. compile, run tests, etc) Due to my trigger-happy fingers I've had quite a few cases where I inadvertently ran fossil commit -m .. from history when in reality I wanted to run my tests for example. Fossil could compare the current message against the latest checkin in the active branch and warn if they match. If this sounds fine - I can make and send a patch :) Regards, Stanislav Paskalev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
Re: [fossil-users] Suggestion about fossil commit
This might better be handled with an alias or wrapper script. #!/bin/bash read -p You just ran fossil $@ ; are you sure? yn case $yn in [Yy]* ) /usr/bin/fossil $@ ;; [Nn]* ) echo Whew! Dodged a bullet there! ;; esac Elaborated to suit. - JK On Sun, Apr 13, 2014 at 5:41 PM, Stanislav Paskalev ksh...@gmail.com wrote: Hi fossil-devs, I often reuse a console to work with fossil as well as something else (e.g. compile, run tests, etc) Due to my trigger-happy fingers I've had quite a few cases where I inadvertently ran fossil commit -m .. from history when in reality I wanted to run my tests for example. Fossil could compare the current message against the latest checkin in the active branch and warn if they match. If this sounds fine - I can make and send a patch :) Regards, Stanislav Paskalev ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users -- It is always best to think of reality as perfectly normal. Since the beginning, not one unusual thing has ever happened. - Less Wrong ___ fossil-users mailing list fossil-users@lists.fossil-scm.org http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
