[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

--- Comment #4 from commit-h...@freebsd.org ---
A commit references this bug:

Author: cem
Date: Thu May 14 03:01:24 UTC 2020
New revision: 361021
URL: https://svnweb.freebsd.org/changeset/base/361021

Log:
  vfs_extattr: Allow extattr names up to the full max

  Extattr names are allowed to be 255 bytes -- not 254 bytes plus trailing
  NUL.  Provide a 256 buffer so that copyinstr() has room for the trailing
  NUL.

  Re-enable test for maximal name lengths.

  PR:   208965
  Reported by:  asomers
  Reviewed by:  asomers
  Differential Revision:https://reviews.freebsd.org/D24584

Changes:
  head/sys/kern/vfs_extattr.c
  head/usr.sbin/extattr/tests/extattr_test.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

Conrad Meyer  changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

Conrad Meyer  changed:

   What|Removed |Added

   Assignee|f...@freebsd.org  |c...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

Conrad Meyer  changed:

   What|Removed |Added

 Status|New |In Progress
   Assignee|b...@freebsd.org|f...@freebsd.org
   Keywords||patch
   Hardware|amd64   |Any

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

--- Comment #3 from Conrad Meyer  ---
FWIW, UFS_EXTATTR only disables the crummy extattrs in UFS1.  UFS2 extattrs are
not controlled by that knob.

https://reviews.freebsd.org/D24584 is a proposed patch; it compiles but I have
not tested it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

--- Comment #2 from Conrad Meyer  ---
I believe this is due to copyinstr(), which works with NUL-terminated strings
(and lengths), while the stack buffer in sys_extattr_set_fd(), etc, are only
sized to EXTATTR_MAXNAMELEN.  To fix this I think we just need to size the
buffers one larger to allow for the trailing NUL copyinstr expects.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"

[Bug 208965] extattr(2) doesn't allow attribute names of length EXTATTR_MAXNAMELEN

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208965

Ngie Cooper  changed:

   What|Removed |Added

 CC||n...@freebsd.org

--- Comment #1 from Ngie Cooper  ---
(related to https://reviews.freebsd.org/D5889).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-amd64@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "freebsd-amd64-unsubscr...@freebsd.org"