Re: [PATCH] Simplify uart_bus_pci_probe
On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar xcl...@mac.com wrote: On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). The patch is logically wrong for non-ns8250 based UARTs. Leave the code as is. Hi Marcel, Is the layout of the pci_ns8250_ids PCI ID table correct then, as there are a large number of ns16550 chips and other non-ns8250 chips in the table? Thanks, -Garrett ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: [PATCH] Simplify uart_bus_pci_probe
On Nov 10, 2010, at 12:44 AM, Garrett Cooper wrote: On Tue, Nov 9, 2010 at 10:29 PM, Marcel Moolenaar xcl...@mac.com wrote: On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). The patch is logically wrong for non-ns8250 based UARTs. Leave the code as is. Hi Marcel, Is the layout of the pci_ns8250_ids PCI ID table correct then, as there are a large number of ns16550 chips and other non-ns8250 chips in the table? ns16550 is a ns8250 class UART. They are in the same family. Non-ns8250 UARTs include Zilog Z8530, Siemens SAB 82532, Freescale's PowerQUICC SCC, and even SGI's firmware based serial console of you like. FYI, -- Marcel Moolenaar xcl...@mac.com ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: [PATCH] Simplify uart_bus_pci_probe
On Nov 6, 2010, at 11:22 AM, Garrett Cooper wrote: Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). The patch is logically wrong for non-ns8250 based UARTs. Leave the code as is. Thanks, -- Marcel Moolenaar xcl...@mac.com ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
[PATCH] Simplify uart_bus_pci_probe
Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). Thanks! -Garrett uart-bus-probe-minor-cleanup.patch Description: Binary data ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
Re: [PATCH] Simplify uart_bus_pci_probe
On Sat, 6 Nov 2010 11:22:53 -0700 Garrett Cooper gcoo...@freebsd.org wrote: Some of the logic could have been simplified in the probe. The proposed patch makes the detection process a tad bit more straightforward. Comments, review (and maybe a commit :P) are more than welcome :). Thanks! -Garrett This is definitely much less convoluted and easier to understand than the old code! I'd commit it, if I still had my src commit bit :) -- Gary Jennejohn ___ freebsd-hackers@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to freebsd-hackers-unsubscr...@freebsd.org
