[Bug 275774] IPv4 Mapper address problem

2024-03-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Emmanuel Vadot  changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

--- Comment #13 from Emmanuel Vadot  ---
(In reply to Michael Tuexen from comment #12)

Yes :)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2024-03-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #12 from Michael Tuexen  ---
Can we close this?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2024-01-10 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #11 from commit-h...@freebsd.org ---
A commit in branch stable/14 references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3159e314f194bd8db98dd4516f46350b2fbe44f0

commit 3159e314f194bd8db98dd4516f46350b2fbe44f0
Author: Richard Kümmel 
AuthorDate: 2023-12-15 11:49:45 +
Commit: Ed Maste 
CommitDate: 2024-01-10 16:37:44 +

Fix udp IPv4-mapped address

Do not use the cached route if the destination isn't the same.
This fix a problem where an UDP packet will be sent via the wrong route
and interface if a previous one was sent via them.

PR: 275774
Reviewed by:glebius, tuexen
Sponsored by:   Beckhoff Automation GmbH & Co. KG

(cherry picked from commit 7df9da47e8f04267330e1baa751f07c0c4aaf2ac)

 sys/netinet/udp_usrreq.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2024-01-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Mark Linimon  changed:

   What|Removed |Added

  Flags||mfc-stable13?,
   ||mfc-stable14?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2024-01-01 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #10 from commit-h...@freebsd.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=7df9da47e8f04267330e1baa751f07c0c4aaf2ac

commit 7df9da47e8f04267330e1baa751f07c0c4aaf2ac
Author: Richard Kümmel 
AuthorDate: 2023-12-15 11:49:45 +
Commit: Emmanuel Vadot 
CommitDate: 2024-01-02 06:49:12 +

Fix udp IPv4-mapped address

Do not use the cached route if the destination isn't the same.
This fix a problem where an UDP packet will be sent via the wrong route
and interface if a previous one was sent via them.

PR: 275774
Reviewed by:glebius, tuexen
Sponsored by:   Beckhoff Automation GmbH & Co. KG

 sys/netinet/udp_usrreq.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-18 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #9 from Michael Tuexen  ---
(In reply to Emmanuel Vadot from comment #8)
Please include in your commit message:
Reported-by: syzbot+618d4f014f60c0bd0...@syzkaller.appspotmail.com
since this patch also fixes
https://syzkaller.appspot.com/bug?extid=618d4f014f60c0bd06b4

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #8 from Emmanuel Vadot  ---
(In reply to Gleb Smirnoff from comment #4)
Could be but reverting this commit locally to test this makes the panic
re-appears so I'm not sure if this was working before, could also be later
modification as I didn't test the previous hash directly.

Thanks both for your review, will commit later today (after writing a better
commit message :P)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #7 from Michael Tuexen  ---
I think you don't need to initialize `use_cached_route` to `false` in the
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #6 from Michael Tuexen  ---
(In reply to Gleb Smirnoff from comment #5)
Patch looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Gleb Smirnoff  changed:

   What|Removed |Added

 Status|New |In Progress

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

--- Comment #5 from Gleb Smirnoff  ---
The patch looks 100% correct to me, but let's wait for Michael to review. It'll
also be cool to rework test program to atf(3) and land it in tests/netinet.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Gleb Smirnoff  changed:

   What|Removed |Added

 CC||tue...@freebsd.org

--- Comment #4 from Gleb Smirnoff  ---
Broken by abca3ae7734f6 I guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Gleb Smirnoff  changed:

   What|Removed |Added

 CC||gleb...@freebsd.org

--- Comment #3 from Gleb Smirnoff  ---
Can you please create phabricator review instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Bug 275774] IPv4 Mapper address problem

2023-12-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275774

Mark Linimon  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|n...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.