[Bug 276870] mbuf cluster leak with on pf+bird2 bgp routers

2024-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276870

Marek Zarychta  changed:

   What|Removed |Added

 CC||oliv...@freebsd.org

--- Comment #4 from Marek Zarychta  ---
Now, when we have only FreeBSD 13, 14 and CURRENT branches supported and all of
them have reworked routing stack with NETLINK support included, bird2-netlink
is better suited to run on FreeBSD and probably should become the default
flavor of net/bird2 port. The transition is important to avoid such situations
in the future.

Netlink flavor supports ECMP, the memory footprint is much lower compared to
rtsock version, and it will run with the same config file, though small config
changes are recommended. The user experience with bird2-netlink is better since
it can run undisturbed for months on FreeBSD 13.2+ without any observable
drawbacks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 276870] mbuf cluster leak with on pf+bird2 bgp routers

2024-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276870

Gleb Smirnoff  changed:

   What|Removed |Added

 CC||melif...@freebsd.org

--- Comment #3 from Gleb Smirnoff  ---
On Wed Feb  7 15:25:11  2024 UTC, tho...@gibfest.dk wrote:
> Over the holidays I upgraded from bird 2.0.9 to bird 2.14, as well as 
> upgrading
> FreeBSD from 13-STABLE-384a885111ad to 13-STABLE-2cbd132986a7. I suspect one 
> of
> these two changes made this problem appear. I made no changes to bird or 
> router
> config other than the upgrades.

What I would suspect here is NETLINK. Lots of stuff merged between
384a885111ad and 2cbd132986a7.

Thomas, is it possible for you to work more on isolating the regression?

Things to check:
1) Did bird upgrade 2.0.9 to 2.14 switch bird to use NETLINK instead of
   route socket?

If 1) is false, there are two options: 2.0.9 and 2.14 both used NETLINK
or both used route socket. If the latter, than my guess is totally wrong
and Mark's guess is much better. If the former, than we need to bisect
between 384a885111ad and 2cbd132986a7.

2) If 1) is true, then please compile 2.14 with NETLINK disabled and
   check if leak has gone.

If 1) and 2) are true it could be the problem was in 384a885111ad
as well, but you did not use NETLINK.

3) Check if running with NETLINK on 384a885111ad reproduces the leak
   or not? (Be careful, as lots of bugs were removed after 384a885111ad)

Depending on 3) we may need to run bisection.

Anyway, please keep us updated when you got more info, starting with 1).

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 276870] mbuf cluster leak with on pf+bird2 bgp routers

2024-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276870

Mark Johnston  changed:

   What|Removed |Added

 CC||gleb...@freebsd.org,
   ||ma...@freebsd.org
 Status|New |Open

--- Comment #2 from Mark Johnston  ---
Gleb, based on the report this sounds more like a leak in the routing socket
code, no?  There's no mention of pf except in the bug title.

> I at one point tried adding the missing kernel export filter (as to at least 
> silence the noisy warnings in the logs), and imagine my surprise when the 
> mbuf cluster leak stopped.

I'm not too familiar with how this works - does this basically install a bunch
of routes in the kernel, so most likely you're hitting an mbuf leak in the
routing socket code?  This may be fixed in 14.0 by virtue of having
reimplemented parts of that interface using netlink.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 276870] mbuf cluster leak with on pf+bird2 bgp routers

2024-02-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276870

Gleb Smirnoff  changed:

   What|Removed |Added

   Assignee|b...@freebsd.org|p...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.


[Bug 276870] mbuf cluster leak with on pf+bird2 bgp routers

2024-02-07 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276870

Marek Zarychta  changed:

   What|Removed |Added

 CC||n...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.