Re: [Freedos-kernel] PATCH: sys fix

2009-05-01 Thread Eric Auer

Hi Bart,

thanks for making the patch much shorter, very commitable now :-)

Why did our old code do that complex put bp at [bp+2] thing? And
what does the cpm_error jump decision now inverted patch mean?

Eric

 This is a minimal fix for [entry.asm]
...
 -pushbp  ; trash old return address
 -mov bp,sp
 -xchgbp,[2+bp]
 -pop bp
 +add sp,2; trash old return address
...
  cmp cl,024h
 -jbe cpm_error
 +ja  cpm_error
...


--
Register Now  Save for Velocity, the Web Performance  Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance  Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel


Re: [Freedos-kernel] PATCH: sys fix

2009-05-01 Thread Kenneth J. Davis
On Fri, May 1, 2009 at 4:01 AM, Eric Auer e.a...@jpberlin.de wrote:

 Hi Bart,

 thanks for making the patch much shorter, very commitable now :-)

 Why did our old code do that complex put bp at [bp+2] thing? And
don't know

 what does the cpm_error jump decision now inverted patch mean?
skips the call to int21 if the value in cl is  24h, ie limits the
call to int 21h functions 0-24h
before it incorrectly limited the calls to functions  24h

 Eric

 This is a minimal fix for [entry.asm]
 ...
 ...
                  cmp     cl,024h
 -                jbe     cpm_error
 +                ja      cpm_error
 ...


Jeremy

--
Register Now  Save for Velocity, the Web Performance  Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance  Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel


Re: [Freedos-kernel] PATCH: sys fix

2009-05-01 Thread Bart Oldeman
2009/5/1 Eric Auer e.a...@jpberlin.de:

 Why did our old code do that complex put bp at [bp+2] thing?

I don't know; it is old code from Pat Villani. Perhaps it wanted to do an extra
pop bp from that place but bp was already set to sp so that would be
wrong too.

 -pushbp  ; trash old return address
 -mov bp,sp
 -xchgbp,[2+bp]
 -pop bp

Bart

--
Register Now  Save for Velocity, the Web Performance  Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance  Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
___
Freedos-kernel mailing list
Freedos-kernel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-kernel