On Mon, Feb 27, 2017 at 11:10 PM, Jaimos Skriletz
<jaimosskril...@gmail.com> wrote:
> Hello,
>
> FvwmIconMan still reports Hint warnings even with the patchs applied.
>
I wrote this small patch that has FvwmIconMan wait until the window
has resized to set the window hints. This is in the lines of Dominik
Vogt's patch, but waits until FvwmIconMan has fully resized to run
fix_manager_size() to set the window hints. My tests here no longer
seem to tiger the warnings like it still sometimes did.
As an additional thought, talking to Thomas Adam about the patch in
#fvwm, he mentioned that the issue is more FVWM being overly cautious
and the fix should be in how fvwm handles size hint warnings over
working with FvwmIconMan to avoid triggering them.
I don't know enough about the issue to say which is more appropriate,
but here is a patch that stops the warnings from being triggered in my
tests.
jaimos
From 227d7ea2597ec3fec304c53934fcc41773ab7e89 Mon Sep 17 00:00:00 2001
From: Jaimos Skriletz <jaimosskril...@gmail.com>
Date: Tue, 28 Feb 2017 17:43:12 -0700
Subject: [PATCH 1/1] Wait until FvwmIconMan is resized to set window HINTS
---
modules/FvwmIconMan/xmanager.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/modules/FvwmIconMan/xmanager.c b/modules/FvwmIconMan/xmanager.c
index 58eaaedc..b4efe890 100644
--- a/modules/FvwmIconMan/xmanager.c
+++ b/modules/FvwmIconMan/xmanager.c
@@ -439,6 +439,16 @@ static void resize_window(WinManager *man)
}
MyXUngrabServer(theDisplay);
}
+
+ // Wait until the window has resised to fix the HINTS.
+ // counter is used to break an infinte loop.
+ XWindowAttributes attribs;
+ int counter = 20000;
+ while ( counter && (attribs.width != man->geometry.width ||
+ attribs.height != man->geometry.height)) {
+ XGetWindowAttributes(theDisplay, man->theWindow, &attribs);
+ counter--;
+ }
fix_manager_size(man, man->geometry.width, man->geometry.height);
}
--
2.11.0
