Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread Thomas Adam 
On Sat, Oct 22, 2016 at 11:02:16PM +0100, Dominik Vogt wrote:
> On Sat, Oct 22, 2016 at 10:55:39PM +0100, Thomas Adam wrote:
> > OK, this looks better.  Thanks!
> > 
> > GCC/Clang don't moan at these changes, which is good.  The changes built via
> > travis-ci just fine.
> > 
> > I say you're good to merge to master.
> 
> Good.  I think I've also figured out how these safety measures on
> master work.  Thanks for your patience, Thomas.

Not at all, you're the first person who's actually had to go through this
process who wasn't me so it's really important we get this right.

I hope things are clearer now; if DEVELOPERS.md needs to change, feel free so
that it helps the next person who comes along.

-- Thomas Adam

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread Dominik Vogt 
On Sat, Oct 22, 2016 at 10:55:39PM +0100, Thomas Adam wrote:
> OK, this looks better.  Thanks!
> 
> GCC/Clang don't moan at these changes, which is good.  The changes built via
> travis-ci just fine.
> 
> I say you're good to merge to master.

Good.  I think I've also figured out how these safety measures on
master work.  Thanks for your patience, Thomas.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

[fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread GitHub 
  Branch: refs/heads/master
  Home:   https://github.com/fvwmorg/fvwm
  Commit: c0ae18064466425f3864bd1e3baf03815cae4a44
  
https://github.com/fvwmorg/fvwm/commit/c0ae18064466425f3864bd1e3baf03815cae4a44
  Author: Dominik Vogt 
  Date:   2016-10-22 (Sat, 22 Oct 2016)

  Changed paths:
M configure.ac
M fvwm/add_window.c
M fvwm/events.c
M fvwm/frame.c
M fvwm/icons.c
M fvwm/menus.c
M fvwm/session.c
M libs/FGettext.c
M libs/FImage.c
M libs/FRender.c
M libs/FScreen.c
M libs/Fft.c
M libs/Ficonv.c
M libs/fsm.c
M modules/FvwmConsole/getline.c

  Log Message:
  ---
  Fix Gcc warnings.

* fvwm/session.c (SessionInit, set_sm_properties): Fix warnings.
* fvwm/frame.c (frame_prepare_animation_shape)
(frame_setup_shape): Fix warnings.
* fvwm/icons.c (CreateIconWindow): Fix warnings.
* fvwm/add_window.c (setup_style_and_decor): Fix warnings.
* fvwm/events.c (_handle_cr_on_shaped): Fix warnings.
* configure.ac: Add helper macro SUPPRESS_UNUSED_VAR_WARNING to fake
using a variable and its value in certain hard to fix places.
* fvwm/menus.c (size_menu_vertically): Fix write access to read-only
location with gettext.

libs:
* fsm.c (SaveYourselfPhase2ReqProc, SaveYourselfDoneProc)
(NewConnectionMsg): Fix warnings.
* FGettext.c (FGettextInit): Fix warnings.
* FImage.c (FGetFImage): Fix warnings.
* Fft.c (FftGetFont): Fix warnings.
* FRender.c (FRenderVisualInit, FRenderCreateShadePicture)
(FRenderTintPicture, FRenderTintRectangle, FRenderRender): Fix
warnings.
* FScreen.c (FScreenInit): Fix warnings.
* Ficonv.c (is_translit_supported, convert_charsets): Fix warnings.

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread Thomas Adam 
On Sat, Oct 22, 2016 at 10:53:10PM +0100, Dominik Vogt wrote:
> Different approach at fixing the warning.  Hopefully this one
> works without removing any "uninitialised variable" warnings.  The
> macro SUPPRESS_UNUSED_VAR_WARNING(var) from config.h is used to
> remove the "set but not used" warning in the discussed case.
> 
> I've forced a new version of the branch replacing the old one.
> 
> Plese double check this is sensible.

OK, this looks better.  Thanks!

GCC/Clang don't moan at these changes, which is good.  The changes built via
travis-ci just fine.

I say you're good to merge to master.

-- Thomas Adam

Re: [fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread Dominik Vogt 
Different approach at fixing the warning.  Hopefully this one
works without removing any "uninitialised variable" warnings.  The
macro SUPPRESS_UNUSED_VAR_WARNING(var) from config.h is used to
remove the "set but not used" warning in the discussed case.

I've forced a new version of the branch replacing the old one.

Plese double check this is sensible.

>   * fvwm/session.c (SessionInit, set_sm_properties): Fix warnings.
>   * fvwm/frame.c (frame_prepare_animation_shape)
>   (frame_setup_shape): Fix warnings.
>   * fvwm/icons.c (CreateIconWindow): Fix warnings.
>   * fvwm/add_window.c (setup_style_and_decor): Fix warnings.
>   * fvwm/events.c (_handle_cr_on_shaped): Fix warnings.
>   * configure.ac: Add helper macro SUPPRESS_UNUSED_VAR_WARNING to fake
>   using a variable and its value in certain hard to fix places.
>   * fvwm/menus.c (size_menu_vertically): Fix write access to read-only
>   location with gettext.
> 
> libs:
>   * fsm.c (SaveYourselfPhase2ReqProc, SaveYourselfDoneProc)
>   (NewConnectionMsg): Fix warnings.
>   * FGettext.c (FGettextInit): Fix warnings.
>   * FImage.c (FGetFImage): Fix warnings.
>   * Fft.c (FftGetFont): Fix warnings.
>   * FRender.c (FRenderVisualInit, FRenderCreateShadePicture)
>   (FRenderTintPicture, FRenderTintRectangle, FRenderRender): Fix
>   warnings.
>   * FScreen.c (FScreenInit): Fix warnings.
>   * Ficonv.c (is_translit_supported, convert_charsets): Fix warnings.

Ciao

Dominik ^_^  ^_^

-- 

Dominik Vogt

[fvwmorg/fvwm] c0ae18: Fix Gcc warnings.

2016-10-22 Thread GitHub 
  Branch: refs/heads/dv-gcc-warning-fixes
  Home:   https://github.com/fvwmorg/fvwm
  Commit: c0ae18064466425f3864bd1e3baf03815cae4a44
  
https://github.com/fvwmorg/fvwm/commit/c0ae18064466425f3864bd1e3baf03815cae4a44
  Author: Dominik Vogt 
  Date:   2016-10-22 (Sat, 22 Oct 2016)

  Changed paths:
M configure.ac
M fvwm/add_window.c
M fvwm/events.c
M fvwm/frame.c
M fvwm/icons.c
M fvwm/menus.c
M fvwm/session.c
M libs/FGettext.c
M libs/FImage.c
M libs/FRender.c
M libs/FScreen.c
M libs/Fft.c
M libs/Ficonv.c
M libs/fsm.c
M modules/FvwmConsole/getline.c

  Log Message:
  ---
  Fix Gcc warnings.

* fvwm/session.c (SessionInit, set_sm_properties): Fix warnings.
* fvwm/frame.c (frame_prepare_animation_shape)
(frame_setup_shape): Fix warnings.
* fvwm/icons.c (CreateIconWindow): Fix warnings.
* fvwm/add_window.c (setup_style_and_decor): Fix warnings.
* fvwm/events.c (_handle_cr_on_shaped): Fix warnings.
* configure.ac: Add helper macro SUPPRESS_UNUSED_VAR_WARNING to fake
using a variable and its value in certain hard to fix places.
* fvwm/menus.c (size_menu_vertically): Fix write access to read-only
location with gettext.

libs:
* fsm.c (SaveYourselfPhase2ReqProc, SaveYourselfDoneProc)
(NewConnectionMsg): Fix warnings.
* FGettext.c (FGettextInit): Fix warnings.
* FImage.c (FGetFImage): Fix warnings.
* Fft.c (FftGetFont): Fix warnings.
* FRender.c (FRenderVisualInit, FRenderCreateShadePicture)
(FRenderTintPicture, FRenderTintRectangle, FRenderRender): Fix
warnings.
* FScreen.c (FScreenInit): Fix warnings.
* Ficonv.c (is_translit_supported, convert_charsets): Fix warnings.