[PATCH] Fix broken Perl version dependency in fvwm-menu-desktop

2011-04-16 Thread Sergey Vlasov
use version '5.0008' does not do what was intended - the proper form
for Perl version dependency is use 5.008.  The broken statement does
not do anything useful and breaks packaging at least in ALT Linux
(use statements in perl scripts are translated to RPM dependencies,
therefore the package gets an unresolvable dependency on a nonexistent
version of the version.pm module).

Index: bin/ChangeLog
===
RCS file: /home/cvs/fvwm/fvwm/bin/ChangeLog,v
retrieving revision 1.100
diff -u -p -r1.100 ChangeLog
--- bin/ChangeLog   10 Apr 2011 22:25:37 -  1.100
+++ bin/ChangeLog   16 Apr 2011 19:46:14 -
@@ -1,3 +1,7 @@
+2011-04-16  Sergey Vlasov  v...@altlinux.ru
+
+   * fvwm-menu-desktop.in: Specify perl = 5.8 requirement properly.
+
 2011-04-10  Thomas Adam  tho...@fvwm.org
* fvwm-menu-desktop.in (get_root_menu):
Make the root menu look for more than one place.
Index: bin/fvwm-menu-desktop.in
===
RCS file: /home/cvs/fvwm/fvwm/bin/fvwm-menu-desktop.in,v
retrieving revision 1.14
diff -u -p -r1.14 fvwm-menu-desktop.in
--- bin/fvwm-menu-desktop.in10 Apr 2011 22:25:37 -  1.14
+++ bin/fvwm-menu-desktop.in16 Apr 2011 19:46:14 -
@@ -72,7 +72,7 @@
 #  
 #  Author: nadvor...@suse.cz
 
-use version '5.0008';
+use 5.008;
 use strict;
 use warnings;
 use Getopt::Long;



Re: [PATCH] Fix broken Perl version dependency in fvwm-menu-desktop

2011-04-16 Thread Thomas Adam
On Sat, Apr 16, 2011 at 11:56:36PM +0400, Sergey Vlasov wrote:
 use version '5.0008' does not do what was intended - the proper form

Thank you, but I've already fixed this with a runtime check for XML::Parser.

-- Thomas Adam

-- 
It was the cruelest game I've ever played and it's played inside my head.
-- Hush The Warmth, Gorky's Zygotic Mynci.