Re: TrianglesUseFore patch.

2005-12-21 Thread Viktor Griph

On Mon, 21 Nov 2005, Malcolm Still wrote:

Hello again,

I've now patched against the CVS version. Again I've uploaded
it to my webspace:
http://rv.sdf-eu.org/CVSTrianglesUseFore.patch

With the old patch I'd also found that it didn't paint with the
foreground colour when using TrianglesRelief, so I modified
the patch to do that.

I've also patched menustyle_copy() to copy the TrianglesUseFore
value to a new menustyle, which it didn't do before.

As requested you can use !TrianglesUseFore to negate the
option.

I've also patched the manpage, AUTHORS, and NEWS to
reflect the new option.

Hope thats all fine.



I've applied your patch, with lines shortened to less than 80 characters. 
If you write another patch in the future you should not use more than 79 
columns. Also when responding to this list you should write the reply 
after the quoted text.


/Viktor



Re: TrianglesUseFore patch.

2005-11-20 Thread Malcolm Still
Hello again,

I've now patched against the CVS version. Again I've uploaded
it to my webspace:
http://rv.sdf-eu.org/CVSTrianglesUseFore.patch

With the old patch I'd also found that it didn't paint with the
foreground colour when using TrianglesRelief, so I modified
the patch to do that.

I've also patched menustyle_copy() to copy the TrianglesUseFore
value to a new menustyle, which it didn't do before.

As requested you can use !TrianglesUseFore to negate the 
option.

I've also patched the manpage, AUTHORS, and NEWS to 
reflect the new option.

Hope thats all fine.

Regards,
Malcolm
 On 11/18/05, Viktor Griph [EMAIL PROTECTED] wrote:
On Fri, 18 Nov 2005, Mikhael Goikhman wrote: On 14 Nov 2005 01:31:05 +, Malcolm Still wrote: This patch allows users to use their menu foreground colour for submenu triangles, by using the new MenuStyle keyword TrianglesUseFore,
 e.g.: MenuStyle * TrianglesSolid, TrianglesUseFore I've uploaded the patch to my webspace at: http://rv.sdf-eu.org/trianglesusefore.diff
 I think this patch is short and good. Can you also patch all other relevant files, like the man page, NEWS? Regards, Mikhael.Also, please do the patch against the CVS version, or a recent snapshot.
It should also be possible to negate the effect of the style./Viktor


Re: TrianglesUseFore patch.

2005-11-17 Thread Mikhael Goikhman
On 14 Nov 2005 01:31:05 +, Malcolm Still wrote:
 
 This patch allows users to use their menu foreground colour for
 submenu triangles, by using the new MenuStyle keyword TrianglesUseFore,
 e.g.:
 
 MenuStyle * TrianglesSolid, TrianglesUseFore
 
 I've uploaded the patch to my webspace at:
 http://rv.sdf-eu.org/trianglesusefore.diff

I think this patch is short and good.

Can you also patch all other relevant files, like the man page, NEWS?

Regards,
Mikhael.