Re: memleak in FScreenParseGeometryWithScreen

2021-11-25 Thread Thomas Adam
On Fri, Nov 26, 2021 at 12:45:36AM +0100, Dominik Vogt wrote:
> On Thu, Nov 25, 2021 at 11:04:25PM +, Thomas Adam wrote:
> > On Wed, Nov 24, 2021 at 03:13:34PM +0100, Dominik Vogt wrote:
> > > From FScreen.c:FScreenParseGeometryWithScreen():
> > >
> > > I can't fix this because I don't understand what the code does.
> >
> > I will fix this.
> 
> Too late, but please do look at the two commits I made.  The

I'll check more thoroughly in the morning.  I'm not too sure this should have
been merged to master though as it's still under review, as far as I can tell.
There's no need to rush to merge on-going work like this.

> structure "icon_boxes" (fvwm.h) really should not contain an
> allocated string.  Can we not store the numeric screen rectangle
> instead of the name?

Quite possibly.  I've a few other fixes to IconBox laying around here, so I'll
double-check.

Kindly,
Thomas



Re: memleak in FScreenParseGeometryWithScreen

2021-11-25 Thread Dominik Vogt
On Thu, Nov 25, 2021 at 11:04:25PM +, Thomas Adam wrote:
> On Wed, Nov 24, 2021 at 03:13:34PM +0100, Dominik Vogt wrote:
> > From FScreen.c:FScreenParseGeometryWithScreen():
> >
> > I can't fix this because I don't understand what the code does.
>
> I will fix this.

Too late, but please do look at the two commits I made.  The
structure "icon_boxes" (fvwm.h) really should not contain an
allocated string.  Can we not store the numeric screen rectangle
instead of the name?

Ciao

Dominik ^_^  ^_^

--

Dominik Vogt



Re: memleak in FScreenParseGeometryWithScreen

2021-11-25 Thread Thomas Adam
On Wed, Nov 24, 2021 at 03:13:34PM +0100, Dominik Vogt wrote:
> From FScreen.c:FScreenParseGeometryWithScreen():
>
> I can't fix this because I don't understand what the code does.

I will fix this.

Kindly,
Thomas