Hi Bernard,
I tried the binary rpms from dag and they worked good, but I couldn't
rebuild the 1.2 version of the src rpm on my RHEL4 server, so I could
try adding my patch to it. I think it failed with a libtool error, but
I haven't had the time to look into it.
~Jason
On Fri, 2006-04-14 at 18:48, Bernard Li wrote:
Hi Jason:
Thanks for the patch.
FYI you can download prebuilt RHEL4 RPMs for rrdtool 1.2.12 here:
http://dag.wieers.com/packages/rrdtool/
Cheers,
Bernard
__
From: [EMAIL PROTECTED] on behalf of Jason
A. Smith
Sent: Fri 14/04/2006 15:13
To: [EMAIL PROTECTED]
Cc: Ganglia General
Subject: [Ganglia-general] rrdtool patch to guarantee 2 vertical grid
labels.
In our experience, ganglia's use of rrdtool to make the metric graphs
will often result in only a single 0 y-axis grid label, especially on
the small graphs. This makes the graph almost useless since there is
no
vertical scale information. I looked at the rrdtool source code and
came up with the attached patch, which will guarantee the addition of
a
second y-axis grid label, if only one has been added so far and the
current grid line is the last available one where a label can be
added,
as it loops through adding all of the grid lines.
Since we are still using rrdtool 1.0.50 here, this is the only version
of the patch that I have tested, and it seems to work well. I made a
similar patch for version 1.2.12, but it is untested. I tried
compiling
the stock 1.2.12 version of rrdtool on a RHEL4 system, but it failed
and
I haven't had the time to investigate further.
I also attached two images from ganglia to illustrate the problem,
showing the same graph before after my patch. I am sending this
email
to the rrdtool developers list to see if they will consider including
it, and also to the ganglia user's list in case any other ganglia
users
would like to try it.
~Jason
--
/--\
| Jason A. Smith Email: [EMAIL PROTECTED] |
| Atlas Computing Facility, Bldg. 510MPhone: (631)344-4226 |
| Brookhaven National Lab, P.O. Box 5000 Fax:(631)344-7616 |
| Upton, NY 11973-5000|
\--/
