[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Sebastian Pop changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #16 from Sebastian Pop --- fixed in r232658.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #15 from vries at gcc dot gnu.org --- https://gcc.gnu.org/ml/gcc-cvs/2016-01/msg00644.html : Author: spop Date: Thu Jan 21 02:13:52 2016 New Revision: 232658 URL: https://gcc.gnu.org/viewcvs?rev=232658=gcc=rev Log: fix PR68976: only add loop close phi for names defined in loop * graphite-isl-ast-to-gimple.c: Fix comment. * graphite-scop-detection.c (defined_in_loop_p): New. (canonicalize_loop_closed_ssa): Do not add close phi nodes for SSA names defined in loop. gcc/testsuite * gcc.dg/graphite/pr68976.c: New test. Added: trunk/gcc/testsuite/gcc.dg/graphite/pr68976.c Modified: trunk/gcc/ChangeLog trunk/gcc/graphite-isl-ast-to-gimple.c trunk/gcc/graphite-scop-detection.c trunk/gcc/testsuite/ChangeLog
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 vries at gcc dot gnu.org changed: What|Removed |Added Keywords||patch --- Comment #9 from vries at gcc dot gnu.org --- https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01067.html
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #11 from vries at gcc dot gnu.org --- Created attachment 37354 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=37354=edit test.c.137t.graphite
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #10 from vries at gcc dot gnu.org --- Created attachment 37353 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=37353=edit pdfs.tgz For the record: 1-pre.pdf Before scop detection 2-scops.pdf After scop detection 3-cond.pdf After moving region into condition 4-ice.pdf At ICE.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #12 from vries at gcc dot gnu.org --- (In reply to vries from comment #9) > https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01067.html Hmm. The patch does not address the dup PR68692, and introduces a new ICE for that test-case.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #13 from vries at gcc dot gnu.org --- new patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01139.html
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #14 from vries at gcc dot gnu.org --- (In reply to vries from comment #13) > new patch: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01139.html new patch does not fix dup. Will reopen dup.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 vries at gcc dot gnu.org changed: What|Removed |Added CC||vries at gcc dot gnu.org --- Comment #7 from vries at gcc dot gnu.org --- This patch triggers the error earlier, at the point where we insert a phi argument that is not dominated by its def: ... diff --git a/gcc/sese.c b/gcc/sese.c index 59d2770..9dbc3c8 100644 --- a/gcc/sese.c +++ b/gcc/sese.c @@ -278,6 +278,8 @@ sese_add_exit_phis_edge (basic_block exit, tree use, edge false_e, edge true_e) gphi *phi = create_phi_node (NULL_TREE, exit); create_new_def_for (use, phi, gimple_phi_result_ptr (phi)); add_phi_arg (phi, use, false_e, UNKNOWN_LOCATION); + gcc_assert (dominated_by_p (CDI_DOMINATORS, true_e->src, + gimple_bb (SSA_NAME_DEF_STMT (use; add_phi_arg (phi, use, true_e, UNKNOWN_LOCATION); update_stmt (phi); } ...
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #8 from vries at gcc dot gnu.org --- Created attachment 37344 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=37344=edit tentative patch
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #5 from Joost VandeVondele --- I'm somewhat surprised graphite regressions get a P4. Discussions on the list suggested that graphite would be enabled by default in the near future. Lowering graphite regression priority to 'not serious' signals the opposite. It is a bit a chicken-and-egg problem, graphite won't get good testing if it is not reliable, and it won't get reliable if it doesn't get good testing.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 --- Comment #6 from Jeffrey A. Law --- P4 priority for Graphite issues is consistent with prior releases. While I'm extremely happy to see Sebastian and others addressing graphite issues again, I can't see any path by which graphite is turned on by default for GCC 6.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Jeffrey A. Law changed: What|Removed |Added Priority|P3 |P4 CC||law at redhat dot com --- Comment #3 from Jeffrey A. Law --- Look in DUP for additional testcase (fortran)
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Jeffrey A. Law changed: What|Removed |Added CC||Joost.VandeVondele at mat dot ethz ||.ch --- Comment #2 from Jeffrey A. Law --- *** Bug 68692 has been marked as a duplicate of this bug. ***
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Dominique d'Humieres changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed||2016-01-12 Ever confirmed|0 |1 --- Comment #4 from Dominique d'Humieres --- > *** Bug 68692 has been marked as a duplicate of this bug. *** If a confirmed PR is a duplicate of this one, it should probably be confirmed too.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Arseny Solokha changed: What|Removed |Added CC||spop at gcc dot gnu.org --- Comment #1 from Arseny Solokha --- Probably a duplicate of PR68692.
[Bug tree-optimization/68976] [6 Regression] ICE w/ -O2 (and above) -fgraphite-identity (or -floop-nest-optimize)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68976 Andrew Pinski changed: What|Removed |Added Target Milestone|--- |6.0
