Re: [PATCH AutoFDO]Skip generating histogram value for internal call

[Jeff Law]

On 12/12/18 8:50 PM, bin.cheng wrote:
> Hi,
> This patch skips generating histogram value for internal function call in 
> autofdo,
> otherwise it would trigger ICE with following patch re-enabling indirect call 
> value
> profile transformation.  I think this patch is actually needed for GCC-6 on 
> which
> indirect call value profile is not disabled.
> 
> Bootstrap and test on x86_64 along with following patches.  Is it OK?
> 
> Thanks,
> bin
> 
> 2018-12-13  Bin Cheng  
> 
> * auto-profile.c (afdo_indirect_call): Skip generating histogram
> value for internal call.
> 
OK
jeff

[PATCH AutoFDO]Skip generating histogram value for internal call

[bin.cheng]

Hi,
This patch skips generating histogram value for internal function call in 
autofdo,
otherwise it would trigger ICE with following patch re-enabling indirect call 
value
profile transformation.  I think this patch is actually needed for GCC-6 on 
which
indirect call value profile is not disabled.

Bootstrap and test on x86_64 along with following patches.  Is it OK?

Thanks,
bin

2018-12-13  Bin Cheng  

* auto-profile.c (afdo_indirect_call): Skip generating histogram
value for internal call.

0004-Don-t-generate-histogram-value-for-internal-call-in-.patch
Description: Binary data