Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hello,

Am Mo den  6. Aug 2012 um 15:51 schrieb Vladimir Nadvornik:
 I thought that I release 1.1 ASAP and then,

Good Idea.

 if sombebody complains, eventually release 1.1.1. But it is no problem
 to delay the release if you want to test it before.

Do you really think we have the resources to manage 3 levels of
versions? I think we should just increment the second version digit. So
just go on to 1.2, 1.3, ...

Regards
   Klaus
- -- 
Klaus Ethgen  http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen kl...@ethgen.de
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.12 (GNU/Linux)

iQGcBAEBCgAGBQJQIOtfAAoJEKZ8CrGAGfasVzwMAKy/CFrKh0UESo5aQCKTE/IU
SiX8QUpM0g2VP7Cqfpel5xbTPljEF9cKtbo4dxTVLJ7Um/JYJME5K272gTrfb51l
5bzdWgJlcw/Dk9jIWgFzyeV2tla+EMIth0Z2ELU7MZeJuEbhoYH9aAIjlrHgcLo+
EFBnVUDPDGLOL9ShVpLvVSIofFSfF45LpLtV0Qi1RMsZ+0ABJWvVUmC+n06zOtqG
B/WlHWFu1unM+1YzpJonTGTFF2QptxDh7OjJz/NGfb6o5h8kS1syFb0HhEn3m0F0
eMi/C1G0VgvCHSdvyeOShX02HMmLqplViTL8vSMSWEYZV2XkibgbTEuUmTc9NPyP
gv7qnvs52NftMzEyO7865llJmStFNbwevnllCYKjcOYZ1PQv/eO/vSjmiP5gFbj9
7rIGpdiIkVDpRDDp6Le9mn16c3ZYpTgkzN4OHI+IprJPCYFAGQJbpNzXA+deOQqt
X76ctQivgyAL5wBytvgSjHMRJ2Rs9wqXczDuTMTlMw==
=cwAB
-END PGP SIGNATURE-

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Greg Troxel

Vladimir Nadvornik nadvor...@suse.cz writes:

 The tarball I used for creating the testing packages can be downloaded here:

 http://download.opensuse.org/repositories/home:/nadvornik:/geeqie:/testing/Debian_5.0/geeqie_1.1.orig.tar.gz

Thanks very much for putting that up.  I downloaded it and renamed it to

  geeqie-1.1.tar.gz

which I think is the normal name for the tarball and what I'd expect the
released name to be (and the above is a debianized version, with s/-/_/
and .orig added).  I updated pkgsrc (locally), and the only change I had
to make from 1.0 was that one of the localization files changed names:

-share/locale/zh_CN.GB2312/LC_MESSAGES/geeqie.mo
+share/locale/zh_CN/LC_MESSAGES/geeqie.mo

I installed the new version and used it (the way I use 1.0, which means
not tree view, and not a lot of other stuff, but includes gps/osm
display) and it worked fine.  This was on NetBSD 5.1_STABLE, i386.

The NEWS file says it's a wiki snapshot.  Presumably it contains all the
things new since 1.0, and the wiki page will be deleted (or a new one
created) the next time?  So that file is really NEWS since 1.0?
(pkgsrc requires NEWS-type content in commit messages that update the
version.)

Greg


pgpHlrjnHInOK.pgp
Description: PGP signature
--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Vladimir Nadvornik
On Tuesday, August 07, 2012 10:37:20 AM Michael Schwendt wrote:
  Maybe the attached patch fixes it.
 
 Not entirely. It's been harder to make it crash, though:
 
   filedata.c:446: fd magick mismatch at filedata.c:629
   **
   ERROR:filedata.c:448:file_data_ref_debug: assertion failed: (fd-magick ==
 0x12345678)

Ok, then I would like to know what was the output from line 628 (removing 
unknown...).

Vladimir


--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Michael Schwendt
On Tue, 07 Aug 2012 17:05:58 +0200, Vladimir Nadvornik wrote:

  removing unknown sidecar /home/misc/tmp/stresstest/000454.JPG: �Jd8 fd
  magick mismatch at filedata.c:629
  **
  ERROR:filedata.c:448:file_data_ref_debug: assertion failed: (fd-magick ==
  0x12345678) Aborted
 
 Hmm, this could be corrupted anywhere. 

My brute-force change from last year is this:

  
http://pkgs.fedoraproject.org/cgit/geeqie.git/plain/geeqie-1.0-vflist-refresh.patch

With it and a couple of tiny patches (some cherry-picked post-1.0 ones),
users have not reported any further crashes:

  http://pkgs.fedoraproject.org/cgit/geeqie.git/tree/

Anyway, I'll try to create an isolated stresstest script.

-- 
Fedora release 17 (Beefy Miracle) - Linux 3.5.0-2.fc17.x86_64
loadavg: 0.19 0.31 0.22

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread John Stoffel
 Klaus == Klaus Ethgen klaus+gee...@ethgen.de writes:

Klaus -BEGIN PGP SIGNED MESSAGE-
Klaus Hash: SHA512

Klaus Hello,

Klaus Am Mo den  6. Aug 2012 um 21:21 schrieb John Stoffel:
 /home/john/src/geegie/gitorious/src/exif-common.c:642: undefined
 reference to `assert'

Klaus I will just go and track that down. It is a annoying problem. That is
Klaus only a missing library but I do not know which one.

I tried tracking it, but haven't had any time to spend on testing.
Thanks for looking into it.

John

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread John Stoffel
 Vladimir == Vladimir Nadvornik nadvor...@suse.cz writes:

Vladimir Dne pondělí 06 Srpen 2012 22:28:29 John Stoffel napsal(a):
John I've pulled down the latest v1.1 from GIT and tried to configure
John and compile on a Debian Squeeze (v5.0) system, but each time I
John get an error when compiling, it's looking for 'assert' but I
John haven't had a chance to dig into this in any detail.  I'm doing
John the full
 
John exif-common.o: In function `exif_init_cache':
John /home/john/src/geegie/gitorious/src/exif-common.c:642: undefined
 
 Well, now that I've spent two minutes on this, it now compiles if
 I change that to g_assert() instead of assert() in that file.
 Haven't a chance to actually run it though.
 
 I did also try installing libexif-dev, libexif-gtk-dev and another
 library which wasn't installed yet, but that didn't make a
 difference.
 
 I'm wondering why other's aren't seeing this problem?  I'm current as
 of commit 5fd7dc2e202ea131aa0d9d399a17066c3be56393
 

Vladimir Here is my log from debian 5.0. It compiles fine.

Vladimir 
https://build.opensuse.org/package/rawlog?arch=x86_64package=geeqieproject=home%3Anadvornik%3Ageeqie%3Atestingrepository=Debian_5.0


Vladimir You can compare the details if you want, but I also think that 
changing it to 
Vladimir g_assert is the easiest fix.

If it's a missing dependency in the build, then fixing the autogen.sh
and configure steps might be a good thing too.  Though I don't know
how divergent the various distros are from each other in terms of
packaging libraries.  

I'll see about pulling out your install list and comparing it with
mine to see what libsyou have installed that I don't have.  

But if just changing to g_assert is the answer... then we should
probably go there.

John

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread John Stoffel

vinit The current version of geeqie1.1 that vladimir has putted, is
vinit not been able to recognize the image files if the file names of
vinit these file do not end with one of the standard image file
vinit extension. I think the application should look into the
vinit directory for all the image files based on their format rather
vinit than their file extension. like how the nautilus, the default
vinit file browser for gnome does. it does it for all media files. i
vinit think geeqie should have this feature.

It's a good idea, but maybe have it as an option instead?  If the
option is on (default off), geeqie does the equivilent of a 'file'
command on each file to see if it can determine the image type.  

And if you want to whip up a patch, even just an example one, I'm sure
that would be an incentive to get it into the app.

John

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Omari Stephens
On 08/07/2012 07:27 PM, John Stoffel wrote:

 vinit The current version of geeqie1.1 that vladimir has putted, is
 vinit not been able to recognize the image files if the file names of
 vinit these file do not end with one of the standard image file
 vinit extension. I think the application should look into the
 vinit directory for all the image files based on their format rather
 vinit than their file extension. like how the nautilus, the default
 vinit file browser for gnome does. it does it for all media files. i
 vinit think geeqie should have this feature.

 It's a good idea, but maybe have it as an option instead?  If the
 option is on (default off), geeqie does the equivilent of a 'file'
 command on each file to see if it can determine the image type.

 And if you want to whip up a patch, even just an example one, I'm sure
 that would be an incentive to get it into the app.

If it's an option, it should default to off.  Having to fork() and 
read() for every single file in a directory is drastically more 
expensive than just doing a single scandir() on the containing directory.

That said, I do question just how useful or widely-used it would be. 
How many people (1) have images which are stored without appropriate 
file extensions, and (2) use, or would use, geeqie rather than something 
less powerful/more user-friendly?  Given how many dark, unmaintained 
corners geeqie has already, I definitely think we should make sure that 
the features we add have sufficient value.

--xsdg



--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Vladimir Nadvornik
Dne úterý 07 Srpen 2012 17:16:59 Michael Schwendt napsal(a):
 On Tue, 07 Aug 2012 17:05:58 +0200, Vladimir Nadvornik wrote:
   removing unknown sidecar /home/misc/tmp/stresstest/000454.JPG: �Jd8 fd
   magick mismatch at filedata.c:629
   **
   ERROR:filedata.c:448:file_data_ref_debug: assertion failed: (fd-magick
   == 0x12345678) Aborted
  
  Hmm, this could be corrupted anywhere.
 
 My brute-force change from last year is this:
 
  
 http://pkgs.fedoraproject.org/cgit/geeqie.git/plain/geeqie-1.0-vflist-refr
 esh.patch
 

IMHO the only possibility how this could fix it is that this is a bug in gtk. 
On the other hand it would explain that it works for me - I probably have a 
different gtk version.

Vladimir




--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread John Stoffel
 Omari == Omari Stephens x...@csail.mit.edu writes:

Omari On 08/07/2012 07:27 PM, John Stoffel wrote:
 
vinit The current version of geeqie1.1 that vladimir has putted, is
vinit not been able to recognize the image files if the file names of
vinit these file do not end with one of the standard image file
vinit extension. I think the application should look into the
vinit directory for all the image files based on their format rather
vinit than their file extension. like how the nautilus, the default
vinit file browser for gnome does. it does it for all media files. i
vinit think geeqie should have this feature.
 
 It's a good idea, but maybe have it as an option instead?  If the
 option is on (default off), geeqie does the equivilent of a 'file'
 command on each file to see if it can determine the image type.
 
 And if you want to whip up a patch, even just an example one, I'm sure
 that would be an incentive to get it into the app.

Omari If it's an option, it should default to off. 

That's what I suggested too.  

Omari Having to fork() and read() for every single file in a
Omari directory is drastically more expensive than just doing a
Omari single scandir() on the containing directory.

Well, since we already build thumbnails when we enter a directory, it
might only need to do this work when it finds a file it doesn't
recognize in terms of extension. 

Omari That said, I do question just how useful or widely-used it
Omari would be.  How many people (1) have images which are stored
Omari without appropriate file extensions, and (2) use, or would use,
Omari geeqie rather than something less powerful/more user-friendly?

I think I'd like to have this, since sometimes I have geeqie list
files in my thumbnail view which it can't open for various reasons.  

Omari Given how many dark, unmaintained corners geeqie has already, I
Omari definitely think we should make sure that the features we add
Omari have sufficient value.

Sure, but if it's not expensive to implement as a test... what hurt
can it do?  *grin*  I took a quick look throug  the code, but I didn't
find the proper routines, but I'm also not up on the gtk toolkit
either, so I don't know what to look for.

John

--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Geeqie 1.1

2012-08-07 Thread Vladimir Nadvornik
Dne úterý 07 Srpen 2012 19:10:07 vinit agrawal napsal(a):
 hello ,
 
 The current version of geeqie1.1 that vladimir has putted, is not been able
 to recognize the image files if the file names of these file do not
 end with one of the standard image file extension. I think the application
 should look into the directory for all the image files based on their
 format rather than their file extension. like how the nautilus, the default
 file browser for gnome does. it does it for all media files. i think geeqie
 should have this feature.
 
 --Vinit

In the preferences you can add the extensions you need or disable file 
filtering at all.

Image and thumbnail decoding is based on file content, so it should work OK.

Creating/filtering of the file list (which can contain thousands of files) 
based on file content would be unaccceptably slow. BTW, the same problem we 
have have with sorting by exif date.

Vladimir





--
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel