Hello everyone!

The patch for LCMS2 support that has been published on this list does the
following to generate the tooltip texts for "Image profile" and "Screen
profile":

        cmsUInt8Number profileID[17];
        profileID[16] = '\0';
        cmsGetHeaderProfileID(profile, profileID);
        return g_strdup(profileID);

This results in unprintable strings that can crash g_markup, because
these profile IDs are based on MD5. Even with LCMS1 unpatched,
Geeqie could not print such a Screen profile name and warned about it
in terminal output (probably causing a crash in special cases, too).

One safer way to retrieve printable image/screen profile names is this:

        cmsUInt32Number r;
        char buffer[20];
        buffer[0] = '\0';
        r = cmsGetProfileInfoASCII(profile, cmsInfoDescription, "en", "US", 
&buffer, 20);
        return g_strdup(buffer);

Find the full revised patch at:
http://mschwendt.fedorapeople.org/geeqie-1.1-lcms2.patch

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to