Re: [Geeqie-devel] Collections - collect_io.c - possible bug

2011-01-21 Thread Laurent Monin
Colin Clark a écrit :
 Hi

 If one sets up a collection with a single file, then renames that file, 
 Geeqie will crash.

 I believe the problem is line 661 in collect_io.c where 'path' is freed. 
 This is coming from the call in line 161 where 'buf' is set to something 
 that should not be freed.

 At the moment I do not understand the collection code, but for me just 
 commenting out line 661 solves the problem.


 Colin Clark


   
Hi,

from what i see, this part of code is totally wrong.
We are trying to free mem used elsewhere due to code at lines 151-155 i 
think.
@buf is pointing to a random point in a string, in no case it should be 
freed.

I don't have time atm to fix it, let's see if Klaus can.

--
Zas



--
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


[Geeqie-devel] Collections - collect_io.c - possible bug

2011-01-20 Thread Colin Clark
Hi

If one sets up a collection with a single file, then renames that file, 
Geeqie will crash.

I believe the problem is line 661 in collect_io.c where 'path' is freed. 
This is coming from the call in line 161 where 'buf' is set to something 
that should not be freed.

At the moment I do not understand the collection code, but for me just 
commenting out line 661 solves the problem.


Colin Clark


--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel


Re: [Geeqie-devel] Collections - collect_io.c - possible bug

2011-01-20 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi,

Am Do den 20. Jan 2011 um 19:34 schrieb Colin Clark:
 If one sets up a collection with a single file, then renames that file, 
 Geeqie will crash.

I will check that. Unfortunately there are some more problems with
collections that was no problem with gqview. One is when you view a
collection and delete the current viewed picture, in gqview the next
file was viewed and you was able to go on; with geeqie no file is viewed
anymore and you cannot go on.

 At the moment I do not understand the collection code,

I have the same problem. I did plan several time to dive into this code
to solve the problem. But Vlad seems to be the only one who know the
code. Lets see what I can do.

Regards
   Klaus
- -- 
Klaus Ethgenhttp://www.ethgen.ch/
pub  2048R/D1A4EDE5 2000-02-26 Klaus Ethgen kl...@ethgen.de
Fingerprint: D7 67 71 C4 99 A6 D4 FE  EA 40 30 57 3C 88 26 2B
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)

iQEVAwUBTTiD5Z+OKpjRpO3lAQpSIQgAsvaX7jPdb9tgZQXMHu8WXGX37nE+lV+Q
Oc35wESG0yFFXQ85E4Ud159Tu6ubuk2UlfhkodMO1X7+Krqo1aoSQofsiXv1Nyp/
r6IvNsuJbzTkWa4aeY5XeefWYFdvR2lrAE7tm5jRPN3v/PgKwxoIU94OKnP+64IT
hxlUcMshcxxCRDPdC0U+8YSr7hM3Ig/5gAFahlrZzc8jpz7tfYIAJBfhP9XLC0BA
KEzKZ6U3++j9pE+oy8h/kTSALhY4LcpZR9wrJ0Hk6B1OFa0oTghxKaOmx8M/EqJu
QwsCywZ51+dD0IMrddF73lnpyiJzORhChrqE22LEE2z1w9rjSLzQ5Q==
=oMQ/
-END PGP SIGNATURE-

--
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand 
malware threats, the impact they can have on your business, and how you 
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel