Re: [Gimp-developer] patch: change default units for colors/map/rotate colors, from radians over pi (!) to degrees
On Tue, 2012-12-04 at 22:42 -0500, Liam R E Quin wrote: On Tue, 2012-12-04 at 23:49 +0100, Michael Natterer wrote: Yeah, go ahead and push to 2-8 and master please. Thanks. Someone else will have to do that, I'm afraid - I've never had commit access, nor (I think) a gnome.org account. Unbelievable :) Or I can squirrel the patch away in bugzilla if you prefer. Yes please file a bug, I'm pretty busy at the moment, --mitch ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] patch: change default units for colors/map/rotate colors, from radians over pi (!) to degrees
On Wed, 2012-12-05 at 11:05 +0100, Michael Natterer wrote: Yes please file a bug done, with patch attached, 689712 Liam -- Liam Quin - XML Activity Lead, W3C, http://www.w3.org/People/Quin/ Pictures from old books: http://fromoldbooks.org/ Ankh: irc.sorcery.net irc.gnome.org freenode/#xml ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] patch: change default units for colors/map/rotate colors, from radians over pi (!) to degrees
On Tue, Dec 4, 2012 at 3:08 PM, Liam R E Quin l...@holoweb.net wrote: The colors/map/rotate colors dialog box uses angles to show colour ranges; it defaults to using radians over pi for the angle. I'm pretty sure more Gimp users will want degrees than radians over pi for rotating colours. There's a pull-down menu to change it, but it's irritating to have to do that every time, and it seems crazy to add a preference. This seems like a much saner default. Rockwalrus ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] patch: change default units for colors/map/rotate colors, from radians over pi (!) to degrees
On Tue, 2012-12-04 at 15:08 -0500, Liam R E Quin wrote: The colors/map/rotate colors dialog box uses angles to show colour ranges; it defaults to using radians over pi for the angle. I'm pretty sure more Gimp users will want degrees than radians over pi for rotating colours. There's a pull-down menu to change it, but it's irritating to have to do that every time, and it seems crazy to add a preference. The enclosed patch changes the default to degrees. It does not affect the actual plugin, only the GIMP dialog box. The change would presumably also affect the documentation. Minor note, the indenting and code style in this plugin is somewhat varied, e.g. with spaces in foo () in some places and not - foo() - in others. I tried to make the few lines I changed more gimpish. Yeah, go ahead and push to 2-8 and master please. --mitch ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-developer-list
Re: [Gimp-developer] patch: change default units for colors/map/rotate colors, from radians over pi (!) to degrees
On Tue, 2012-12-04 at 23:49 +0100, Michael Natterer wrote: Yeah, go ahead and push to 2-8 and master please. Thanks. Someone else will have to do that, I'm afraid - I've never had commit access, nor (I think) a gnome.org account. Or I can squirrel the patch away in bugzilla if you prefer. If I start doing patches more often I'll see if I can get an account. Sorry to be (as so often) a pain! Liam -- Liam Quin - XML Activity Lead, W3C, http://www.w3.org/People/Quin/ Pictures from old books: http://fromoldbooks.org/ Ankh: irc.sorcery.net irc.gnome.org freenode/#xml ___ gimp-developer-list mailing list gimp-developer-list@gnome.org https://mail.gnome.org/mailman/listinfo/gimp-developer-list
