Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
On Fri, Mar 3, 2017 at 8:10 PM, Junio C Hamanowrote: >> Just a niggle: This change moves the warning message from stderr to stdout. > > Right. Here is what I'll queue. Indeed, thanks for the note, and also Junio for fixing while queuing. -- Sebastian Schuberth
Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
Marc Branchaudwrites: > On 2017-03-03 05:57 AM, Sebastian Schuberth wrote: >> It does not make sense for these placeholder scripts to depend on Python >> just because the real scripts do. At the example of Git for Windows, we >> would not even be able to see those warnings as it does not ship with >> Python. So just use plain shell scripts instead. > > Just a niggle: This change moves the warning message from stderr to stdout. Right. Here is what I'll queue. -- >8 -- From: Sebastian Schuberth Date: Fri, 3 Mar 2017 10:57:46 + Subject: [PATCH] contrib: git-remote-{bzr,hg} placeholders don't need Python It does not make sense for these placeholder scripts to depend on Python just because the real scripts do. At the example of Git for Windows, we would not even be able to see those warnings as it does not ship with Python. So just use plain shell scripts instead. Signed-off-by: Sebastian Schuberth Reviewed-by: Jeff King Signed-off-by: Junio C Hamano --- contrib/remote-helpers/git-remote-bzr | 16 +++- contrib/remote-helpers/git-remote-hg | 16 +++- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 712a1377e2..ccc4aea362 100755 --- a/contrib/remote-helpers/git-remote-bzr +++ b/contrib/remote-helpers/git-remote-bzr @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n') - -sys.stderr.write('''WARNING: +cat >&2 <<'EOT' +WARNING: git-remote-bzr is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-bzr +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-bzr \\ +WARNING: $ wget -O $HOME/bin/git-remote-bzr \ WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr WARNING: $ chmod +x $HOME/bin/git-remote-bzr -''') +EOT diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 4255ad6312..dfda44f311 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n') - -sys.stderr.write('''WARNING: +cat >&2 <<'EOT' +WARNING: git-remote-hg is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-hg +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-hg \\ +WARNING: $ wget -O $HOME/bin/git-remote-hg \ WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg WARNING: $ chmod +x $HOME/bin/git-remote-hg -''') +EOT -- 2.12.0-368-g85767a6c71
Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
Jeff Kingwrites: > On Fri, Mar 03, 2017 at 10:57:46AM +, Sebastian Schuberth wrote: > >> It does not make sense for these placeholder scripts to depend on Python >> just because the real scripts do. At the example of Git for Windows, we >> would not even be able to see those warnings as it does not ship with >> Python. So just use plain shell scripts instead. > > Yeah, this seems like an obvious improvement. I think we got here > because the originals issued a warning but kept working, and then it was > slowly whittled down to remove the "working" part. > ... > OTOH, it is not really hurting much, so I do not mind keeping them > around for another 3 years (or more) just to catch any stragglers. Yup, let's queue it and remove it in a few years. Thanks.
Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
On 2017-03-03 05:57 AM, Sebastian Schuberth wrote: It does not make sense for these placeholder scripts to depend on Python just because the real scripts do. At the example of Git for Windows, we would not even be able to see those warnings as it does not ship with Python. So just use plain shell scripts instead. Just a niggle: This change moves the warning message from stderr to stdout. M. Signed-off-by: Sebastian Schuberth--- contrib/remote-helpers/git-remote-bzr | 16 +++- contrib/remote-helpers/git-remote-hg | 16 +++- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 712a137..ccc4aea 100755 --- a/contrib/remote-helpers/git-remote-bzr +++ b/contrib/remote-helpers/git-remote-bzr @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n') - -sys.stderr.write('''WARNING: +cat <<'EOT' +WARNING: git-remote-bzr is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-bzr +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-bzr \\ +WARNING: $ wget -O $HOME/bin/git-remote-bzr \ WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr WARNING: $ chmod +x $HOME/bin/git-remote-bzr -''') +EOT diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 4255ad6..dfda44f 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n') - -sys.stderr.write('''WARNING: +cat <<'EOT' +WARNING: git-remote-hg is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-hg +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-hg \\ +WARNING: $ wget -O $HOME/bin/git-remote-hg \ WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg WARNING: $ chmod +x $HOME/bin/git-remote-hg -''') +EOT -- https://github.com/git/git/pull/333
Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
On Fri, Mar 03, 2017 at 10:57:46AM +, Sebastian Schuberth wrote: > It does not make sense for these placeholder scripts to depend on Python > just because the real scripts do. At the example of Git for Windows, we > would not even be able to see those warnings as it does not ship with > Python. So just use plain shell scripts instead. Yeah, this seems like an obvious improvement. I think we got here because the originals issued a warning but kept working, and then it was slowly whittled down to remove the "working" part. At some point these can probably go away. It's been 3 years since they turned into nothing but warnings, so presumably most people have upgraded by now (I know people often go a long time on old distro-packaged versions, but the distro packagers would presumably figure this out in the meantime). OTOH, it is not really hurting much, so I do not mind keeping them around for another 3 years (or more) just to catch any stragglers. -Peff
[PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
It does not make sense for these placeholder scripts to depend on Python just because the real scripts do. At the example of Git for Windows, we would not even be able to see those warnings as it does not ship with Python. So just use plain shell scripts instead. Signed-off-by: Sebastian Schuberth--- contrib/remote-helpers/git-remote-bzr | 16 +++- contrib/remote-helpers/git-remote-hg | 16 +++- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr index 712a137..ccc4aea 100755 --- a/contrib/remote-helpers/git-remote-bzr +++ b/contrib/remote-helpers/git-remote-bzr @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-bzr is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-bzr\n') - -sys.stderr.write('''WARNING: +cat <<'EOT' +WARNING: git-remote-bzr is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-bzr +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-bzr \\ +WARNING: $ wget -O $HOME/bin/git-remote-bzr \ WARNING: https://raw.github.com/felipec/git-remote-bzr/master/git-remote-bzr WARNING: $ chmod +x $HOME/bin/git-remote-bzr -''') +EOT diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg index 4255ad6..dfda44f 100755 --- a/contrib/remote-helpers/git-remote-hg +++ b/contrib/remote-helpers/git-remote-hg @@ -1,13 +1,11 @@ -#!/usr/bin/env python +#!/bin/sh -import sys - -sys.stderr.write('WARNING: git-remote-hg is now maintained independently.\n') -sys.stderr.write('WARNING: For more information visit https://github.com/felipec/git-remote-hg\n') - -sys.stderr.write('''WARNING: +cat <<'EOT' +WARNING: git-remote-hg is now maintained independently. +WARNING: For more information visit https://github.com/felipec/git-remote-hg +WARNING: WARNING: You can pick a directory on your $PATH and download it, e.g.: -WARNING: $ wget -O $HOME/bin/git-remote-hg \\ +WARNING: $ wget -O $HOME/bin/git-remote-hg \ WARNING: https://raw.github.com/felipec/git-remote-hg/master/git-remote-hg WARNING: $ chmod +x $HOME/bin/git-remote-hg -''') +EOT -- https://github.com/git/git/pull/333