[Gnash-dev] Vitaly's #ifdef WIN32 checkins from Nov 24th
Is there somebody on the team who can teach Vitaly Alexeev how to make gnash code more modular when it doesn't compile on WIN32? He tends to patch in #ifdef hacks, which is great for local testing and development. But then he checks them into the main code base, rather than trying to understand the config scripts and provide a clean fix. I can hardly blame him -- but perhaps with collaboration the code will port more easily and we'll all know a bit more about config scripts. Grepping the sources for WIN32 will find lots of opportunities to move WIN32-specific hacks out of mainline code and into the config system. Thanks folks -- the gnash project is moving along very well and quickly. It's all due to your efforts. John Examples: +/* $Id: extension.cpp,v 1.2 2006/11/24 14:41:39 alexeev Exp $ */ ... -#if HAVE_DIRENT_H +#if HAVE_DIRENT_H || WIN32==1 // win32 hack # include dirent.h # define NAMLEN(dirent) strlen((dirent)-d_name) #else ... +++ ltdl.c 24 Nov 2006 14:42:21 - 1.3 @@ -25,6 +25,19 @@ */ +// win32 hack +#if defined(_WIN32) || defined(WIN32) +#define HAVE_STDLIB_H 1 +#define HAVE_STDIO_H 1 +#define HAVE_STRING_H 1 +#define HAVE_CTYPE_H 1 +#define HAVE_ERRNO_H 1 +#define __WINDOWS__ 1 +#define error_t int +#define LTDL_OBJDIR +#endif + + #if HAVE_CONFIG_H # include config.h #endif ... Etc. John ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re[2]: [Gnash-dev] Gnash extensions question
Hello John, Monday, November 27, 2006, 12:53:40 PM, you wrote: JG To avoid a lot of startup overhead on every gnash startup, I suggest JG only looking for these extensions if or when someone invokes a class JG that isn't already defined. I.e. turn an error into a look for JG extensions. What about explicitly loading extensions with an ActionScript call? After all, these are extensions and a Flash developer is aware that it won't work in the original Flash player. Something like the dl function of php: http://php.net/dl BTW, when you search around for Gnash discussions you will find many Flash developers actually *concerned* because of Gnash. They fear having different players will make development more difficult. With a single Flash player one can be sure that a movie works everywhere when it works in the own player (as opposed to HTML where you have to test it with a bunch of browser combinations). As a Flash developer I can understand this, but I'd say one should write clean code instead of don't-know-exactly-why-but-it-works code. So, Gnash actually can help finding errors during development and avoid bugs right from the start. It all goes to prove that it's important that Gnash targets maximum compatibility, starting from a fixed-ratio centered player image up to ActionScript deviations. I'm a big friend of the extension mechanism (have great uses for it, for example direct file system access). However, I think we should be careful with it. It is a great thing for embedded devices, for sure. But it may a problem for web browser plugins when Gnash has more classes that the original Adobe player has. Would not like to see things like This site is best viewed at XxY pixels, Gnash plugin and extension Foo... Udo ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] Gnash extensions question
John Gilmore wrote: To avoid a lot of startup overhead on every gnash startup, I suggest only looking for these extensions if or when someone invokes a class that isn't already defined. I.e. turn an error into a look for extensions. That's the plan. Currently I scan the directory for just the names of the modules, and store that away. Then later if that gets called from within a movie, it'll get loaded at that time. Another thing I'm considering is making *all* the ActionScript classes plugins, which would reduce the size of the player, and reduce the amount of objects the VM would have to go through when playing a movie. - rob - ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] Vitaly's #ifdef WIN32 checkins from Nov 24th
John, belive me, we're all trying ! You can join the effort with group-replies against gnash-commit posts. --strk; On Mon, Nov 27, 2006 at 03:50:27AM -0800, John Gilmore wrote: Is there somebody on the team who can teach Vitaly Alexeev how to make gnash code more modular when it doesn't compile on WIN32? He tends to patch in #ifdef hacks, which is great for local testing and development. But then he checks them into the main code base, rather than trying to understand the config scripts and provide a clean fix. I can hardly blame him -- but perhaps with collaboration the code will port more easily and we'll all know a bit more about config scripts. Grepping the sources for WIN32 will find lots of opportunities to move WIN32-specific hacks out of mainline code and into the config system. Thanks folks -- the gnash project is moving along very well and quickly. It's all due to your efforts. John Examples: +/* $Id: extension.cpp,v 1.2 2006/11/24 14:41:39 alexeev Exp $ */ ... -#if HAVE_DIRENT_H +#if HAVE_DIRENT_H || WIN32==1// win32 hack # include dirent.h # define NAMLEN(dirent) strlen((dirent)-d_name) #else ... +++ ltdl.c24 Nov 2006 14:42:21 - 1.3 @@ -25,6 +25,19 @@ */ +// win32 hack +#if defined(_WIN32) || defined(WIN32) +#define HAVE_STDLIB_H 1 +#define HAVE_STDIO_H 1 +#define HAVE_STRING_H 1 +#define HAVE_CTYPE_H 1 +#define HAVE_ERRNO_H 1 +#define __WINDOWS__ 1 +#define error_t int +#define LTDL_OBJDIR +#endif + + #if HAVE_CONFIG_H # include config.h #endif ... Etc. John ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev -- /\ASCII Ribbon Campaign \ /Respect for low technology. X Keep e-mail messages readable by any computer system. / \Keep it ASCII. ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re[2]: [Gnash-dev] Gnash extensions question
Hello Rob, Monday, November 27, 2006, 4:10:38 PM, you wrote: RS Personally, any flash developer scared of Gnash should just ignore us, RS and live in their tightly closed world. I've read some of same blogs, RS and if this attitude prevailed, we wouldn't have projects like Firefox, RS OpenOffice, etc... Well, they can't ignore it in the long turn when they want to create working website. RS My gut feeling is the extension mechanism is primarily for embedded RS platforms, as it'll let people add more hardware specific classes. Agree. RS At RS the same time, current Flash implementations are pretty limited, really. RS What if you want to access a real SQL database from a Flash movie ? RS Access a GPS so your Flash based GIS software works on your PDA ? Agree. That's why I think extensions are a great thing. RS Some people will want to use extensions on the desktop, but that'll RS probably be less common. As long as Gnash is compatible with the Adobe RS player, nobody should notice any difference when web browsing. If it RS gets to where Gnash becomes popular enough that people are doing RS interesting things with Gnash extensions on the desktop, then that's RS life, and Adobe can add support for plugins too. After all, all of our RS code is visible. That's my point. Compatibility is very important.. Udo ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
[Gnash-dev] weird problems with gtk/agg
I dunno if I'm just getting mad but when building gtk/agg I experience segmentation faults if and only iff invoking gnash from it's *installation* directory, while it works fine from the *build* dir. Tried 'ldd' and see no real differences. Tried with gtk/ogl and I don't have the problem. Is anyone experiencing similar problems ? --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] internet explorer. flash v6. test case results. adobe flash player 8.
Mark, I've updated the online testcases, and SWF5 target now works too, so any rerun is appreciated. Thanks. Tests are at http://gnash.lulu.com/testcases/ --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
[Gnash-dev] Re: Vitaly's #ifdef WIN32 checkins from Nov 24th
John Gilmore wrote: He tends to patch in #ifdef hacks, which is great for local testing and development. 'hack' allows me to make quickly the project working in the limited conditions. At the same time 'hack' is a mark to which the developer wishes to return at presence of a free time. Is there somebody on the team who can teach Vitaly Alexeev how to make gnash code more modular when it doesn't compile on WIN32? I think that John Gilmore the most important candidate for the teacher for me :-) - Вы уже с Yahoo!? Испытайте обновленную и улучшенную Yahoo! Почту!___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
