Re[2]: [Gnash-dev] release shortlist
Hello strk, Thursday, November 2, 2006, 11:13:12 PM, you wrote: s Checking this in 0.7.2 branch, it seems that the fact that s AGG keeps the aspect ratio breaks mouse events. s Try with gtk/agg. s Resize the window so that aspect ratio (of the window) is not s retained and try clicking on some buttons (gravity-embed.swf s shows this easily). Ok, I'll check this. It's most probably because it uses different scales. s It will work with gtk/ogl since ogl respects arbitrary aspect s ratios. There is a huge inconsistency regarding the rescaling. All backends should use the same scales and it seems appropriate to me that it is defined in gui.cpp (getXScale you defined). The fixed aspect ratio is maintained there, not directly in the AGG renderer. The latter can work with arbitrary scales (changed this in my last patch), but it will break image rescaling* and I see no reason why it's necessary at all. Also, can anyone explain the real use of the begin_display() arguments? What's the difference between viewport_width and x1-x0 ? Udo * Because rescaling currently happens /before/ the real image transformation. So with a rotated image it won't scale with the screen's X/Y axis but instead with the original image's axis. This can be fixed, but I could not manage it yet. ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re[2]: [Gnash-dev] release shortlist
Hello strk, Wednesday, November 1, 2006, 12:11:39 PM, you wrote: Additionally, when I last tried, resizing a Gtk/Agg window didn't work properly; that is, the drawing area was not resized accordingly. Can anyone confirm whether or not this is the case on the release branch? s For sure gtk/agg combination doesn't scale the rendering area. It does now (in CVS-head). Please test it (also with other renderers). Udo ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Thu, Nov 02, 2006 at 03:23:03PM +0100, strk wrote: On Thu, Nov 02, 2006 at 03:13:36PM +0100, strk wrote: On Thu, Nov 02, 2006 at 03:11:54PM +0100, Udo Giacomozzi wrote: Hello Markus, Thursday, November 2, 2006, 3:09:00 PM, you wrote: MG Are you going to backport it? :/ Yes, I think so... But I'd like to have someone test it first (it works for me, but normally most bugs are found by other people ;) I'm about to try it with gtk/agg, can also try with others. GTK/AGG is ok (keeps aspect ratio, but guess that's intended behaviour) Tested GTK/Opengl. Works (and doesn't keep aspect ratio, dunno which is better :) --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
--- Rob Savoye [EMAIL PROTECTED] skrev: Bastiaan Jacques wrote: I tried both branch and HEAD last night, before your commit. It seems to be working properly now (on the branch). Whew. :-) Can I convince you to merge this to HEAD too? ;) I plan too after I hear that it works for everyone in the branch. It got pretty complicated at one point, so it needs some testing. It doesn't work for me :( using configure --enable-strict the 0.7.2 build dies with this error message: klash-klash.o: In function `EmbedWidget::qt_property(int, int, QVariant*)': ./klash.moc:140: undefined reference to `QGLWidget::qt_property(int, int, QVariant*)' klash-klash.o: In function `EmbedWidget::staticMetaObject()': ./klash.moc:52: undefined reference to `QGLWidget::staticMetaObject()' klash-klash.o: In function `EmbedWidget::qt_invoke(int, QUObject*)': ./klash.moc:122: undefined reference to `QGLWidget::qt_invoke(int, QUObject*)' klash-klash.o: In function `EmbedWidget::qt_emit(int, QUObject*)': ./klash.moc:132: undefined reference to `QGLWidget::qt_emit(int, QUObject*)' klash-klash.o: In function `EmbedWidget::qt_cast(char const*)': ./klash.moc:99: undefined reference to `QGLWidget::qt_cast(char const*)' klash-klash.o: In function `~EmbedWidget': /home/tomas/gnash/0.7.2/gnash/plugin/klash/klash.cpp:95: undefined reference to `QGLWidget::~QGLWidget()' /home/tomas/gnash/0.7.2/gnash/plugin/klash/klash.cpp:95: undefined reference to `QGLWidget::~QGLWidget()' klash-klash.o: In function `EmbedWidget': /home/tomas/gnash/0.7.2/gnash/plugin/klash/klash.cpp:98: undefined reference to `QGLWidget::QGLWidget(QWidget*, char const*, QGLWidget const*, unsigned int)' /home/tomas/gnash/0.7.2/gnash/plugin/klash/klash.cpp:113: undefined reference to `QGLWidget::~QGLWidget()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x158): undefined reference to `QGLWidget::setMouseTracking(bool)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x210): undefined reference to `QGLWidget::reparent(QWidget*, unsigned int, QPoint const, bool)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x290): undefined reference to `QGLWidget::paintEvent(QPaintEvent*)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x380): undefined reference to `QGLWidget::makeCurrent()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x388): undefined reference to `QGLWidget::swapBuffers()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x390): undefined reference to `QGLWidget::setFormat(QGLFormat const)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x398): undefined reference to `QGLWidget::setContext(QGLContext*, QGLContext const*, bool)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3a0): undefined reference to `QGLWidget::renderPixmap(int, int, bool)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3a8): undefined reference to `QGLWidget::grabFrameBuffer(bool)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3b0): undefined reference to `QGLWidget::makeOverlayCurrent()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3b8): undefined reference to `QGLWidget::updateGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3c0): undefined reference to `QGLWidget::updateOverlayGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3c8): undefined reference to `QGLWidget::initializeGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3d0): undefined reference to `QGLWidget::resizeGL(int, int)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3d8): undefined reference to `QGLWidget::paintGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3e0): undefined reference to `QGLWidget::initializeOverlayGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3e8): undefined reference to `QGLWidget::resizeOverlayGL(int, int)' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3f0): undefined reference to `QGLWidget::paintOverlayGL()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x3f8): undefined reference to `QGLWidget::glInit()' klash-klash.o:(.rodata._ZTV11EmbedWidget[vtable for EmbedWidget]+0x400): undefined reference to `QGLWidget::glDraw()' klash-klash.o:(.rodata._ZTI11EmbedWidget[typeinfo for EmbedWidget]+0x10): undefined reference to `typeinfo for QGLWidget' collect2: ld returned 1 exit status the KDE config stuff: KDE_CFLAGS is -I/opt/kde/include -I/opt/qt/include -I/opt/kde/include/kio KDE_LIBS is -L/opt/kde/lib -lkdeui -lkdecore -lkdeprint -L/opt/qt/lib -lqt-mt cheers, Tomas ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Thu, Nov 02, 2006 at 09:06:38AM -0700, Rob Savoye wrote: strk wrote: A question jumps out of my mind: Do I have all required dependencies to build klash ? How do I tell ? :) (configure seems to answer: NO, since it disables klash) In your configure log, you should see several new warnings about this. For the release, I'm less worried about it. The few people than want klash for Konqueror probably already have KDE installed. Those that don't have KDE installed won't care if klash isn't built. :-) I just committed some cleanups and increased verbosity. It seems that klash variable is also set in kde.m4, which sounds inappropriate to me. Anyway, there is where it is disabled on my laptop system: configure: dcopidl not found configure: WARNIN: klash disabled due to this Just the first of a few other such warnings --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re[2]: [Gnash-dev] release shortlist
Hello strk, Thursday, November 2, 2006, 3:36:20 PM, you wrote: GTK/AGG is ok (keeps aspect ratio, but guess that's intended behaviour) Yes, I updated gui.cpp so that it always keeps aspect ratio: http://cvs.savannah.gnu.org/viewcvs/gnash/gui/gui.cpp?cvsroot=gnashr1=1.43r2=1.44 That's how the MM plugin does rescaling and many movies expect it to work that way. Newer SWF version make the behaviour configurable (for example, you can disable rescaling if you wish). AFAIK aspect ratio is fixed in any case. Most Flash websites embed the plugin with 100% width and height and it would look odd when the aspect ratio would not be fixed. s Tested GTK/Opengl. Works (and doesn't keep aspect ratio, dunno which s is better :) It does not use the xscale/yscale values calculated in the gui. Prior to my patch they were not used anywhere... Udo ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Thu, Nov 02, 2006 at 09:06:45PM +0100, Udo Giacomozzi wrote: s Tested GTK/Opengl. Works (and doesn't keep aspect ratio, dunno which s is better :) It does not use the xscale/yscale values calculated in the gui. Prior to my patch they were not used anywhere... I introduced xscale/yscale in Gui class for correctly reporting mouse events in specifically this case (aspect ratio not kept). So they *were* used (just accessed trough getXScale and getYScale by implementations - gtk.cpp for sure [motion_notify_event]) --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Thu, Nov 02, 2006 at 09:13:56PM +0100, strk wrote: On Thu, Nov 02, 2006 at 09:06:45PM +0100, Udo Giacomozzi wrote: s Tested GTK/Opengl. Works (and doesn't keep aspect ratio, dunno which s is better :) It does not use the xscale/yscale values calculated in the gui. Prior to my patch they were not used anywhere... I introduced xscale/yscale in Gui class for correctly reporting mouse events in specifically this case (aspect ratio not kept). So they *were* used (just accessed trough getXScale and getYScale by implementations - gtk.cpp for sure [motion_notify_event]) Checking this in 0.7.2 branch, it seems that the fact that AGG keeps the aspect ratio breaks mouse events. Try with gtk/agg. Resize the window so that aspect ratio (of the window) is not retained and try clicking on some buttons (gravity-embed.swf shows this easily). It will work with gtk/ogl since ogl respects arbitrary aspect ratios. --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Tue, 2006-10-31 at 09:42 -0700, Rob Savoye wrote: Anyway, other than that little tweak, and the font issue, is there anything major left that needs to be done ? The SDL-GUI/Agg combination is broken due to a revert. I'll backport a fix for this and commit it to the release branch tonight (or tomorrow at the latest). Additionally, when I last tried, resizing a Gtk/Agg window didn't work properly; that is, the drawing area was not resized accordingly. Can anyone confirm whether or not this is the case on the release branch? Bastiaan ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Wed, Nov 01, 2006 at 12:01:16PM +0100, Bastiaan Jacques wrote: Additionally, when I last tried, resizing a Gtk/Agg window didn't work properly; that is, the drawing area was not resized accordingly. Can anyone confirm whether or not this is the case on the release branch? For sure gtk/agg combination doesn't scale the rendering area. --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
[Gnash-dev] release shortlist
I just fixed klash in the release branch. In the original shortlist there was an item about fixing font anti-aliasing, is anybody working on that ? Should we punt this till the next release ? (probably) Default configuration is SDL sound with libMAD, OpenGL with GTK. --enable-plugin builds both the GTK and the KDE based plugins. I'm starting to think we should enable building the plugins by default, and require a --disable-plugin, since I think most people grabbing this release will be primarily be using it as a browser plugin. Anyway, other than that little tweak, and the font issue, is there anything major left that needs to be done ? If not, we should declare a code freeze in the release branch and focus on whatever bug fixes are required to push the release out soon. - rob - ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
Patrice Dumas wrote: On Tue, Oct 31, 2006 at 09:42:45AM -0700, Rob Savoye wrote: Please leave little time to check the packaging, to ensure that the packaging examples are correct and hopefully tested by packagers before the release (I will look at and test the spec once I can build gnash...). In the release branch I fixed several things in the packaging files, and successfully built both deb and rpm packages that look correct. (this needs to be tested for the release of course) The dist-bzip2 tarball also looks correct. Also --enable-testing code is broken as I reported some time ago. It is just for the sake of reporting, I have no opinion whether it is a problem for the release or not. Thanks for reminding me! I just fixed this by moving the additional ActionScript code out of the base class, and moving it to NetConnection where it belongs. I'll migrate this to HEAD next. - rob - ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] release shortlist
On Tue, Oct 31, 2006 at 09:42:45AM -0700, Rob Savoye wrote: Anyway, other than that little tweak, and the font issue, is there anything major left that needs to be done ? If not, we should declare a code freeze in the release branch and focus on whatever bug fixes are required to push the release out soon. Please leave little time to check the packaging, to ensure that the packaging examples are correct and hopefully tested by packagers before the release (I will look at and test the spec once I can build gnash...). Also --enable-testing code is broken as I reported some time ago. It is just for the sake of reporting, I have no opinion whether it is a problem for the release or not. -- Pat ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] Release shortlist
On Tue, Oct 03, 2006 at 09:33:32AM -0600, Rob Savoye wrote: strk wrote: On Mon, Oct 02, 2006 at 10:38:21AM -0600, Rob Savoye wrote: I don't think GUI testing will fit in next release, just having the tests under actionscript.all/ and libbase/ all run by make check would be good enough for now. There is no way even simple GUI testing should be in the next release. Other than fixing sound, we should probably hesitate to launch off on any new projects to squeeze into this next release. Once the release goes out, then we can risk destabilizing everything again with alot of development. I've started a simple MovieTester class, doesn't do much, but can be something to use for inspecting a movie while it's playing. Altough I provided a test for our DefineEditTextVariableName testcase I've to say I'm not happy with the root advance stepping into frames in this way: create_instance : framenumber=0 advance : framenumber=0 advance : framenumber=1 ... I accepted this as a form of regress test, but I think we should fix the libserver instead ... --strk; ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
Re: [Gnash-dev] Release shortlist
strk wrote: On Mon, Oct 02, 2006 at 10:38:21AM -0600, Rob Savoye wrote: I don't think GUI testing will fit in next release, just having the tests under actionscript.all/ and libbase/ all run by make check would be good enough for now. There is no way even simple GUI testing should be in the next release. Other than fixing sound, we should probably hesitate to launch off on any new projects to squeeze into this next release. Once the release goes out, then we can risk destabilizing everything again with alot of development. - rob - ___ Gnash-dev mailing list Gnash-dev@gnu.org http://lists.gnu.org/mailman/listinfo/gnash-dev
