Re: [PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry sizes

2023-10-31 Thread John Paul Adrian Glaubitz 
On Tue, 2023-10-31 at 20:35 +0100, Vladimir 'phcoder' Serbinenko wrote:

> With new alignment specification it's easy to screw up. Fortunately if it
> happens the size will be bigger than intended. Compile time assert will catch
> this.
> 
> Signed-off-by: Vladimir Serbinenko 
> ---
>  grub-core/partmap/gpt.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/grub-core/partmap/gpt.c b/grub-core/partmap/gpt.c
> index 877ceefc3..426f616ae 100644
> --- a/grub-core/partmap/gpt.c
> +++ b/grub-core/partmap/gpt.c
> @@ -229,6 +229,9 @@ static struct grub_partition_map grub_gpt_partition_map =
>  
>  GRUB_MOD_INIT(part_gpt)
>  {
> +  COMPILE_TIME_ASSERT(sizeof(grub_guid_t) == 16);
> +  COMPILE_TIME_ASSERT(sizeof(grub_packed_guid_t) == 16);
> +  COMPILE_TIME_ASSERT(sizeof(struct grub_gpt_partentry) == 128);
>grub_partition_map_register (_gpt_partition_map);
>  }
>  
> -- 
> 2.39.2
> 

Tested-by: John Paul Adrian Glaubitz 

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry sizes

2023-10-31 Thread Vladimir 'phcoder' Serbinenko 
With new alignment specification it's easy to screw up. Fortunately if it
happens the size will be bigger than intended. Compile time assert will catch
this.

Signed-off-by: Vladimir Serbinenko 

-- 
Regards
Vladimir 'phcoder' Serbinenko
From 6a4e58a9fe989dbe0f6b3ef9865cab05a55ac19a Mon Sep 17 00:00:00 2001
From: Vladimir Serbinenko 
Date: Sun, 13 Aug 2023 09:18:53 +0200
Subject: [PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry
 sizes

With new alignment specification it's easy to screw up. Fortunately if it
happens the size will be bigger than intended. Compile time assert will catch
this.

Signed-off-by: Vladimir Serbinenko 
---
 grub-core/partmap/gpt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/grub-core/partmap/gpt.c b/grub-core/partmap/gpt.c
index 877ceefc3..426f616ae 100644
--- a/grub-core/partmap/gpt.c
+++ b/grub-core/partmap/gpt.c
@@ -229,6 +229,9 @@ static struct grub_partition_map grub_gpt_partition_map =
 
 GRUB_MOD_INIT(part_gpt)
 {
+  COMPILE_TIME_ASSERT(sizeof(grub_guid_t) == 16);
+  COMPILE_TIME_ASSERT(sizeof(grub_packed_guid_t) == 16);
+  COMPILE_TIME_ASSERT(sizeof(struct grub_gpt_partentry) == 128);
   grub_partition_map_register (_gpt_partition_map);
 }
 
-- 
2.39.2

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry sizes

2023-10-17 Thread Daniel Kiper 
On Sat, Oct 07, 2023 at 05:08:48PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> From c338c54a127656ef0f750d78bad6371874a98ca8 Mon Sep 17 00:00:00 2001
> From: Vladimir Serbinenko 
> Date: Sun, 13 Aug 2023 09:18:53 +0200
> Subject: [PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry
>  sizes
>

Could you add a commit message which explains why this patch is needed?

> Signed-off-by: Vladimir Serbinenko 
> ---
>  grub-core/partmap/gpt.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/grub-core/partmap/gpt.c b/grub-core/partmap/gpt.c
> index 877ceefc3..426f616ae 100644
> --- a/grub-core/partmap/gpt.c
> +++ b/grub-core/partmap/gpt.c
> @@ -229,6 +229,9 @@ static struct grub_partition_map grub_gpt_partition_map =
>
>  GRUB_MOD_INIT(part_gpt)
>  {
> +  COMPILE_TIME_ASSERT(sizeof(grub_guid_t) == 16);
> +  COMPILE_TIME_ASSERT(sizeof(grub_packed_guid_t) == 16);
> +  COMPILE_TIME_ASSERT(sizeof(struct grub_gpt_partentry) == 128);
>grub_partition_map_register (_gpt_partition_map);
>  }

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry sizes

2023-10-07 Thread Vladimir 'phcoder' Serbinenko 

From c338c54a127656ef0f750d78bad6371874a98ca8 Mon Sep 17 00:00:00 2001
From: Vladimir Serbinenko 
Date: Sun, 13 Aug 2023 09:18:53 +0200
Subject: [PATCH 4/4] gpt: Add compile time asserts for guid and gpt_partentry
 sizes

Signed-off-by: Vladimir Serbinenko 
---
 grub-core/partmap/gpt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/grub-core/partmap/gpt.c b/grub-core/partmap/gpt.c
index 877ceefc3..426f616ae 100644
--- a/grub-core/partmap/gpt.c
+++ b/grub-core/partmap/gpt.c
@@ -229,6 +229,9 @@ static struct grub_partition_map grub_gpt_partition_map =
 
 GRUB_MOD_INIT(part_gpt)
 {
+  COMPILE_TIME_ASSERT(sizeof(grub_guid_t) == 16);
+  COMPILE_TIME_ASSERT(sizeof(grub_packed_guid_t) == 16);
+  COMPILE_TIME_ASSERT(sizeof(struct grub_gpt_partentry) == 128);
   grub_partition_map_register (_gpt_partition_map);
 }
 
-- 
2.39.2

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel