Re: bug#69921: [PATCH] eval-string: Fix setting port column

[Ludovic Courtès]

Jonas Hahnfeld  skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f1..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>(if line
>>(set-port-line! port line))
>>(if column
>> -  (set-port-column! port line))
>> +  (set-port-column! port column))
>>  
>>(if (or compile? (not (language-evaluator lang)))
>>((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.

Re: [PATCH] eval-string: Fix setting port column

[Rob Browning]

Nikita Domnitskii  writes:

> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f1..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>(if line
>(set-port-line! port line))
>(if column
> -  (set-port-column! port line))
> +  (set-port-column! port column))
>  
>(if (or compile? (not (language-evaluator lang)))
>((load-thunk-from-memory

Thanks - added a test and pushed to main.

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Re: [PATCH] eval-string: Fix setting port column

[Developers list for Guile, the GNU extensibility library]

On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f1..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>(if line
>(set-port-line! port line))
>(if column
> -  (set-port-column! port line))
> +  (set-port-column! port column))
>  
>(if (or compile? (not (language-evaluator lang)))
>((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.


signature.asc
Description: This is a digitally signed message part

[PATCH] eval-string: Fix setting port column

[Nikita Domnitskii]

---
 module/ice-9/eval-string.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
index ea0f1..9cac03632 100644
--- a/module/ice-9/eval-string.scm
+++ b/module/ice-9/eval-string.scm
@@ -81,7 +81,7 @@
   (if line
   (set-port-line! port line))
   (if column
-  (set-port-column! port line))
+  (set-port-column! port column))
 
   (if (or compile? (not (language-evaluator lang)))
   ((load-thunk-from-memory


-- 
Best Regards,
Nikita Domnitskii