CLD doesn't build on db-4.3
hi, * CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated structure members DBC-c_xxx(c_close(), etc) instead of DBC-xxx. :-) It won't build on db-4.4, either. probably won't build on db-4.5, as db-5.0 says DBC-xxx was introduced in db-4.6. :-) Should we disable support for 4.3 - 4.5 and add 4.9 - 5.0? -- Samba Team boy...@samba.orghttp://www.samba.org -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CLD doesn't build on db-4.3
On 04/01/2010 07:01 AM, Samba - BoYang wrote: hi, * CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated structure members DBC-c_xxx(c_close(), etc) instead of DBC-xxx. :-) It won't build on db-4.4, either. probably won't build on db-4.5, as db-5.0 says DBC-xxx was introduced in db-4.6. :-) Should we disable support for 4.3 - 4.5 and add 4.9 - 5.0? I'd answer yes, by a circuitous route: if I understand things correctly, the replicated PAXOS db4 backend that we are heading towards (see the 'replica' branch of git://git.kernel.org/pub/scm/daemon/cld/cld.git) was buggy in early db4 releases. Therefore, it sounds like we could eliminate two issues with a single change, by removing support for db 4.3 - 4.5, the DBC issue and the PAXOS issue. I'm fine with adding support for 4.9+ as long as the APIs function in a compatible manner. Want to create the simple patch for this? :) Thanks, Jeff -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CLD doesn't build on db-4.3
On Thu, 01 Apr 2010 19:01:59 +0800 Samba - BoYang boy...@samba.org wrote: CLD doesn't build on db-4.3 on suse 11, since db-4.3 uses deprecated structure members DBC-c_xxx(c_close(), etc) instead of DBC-xxx. :-) That's unexpected. Jeff is our portability expert, but he's busy with the baby, so I guess I'll have to look if it's something easily fixable. -- Pete -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CLD doesn't build on db-4.3
On 04/02/2010 04:50 AM, Pete Zaitcev wrote: RHEL 5 ships with db4-4.3.29-10.el5 (I checked for Bo's problem this morning), so dropping 4.3 will make RHEL 5 unsupportable. Just a point to consider. It might add a lot of #ifdef to the code to support 4.5-. :-) -- Pete -- Samba Team boy...@samba.orghttp://www.samba.org -- To unsubscribe from this list: send the line unsubscribe hail-devel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: CLD doesn't build on db-4.3
On 04/01/2010 11:03 PM, Jeff Garzik wrote: I'm fine with adding support for 4.9+ as long as the APIs function in a compatible manner. Want to create the simple patch for this? :) Here is the patch for master, please review it. Thanks! Thanks, Jeff -- Samba Team boy...@samba.orghttp://www.samba.org From 94472c2e304a9a94197e8d593ad3987cdbe4e383 Mon Sep 17 00:00:00 2001 From: Bo Yang boy...@samba.org Date: Fri, 2 Apr 2010 08:30:39 +0800 Subject: [PATCH] Disable db4.3 - 4.5 for incompatible APIs. Signed-off-by: Bo Yang boy...@samba.org --- configure.ac |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 38688f1..4dcf9e3 100644 --- a/configure.ac +++ b/configure.ac @@ -74,13 +74,12 @@ dnl AC_TYPE_PID_T dnl - dnl Checks for required libraries dnl - -AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8, +AC_CHECK_LIB(db-5.0, db_create, DB4_LIBS=-ldb-5.0, + AC_CHECK_LIB(db-4.9, db_create, DB4_LIBS=-ldb-4.9, + AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8, AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7, AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6, - AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5, - AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4, - AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3, - [AC_MSG_ERROR([Missing required libdb 4.x])])) + [AC_MSG_ERROR([Missing required libdb 4.6+])]) AC_CHECK_LIB(crypto, MD5_Init, CRYPTO_LIBS=-lcrypto) AC_SEARCH_LIBS(argp_parse, argp) AC_SEARCH_LIBS(recv, socket) -- 1.6.0.2
