RE: Proxy protocol patch for nginx 1.4.x

2014-03-23 Thread Lukas Tribus 
Hi,


 Please try it and report any issue / bug / success story.
 (the wiki hosting the page above uses the patch, of course)

FYI: this feature has been committed to the nginx code base [1]
and is in nginx v1.5.12 [2]. Docs are [3] and [4] and someone
also wrote a blog post about it [5].



Regards,

Lukas


[1] http://hg.nginx.org/nginx/rev/3a72b1805c52
[2] http://nginx.org/en/CHANGES
[3] http://nginx.org/en/docs/http/ngx_http_core_module.html#listen
[4] http://nginx.org/en/docs/http/ngx_http_core_module.html#variables
[5] https://chrislea.com/2014/03/20/using-proxy-protocol-nginx/

RE: Proxy protocol patch for nginx 1.4.x

2014-03-09 Thread Lukas Tribus 
Hi Jim,


 Please try it and report any issue / bug / success story.
 (the wiki hosting the page above uses the patch, of course)


 This is great, and mostly working for me on 1.4.5! Solves a big problem
 of mine.However, is it not possible to use SNI at the same time?

 When I configure nginx like so:
 server {
 listen 127.0.0.1:443 ssl;
 server_name *.one.com;
 ...
 }
 server {
 listen 127.0.0.1:443 ssl;
 server_name *.two.com;
 ...
 }

 SNI works as expected. If I add accept_proxy_protocol=on to both listen
 directives, nginx fails like so:

 Starting nginx: nginx: [emerg] duplicate listen options for 127.0.0.1:443
 in /etc/nginx/sites-enabled/_.one.com:9

You can only specify listen options once per address:port tuple, all other
listen directives will inherit those options.

Thats because you cannot enable or disable some specific options or settings
like proxy_protocol, backlog or fastopen on the same port in a specific
server, you can only configure it per address:port pair (like you cannot
configure both http and https on the same port).

So just configure it in the first server and it will be inherited on all
servers using the same address:port tuple.

Also read [1].


So this shouldn't be related to the patch.



 Thanks a lot for the feedback.
 I know nginx devs are now working on an official patch:
 https://twitter.com/mdounin/status/441705983581372417

 Baptiste

Nice!



Regards,

Lukas


[1] http://nginx.org/en/docs/http/ngx_http_core_module.html#listen

Re: Proxy protocol patch for nginx 1.4.x

2014-03-08 Thread Jim Howell 
Baptiste bedis9@... writes:


 Please try it and report any issue / bug / success story.
 (the wiki hosting the page above uses the patch, of course)
 

This is great, and mostly working for me on 1.4.5!  Solves a big problem
of mine.However, is it not possible to use SNI at the same time?

When I configure nginx like so:
server {
listen 127.0.0.1:443 ssl;
server_name *.one.com;
...
}
server {
listen 127.0.0.1:443 ssl;
server_name *.two.com;
...
}

SNI works as expected.  If I add accept_proxy_protocol=on to both listen
directives, nginx fails like so:

Starting nginx: nginx: [emerg] duplicate listen options for 127.0.0.1:443
in /etc/nginx/sites-enabled/_.one.com:9

Re: Proxy protocol patch for nginx 1.4.x

2014-03-08 Thread Baptiste 
Hi Jim,

Thanks a lot for the feedback.
I know nginx devs are now working on an official patch:
https://twitter.com/mdounin/status/441705983581372417

Baptiste


On Sun, Mar 9, 2014 at 2:30 AM, Jim Howell jimboco...@gmail.com wrote:
 Baptiste bedis9@... writes:


 Please try it and report any issue / bug / success story.
 (the wiki hosting the page above uses the patch, of course)


 This is great, and mostly working for me on 1.4.5!  Solves a big problem
 of mine.However, is it not possible to use SNI at the same time?

 When I configure nginx like so:
 server {
 listen 127.0.0.1:443 ssl;
 server_name *.one.com;
 ...
 }
 server {
 listen 127.0.0.1:443 ssl;
 server_name *.two.com;
 ...
 }

 SNI works as expected.  If I add accept_proxy_protocol=on to both listen
 directives, nginx fails like so:

 Starting nginx: nginx: [emerg] duplicate listen options for 127.0.0.1:443
 in /etc/nginx/sites-enabled/_.one.com:9

Proxy protocol patch for nginx 1.4.x

2013-09-19 Thread Baptiste 
Hi all,

I've just updated my patches for proxy protocol in nginx 1.4.x.
They are avaiable here:
https://wiki.bedis.eu/nginx/nginx_proxy_protocol_patch

Note in that version, accept_proxy_protocol is not a server option
anymore, it is now a bind option.

Please try it and report any issue / bug / success story.
(the wiki hosting the page above uses the patch, of course)

Baptiste

Re: Proxy protocol patch for nginx 1.4.x

2013-09-19 Thread Sebastien Estienne 
Hello Baptiste,

Does it mean that it should work with a module like nginx-rtmp?

thanx,

Sebastien Estienne


On Thu, Sep 19, 2013 at 9:30 PM, Baptiste bed...@gmail.com wrote:

 Hi all,

 I've just updated my patches for proxy protocol in nginx 1.4.x.
 They are avaiable here:
 https://wiki.bedis.eu/nginx/nginx_proxy_protocol_patch

 Note in that version, accept_proxy_protocol is not a server option
 anymore, it is now a bind option.

 Please try it and report any issue / bug / success story.
 (the wiki hosting the page above uses the patch, of course)

 Baptiste