Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
On Monday 04 January 2016 21:04:25 Darren Hart wrote: > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > This patch adds support for controlling keyboard backlight via > > standard linux led class interface (::kbd_backlight). It uses ACPI > > HKEY device with MLCG and MLCS methods. > > Which laptops is this intended to support? Thinkpad ??30 series and new which have backlight keyboard. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
On Monday 04 January 2016 21:40:20 Darren Hart wrote: > On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > > This patch adds support for controlling keyboard backlight via > > > > standard linux led class interface (::kbd_backlight). It uses > > > > ACPI HKEY device with MLCG and MLCS methods. > > > > > > Which laptops is this intended to support? > > > > Thinkpad ??30 series and new which have backlight keyboard. > > Thanks, we should include that in the commit message as well as the > comments surrounding the driver section. ??30 is probably not good characteristic, but I mean all those Thinkpad laptops like T430, x230, E430, X1 (1st) and their successors (T440, T450, X1 3rd, ...) All those which are from Ivy Bridge processor generation (and new). But basically it cover all Thinkpad laptops which have backlight keyboard. Older Thinkpad laptops had only light in bezel. So if you have better idea for commit message, feel free to change it. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part. -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151=/4140___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > This patch adds support for controlling keyboard backlight via > > > standard linux led class interface (::kbd_backlight). It uses ACPI > > > HKEY device with MLCG and MLCS methods. > > > > Which laptops is this intended to support? > > Thinkpad ??30 series and new which have backlight keyboard. Thanks, we should include that in the commit message as well as the comments surrounding the driver section. Henrique, are your concerns surrounding suspend/resume resolved? -- Darren Hart Intel Open Source Technology Center -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > This patch adds support for controlling keyboard backlight via standard > linux led class interface (::kbd_backlight). It uses ACPI HKEY device with > MLCG and MLCS methods. > Which laptops is this intended to support? Henrique, I'm holding off a bit more to give you time to respond given the holiday season. Thanks, -- Darren Hart Intel Open Source Technology Center -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
On Mon, Jan 04, 2016 at 09:51:23PM +0100, Pali Rohár wrote: > On Monday 04 January 2016 21:40:20 Darren Hart wrote: > > On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote: > > > On Monday 04 January 2016 21:04:25 Darren Hart wrote: > > > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote: > > > > > This patch adds support for controlling keyboard backlight via > > > > > standard linux led class interface (::kbd_backlight). It uses > > > > > ACPI HKEY device with MLCG and MLCS methods. > > > > > > > > Which laptops is this intended to support? > > > > > > Thinkpad ??30 series and new which have backlight keyboard. > > > > Thanks, we should include that in the commit message as well as the > > comments surrounding the driver section. > > ??30 is probably not good characteristic, but I mean all those Thinkpad > laptops like T430, x230, E430, X1 (1st) and their successors (T440, > T450, X1 3rd, ...) All those which are from Ivy Bridge processor > generation (and new). > > But basically it cover all Thinkpad laptops which have backlight > keyboard. Older Thinkpad laptops had only light in bezel. > > So if you have better idea for commit message, feel free to change it. Ah, I see. New feature that didn't exist previously. OK, no need for changes on that score then. -- Darren Hart Intel Open Source Technology Center -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
