Re: [Intel-gfx] [PATCH] drm/i915: error_buffer-ring should be signed
On Thu, Feb 16, 2012 at 02:16:27PM +0300, Dan Carpenter wrote: On Thu, Feb 16, 2012 at 11:03:29AM +0100, Daniel Vetter wrote: gcc seems to get uber-anal recently about these things. Sorry, I should have said that it's not a gcc warning, it's a smatch thing. But also it's not uber-anal. It's the exact level of anality which is required to make the == -1 test work. You can compare unsigned int and longs to -1 and it works but for smaller types it doesn't. I've picked this one here up for -next, thanks for your clarification (added to the commit message in). -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: error_buffer-ring should be signed
gcc seems to get uber-anal recently about these things. Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b839728..35833fc 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -199,7 +199,7 @@ struct drm_i915_error_state { u32 tiling:2; u32 dirty:1; u32 purgeable:1; - u32 ring:4; + s32 ring:4; u32 cache_level:2; } *active_bo, *pinned_bo; u32 active_bo_count, pinned_bo_count; -- 1.7.9 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: error_buffer-ring should be signed
Am Donnerstag, den 16.02.2012, 11:03 +0100 schrieb Daniel Vetter: gcc seems to get uber-anal recently about these things. which was introduced by the following commit. 96154f2faba5: drm/i915: switch ring-id to be a real id Reported-by: Dan Carpenter dan.carpen...@oracle.com The URL of the report is the following. http://lists.freedesktop.org/archives/dri-devel/2012-February/019183.html Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Paul Menzel paulepan...@users.sourceforge.net --- drivers/gpu/drm/i915/i915_drv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index b839728..35833fc 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -199,7 +199,7 @@ struct drm_i915_error_state { u32 tiling:2; u32 dirty:1; u32 purgeable:1; - u32 ring:4; + s32 ring:4; u32 cache_level:2; } *active_bo, *pinned_bo; u32 active_bo_count, pinned_bo_count; Thanks, Paul signature.asc Description: This is a digitally signed message part ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx