Re: [Intel-gfx] [PATCH 00/59] prime doc polish and ... a few cleanups
On 2019/06/17, Emil Velikov wrote: > Hi Daniel, > > On Fri, 14 Jun 2019 at 21:36, Daniel Vetter wrote: > > > > Hi all, > > > > So I figured let's get going and polish the docs for the last part of drm > > core/helpers that hasn't yet seen some neat polish last few years. With > > the goal to make docs for driver kapi a requirement henceforth - see last > > patch. Aside from that final doc patch I also included some todo.rst > > updates, bunch of things have progressed quite a bit. > > > > Of course spotted some lower-hanging fruit to untangle the prime helpers > > and interfaces, and decided to at least fix a few of those. > > > > Patch series survived some light testing on i915+vgem, but that's it. So > > review, testing, comments and anything else really highgly welcome. > > > > Cheers, Daniel > > > > Daniel Vetter (59): > I think this is the larges series from you so far. As already > mentioned - might be good idea to split this up a bit and merge it > into a few pieces? > Should make the churn much more manageable. > > > drm/prime: Unconditionally set up the prime file private > > drm/prime: Make DRIVER_PRIME a no-op > > drm/prime: Actually remove DRIVER_PRIME everywhere > Patch set#1 > Reviewed-by: Emil Velikov > > > drm/arm/komeda: Remove DRIVER_HAVE_IRQ > > drm/omapdrm: drop fb_debug_enter/leave > I'd keep these separate - each one is: > Reviewed-by: Emil Velikov > > > drm/arc: Drop drm_gem_prime_export/import > > drm/arm: Drop drm_gem_prime_export/import > > drm/atmel: Drop drm_gem_prime_export/import > > drm/etnaviv: Drop drm_gem_prime_export/import > > drm/exynos: Drop drm_gem_prime_export > > drm/fsl-dcu: Drop drm_gem_prime_export/import > > drm/hisilicon: Drop drm_gem_prime_export/import > > drm/imx: Drop drm_gem_prime_export/import > > drm/mcde: Drop drm_gem_prime_export/import > > drm/mtk: Drop drm_gem_prime_export/import > > drm/meson: Drop drm_gem_prime_export/import > > drm/msm: Drop drm_gem_prime_export/import > > drm/mxsfb: Drop drm_gem_prime_export/import > > drm/nouveau: Drop drm_gem_prime_export/import > > drm/pl111: Drop drm_gem_prime_export/import > > drm/qxl: Drop drm_gem_prime_export/import > > drm/rcar-du: Drop drm_gem_prime_export/import > > drm/rockchip: Drop drm_gem_prime_export/import > > drm/shmob: Drop drm_gem_prime_export/import > > drm/sti: Drop drm_gem_prime_export/import > > drm/stm: Drop drm_gem_prime_export/import > > drm/tilcdc: Drop drm_gem_prime_export/import > > drm/tve2000: Drop drm_gem_prime_export/import > > drm/vboxvideo: Drop drm_gem_prime_export/import > > drm/vc3: Drop drm_gem_prime_import > > drm/radeon: Drop drm_gem_prime_import > > drm/vgem: Drop drm_gem_prime_export > > drm/virtio: Drop drm_gem_prime_export/import > > drm/xen: Drop drm_gem_prime_export/import > > drm/zte: Drop drm_gem_prime_export/import > > drm/vram-helper: Drop drm_gem_prime_export/import > > The above are completely orthogonal of the preceding prime patches. For this > lot > Reviewed-by: Emil Velikov > > I'll get to the rest tomorrow. > > HTH > Emil > > > drm/todo: Improve drm_gem_object funcs todo > > drm/gem: Unexport drm_gem_(un)pin/v(un)map > Series X++: Reviewed-by: Emil Velikov > > drm/prime: Update docs > Will look/reply in v2 of the above. > > drm/prime: Align gem_prime_export with obj_funcs.export > Reviewed-by: Emil Velikov > > drm/prime: automatically set gem_obj->resv on import > > drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl > > drm/lima: Drop resv argument from lima_bo_create_struct > > drm/mediatek: Use drm_atomic_helper_wait_for_fences > > drm/msm: Drop robj from msm_gem_new_impl > > drm/panfrost: don't set gem_obj->resv for prime import anymore > > drm/vc4: Don set gem_obj->resv in prime import anymore > > drm/vgem: Ditch attach trickery in the fence ioctl Series X++: Reviewed-by: Emil Velikov > > drm/msm: Use drm_gem_fb_prepare_fb > > drm/vc4: Use drm_gem_fb_prepare_fb Series X++? My atomic foo isn't that great so I cannot provide any meaningful review > > drm/radeon: Fill out gem_object->resv > > drm/nouveau: Fill out gem_object->resv > > drm/amdgpu: Fill out gem_object->resv > > drm/prime: Ditch gem_prime_res_obj hook Series X++. For the lot: Reviewed-by: Emil Velikov > > drm/todo: remove gem_prime_import/export todo > > drm/todo: Update backlight todo > > drm/todo: Update mmap todo > > drm/todo: Add new debugfs todo > > drm/doc: Document kapi doc expectations > > For the documentation updates Acked-by: Emil Velikov Thanks Emil ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 00/59] prime doc polish and ... a few cleanups
Hi Daniel, On Fri, 14 Jun 2019 at 21:36, Daniel Vetter wrote: > > Hi all, > > So I figured let's get going and polish the docs for the last part of drm > core/helpers that hasn't yet seen some neat polish last few years. With > the goal to make docs for driver kapi a requirement henceforth - see last > patch. Aside from that final doc patch I also included some todo.rst > updates, bunch of things have progressed quite a bit. > > Of course spotted some lower-hanging fruit to untangle the prime helpers > and interfaces, and decided to at least fix a few of those. > > Patch series survived some light testing on i915+vgem, but that's it. So > review, testing, comments and anything else really highgly welcome. > > Cheers, Daniel > > Daniel Vetter (59): I think this is the larges series from you so far. As already mentioned - might be good idea to split this up a bit and merge it into a few pieces? Should make the churn much more manageable. > drm/prime: Unconditionally set up the prime file private > drm/prime: Make DRIVER_PRIME a no-op > drm/prime: Actually remove DRIVER_PRIME everywhere Patch set#1 Reviewed-by: Emil Velikov > drm/arm/komeda: Remove DRIVER_HAVE_IRQ > drm/omapdrm: drop fb_debug_enter/leave I'd keep these separate - each one is: Reviewed-by: Emil Velikov > drm/arc: Drop drm_gem_prime_export/import > drm/arm: Drop drm_gem_prime_export/import > drm/atmel: Drop drm_gem_prime_export/import > drm/etnaviv: Drop drm_gem_prime_export/import > drm/exynos: Drop drm_gem_prime_export > drm/fsl-dcu: Drop drm_gem_prime_export/import > drm/hisilicon: Drop drm_gem_prime_export/import > drm/imx: Drop drm_gem_prime_export/import > drm/mcde: Drop drm_gem_prime_export/import > drm/mtk: Drop drm_gem_prime_export/import > drm/meson: Drop drm_gem_prime_export/import > drm/msm: Drop drm_gem_prime_export/import > drm/mxsfb: Drop drm_gem_prime_export/import > drm/nouveau: Drop drm_gem_prime_export/import > drm/pl111: Drop drm_gem_prime_export/import > drm/qxl: Drop drm_gem_prime_export/import > drm/rcar-du: Drop drm_gem_prime_export/import > drm/rockchip: Drop drm_gem_prime_export/import > drm/shmob: Drop drm_gem_prime_export/import > drm/sti: Drop drm_gem_prime_export/import > drm/stm: Drop drm_gem_prime_export/import > drm/tilcdc: Drop drm_gem_prime_export/import > drm/tve2000: Drop drm_gem_prime_export/import > drm/vboxvideo: Drop drm_gem_prime_export/import > drm/vc3: Drop drm_gem_prime_import > drm/radeon: Drop drm_gem_prime_import > drm/vgem: Drop drm_gem_prime_export > drm/virtio: Drop drm_gem_prime_export/import > drm/xen: Drop drm_gem_prime_export/import > drm/zte: Drop drm_gem_prime_export/import > drm/vram-helper: Drop drm_gem_prime_export/import The above are completely orthogonal of the preceding prime patches. For this lot Reviewed-by: Emil Velikov I'll get to the rest tomorrow. HTH Emil > drm/todo: Improve drm_gem_object funcs todo > drm/gem: Unexport drm_gem_(un)pin/v(un)map > drm/prime: Update docs > drm/prime: Align gem_prime_export with obj_funcs.export > drm/prime: automatically set gem_obj->resv on import > drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl > drm/lima: Drop resv argument from lima_bo_create_struct > drm/mediatek: Use drm_atomic_helper_wait_for_fences > drm/msm: Drop robj from msm_gem_new_impl > drm/panfrost: don't set gem_obj->resv for prime import anymore > drm/vc4: Don set gem_obj->resv in prime import anymore > drm/vgem: Ditch attach trickery in the fence ioctl > drm/msm: Use drm_gem_fb_prepare_fb > drm/vc4: Use drm_gem_fb_prepare_fb > drm/radeon: Fill out gem_object->resv > drm/nouveau: Fill out gem_object->resv > drm/amdgpu: Fill out gem_object->resv > drm/prime: Ditch gem_prime_res_obj hook > drm/todo: remove gem_prime_import/export todo > drm/todo: Update backlight todo > drm/todo: Update mmap todo > drm/todo: Add new debugfs todo > drm/doc: Document kapi doc expectations > ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 00/59] prime doc polish and ... a few cleanups
Hi all, So I figured let's get going and polish the docs for the last part of drm core/helpers that hasn't yet seen some neat polish last few years. With the goal to make docs for driver kapi a requirement henceforth - see last patch. Aside from that final doc patch I also included some todo.rst updates, bunch of things have progressed quite a bit. Of course spotted some lower-hanging fruit to untangle the prime helpers and interfaces, and decided to at least fix a few of those. Patch series survived some light testing on i915+vgem, but that's it. So review, testing, comments and anything else really highgly welcome. Cheers, Daniel Daniel Vetter (59): drm/todo: Improve drm_gem_object funcs todo drm/gem: Unexport drm_gem_(un)pin/v(un)map drm/prime: Update docs drm/prime: Unconditionally set up the prime file private drm/prime: Make DRIVER_PRIME a no-op drm/prime: Actually remove DRIVER_PRIME everywhere drm/arm/komeda: Remove DRIVER_HAVE_IRQ drm/omapdrm: drop fb_debug_enter/leave drm/prime: Align gem_prime_export with obj_funcs.export drm/arc: Drop drm_gem_prime_export/import drm/arm: Drop drm_gem_prime_export/import drm/atmel: Drop drm_gem_prime_export/import drm/etnaviv: Drop drm_gem_prime_export/import drm/exynos: Drop drm_gem_prime_export drm/fsl-dcu: Drop drm_gem_prime_export/import drm/hisilicon: Drop drm_gem_prime_export/import drm/imx: Drop drm_gem_prime_export/import drm/mcde: Drop drm_gem_prime_export/import drm/mtk: Drop drm_gem_prime_export/import drm/meson: Drop drm_gem_prime_export/import drm/msm: Drop drm_gem_prime_export/import drm/mxsfb: Drop drm_gem_prime_export/import drm/nouveau: Drop drm_gem_prime_export/import drm/pl111: Drop drm_gem_prime_export/import drm/qxl: Drop drm_gem_prime_export/import drm/rcar-du: Drop drm_gem_prime_export/import drm/rockchip: Drop drm_gem_prime_export/import drm/shmob: Drop drm_gem_prime_export/import drm/sti: Drop drm_gem_prime_export/import drm/stm: Drop drm_gem_prime_export/import drm/tilcdc: Drop drm_gem_prime_export/import drm/tve2000: Drop drm_gem_prime_export/import drm/vboxvideo: Drop drm_gem_prime_export/import drm/vc3: Drop drm_gem_prime_import drm/radeon: Drop drm_gem_prime_import drm/vgem: Drop drm_gem_prime_export drm/virtio: Drop drm_gem_prime_export/import drm/xen: Drop drm_gem_prime_export/import drm/zte: Drop drm_gem_prime_export/import drm/vram-helper: Drop drm_gem_prime_export/import drm/prime: automatically set gem_obj->resv on import drm/etnaviv: Drop resv argument from etnaviv_gem_new_impl drm/lima: Drop resv argument from lima_bo_create_struct drm/mediatek: Use drm_atomic_helper_wait_for_fences drm/msm: Drop robj from msm_gem_new_impl drm/panfrost: don't set gem_obj->resv for prime import anymore drm/vc4: Don set gem_obj->resv in prime import anymore drm/vgem: Ditch attach trickery in the fence ioctl drm/msm: Use drm_gem_fb_prepare_fb drm/vc4: Use drm_gem_fb_prepare_fb drm/radeon: Fill out gem_object->resv drm/nouveau: Fill out gem_object->resv drm/amdgpu: Fill out gem_object->resv drm/prime: Ditch gem_prime_res_obj hook drm/todo: remove gem_prime_import/export todo drm/todo: Update backlight todo drm/todo: Update mmap todo drm/todo: Add new debugfs todo drm/doc: Document kapi doc expectations Documentation/gpu/drm-mm.rst | 40 +- Documentation/gpu/introduction.rst| 13 + Documentation/gpu/todo.rst| 65 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 24 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.h | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 2 + drivers/gpu/drm/arc/arcpgu_drv.c | 5 +- .../gpu/drm/arm/display/komeda/komeda_kms.c | 5 +- drivers/gpu/drm/arm/hdlcd_drv.c | 6 +- drivers/gpu/drm/arm/malidp_drv.c | 5 +- drivers/gpu/drm/armada/armada_drv.c | 3 +- drivers/gpu/drm/armada/armada_gem.c | 5 +- drivers/gpu/drm/armada/armada_gem.h | 3 +- drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 6 +- drivers/gpu/drm/bochs/bochs_drv.c | 3 +- drivers/gpu/drm/cirrus/cirrus.c | 2 +- drivers/gpu/drm/drm_file.c| 9 +- drivers/gpu/drm/drm_gem.c | 35 +- drivers/gpu/drm/drm_internal.h| 5 + drivers/gpu/drm/drm_prime.c | 861 +- drivers/gpu/drm/etnaviv/etnaviv_drv.c | 6 +- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 14 +- drivers/gpu/drm/etnaviv/etnaviv_gem.h | 3 +- drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 1 - drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 +- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 5 +- .../gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 5 +-
