[jira] [Commented] (LANG-1120) StringUtils.stripAccents from "Ł" and "ł"

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255478#comment-15255478
 ] 

ASF GitHub Bot commented on LANG-1120:
--

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/105#issuecomment-213879732
  
Patch does not apply.  Please update pull request.


> StringUtils.stripAccents from "Ł" and "ł"
> -
>
> Key: LANG-1120
> URL: https://issues.apache.org/jira/browse/LANG-1120
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.*
>Affects Versions: 3.4
> Environment: win
>Reporter: Krzysztof Walczewski
>Assignee: Charles Honton
> Fix For: Review Patch
>
>
> {code}
> import org.apache.commons.lang3.StringUtils;
> public class Main {
> public static void main(String[] args) {
> System.out.println(StringUtils.stripAccents("ĄŁÓŚŻŹĆŃ ąłóśżźćń"));
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: [LANG-1120] Bugfix: StringUtils#stripAc...

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/105#issuecomment-213879732
  
Patch does not apply.  Please update pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (LANG-1151) Performance improvements for NumberUtils.isParsable

[Charles Honton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Honton updated LANG-1151:
-
Assignee: (was: Charles Honton)

> Performance improvements for NumberUtils.isParsable
> ---
>
> Key: LANG-1151
> URL: https://issues.apache.org/jira/browse/LANG-1151
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.math.*
>Affects Versions: 3.4
>Reporter: Juan Pablo Santos Rodríguez
> Attachments: benchmark-lang1151.zip
>
>
> NumberUtils.isParsable contains String comparisons + some String replacing, 
> which could be improved in terms of performance. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/25#issuecomment-213879014
  
Please update to resolve conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: LANG-1065 Added new 'merge' method to D...

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/39#issuecomment-213879073
  
Please update to resolve conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LANG-1151) Performance improvements for NumberUtils.isParsable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255475#comment-15255475
 ] 

ASF GitHub Bot commented on LANG-1151:
--

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/99#issuecomment-213878630
  
Please update to resolve conflicts.


> Performance improvements for NumberUtils.isParsable
> ---
>
> Key: LANG-1151
> URL: https://issues.apache.org/jira/browse/LANG-1151
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.math.*
>Affects Versions: 3.4
>Reporter: Juan Pablo Santos Rodríguez
>Assignee: Charles Honton
> Attachments: benchmark-lang1151.zip
>
>
> NumberUtils.isParsable contains String comparisons + some String replacing, 
> which could be improved in terms of performance. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/24#issuecomment-213878951
  
Please update to resolve conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: fix LANG-1151

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/99#issuecomment-213878630
  
Please update to resolve conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (LANG-1205) NumberUtils.createNumber() behaves inconsistently with NumberUtils.isNumber()

[Charles Honton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Honton resolved LANG-1205.
--
Resolution: Fixed

commit b877fb9abef4a19eec9cc7329acbd433648b8f7b

> NumberUtils.createNumber() behaves inconsistently with NumberUtils.isNumber()
> -
>
> Key: LANG-1205
> URL: https://issues.apache.org/jira/browse/LANG-1205
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.math.*
>Affects Versions: 3.1
>Reporter: Daniel Brown
>Assignee: Charles Honton
>
> The {{NumberUtils.createNumber()}} method fails to check for multiple 
> trailing characters, and as a result, it returns a value even though 
> {{NumberUtils.isNumber()}} indicates that it should not.  For example:
> {code}
> boolean isNumber = NumberUtils.isNumber("81.5514DD");   // returns false
> Number numValue = NumberUtils.createNumber("81.5514DD");  // returns a Double 
> value, 81.5514
> {code}
> I would expect the {{createNumber()}} method to throw a 
> {{NumberFormatException}} in this case.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (LANG-1115) Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils

[Charles Honton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Honton resolved LANG-1115.
--
Resolution: Fixed

commit 5e62bf80f345ff28d494c2b407a9e8691a9fb684

> Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
> -
>
> Key: LANG-1115
> URL: https://issues.apache.org/jira/browse/LANG-1115
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Joe Ferner
>Assignee: Charles Honton
>Priority: Minor
> Fix For: Review Patch, 3.5
>
> Attachments: LANG-1115.patch
>
>
> Currently when calling methods such as 
> MethodUtils.getMatchingAccessibleMethod variable arguments are not supported. 
> It would be nice if by calling getMatchingAccessibleMethod with arguments 
> that the java compiler would normally match with a vararg method would be 
> matched.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1115) Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255463#comment-15255463
 ] 

ASF GitHub Bot commented on LANG-1115:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/89


> Add support for varargs in ConstructorUtils, MemberUtils, and MethodUtils
> -
>
> Key: LANG-1115
> URL: https://issues.apache.org/jira/browse/LANG-1115
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.reflect.*
>Reporter: Joe Ferner
>Assignee: Charles Honton
>Priority: Minor
> Fix For: Review Patch, 3.5
>
> Attachments: LANG-1115.patch
>
>
> Currently when calling methods such as 
> MethodUtils.getMatchingAccessibleMethod variable arguments are not supported. 
> It would be nice if by calling getMatchingAccessibleMethod with arguments 
> that the java compiler would normally match with a vararg method would be 
> matched.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: LANG-1115 Add support for varargs in me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LANG-1134) New methods for lang3.Validate

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255444#comment-15255444
 ] 

ASF GitHub Bot commented on LANG-1134:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/87


> New methods for lang3.Validate
> --
>
> Key: LANG-1134
> URL: https://issues.apache.org/jira/browse/LANG-1134
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Stardust
>Assignee: Charles Honton
>Priority: Minor
> Fix For: Review Patch, 3.5
>
>
> These are suggestions for new methods for the Validate class.
> h1. Floating point values
> h2. notNaN(value)
> Throws an exception if value != value .
> {code}double value;
> value = Double.NaN;
> Validate.notNaN(value);// Throws exception
> value = 1.0;
> Validate.notNaN(value);// Validates
> value = Double.POSITIVE_INFINITY;
> Validate.notNaN(value);// Validates{code}
> h2. finite(value)
> Validates that the argument contains a numeric value (not NaN or infinite).
> {code}double value;
> value = Double.NaN;
> Validate.finite(value);// Throws exception
> value = Double.POSITIVE_INFINITY;
> Validate.finite(value);// Throws exception
> value = 1.0;
> Validate.finite(value);// Validates{code}
> h1. Integers and floats
> The following methods are overloaded to accept both integers and floating 
> point values.
> h2. greater(reference, value), greaterOrEqual(reference, value)
> Ensures the argument is greater than (or equal to) a given value.
> {code}double value;
> value = 0.0;
> Validate.greater(0.0, value);// Throws exception
> Validate.greaterOrEqual(0.0, value); // Validates
> value = Double.POSITIVE_INFINITY;
> Validate.greater(0.0, value);// Validates
> value = Double.NaN;
> Validate.greater(0.0, value);// Throws exception{code}
> h2. smaller(reference, value), smallerOrEqual(reference, value)
> Ensures the argument is smaller than (or equal to) a given value. Does the 
> opposite of greater(), see example above.
> h2. different(reference, value)
> Ensures the argument is not equal to a given value. A typical use case would 
> be to accept only non-zero values.
> {code}double value;
> value = 0.0;
> Validate.different(0.0, value);// Throws exception
> Validate.different(1.0, value);// Validates
> value = Double.NaN;
> Validate.different(0.0, value);// Validates{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Lang 1134

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/87


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (LANG-1134) New methods for lang3.Validate

[Charles Honton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Honton resolved LANG-1134.
--
Resolution: Fixed

commit 77d187eefc8596ef8203eb827486099cc8b27835

> New methods for lang3.Validate
> --
>
> Key: LANG-1134
> URL: https://issues.apache.org/jira/browse/LANG-1134
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Stardust
>Assignee: Charles Honton
>Priority: Minor
> Fix For: Review Patch, 3.5
>
>
> These are suggestions for new methods for the Validate class.
> h1. Floating point values
> h2. notNaN(value)
> Throws an exception if value != value .
> {code}double value;
> value = Double.NaN;
> Validate.notNaN(value);// Throws exception
> value = 1.0;
> Validate.notNaN(value);// Validates
> value = Double.POSITIVE_INFINITY;
> Validate.notNaN(value);// Validates{code}
> h2. finite(value)
> Validates that the argument contains a numeric value (not NaN or infinite).
> {code}double value;
> value = Double.NaN;
> Validate.finite(value);// Throws exception
> value = Double.POSITIVE_INFINITY;
> Validate.finite(value);// Throws exception
> value = 1.0;
> Validate.finite(value);// Validates{code}
> h1. Integers and floats
> The following methods are overloaded to accept both integers and floating 
> point values.
> h2. greater(reference, value), greaterOrEqual(reference, value)
> Ensures the argument is greater than (or equal to) a given value.
> {code}double value;
> value = 0.0;
> Validate.greater(0.0, value);// Throws exception
> Validate.greaterOrEqual(0.0, value); // Validates
> value = Double.POSITIVE_INFINITY;
> Validate.greater(0.0, value);// Validates
> value = Double.NaN;
> Validate.greater(0.0, value);// Throws exception{code}
> h2. smaller(reference, value), smallerOrEqual(reference, value)
> Ensures the argument is smaller than (or equal to) a given value. Does the 
> opposite of greater(), see example above.
> h2. different(reference, value)
> Ensures the argument is not equal to a given value. A typical use case would 
> be to accept only non-zero values.
> {code}double value;
> value = 0.0;
> Validate.different(0.0, value);// Throws exception
> Validate.different(1.0, value);// Validates
> value = Double.NaN;
> Validate.different(0.0, value);// Validates{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (LANG-1222) Fix for incorrect comment on StringUtils.containsIgnoreCase method

[Bruno P. Kinoshita (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita resolved LANG-1222.
--
Resolution: Fixed

> Fix for incorrect comment on StringUtils.containsIgnoreCase method
> --
>
> Key: LANG-1222
> URL: https://issues.apache.org/jira/browse/LANG-1222
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
>  Labels: javadoc, typo
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Placeholder for https://github.com/apache/commons-lang/pull/125/files
> {quote}
> Looks that comment on StringUtils.containsIgnoreCase method was copy-pasted.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Fix for incorrect comment on StringUtil...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (LANG-1222) Fix for incorrect comment on StringUtils.containsIgnoreCase method

[Bruno P. Kinoshita (JIRA)]

Bruno P. Kinoshita created LANG-1222:


 Summary: Fix for incorrect comment on 
StringUtils.containsIgnoreCase method
 Key: LANG-1222
 URL: https://issues.apache.org/jira/browse/LANG-1222
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.*
Affects Versions: 3.4
Reporter: Bruno P. Kinoshita
Assignee: Bruno P. Kinoshita
Priority: Trivial


Placeholder for https://github.com/apache/commons-lang/pull/125/files

{quote}
Looks that comment on StringUtils.containsIgnoreCase method was copy-pasted.
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Fix for incorrect comment on StringUtil...

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/125#issuecomment-213862327
  
Adding an entry to changes.xml with dev=ggregory and the text "... closes 
#125" in order to close this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LANG-1222) Fix for incorrect comment on StringUtils.containsIgnoreCase method

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255442#comment-15255442
 ] 

ASF GitHub Bot commented on LANG-1222:
--

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/125#issuecomment-213862318
  
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1222


> Fix for incorrect comment on StringUtils.containsIgnoreCase method
> --
>
> Key: LANG-1222
> URL: https://issues.apache.org/jira/browse/LANG-1222
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
>  Labels: javadoc, typo
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Placeholder for https://github.com/apache/commons-lang/pull/125/files
> {quote}
> Looks that comment on StringUtils.containsIgnoreCase method was copy-pasted.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Fix for incorrect comment on StringUtil...

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/125#issuecomment-213862318
  
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1222


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (LANG-1221) Fix typo on appendIfMissing javadoc

[Bruno P. Kinoshita (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita resolved LANG-1221.
--
Resolution: Fixed

> Fix typo on appendIfMissing javadoc
> ---
>
> Key: LANG-1221
> URL: https://issues.apache.org/jira/browse/LANG-1221
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
>  Labels: javadoc, typo
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Placeholder for https://github.com/apache/commons-lang/pull/129



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (LANG-1220) Add tests for missed branches in DateUtils

[Bruno P. Kinoshita (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno P. Kinoshita resolved LANG-1220.
--
Resolution: Fixed

> Add tests for missed branches in DateUtils
> --
>
> Key: LANG-1220
> URL: https://issues.apache.org/jira/browse/LANG-1220
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.time.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>  Labels: coverage, test
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Place holder for https://github.com/apache/commons-lang/pull/133
> {quote}
> Fixes a typo and adds tests for some missed branches in DateUtils.
> The isSame methods require both dates to be non-null. Previously, breaking 
> the check to allow one of the dates to be null didn't trigger a failing test.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Fix typo on appendIfMissing javadoc

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Fix typo on appendIfMissing javadoc

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/129#issuecomment-213861995
  
Adding an entry in changes.xml for that with dev= ggregory, with a message 
containing the closes #129 in order to close this pull request in GitHub and 
also keep track of the change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LANG-1221) Fix typo on appendIfMissing javadoc

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255441#comment-15255441
 ] 

ASF GitHub Bot commented on LANG-1221:
--

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/129#issuecomment-213861965
  
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1221


> Fix typo on appendIfMissing javadoc
> ---
>
> Key: LANG-1221
> URL: https://issues.apache.org/jira/browse/LANG-1221
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Trivial
>  Labels: javadoc, typo
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Placeholder for https://github.com/apache/commons-lang/pull/129



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LANG-1221) Fix typo on appendIfMissing javadoc

[Bruno P. Kinoshita (JIRA)]

Bruno P. Kinoshita created LANG-1221:


 Summary: Fix typo on appendIfMissing javadoc
 Key: LANG-1221
 URL: https://issues.apache.org/jira/browse/LANG-1221
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.*
Affects Versions: 3.4
Reporter: Bruno P. Kinoshita
Assignee: Bruno P. Kinoshita
Priority: Trivial


Placeholder for https://github.com/apache/commons-lang/pull/129



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Fix typo on appendIfMissing javadoc

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/129#issuecomment-213861965
  
Placeholder ticket created https://issues.apache.org/jira/browse/LANG-1221


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for missed branches in DateUt...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/133


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for missed branches in DateUt...

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/133#issuecomment-213860528
  
Tested locally. All tests pass. Line coverage for Date keeps in 95%, branch 
coverage went from 90% to 92%, having 194/210 whereas it previously was 189/210.

Couldn't merge with the normal commands locally, as the remote branch was 
called 'master' and git wasn't happy about that. Didn't have enough git-fu for 
a workaround, so merged manully as a patch (see the bottom of the page at 
http://wiki.apache.org/commons/UsingGIT).

Thanks for your contribution.
Bruno


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for missed branches in DateUt...

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/133#issuecomment-213860127
  
Merged in 
https://github.com/apache/commons-lang/commit/fac65b868c549d28b786568636bbc8362d2a78f2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (LANG-903) Add XML implementation of ToStringStyle

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255438#comment-15255438
 ] 

ASF GitHub Bot commented on LANG-903:
-

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/7#issuecomment-213859284
  
The values are not xml escaped.  This won't be needed for class or field 
names.

If you're still interested, please update pull request against latest 
master branch.


> Add XML implementation of ToStringStyle
> ---
>
> Key: LANG-903
> URL: https://issues.apache.org/jira/browse/LANG-903
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.builder.*
>Affects Versions: 3.1
>Reporter: Dave Hughes
>Priority: Minor
> Fix For: Review Patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Lang 1.1 included a commented out implementation of XMLToStringStyle.  This 
> disappeared in later versions, but is a very useful implementation.  
> (JSONToStringStyle would also be very nice)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1220) Add tests for missed branches in DateUtils

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255437#comment-15255437
 ] 

ASF GitHub Bot commented on LANG-1220:
--

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/133#issuecomment-213859206
  
Placeholder ticket created in JIRA 
https://issues.apache.org/jira/browse/LANG-1220


> Add tests for missed branches in DateUtils
> --
>
> Key: LANG-1220
> URL: https://issues.apache.org/jira/browse/LANG-1220
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.time.*
>Affects Versions: 3.4
>Reporter: Bruno P. Kinoshita
>Assignee: Bruno P. Kinoshita
>Priority: Minor
>  Labels: coverage, test
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Place holder for https://github.com/apache/commons-lang/pull/133
> {quote}
> Fixes a typo and adds tests for some missed branches in DateUtils.
> The isSame methods require both dates to be non-null. Previously, breaking 
> the check to allow one of the dates to be null didn't trigger a failing test.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: [LANG-903] Trunk - ToStringStyle typos ...

[chonton]

Github user chonton commented on the pull request:

https://github.com/apache/commons-lang/pull/7#issuecomment-213859284
  
The values are not xml escaped.  This won't be needed for class or field 
names.

If you're still interested, please update pull request against latest 
master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for missed branches in DateUt...

[kinow]

Github user kinow commented on the pull request:

https://github.com/apache/commons-lang/pull/133#issuecomment-213859206
  
Placeholder ticket created in JIRA 
https://issues.apache.org/jira/browse/LANG-1220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (LANG-1220) Add tests for missed branches in DateUtils

[Bruno P. Kinoshita (JIRA)]

Bruno P. Kinoshita created LANG-1220:


 Summary: Add tests for missed branches in DateUtils
 Key: LANG-1220
 URL: https://issues.apache.org/jira/browse/LANG-1220
 Project: Commons Lang
  Issue Type: Improvement
  Components: lang.time.*
Affects Versions: 3.4
Reporter: Bruno P. Kinoshita
Assignee: Bruno P. Kinoshita
Priority: Minor


Place holder for https://github.com/apache/commons-lang/pull/133

{quote}
Fixes a typo and adds tests for some missed branches in DateUtils.

The isSame methods require both dates to be non-null. Previously, breaking the 
check to allow one of the dates to be null didn't trigger a failing test.
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1201) Add a TimeUnit-like classes for base 2 and base 10 digital conversions (bits, bytes, KB, MB, and so on)

[Charles Honton (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255433#comment-15255433
 ] 

Charles Honton commented on LANG-1201:
--

Has this been completed with commit 04e52eb6155b3cbf5fffc0d52689a3f679e40b19?

> Add a TimeUnit-like classes for base 2 and base 10 digital conversions (bits, 
> bytes, KB, MB, and so on)
> ---
>
> Key: LANG-1201
> URL: https://issues.apache.org/jira/browse/LANG-1201
> Project: Commons Lang
>  Issue Type: New Feature
>Reporter: Gary Gregory
>Assignee: Gary Gregory
>
> Add a TimeUnit-like class for digital conversions (bits, bytes, KB, MB, and 
> so on)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (MATH-1359) Function object for "expm1(x) / x"

[Gilles (JIRA)]

Gilles created MATH-1359:


 Summary: Function object for "expm1(x) / x"
 Key: MATH-1359
 URL: https://issues.apache.org/jira/browse/MATH-1359
 Project: Commons Math
  Issue Type: Task
Reporter: Gilles
Priority: Minor
 Fix For: 4.0


Function object to be created in package o.a.c.m.analysis.function.
Rationale: see MATH-1344.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (MATH-1358) Function object for "log1p(x) / x"

[Gilles (JIRA)]

Gilles created MATH-1358:


 Summary: Function object for "log1p(x) / x"
 Key: MATH-1358
 URL: https://issues.apache.org/jira/browse/MATH-1358
 Project: Commons Math
  Issue Type: Task
Reporter: Gilles
Priority: Minor
 Fix For: 4.0


Function object to be created in package {{o.a.c.m.analysis.function}}.
Rationale: see MATH-1344.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MATH-1350) Improvement to code coverage

[Gilles (JIRA)]

[ 
https://issues.apache.org/jira/browse/MATH-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255389#comment-15255389
 ] 

Gilles commented on MATH-1350:
--

I've created a branch "test-MATH-1350" that contains the code from the pull 
request.
If you want to continue adding unit tests, please use that branch.
Thanks for contributing to CM.

Let me know when you consider that work is complete and the branch can be 
merged into "develop".

> Improvement to code coverage
> 
>
> Key: MATH-1350
> URL: https://issues.apache.org/jira/browse/MATH-1350
> Project: Commons Math
>  Issue Type: Test
>Reporter: Rob Tompkins
>Priority: Trivial
>  Labels: cleanup, newbie, test
> Fix For: 4.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This is a mechanism for me to gain familiarity with the code and the 
> contributing process.
> This may be mainly trivial, but the plan is to work with some of the packages 
> with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
> {{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and 
> write unit tests to improve their numbers.
> Pull request:
> https://github.com/apache/commons-math/pull/30 
> which can be pulled in with command
> {code:none}
> git pull https://github.com/chtompki/commons-math.git test-MATH-1350
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (LANG-1219) FastDateFormat doesn't respect summer daylight in localized strings

[Charles Honton (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LANG-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Charles Honton resolved LANG-1219.
--
Resolution: Fixed

commit 3c92830ec51fb6b6e9a7ca2fb8fda324cd33e48a

> FastDateFormat doesn't respect summer daylight in localized strings
> ---
>
> Key: LANG-1219
> URL: https://issues.apache.org/jira/browse/LANG-1219
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.time.*
>Affects Versions: 3.4
>Reporter: Jarek
>Assignee: Charles Honton
>  Labels: timezone
>
> FastDateFormat can't properly parse dates with daylight saving in the "z" 
> pattern. It always returns date without daylight saving. Test case:
> {code:java}
>   SimpleDateFormat format = new SimpleDateFormat("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d1 = format.parse("26.10.2014 02:00:00 MESZ");
>   Date d2 = format.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d1);
>   System.out.println(d2);
>   FastDateFormat formatt = FastDateFormat.getInstance("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d3 = formatt.parse("26.10.2014 02:00:00 MESZ");
>   Date d4 = formatt.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d3);
>   System.out.println(d4); 
> {code}
> returns:
> SDF: Sun Oct 26 02:00:00 CEST 2014
> SDF: Sun Oct 26 02:00:00 CET 2014
> FDF: Sun Oct 26 02:00:00 CET 2014
> FDF:  Sun Oct 26 02:00:00 CET 2014
> FastDateFormat returns the same date, which is wrong.
> Bug is in the FastDateParser.TimeZoneStrategy.setCalendar:
> {code:java}
> @Override
> void setCalendar(final FastDateParser parser, final Calendar cal, 
> final String value) {
> TimeZone tz;
> if(value.charAt(0)=='+' || value.charAt(0)=='-') {
> tz= TimeZone.getTimeZone("GMT"+value);
> }
> else if(value.startsWith("GMT")) {
> tz= TimeZone.getTimeZone(value);
> }
> else {
> tz= tzNames.get(value);
> if(tz==null) {
> throw new IllegalArgumentException(value + " is not a 
> supported timezone name");
> }
> }
> cal.setTimeZone(tz);
> }
> {code}
> It's not enough to just call: cal.setTimeZone.
> If zone names in standard and daylight time are different, you have to check 
> the name in DateFormatSymbols.getInstance(locale).getZoneStrings(); and if 
> it's >= 3, you have to activate daylight mode.Just like SimpleDateFormat does 
> it:
> {code:java}
> 1491// (abbreviation) for both standard and daylight time,
> 1492// let the time zone in the Calendar decide which one.
> 1493if (!useSameName) {
> 1494calendar.set(Calendar.ZONE_OFFSET, tz.getRawOffset());
> 1495calendar.set(Calendar.DST_OFFSET,
> 1496 j >= 3 ? tz.getDSTSavings() : 0);
> 1497}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1219) FastDateFormat doesn't respect summer daylight in localized strings

[Charles Honton (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255367#comment-15255367
 ] 

Charles Honton commented on LANG-1219:
--

Upon further investigation, in the update 
DateFormatSymbols.getInstance(locale).getZoneStrings() provides more zoneNames. 
As an example:
[0] "Europe/Paris"
[1] "Mitteleuropäische Zeit"
[2] "MEZ"
[3] "Mitteleuropäische Sommerzeit"
[4] "MESZ"
[5] "Mitteleuropäische Zeit"
[6] "MEZ"

I'm going to drop any duplicate entries and any keys past index 4 are in 
standard time

> FastDateFormat doesn't respect summer daylight in localized strings
> ---
>
> Key: LANG-1219
> URL: https://issues.apache.org/jira/browse/LANG-1219
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.time.*
>Affects Versions: 3.4
>Reporter: Jarek
>Assignee: Charles Honton
>  Labels: timezone
>
> FastDateFormat can't properly parse dates with daylight saving in the "z" 
> pattern. It always returns date without daylight saving. Test case:
> {code:java}
>   SimpleDateFormat format = new SimpleDateFormat("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d1 = format.parse("26.10.2014 02:00:00 MESZ");
>   Date d2 = format.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d1);
>   System.out.println(d2);
>   FastDateFormat formatt = FastDateFormat.getInstance("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d3 = formatt.parse("26.10.2014 02:00:00 MESZ");
>   Date d4 = formatt.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d3);
>   System.out.println(d4); 
> {code}
> returns:
> SDF: Sun Oct 26 02:00:00 CEST 2014
> SDF: Sun Oct 26 02:00:00 CET 2014
> FDF: Sun Oct 26 02:00:00 CET 2014
> FDF:  Sun Oct 26 02:00:00 CET 2014
> FastDateFormat returns the same date, which is wrong.
> Bug is in the FastDateParser.TimeZoneStrategy.setCalendar:
> {code:java}
> @Override
> void setCalendar(final FastDateParser parser, final Calendar cal, 
> final String value) {
> TimeZone tz;
> if(value.charAt(0)=='+' || value.charAt(0)=='-') {
> tz= TimeZone.getTimeZone("GMT"+value);
> }
> else if(value.startsWith("GMT")) {
> tz= TimeZone.getTimeZone(value);
> }
> else {
> tz= tzNames.get(value);
> if(tz==null) {
> throw new IllegalArgumentException(value + " is not a 
> supported timezone name");
> }
> }
> cal.setTimeZone(tz);
> }
> {code}
> It's not enough to just call: cal.setTimeZone.
> If zone names in standard and daylight time are different, you have to check 
> the name in DateFormatSymbols.getInstance(locale).getZoneStrings(); and if 
> it's >= 3, you have to activate daylight mode.Just like SimpleDateFormat does 
> it:
> {code:java}
> 1491// (abbreviation) for both standard and daylight time,
> 1492// let the time zone in the Calendar decide which one.
> 1493if (!useSameName) {
> 1494calendar.set(Calendar.ZONE_OFFSET, tz.getRawOffset());
> 1495calendar.set(Calendar.DST_OFFSET,
> 1496 j >= 3 ? tz.getDSTSavings() : 0);
> 1497}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] commons-lang pull request: Add tests for missed branches in DateUt...

[caseyscarborough]

GitHub user caseyscarborough opened a pull request:

https://github.com/apache/commons-lang/pull/133

Add tests for missed branches in DateUtils

Fixes a typo and adds tests for some missed branches in `DateUtils`.

The `isSame` methods require both dates to be non-null. Previously breaking 
the check to allow one of the dates to be null didn't trigger a failing test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/caseyscarborough/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/133.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #133


commit 1ecdf78a240d9894ca5e25fee49bb8a38aa08a0c
Author: Casey Scarborough 
Date:   2016-04-23T17:46:21Z

Add tests for missed branches in DateUtils




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (MATH-1350) Improvement to code coverage

[Rob Tompkins (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MATH-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Tompkins updated MATH-1350:
---
Description: 
This is a mechanism for me to gain familiarity with the code and the 
contributing process.

This may be mainly trivial, but the plan is to work with some of the packages 
with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
{{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and write 
unit tests to improve their numbers.

Pull request:
https://github.com/apache/commons-math/pull/30 
which can be pulled in with command
{code:none}
git pull https://github.com/chtompki/commons-math.git test-MATH-1350
{code}

  was:
This is a mechanism for me to gain familiarity with the code and the 
contributing process.

This may be mainly trivial, but the plan is to work with some of the packages 
with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
{{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and write 
unit tests to improve their numbers.

Pull request:
https://github.com/apache/commons-math/pull/30 
which can be pulled in with command
{code:no format}
git pull https://github.com/chtompki/commons-math.git test-MATH-1350
{code}


> Improvement to code coverage
> 
>
> Key: MATH-1350
> URL: https://issues.apache.org/jira/browse/MATH-1350
> Project: Commons Math
>  Issue Type: Test
>Reporter: Rob Tompkins
>Priority: Trivial
>  Labels: cleanup, newbie, test
> Fix For: 4.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This is a mechanism for me to gain familiarity with the code and the 
> contributing process.
> This may be mainly trivial, but the plan is to work with some of the packages 
> with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
> {{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and 
> write unit tests to improve their numbers.
> Pull request:
> https://github.com/apache/commons-math/pull/30 
> which can be pulled in with command
> {code:none}
> git pull https://github.com/chtompki/commons-math.git test-MATH-1350
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (MATH-1350) Improvement to code coverage

[Rob Tompkins (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MATH-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Tompkins updated MATH-1350:
---
Description: 
This is a mechanism for me to gain familiarity with the code and the 
contributing process.

This may be mainly trivial, but the plan is to work with some of the packages 
with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
{{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and write 
unit tests to improve their numbers.

Pull request:
https://github.com/apache/commons-math/pull/30 
which can be pulled in with command
{code:no format}
git pull https://github.com/chtompki/commons-math.git test-MATH-1350
{code}

  was:
This is a mechanism for me to gain familiarity with the code and the 
contributing process.

This may be mainly trivial, but the plan is to work with some of the packages 
with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
{{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and write 
unit tests to improve their numbers.


> Improvement to code coverage
> 
>
> Key: MATH-1350
> URL: https://issues.apache.org/jira/browse/MATH-1350
> Project: Commons Math
>  Issue Type: Test
>Reporter: Rob Tompkins
>Priority: Trivial
>  Labels: cleanup, newbie, test
> Fix For: 4.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> This is a mechanism for me to gain familiarity with the code and the 
> contributing process.
> This may be mainly trivial, but the plan is to work with some of the packages 
> with lower coverage numbers (e.g {{org.apache.commons.math4.exception}}, 
> {{org.apache.commons.math4.filter}}, {{org.apache.commons.math4.ml}}) and 
> write unit tests to improve their numbers.
> Pull request:
> https://github.com/apache/commons-math/pull/30 
> which can be pulled in with command
> {code:no format}
> git pull https://github.com/chtompki/commons-math.git test-MATH-1350
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CRYPTO-21) Cannot access cTAKES forums

[Sebb (JIRA)]

[ 
https://issues.apache.org/jira/browse/CRYPTO-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255266#comment-15255266
 ] 

Sebb commented on CRYPTO-21:


Wrong JIRA; should be in CTAKES:

https://issues.apache.org/jira/browse/CTAKES/

However does not appear to be possible to move the issue across at present.

> Cannot access cTAKES forums
> ---
>
> Key: CRYPTO-21
> URL: https://issues.apache.org/jira/browse/CRYPTO-21
> Project: Commons Crypto
>  Issue Type: Bug
>Reporter: CANDAN SOYKAN
>Priority: Minor
>
> I am new to cTAKES and am interested in installing a customized dictionary. 
> This website:
> https://cwiki.apache.org/confluence/display/CTAKES/cTAKES+3.1+Dictionaries+and+Models
> provides links to two posts that detail how to do this. However, the links 
> time out when I click on them. I've tried with Firefox and Safari, so it is 
> not simply a browser issue. I then searched more broadly for cTAKES forums 
> and found that another link was not working properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (MATH-981) An improved algorithm for computing the inverse cumulative probability for the normal distribution

[Gilles (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MATH-981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gilles closed MATH-981.
---

Resolved (as "Won't fix") already before the latest 4 releases of CM.

> An improved algorithm for computing the inverse cumulative probability for 
> the normal distribution
> --
>
> Key: MATH-981
> URL: https://issues.apache.org/jira/browse/MATH-981
> Project: Commons Math
>  Issue Type: Sub-task
>Reporter: Thomas Neidhart
>Priority: Minor
>
> The following page outlines an algorithm (and alternative algorithms) to 
> compute the inverse cumulative probability for the normal distribution:
> http://home.online.no/~pjacklam/notes/invnorm/
> An implementation of this is also included in the referred contribution for a 
> Monte Carlo engine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (MATH-982) Improvements to the User Guide

[Gilles (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MATH-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gilles closed MATH-982.
---

Old issue with no update in almost 2 years.

> Improvements to the User Guide
> --
>
> Key: MATH-982
> URL: https://issues.apache.org/jira/browse/MATH-982
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Thomas Neidhart
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (MATH-982) Improvements to the User Guide

[Gilles (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MATH-982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gilles resolved MATH-982.
-
Resolution: Unresolved

All sub-tasks marked as resolved (but not all as "Fixed").
User guide still needs improvement...

> Improvements to the User Guide
> --
>
> Key: MATH-982
> URL: https://issues.apache.org/jira/browse/MATH-982
> Project: Commons Math
>  Issue Type: Improvement
>Reporter: Thomas Neidhart
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1219) FastDateFormat doesn't respect summer daylight in localized strings

[Charles Honton (JIRA)]

[ 
https://issues.apache.org/jira/browse/LANG-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255164#comment-15255164
 ] 

Charles Honton commented on LANG-1219:
--

While testing a potential solution, found a possible regression in java version 
"1.8.0_60-b27".  The date produced by Gregorian calendar is incorrect when 
setting both TimeZone and DST offset fields.

> FastDateFormat doesn't respect summer daylight in localized strings
> ---
>
> Key: LANG-1219
> URL: https://issues.apache.org/jira/browse/LANG-1219
> Project: Commons Lang
>  Issue Type: Bug
>  Components: lang.time.*
>Affects Versions: 3.4
>Reporter: Jarek
>Assignee: Charles Honton
>  Labels: timezone
>
> FastDateFormat can't properly parse dates with daylight saving in the "z" 
> pattern. It always returns date without daylight saving. Test case:
> {code:java}
>   SimpleDateFormat format = new SimpleDateFormat("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d1 = format.parse("26.10.2014 02:00:00 MESZ");
>   Date d2 = format.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d1);
>   System.out.println(d2);
>   FastDateFormat formatt = FastDateFormat.getInstance("dd.MM. 
> HH:mm:ss z", Locale.GERMANY);
>   Date d3 = formatt.parse("26.10.2014 02:00:00 MESZ");
>   Date d4 = formatt.parse("26.10.2014 02:00:00 MEZ");
>   System.out.println(d3);
>   System.out.println(d4); 
> {code}
> returns:
> SDF: Sun Oct 26 02:00:00 CEST 2014
> SDF: Sun Oct 26 02:00:00 CET 2014
> FDF: Sun Oct 26 02:00:00 CET 2014
> FDF:  Sun Oct 26 02:00:00 CET 2014
> FastDateFormat returns the same date, which is wrong.
> Bug is in the FastDateParser.TimeZoneStrategy.setCalendar:
> {code:java}
> @Override
> void setCalendar(final FastDateParser parser, final Calendar cal, 
> final String value) {
> TimeZone tz;
> if(value.charAt(0)=='+' || value.charAt(0)=='-') {
> tz= TimeZone.getTimeZone("GMT"+value);
> }
> else if(value.startsWith("GMT")) {
> tz= TimeZone.getTimeZone(value);
> }
> else {
> tz= tzNames.get(value);
> if(tz==null) {
> throw new IllegalArgumentException(value + " is not a 
> supported timezone name");
> }
> }
> cal.setTimeZone(tz);
> }
> {code}
> It's not enough to just call: cal.setTimeZone.
> If zone names in standard and daylight time are different, you have to check 
> the name in DateFormatSymbols.getInstance(locale).getZoneStrings(); and if 
> it's >= 3, you have to activate daylight mode.Just like SimpleDateFormat does 
> it:
> {code:java}
> 1491// (abbreviation) for both standard and daylight time,
> 1492// let the time zone in the Calendar decide which one.
> 1493if (!useSameName) {
> 1494calendar.set(Calendar.ZONE_OFFSET, tz.getRawOffset());
> 1495calendar.set(Calendar.DST_OFFSET,
> 1496 j >= 3 ? tz.getDSTSavings() : 0);
> 1497}
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)