[jira] [Updated] (NET-626) SubnetUtils#SubnetUtils - improved comment

[Makoto Sakaguchi (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NET-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Makoto Sakaguchi updated NET-626:
-
Description: 
Describe of CIDR value was more clearly.
https://github.com/apache/commons-net/pull/16

  was:Describe of CIDR value was more clearly.


> SubnetUtils#SubnetUtils - improved comment
> --
>
> Key: NET-626
> URL: https://issues.apache.org/jira/browse/NET-626
> Project: Commons Net
>  Issue Type: Improvement
>Reporter: Makoto Sakaguchi
>Priority: Minor
>
> Describe of CIDR value was more clearly.
> https://github.com/apache/commons-net/pull/16



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (NET-626) SubnetUtils#SubnetUtils - improved comment

[Makoto Sakaguchi (JIRA)]

Makoto Sakaguchi created NET-626:


 Summary: SubnetUtils#SubnetUtils - improved comment
 Key: NET-626
 URL: https://issues.apache.org/jira/browse/NET-626
 Project: Commons Net
  Issue Type: Improvement
Reporter: Makoto Sakaguchi
Priority: Minor


Describe of CIDR value was more clearly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (TEXT-72) Similar to LANG-1025, clirr fails site build.

[Rob Tompkins (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TEXT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Tompkins resolved TEXT-72.
--
Resolution: Fixed
  Assignee: Rob Tompkins

> Similar to LANG-1025, clirr fails site build.
> -
>
> Key: TEXT-72
> URL: https://issues.apache.org/jira/browse/TEXT-72
> Project: Commons Text
>  Issue Type: Bug
>Affects Versions: 1.0
>Reporter: Rob Tompkins
>Assignee: Rob Tompkins
> Fix For: 1.x
>
>
> clirr seems to be failing to build properly with java 1.8.0_121 and maven 
> 3.3.9. Analogous to https://issues.apache.org/jira/browse/LANG-1025, we are 
> upgrading to clirr 2.8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TEXT-72) Similar to LANG-1025, clirr fails site build.

[Rob Tompkins (JIRA)]

[ 
https://issues.apache.org/jira/browse/TEXT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906399#comment-15906399
 ] 

Rob Tompkins commented on TEXT-72:
--

https://git1-us-west.apache.org/repos/asf?p=commons-text.git;a=commit;h=94ca2ca0

> Similar to LANG-1025, clirr fails site build.
> -
>
> Key: TEXT-72
> URL: https://issues.apache.org/jira/browse/TEXT-72
> Project: Commons Text
>  Issue Type: Bug
>Affects Versions: 1.0
>Reporter: Rob Tompkins
> Fix For: 1.x
>
>
> clirr seems to be failing to build properly with java 1.8.0_121 and maven 
> 3.3.9. Analogous to https://issues.apache.org/jira/browse/LANG-1025, we are 
> upgrading to clirr 2.8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TEXT-72) Similar to LANG-1025, clirr fails site build.

[Rob Tompkins (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TEXT-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Tompkins updated TEXT-72:
-
Summary: Similar to LANG-1025, clirr fails site build.  (was: Similar to 
LANG-1025)

> Similar to LANG-1025, clirr fails site build.
> -
>
> Key: TEXT-72
> URL: https://issues.apache.org/jira/browse/TEXT-72
> Project: Commons Text
>  Issue Type: Bug
>Affects Versions: 1.0
>Reporter: Rob Tompkins
> Fix For: 1.x
>
>
> clirr seems to be failing to build properly with java 1.8.0_121 and maven 
> 3.3.9. Analogous to https://issues.apache.org/jira/browse/LANG-1025, we are 
> upgrading to clirr 2.8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TEXT-72) Similar to LANG-1025

[Rob Tompkins (JIRA)]

Rob Tompkins created TEXT-72:


 Summary: Similar to LANG-1025
 Key: TEXT-72
 URL: https://issues.apache.org/jira/browse/TEXT-72
 Project: Commons Text
  Issue Type: Bug
Affects Versions: 1.0
Reporter: Rob Tompkins
 Fix For: 1.x


clirr seems to be failing to build properly with java 1.8.0_121 and maven 
3.3.9. Analogous to https://issues.apache.org/jira/browse/LANG-1025, we are 
upgrading to clirr 2.8.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] commons-lang issue #254: Add checkstyle to the CI

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/254
  

[![Coverage 
Status](https://coveralls.io/builds/10546929/badge)](https://coveralls.io/builds/10546929)

Coverage remained the same at 94.529% when pulling 
**417c2931cef184843a58c85b7bdddc6210494e3a on mureinik:checkstyle** into 
**ee19f8247c4bc0335ad3efe212dc0bdce97e2034 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #254: Add checkstyle to the CI

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/254
  

[![Coverage 
Status](https://coveralls.io/builds/10546889/badge)](https://coveralls.io/builds/10546889)

Coverage remained the same at 94.529% when pulling 
**417c2931cef184843a58c85b7bdddc6210494e3a on mureinik:checkstyle** into 
**ee19f8247c4bc0335ad3efe212dc0bdce97e2034 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #254: Add checkstyle to the CI

[PascalSchumacher]

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/254
  
I think that is normal lately. Seems like a lot of apache projects enabled 
travis recently and now apaches travis-ci capacity can not handle the load. 
Sometimes it takes a day until the build runs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #254: Add checkstyle to the CI

[mureinik]

Github user mureinik commented on the issue:

https://github.com/apache/commons-lang/pull/254
  
CI seems to have been stuck for several hours. What am I missing here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Resolved] (NET-625) SubnetUtils - improve construction

[Sebb (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NET-625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-625.
--
   Resolution: Fixed
Fix Version/s: 3.7

URL: http://svn.apache.org/viewvc?rev=1786511=rev
Log:
NET-625 SubnetUtils - improve construction
Also make most fields final

Modified:
commons/proper/net/trunk/src/changes/changes.xml

commons/proper/net/trunk/src/main/java/org/apache/commons/net/util/SubnetUtils.java


> SubnetUtils - improve construction
> --
>
> Key: NET-625
> URL: https://issues.apache.org/jira/browse/NET-625
> Project: Commons Net
>  Issue Type: Improvement
>Affects Versions: 3.6
>Reporter: Sebb
> Fix For: 3.7
>
>
> The constructors for CIDR format and (address, mask) format both use the same 
> calculate() method. This assumes the input is in CIDR format, which means 
> that the constructor which handles (address, mask) format has to convert the 
> strings to binary and then recreate the CIDR format.
> This is wasteful.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (NET-625) SubnetUtils - improve construction

[Sebb (JIRA)]

Sebb created NET-625:


 Summary: SubnetUtils - improve construction
 Key: NET-625
 URL: https://issues.apache.org/jira/browse/NET-625
 Project: Commons Net
  Issue Type: Improvement
Affects Versions: 3.6
Reporter: Sebb


The constructors for CIDR format and (address, mask) format both use the same 
calculate() method. This assumes the input is in CIDR format, which means that 
the constructor which handles (address, mask) format has to convert the strings 
to binary and then recreate the CIDR format.

This is wasteful.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (NET-622) SubnetInfo#getCidrSignature - improve functions

[Sebb (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb resolved NET-622.
--
   Resolution: Fixed
Fix Version/s: 3.7

Thanks, fixed:

URL: http://svn.apache.org/viewvc?rev=1786507=rev
Log:
NET-624 SubnetInfo#getCidrSignature - improve functions

Modified:
commons/proper/net/trunk/src/changes/changes.xml

commons/proper/net/trunk/src/main/java/org/apache/commons/net/util/SubnetUtils.java


> SubnetInfo#getCidrSignature - improve functions
> ---
>
> Key: NET-622
> URL: https://issues.apache.org/jira/browse/NET-622
> Project: Commons Net
>  Issue Type: Improvement
>Reporter: Makoto Sakaguchi
>Priority: Minor
> Fix For: 3.7
>
>
> The processing part of "netmask" is converted an integer to a string to an 
> integer.
> {code}
> /* SubnetUtils.SubnetInfo#getCidrSignature() */
> // a binary mask address
> int netmask = 0b;
> // convert to a dotted decimal address
> String maskStr = format(toArray(netmask)); // maskStr: "255.0.0.0"
> /* SubnetUtils#toCidrNotation() */
> // counting the 1-bit population
> int cidr = pop(toInteger(maskStr)); // cidr: 8
> {code}
> So, I suggest to create CIDR from the netmask variable.
> https://github.com/apache/commons-net/pull/10



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[kinow]

Github user kinow commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/254#discussion_r105530594
  
--- Diff: checkstyle.xml ---
@@ -36,11 +36,9 @@ limitations under the License.
 
 
 
-
--- End diff --

:+1: thanks for the explanation and the links @mureinik 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #254: Add checkstyle to the CI

[mureinik]

Github user mureinik commented on the issue:

https://github.com/apache/commons-lang/pull/254
  
Latest push fixes the typo (thraed->thread) as per @kinow's review. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[mureinik]

Github user mureinik commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/254#discussion_r105530384
  
--- Diff: checkstyle.xml ---
@@ -36,11 +36,9 @@ limitations under the License.
 
 
 
-
--- End diff --

Yes. I explained this in the relevant commit 
(a7d7e37d091bf1ba3674c6fc617466b284aaac71) , but perhaps I should add the 
explanation to the PR's comment too, to make it more obvious. New checkstyle 
versions removed this check, so we can no longer use it. Since checkstyle is 
not type-aware, there's really no way of performing this check properly - see 
https://github.com/checkstyle/checkstyle/issues/473 for the discussion about 
this removal.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[mureinik]

Github user mureinik commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/254#discussion_r105530325
  
--- Diff: 
src/main/java/org/apache/commons/lang3/concurrent/annotation/package-info.java 
---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/**
+ * Provides annotations to document classes' thraed safety
--- End diff --

Arg :-(
Will fix, thanks for noticing!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[kinow]

Github user kinow commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/254#discussion_r105530165
  
--- Diff: 
src/main/java/org/apache/commons/lang3/concurrent/annotation/package-info.java 
---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/**
+ * Provides annotations to document classes' thraed safety
--- End diff --

typo

s/thraed/thread


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[kinow]

Github user kinow commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/254#discussion_r105530182
  
--- Diff: checkstyle.xml ---
@@ -36,11 +36,9 @@ limitations under the License.
 
 
 
-
--- End diff --

Any reason for removing this one? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #254: Add checkstyle to the CI

[mureinik]

GitHub user mureinik opened a pull request:

https://github.com/apache/commons-lang/pull/254

Add checkstyle to the CI

The Apache Commons Lang project uses checktyle to enforce its coding style, 
but this is only done as part of the reporting phase, when the site is 
generated. Thus, using checkstyle becomes somewhat of an opt-in procedure, 
depending on the vigilance of the developers to check the report, instead of 
being an actual enforcement against violating the codestyle, as evident by the 
fact that the current checkstyle report contains several hundred(!) such 
violations.

This PR contains a series of patches to fix the existing checkstyle 
violations and a final patch that adds checkstyle to Travis CI, making it a 
gating check instead of an opt-in practice.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mureinik/commons-lang checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #254


commit 13ebd5a955787ca91990a713c8cdf482aa72ca2a
Author: Allon Mureinik 
Date:   2017-03-05T10:05:23Z

Apply JavaDoc checkstyle only to public methods

The defacto style of the project requires Javadoc for public methods
only, but the checkstyle Javadoc check defaults to requiring them even
for private methods, generating 46 errors.

This patch sets the checkstyle Javadoc check's scope to public to clean
up the checkstyle report so it can be enabled in the CI.

If we wish to reset the check to a laxer scope, the aforementioned
errors should be fixed first.

commit c1c21cd9a7d1888f054813a50ab6c6a3b0517292
Author: Allon Mureinik 
Date:   2017-03-11T07:52:41Z

Remove unused SystemUtils import from ExceptionUtils

commit e14660f1c86acf8c2432593d9ad1a51108c2e83c
Author: Allon Mureinik 
Date:   2017-03-11T07:54:27Z

Replace tabs with spaces in DateUtils

commit a7d7e37d091bf1ba3674c6fc617466b284aaac71
Author: Allon Mureinik 
Date:   2017-03-11T08:13:44Z

Upgrade maven-checkstyle-plugin to 2.17

This patch upgrades maven-checkstyle-plugin to the latest available
version, 2.17.

This is done in order to consume a fix for checkstyle wrongfully
reporting an error if the @return javadoc tag was used in an
annotation type, as it is in Guarded (line 36).

Note that checkstyle has removed the RedundantThrows check (see
discussion at https://github.com/checkstyle/checkstyle/issues/473),
so it was removed from the project's checkstyle.xml configuration.

commit c407e34e7ecfde0e72bbbed1e5e8106792140d64
Author: Allon Mureinik 
Date:   2017-03-11T08:49:22Z

org.apache.commons.lang3.concurrent.annotation package-info

Added package-info.java to the
org.apache.commons.lang3.concurrent.annotation package to solve a
checkstyle violation.

commit 063e538595897a481f93d0a926a09081777eae4a
Author: Allon Mureinik 
Date:   2017-03-11T09:14:16Z

Add checkstyle to Travis CI

Currently, checkstyle is only run as part of the reporting phase, and
it's up to the developer to check the report manually.

This patch adds the checkstyle configuration to the build plugins so
it can be used to check the code (as opposed to just generate a
report of the failures) and adds it to Travis CI's configuration so
every new patch will be automatically checked against it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---