[jira] [Resolved] (VFS-411) [SFTP] Update Jsch to version 0.1.47 from 0.1.46.
[ https://issues.apache.org/jira/browse/VFS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-411. - Resolution: Fixed In SVN. [SFTP] Update Jsch to version 0.1.47 from 0.1.46. - Key: VFS-411 URL: https://issues.apache.org/jira/browse/VFS-411 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.1 [SFTP] Update Jsch to version 0.1.47 from 0.1.46. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-410) [SFTP] SftpFileObject getInputStream(long) reads the whole file into memory
[
https://issues.apache.org/jira/browse/VFS-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-410.
-
Resolution: Fixed
Martin,
Thank you for providing the patch.
It has been applied with only slight changes.
Committed revision 1328346.
Gary
[SFTP] SftpFileObject getInputStream(long) reads the whole file into memory
---
Key: VFS-410
URL: https://issues.apache.org/jira/browse/VFS-410
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Reporter: Martin Stockhammer
Fix For: 2.1
Attachments: SftpFileObject.java.patch
The method {{getInputStream(long filePointer)}} in {{SftpFileObject.java}}
reads the complete file into memory to create the input stream.
Newer versions of JSch provide a method
{{channel.get(file, monitor, filePointer);}}
that is much faster.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-395) [POM] Declare maven-scm-* dependencies as optional.
[ https://issues.apache.org/jira/browse/VFS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-395. - Resolution: Fixed Removed the offeding plugins. Committed revision 1328366. [POM] Declare maven-scm-* dependencies as optional. --- Key: VFS-395 URL: https://issues.apache.org/jira/browse/VFS-395 Project: Commons VFS Issue Type: Bug Affects Versions: 2.0 Reporter: Xavier Dury Fix For: 2.1 VFS2 includes weird dependencies: maven-scm-api, maven-scm-provider-svnexe. See http://commons.apache.org/vfs/commons-vfs2/dependencies.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-104) Add a function for the classical Unix crypt(3) hash
[ https://issues.apache.org/jira/browse/CODEC-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-104. --- Resolution: Duplicate Marking as duplicate of the more complete [CODEC-133] Add a function for the classical Unix crypt(3) hash --- Key: CODEC-104 URL: https://issues.apache.org/jira/browse/CODEC-104 Project: Commons Codec Issue Type: New Feature Reporter: Christian Hammers Fix For: 1.x The Sun Java APIs lack a function for the classical Unix crypt(3) hash that was used in e.g. /etc/passwd or Apache htpasswd and is still widely used dispite the availablitity of better algorithms like MD5 or SHA. Apart from me cursing Sun for producing monster crypto APIs but missing the little things that one really needs, there are already several Apache projects that implemented UnixCrypt for their own: org.apache.directory.studio.ldapbrowser.core.utils.UnixCrypt org.apache.fulcrum.crypto.impl.UnixCrypt and maybe others bye, -christian- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-133) Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants.
[ https://issues.apache.org/jira/browse/CODEC-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-133. --- Resolution: Fixed Fix Version/s: 1.7 In SVN. Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. --- Key: CODEC-133 URL: https://issues.apache.org/jira/browse/CODEC-133 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.6 Reporter: Christian Hammers Labels: MD5, SHA-512, crypt(3), crypto, hash Fix For: 1.7 Attachments: commons-codec-crypt3.diff, crypt3-with-utexas-licence.diff The Linux libc6 crypt(3) function, which is used to generate e.g. the password hashes in /etc/shadow, is available in nearly all other programming languages (Perl, PHP, Python, C, C++, ...) and databases like MySQL and offers MD5/SHA1/SHA-512 based algorithms that were improved by adding a salt and several iterations to make rainbow table attacks harder. Thus they are widely used to store user passwords. Java, though, has due it's platform independence, no direct access to the libc functions and still lacks an proper port of the crypt(3) function. I already filed a wishlist bug (CODEC-104) for the traditional 56-bit DES based crypt(3) method but would also like to see the much stronger algorithms. There are other bug reports like DIRSTUDIO-738 that demand those crypt variants for some specific applications so there it would benefit other Apache projects as well. Java ports of most of the specific crypt variants are already existing, but they would have to be cleaned up, properly tested and license checked: ftp://ftp.arlut.utexas.edu/pub/java_hashes/ I would be willing to help here by cleaning the source code and writing unit tests etc. but I'd like to generally know if you are interested and if there's someone who can do a code review (it's security relevant after all and I'm no crypto guy) bye, -christian- -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-327) Add byteCountToDisplaySize(BigInteger)
[ https://issues.apache.org/jira/browse/IO-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-327. Resolution: Fixed In SVN. Add byteCountToDisplaySize(BigInteger) -- Key: IO-327 URL: https://issues.apache.org/jira/browse/IO-327 Project: Commons IO Issue Type: New Feature Components: Utilities Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.4 Add byteCountToDisplaySize(BigInteger), just like Add byteCountToDisplaySize(long), in fact the long version can call the BI version to avoid duplication. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-324) Add missing Charset sister APIs to method that take a String charset name.
[ https://issues.apache.org/jira/browse/IO-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-324. Resolution: Fixed In SVN. Add missing Charset sister APIs to method that take a String charset name. -- Key: IO-324 URL: https://issues.apache.org/jira/browse/IO-324 Project: Commons IO Issue Type: New Feature Components: Utilities Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.4 Add Charset sister APIs to method that take a String charset name. This is like [IO-318] for 2.3. At least one API was missed: - org.apache.commons.io.FileUtils.writeStringToFile(File, String, Charset) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-325) Add IOUtils.toByteArray methods to work with URL and URI
[ https://issues.apache.org/jira/browse/IO-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-325. Resolution: Fixed In SVN. Add IOUtils.toByteArray methods to work with URL and URI Key: IO-325 URL: https://issues.apache.org/jira/browse/IO-325 Project: Commons IO Issue Type: New Feature Components: Utilities Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.4 Add IOUtils.toByteArray methods to work with URL and URI: - IOUtils.toByteArray(URI) - IOUtils.toByteArray(URL) - IOUtils.toByteArray(URLConnection) - IOUtils.close(URLConnection) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-409) Update Apache Commons Compress to 1.4 from 1.3
[ https://issues.apache.org/jira/browse/VFS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-409. - Resolution: Fixed SendingC:/svn/org/apache/commons/trunks-proper/vfs/pom.xml Sending C:/svn/org/apache/commons/trunks-proper/vfs/src/changes/changes.xml Transmitting file data ... Committed revision 1324814. Update Apache Commons Compress to 1.4 from 1.3 -- Key: VFS-409 URL: https://issues.apache.org/jira/browse/VFS-409 Project: Commons VFS Issue Type: Task Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.1 Update Apache Commons Compress to 1.4 from 1.3 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-322) Add and use class Charsets
[ https://issues.apache.org/jira/browse/IO-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-322. Resolution: Fixed In SVN. Add and use class Charsets -- Key: IO-322 URL: https://issues.apache.org/jira/browse/IO-322 Project: Commons IO Issue Type: New Feature Components: Utilities Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.3 Add and use class Charsets, a class that defines constants the required JRE Charsets. Also includes a few util methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-321) ByteOrderMark UTF_32LE is incorrect
[
https://issues.apache.org/jira/browse/IO-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-321.
Resolution: Fixed
In SVN.
ByteOrderMark UTF_32LE is incorrect
---
Key: IO-321
URL: https://issues.apache.org/jira/browse/IO-321
Project: Commons IO
Issue Type: Bug
Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: 1.6.0_31, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_31\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
C:\svn\org\apache\commons\trunks-proper\lang\test\io-320.diff
Reporter: Gary D. Gregory
Fix For: 2.3
ByteOrderMark UTF_32LE is incorrect.
Is should be {{FF FE 00 00}} not {{FE FF 00 00}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (LANG-798) Use generics in SerializationUtils
[
https://issues.apache.org/jira/browse/LANG-798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-798.
--
Resolution: Fixed
In SVN.
Use generics in SerializationUtils
--
Key: LANG-798
URL: https://issues.apache.org/jira/browse/LANG-798
Project: Commons Lang
Issue Type: Improvement
Components: lang.*
Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500)
Maven home: C:\Java\apache-maven-3.0.4\bin\..
Java version: 1.6.0_31, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_31\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Fix For: 3.2
Use generics in SerializationUtils:
I'd like to propose the change below. This lets you get rid of type casts in
call sites. You'll still get a ClassCastException if you code it wrong of
course.
Old: {{public static Object deserialize(InputStream inputStream)}}
New: {{public static T T deserialize(InputStream inputStream)}}
Old: {{public static Object deserialize(byte[] objectData)}}
New: {{public static T T deserialize(byte[] objectData)}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-96) Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder
[
https://issues.apache.org/jira/browse/CODEC-96?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-96.
--
Resolution: Fixed
Assignee: (was: Julius Davies)
In SVN
Base64 encode() method is no longer thread-safe, breaking clients using it as
a shared BinaryEncoder
Key: CODEC-96
URL: https://issues.apache.org/jira/browse/CODEC-96
Project: Commons Codec
Issue Type: Bug
Affects Versions: 1.4
Reporter: Matt Ryall
Fix For: 1.x
Attachments: CODEC-96.patch, CODEX-96-2.patch,
codec-96-3rd-attempt.patch
Streaming support was added to Base64 in commons-codec 1.4 with CODEC-69.
This introduced instance variables to Base64 which means the class can no
longer be used as a shared BinaryEncoder instance.
For example, BinaryEncoder has an interface which could be (and was) used
like this with Base64:
{code:java}
class Example {
private BinaryEncoder encoder = new Base64();
byte[] someMethod(byte[] data) {
try {
return encoder.encode(data);
}
catch (EncoderException e) {
throw new RuntimeException(e);
}
}
}
{code}
Base64 is no longer thread-safe in commons-codec 1.4, so code like the above
which is accessed by multiple threads can throw NullPointerException:
{noformat}
java.lang.NullPointerException
at org.apache.commons.codec.binary.Base64.encode(Base64.java:469)
at org.apache.commons.codec.binary.Base64.encode(Base64.java:937)
at ... (application code)
{noformat}
Looking at the implementation of Base64, I think making it thread-safe for
this kind of usage would be quite tricky. I haven't attempted to prepare a
patch.
I would be happy if it was indicated in the Javadoc that Base64 is not
thread-safe and should not be shared. However, some other users of
commons-codec might be more worried about this regression.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-318) Add Charset sister APIs to method that take a String charset name.
[ https://issues.apache.org/jira/browse/IO-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-318. Resolution: Fixed In SVN. Add Charset sister APIs to method that take a String charset name. -- Key: IO-318 URL: https://issues.apache.org/jira/browse/IO-318 Project: Commons IO Issue Type: New Feature Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.7.0_03, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.7.0_03\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: 2.3 Add Charset sister APIs to method that take a String charset name (aka encoding). For example: foo(..., String charsetName) - foo(..., Charset charset). Refactor such that we do not have code duplication of the algorithms. Known issue: Source compatibility. Now there are APIs that change only with the last type, String vs. Charset, you will get a compile error if you pass null to the old String API because the target method will be ambiguous: do you want to call the String or Charset version? You must type-cast to one type or the other. Known issue: checked java.io.UnsupportedEncodingException vs. unchecked java.nio.charset.UnsupportedCharsetException The JRE API Charset.forName throws the unchecked UnsupportedCharsetException. The Commons IO 2.2 String APIs throw the checked UnsupportedEncodingException, a subclass of IOException, when an charset is not available. The refactored String APIs throw UnsupportedCharsetException from Charset.forName, an unchecked IllegalArgumentException. The String APIs throw IOException, so there is no source compatibility issue. If you somehow relied on catching the checked UnsupportedEncodingException instead of IOException, its superclass, you should catch the unchecked java.nio.charset.UnsupportedCharsetException to act on the fact that the charset is not available. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-136) Use Charset objects when possible, create Charsets class for required character encodings
[ https://issues.apache.org/jira/browse/CODEC-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-136. --- Resolution: Fixed In svn. Use Charset objects when possible, create Charsets class for required character encodings - Key: CODEC-136 URL: https://issues.apache.org/jira/browse/CODEC-136 Project: Commons Codec Issue Type: New Feature Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_31, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_31\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: 1.7 Use Charset objects when possible, create Charsets for required character encodings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-407) [RAM] Reading a RAM FileSystem file fails because it never returns EOF -1.
[
https://issues.apache.org/jira/browse/VFS-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-407.
-
Resolution: Fixed
Patch applied, in SVN, thank you!
[RAM] Reading a RAM FileSystem file fails because it never returns EOF -1.
--
Key: VFS-407
URL: https://issues.apache.org/jira/browse/VFS-407
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Reporter: Miroslav Pokorny
Fix For: 2.1
Attachments: CustomRamProviderTest.java,
EmptyRamProviderFileBugTests-from-miroslav.pokorny-20120322.patch
Original Estimate: 5m
Remaining Estimate: 5m
RamFileRandomAccessContent
ORIGINAL
@Override
public int read(byte[] b, int off, int len) throws IOException
{
int retLen = Math.min(len, getLeftBytes());
RamFileRandomAccessContent.this.readFully(b, off, retLen);
return retLen;
}
// getLeftBytes() returns 0 when empty. retLen is 0 when empty and never -1.
FIXED
// HACK Patched to return -1 when empty previously it returned 0
@Override
public int read(final byte[] b, final int off, final int len)
throws IOException {
int retLen = InputStreams.END;
final int left =
RamFileRandomAccessContent.this.getLeftBytes();
if (left 0) {
retLen = Math.min(len, left);
RamFileRandomAccessContent.this.readFully(b, off, retLen);
}
return retLen;
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-313) Add IOUTils.toBufferedReader(Reader)
[ https://issues.apache.org/jira/browse/IO-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-313. Resolution: Fixed Assignee: Gary D. Gregory In SVN. Add IOUTils.toBufferedReader(Reader) Key: IO-313 URL: https://issues.apache.org/jira/browse/IO-313 Project: Commons IO Issue Type: New Feature Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: 2.2 Add IOUTils.toBufferedReader(Reader) to return a new BufferedReader unless the given Reader is already a BufferedReader. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-130) Base64InputStream.skip skips underlying stream, not output
[
https://issues.apache.org/jira/browse/CODEC-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved CODEC-130.
---
Resolution: Fixed
In SVN.
Base64InputStream.skip skips underlying stream, not output
--
Key: CODEC-130
URL: https://issues.apache.org/jira/browse/CODEC-130
Project: Commons Codec
Issue Type: Bug
Affects Versions: 1.5
Reporter: James Pickering
Priority: Minor
Fix For: 1.7
Attachments: base64snippet.java
Base64InputStream.skip() skips within underlying stream, leading to
unexpected behaviour.
The following code will reproduce the issue:
@Test
public void testSkip() throws Throwable {
InputStream ins =
new
ByteArrayInputStream(.getBytes(ISO-8859-1));//should decode to
{0, 0, 0, 255, 255, 255}
Base64InputStream instance = new Base64InputStream(ins);
assertEquals(3L, instance.skip(3L)); //should skip 3 decoded characters,
or 4 encoded characters
assertEquals(255, instance.read()); //Currently returns 3, as it is
decoding A/, not //
}
The following code, if added to Base64InputStream, or (BaseNCodecInputStream
in the dev build) would resolve the issue:
@Override
public long skip(long n) throws IOException {
//delegate to read()
long bytesRead = 0;
while ((bytesRead n) (read() != -1)) {
bytesRead++;
}
return bytesRead;
}
More efficient code may be possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-63) Implement NYSIIS
[ https://issues.apache.org/jira/browse/CODEC-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-63. -- Resolution: Fixed Implement NYSIIS Key: CODEC-63 URL: https://issues.apache.org/jira/browse/CODEC-63 Project: Commons Codec Issue Type: New Feature Affects Versions: 1.x Reporter: Henri Yandell Fix For: 1.7 Attachments: CODEC-63-reworked.tar, Nysiis.patch, codec-63-nysiis-ggregory.diff http://en.wikipedia.org/wiki/NYSIIS -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-121) QuotedPrintableCodec does not support soft line break per the 'quoted-printable' example on Wikipedia
[ https://issues.apache.org/jira/browse/CODEC-121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-121. --- Resolution: Fixed Patch applied with slight modifications. Thank you! QuotedPrintableCodec does not support soft line break per the 'quoted-printable' example on Wikipedia - Key: CODEC-121 URL: https://issues.apache.org/jira/browse/CODEC-121 Project: Commons Codec Issue Type: Bug Affects Versions: 1.5 Environment: I tested on Windows 7. Reporter: Java John Labels: codec, decode, quoted-printable Fix For: 1.x Attachments: CODEC-121.patch, CODEC-121_v2.patch Writing a unit test I discovered that the example Wikipedia uses for quoted-printable data does not decode but instead throws an exception. Their example is here: http://en.wikipedia.org/wiki/Quoted-printable#Example test: String qpdata = If you believe that truth=3Dbeauty, then surely=20=\r\n + mathematics is the most beautiful branch of philosophy.; String expected = If you believe that truth=beauty, then surely + mathematics is the most beautiful branch of philosophy.; assertEquals( expected, new QuotedPrintableCodec().decode(qpdata) ); I suppose I could fix if you like but currently I'm not a registered developer. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-132) BeiderMorseEncoder OOM issues
[ https://issues.apache.org/jira/browse/CODEC-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved CODEC-132. --- Resolution: Fixed Fix Version/s: 1.6.1 Patch applied in SVN, plus some other minor test improvements. BeiderMorseEncoder OOM issues - Key: CODEC-132 URL: https://issues.apache.org/jira/browse/CODEC-132 Project: Commons Codec Issue Type: Bug Affects Versions: 1.6 Reporter: Robert Muir Fix For: 1.6.1 Attachments: CODEC-132.patch, CODEC-132_test.patch In Lucene/Solr, we integrated this encoder into the latest release. Our tests use a variety of random strings, and we have recent jenkins failures from some input streams (of length = 10), using huge amounts of memory (e.g. 64MB), resulting in OOM. I've created a test case (length is 30 here) that will OOM with -Xmx256M. I haven't dug into this much as to what's causing it, but I suspect there might be a bug revolving around certain punctuation characters: we didn't see this happening until we beefed up our random string generation to start producing html-like strings. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-304) The second constructor of Tailer class does not pass 'delay' to the third one
[
https://issues.apache.org/jira/browse/IO-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-304.
Resolution: Fixed
Fix Version/s: 2.2
Assignee: Gary D. Gregory
Committed revision 1295587.
The second constructor of Tailer class does not pass 'delay' to the third one
--
Key: IO-304
URL: https://issues.apache.org/jira/browse/IO-304
Project: Commons IO
Issue Type: Bug
Affects Versions: 2.1
Reporter: Liyin Liang
Assignee: Gary D. Gregory
Fix For: 2.2
Attachments: tailer.diff
Here is the second contructor of Tailer class:
{code:}
public Tailer(File file, TailerListener listener, long delay) {
this(file, listener, 1000, false);
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (LANG-788) SerializationUtils throws ClassNotFoundException when cloning primitive classes
[
https://issues.apache.org/jira/browse/LANG-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved LANG-788.
--
Resolution: Fixed
Fix Version/s: 3.2
Assignee: Gary D. Gregory
In SVN.
SerializationUtils throws ClassNotFoundException when cloning primitive
classes
---
Key: LANG-788
URL: https://issues.apache.org/jira/browse/LANG-788
Project: Commons Lang
Issue Type: Bug
Affects Versions: 3.1
Reporter: René Link
Assignee: Gary D. Gregory
Fix For: 3.2
Attachments: LANG-788
If a serializable object contains a reference to a primitive class, e.g.
int.class or int[].class, the SerializationUtils throw a
ClassNotFoundException when trying to clone that object.
{noformat}
import org.apache.commons.lang3.SerializationUtils;
import org.junit.Test;
public class SerializationUtilsTest {
@Test
public void primitiveTypeClassSerialization(){
Class? primitiveType = int.class;
Class? clone = SerializationUtils.clone(primitiveType);
assertEquals(primitiveType, clone);
}
}
{noformat}
The problem was already reported as a java bug
http://bugs.sun.com/view_bug.do?bug_id=4171142 and ObjectInputStream is fixed
since java version 1.4.
The SerializationUtils problem arises because the SerializationUtils
internally use the ClassLoaderAwareObjectInputStream that overrides the
ObjectInputStream's
resoleClass method without delegating to the super method in case of a
ClassNotFoundException.
I understand the intention of the ClassLoaderAwareObjectInputStream, but this
implementation should also implement a fallback to the original
implementation.
For example:
{noformat}
protected Class? resolveClass(ObjectStreamClass desc) throws
IOException, ClassNotFoundException {
String name = desc.getName();
try {
return Class.forName(name, false, classLoader);
} catch (ClassNotFoundException ex) {
try {
return Class.forName(name, false,
Thread.currentThread().getContextClassLoader());
} catch (Exception e) {
return super.resolveClass(desc);
}
}
}
{noformat}
Here is the code in ObjectInputStream that fixed the java bug.
{noformat}
protected Class? resolveClass(ObjectStreamClass desc)
throws IOException, ClassNotFoundException
{
String name = desc.getName();
try {
return Class.forName(name, false, latestUserDefinedLoader());
} catch (ClassNotFoundException ex) {
Class cl = (Class) primClasses.get(name);
if (cl != null) {
return cl;
} else {
throw ex;
}
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-302) ArrayIndexOutOfBoundsException in BOMInputStream when reading a file without BOM multiple times
[ https://issues.apache.org/jira/browse/IO-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-302. Resolution: Fixed Fix Version/s: 2.2 Assignee: Gary D. Gregory In SVN. ArrayIndexOutOfBoundsException in BOMInputStream when reading a file without BOM multiple times --- Key: IO-302 URL: https://issues.apache.org/jira/browse/IO-302 Project: Commons IO Issue Type: Bug Components: Streams/Writers Affects Versions: 2.1 Environment: Win7 64bit, Java 6 32bit Reporter: Jan Steuerwald Assignee: Gary D. Gregory Fix For: 2.2 Attachments: IO-302.patch, Test.java, testfileBOM.xml, testfileNoBOM.xml Resetting the BOMInputStream doesn't reset the _fbLength_ member variable. This causes _fbLength_ to grow bigger than the _firstBytes_ array (when the file doesn't contain a BOM), which leads to an ArrayIndexOutOfBoundsException in the _readFirstBytes_ method. The attached test case reveals the problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-303) TeeOutputStream does not call branch.close() when main.close() throws an exception
[
https://issues.apache.org/jira/browse/IO-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved IO-303.
Resolution: Fixed
This is the solution I implemented. For simplicity's sake, note that the
exception thrown is the last exception encountered.
{code:java}
/**
* Closes both output streams.
*
* If closing the main output stream throws an exception, attempt to close
the branch output stream.
*
* If closing the main and branch output streams both throw exceptions,
which exceptions is thrown by this method is
* currently unspecified and subject to change.
*
* @throws IOException
* if an I/O error occurs
*/
@Override
public void close() throws IOException {
try {
super.close();
} catch (IOException e) {
this.branch.close();
throw e;
}
this.branch.close();
}
{code}
TeeOutputStream does not call branch.close() when main.close() throws an
exception
--
Key: IO-303
URL: https://issues.apache.org/jira/browse/IO-303
Project: Commons IO
Issue Type: Bug
Components: Streams/Writers
Affects Versions: 2.1
Reporter: Fabian Barney
Assignee: Gary D. Gregory
Labels: close, stream
Fix For: 2.2
TeeOutputStream.close() looks like this:
{code:title=TeeOutputStream.java|borderStyle=solid}
/**
* Closes both streams.
* @throws IOException if an I/O error occurs
*/
@Override
public void close() throws IOException {
super.close();
this.branch.close();
}
{code}
It is obvious that {{this.branch.close()}} is not executed when
{{super.close()}} raises an exception. {{super.close()}} may in fact raise an
IOException since {{ProxyOutputStream.handleIOException(IOException)}} is not
overridden.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-392) Build tests WebDAV file system with an embedded WebDAV server (Apache Jackrabbit).
[ https://issues.apache.org/jira/browse/VFS-392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-392. - Resolution: Fixed In SVN. Build tests WebDAV file system with an embedded WebDAV server (Apache Jackrabbit). -- Key: VFS-392 URL: https://issues.apache.org/jira/browse/VFS-392 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: 2.1 The build should test the WebDAV file system with an embedded HTTP server like Apache Jackrabbit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-402) [WebDAV] Update Apache Jackrabbit 1.5.2 to 1.6.5.
[ https://issues.apache.org/jira/browse/VFS-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-402. - Resolution: Fixed In SVN. [WebDAV] Update Apache Jackrabbit 1.5.2 to 1.6.5. - Key: VFS-402 URL: https://issues.apache.org/jira/browse/VFS-402 Project: Commons VFS Issue Type: Task Affects Versions: 2.0 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: 2.1 [WebDAV] Update Apache Jackrabbit 1.5.2 to 1.6.5. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-401) Update JSch to 0.1.46 from 0.1.45 for the SFTP provider.
[ https://issues.apache.org/jira/browse/VFS-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-401. - Resolution: Fixed In SVN. Update JSch to 0.1.46 from 0.1.45 for the SFTP provider. Key: VFS-401 URL: https://issues.apache.org/jira/browse/VFS-401 Project: Commons VFS Issue Type: Task Affects Versions: 2.0 Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds Update JSch to 0.1.46 from 0.1.45 for the SFTP provider. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (IO-301) Add IOUtils.closeQuietly(Selector)
[ https://issues.apache.org/jira/browse/IO-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved IO-301. Resolution: Fixed Patch applied, thank you. Also added a test to get test code coverage to 100% for the new method. Add IOUtils.closeQuietly(Selector) -- Key: IO-301 URL: https://issues.apache.org/jira/browse/IO-301 Project: Commons IO Issue Type: Improvement Components: Utilities Affects Versions: 2.1 Reporter: Karthik K Fix For: 2.2 Attachments: IO-301.patch IOUtils.closeQuietly(Selector) would be useful to fix yet another resource leakage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (POOL-210) Jar manifest.mf does not contain SVN information for Implementation-Build
[
https://issues.apache.org/jira/browse/POOL-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved POOL-210.
--
Resolution: Fixed
In SVN.
Jar manifest.mf does not contain SVN information for Implementation-Build
-
Key: POOL-210
URL: https://issues.apache.org/jira/browse/POOL-210
Project: Commons Pool
Issue Type: Bug
Affects Versions: 1.6
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
svn, version 1.7.2-SlikSvn-1.7.2-X64 (SlikSvn/1.7.2) X64
compiled Dec 6 2011, 13:13:15
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: 1.6.1
The value found in the manfest is:
{quote}
Implementation-Build: UNKNOWN_BRANCH@r??; 2012-01-04 10:31:47-0500
{quote}
This is fixed by upgrading to commons-parent 23 from 22.
The value should look like this:
{quote}
Implementation-Build: branches/POOL_1_X@r1229459; 2012-01-11 16:38:38-
0500
{quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (POOL-208) Support Java 1.5 Generics in version 1.x.
[ https://issues.apache.org/jira/browse/POOL-208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved POOL-208. -- Resolution: Fixed Assignee: Gary D. Gregory In SVN. Support Java 1.5 Generics in version 1.x. - Key: POOL-208 URL: https://issues.apache.org/jira/browse/POOL-208 Project: Commons Pool Issue Type: Improvement Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: 1.6 Support Java 1.5 Generics in version 1.x. Create a 1.x release with generics. Right now, that would be 1.6. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-391) Build tests URL HTTP file system with an embedded HTTP server (Apache HttpComponent Core).
[ https://issues.apache.org/jira/browse/VFS-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-391. - Resolution: Fixed In SVN. Build tests URL HTTP file system with an embedded HTTP server (Apache HttpComponent Core). -- Key: VFS-391 URL: https://issues.apache.org/jira/browse/VFS-391 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds The build should test the URL HTTP file system with an embedded HTTP server like Apache HttpComponent Core. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-386) Build tests HTTP file system with an embedded HTTP server (Apache HttpComponent Core)
[ https://issues.apache.org/jira/browse/VFS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-386. - Resolution: Fixed Committed revision 1203669. Build tests HTTP file system with an embedded HTTP server (Apache HttpComponent Core) - Key: VFS-386 URL: https://issues.apache.org/jira/browse/VFS-386 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds The build should test the HTTP file system with an embedded HTTP server like Apache HttpComponent Core. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-387) Build tests FTP file system with an embedded FTP server (Apache MINA)
[ https://issues.apache.org/jira/browse/VFS-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-387. - Resolution: Fixed Already in SVN. Build tests FTP file system with an embedded FTP server (Apache MINA) - Key: VFS-387 URL: https://issues.apache.org/jira/browse/VFS-387 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds The build should test the FTP file system with an embedded FTP server like Apache MINA. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-388) Build tests SFTP file system with an embedded SFTP server (Apache MINA)
[ https://issues.apache.org/jira/browse/VFS-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-388. - Resolution: Fixed Already in SVN. Build tests SFTP file system with an embedded SFTP server (Apache MINA) --- Key: VFS-388 URL: https://issues.apache.org/jira/browse/VFS-388 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds The build should test the SFTP file system with an embedded SFTP server like Apache MINA. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-389) Use variable argument lists in FileSystemException instead of Object[]s
[
https://issues.apache.org/jira/browse/VFS-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-389.
-
Resolution: Fixed
Assignee: Gary D. Gregory
Committed revision 1203691.
Use variable argument lists in FileSystemException instead of Object[]s
---
Key: VFS-389
URL: https://issues.apache.org/jira/browse/VFS-389
Project: Commons VFS
Issue Type: New Feature
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
h3. Replace
{code:java}
org.apache.commons.vfs2.FileSystemException.FileSystemException(String,
Object[])
{code}
with:
{code:java}
org.apache.commons.vfs2.FileSystemException.FileSystemException(String,
Object...)
{code}
This is a binary compatible change.
h3. Add
{code:java}
org.apache.commons.vfs2.FileSystemException.FileSystemException(String,
Throwable, Object...)
{code}
and deprecate:
{code:java}
org.apache.commons.vfs2.FileSystemException.FileSystemException(String,
Object[], Throwable)
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-390) Use variable argument list in org.apache.commons.vfs2.util.Messages instead of Object[]
[ https://issues.apache.org/jira/browse/VFS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-390. - Resolution: Fixed Committed revision 1203796. Use variable argument list in org.apache.commons.vfs2.util.Messages instead of Object[] --- Key: VFS-390 URL: https://issues.apache.org/jira/browse/VFS-390 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds This issue is for file system implementers and likely of very little impact. I am recording it for completeness because this is a kind of API change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-385) Add HTTP status code to HTTP file provider exception messages when available.
[
https://issues.apache.org/jira/browse/VFS-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-385.
-
Resolution: Fixed
Committed revision 1203475.
Add HTTP status code to HTTP file provider exception messages when available.
-
Key: VFS-385
URL: https://issues.apache.org/jira/browse/VFS-385
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
Enhance the following message patterns with the HTTP status code:
{noformat}
vfs.provider.http/get.error=GET method failed for {0} with HTTP status {1}.
vfs.provider.http/head.error=HEAD method failed for {0} with HTTP status
{1}.
vfs.provider.http/get-range.error=GET method failed for {0} range {1}
with HTTP status {2}.
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-382) SFTP getChildren() does not fail when called on a file
[
https://issues.apache.org/jira/browse/VFS-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-382.
-
Resolution: Fixed
Fix Version/s: Nightly Builds
Assignee: Gary D. Gregory
Committed revision 1200015.
SFTP getChildren() does not fail when called on a file
--
Key: VFS-382
URL: https://issues.apache.org/jira/browse/VFS-382
Project: Commons VFS
Issue Type: Bug
Affects Versions: Nightly Builds
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
Attachments: vfs-382.diff
SFTP test testChildren(org.apache.commons.vfs2.test.ContentTests) fails
I've tried this with *Apache SSHd* and *Bitvise WinSSHD* and I get the same
failure.
The test {{org.apache.commons.vfs2.test.ContentTests}} asks for the children
({{getChildren()}}) of a {{file1.txt}} file (not a folder) and does not fail.
The test expects the {{getChildren()}} method to throw an exception.
Instead, it returns one file, file1.txt itself.
Under the covers, we do a ls file1.txt, which returns file1.txt.
It looks like [VFS-210] was an effort to optimize and reduce roundtrips but
it may have broken this code.
Thoughts on fixing this?
In
{{org.apache.commons.vfs2.provider.sftp.SftpFileObject.doListChildrenResolved()}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-383) Update JSch to 0.1.45 from 0.1.42 for the SFTP provider.
[ https://issues.apache.org/jira/browse/VFS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-383. - Resolution: Fixed Committed revision 1200097. Update JSch to 0.1.45 from 0.1.42 for the SFTP provider. Key: VFS-383 URL: https://issues.apache.org/jira/browse/VFS-383 Project: Commons VFS Issue Type: Task Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds Update jsch to 0.1.45 from 0.1.42. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-384) Update Apache Commons Net to 3.0.1 from 2.2 for FTP and SFTP providers.
[ https://issues.apache.org/jira/browse/VFS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-384. - Resolution: Fixed Committed revision 1200099. Update Apache Commons Net to 3.0.1 from 2.2 for FTP and SFTP providers. --- Key: VFS-384 URL: https://issues.apache.org/jira/browse/VFS-384 Project: Commons VFS Issue Type: Task Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds Update Apache Commons Net to 3.0.1 from 2.2 for FTP and SFTP providers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-381) Iterate over a FileObject using the Java foreach statement, to provide all descendents of a FileObject.
[ https://issues.apache.org/jira/browse/VFS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-381. - Resolution: Fixed Committed revision 1198524. Iterate over a FileObject using the Java foreach statement, to provide all descendents of a FileObject. - Key: VFS-381 URL: https://issues.apache.org/jira/browse/VFS-381 Project: Commons VFS Issue Type: New Feature Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds Iterate over a FileObject using the Java foreach statement, to provide all descendents of a FileObject. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-371) Add FileObject API deleteAll()
[
https://issues.apache.org/jira/browse/VFS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-371.
-
Resolution: Fixed
Fix Version/s: Nightly Builds
Assignee: Gary D. Gregory
Committed revision 1198532.
Add FileObject API deleteAll()
--
Key: VFS-371
URL: https://issues.apache.org/jira/browse/VFS-371
Project: Commons VFS
Issue Type: New Feature
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds, 2.1
Attachments: FileObject-deleteAllDescendents.diff
I see a lot of call sites within VFS 2 and some in my work server that do:
{code:java}
fileObject.delete(Selectors.SELECT_ALL);
{code}
It therefore seems like a sensible refactoring.
Add to {{FileObject}}:
{code:java}
/**
* Deletes all descendents of this file.
* Does nothing if this file does not exist.
* Shorthand for {@code delete(Selectors.Selectors.SELECT_ALL)}
* p/
* pThis method is not transactional. If it fails and throws an
* exception, this file will potentially only be partially deleted.
*
* @return the number of deleted objects
* @throws FileSystemException If this file or one of its descendents is
read-only, or on error
* deleting this file or one of its
descendents.
*/
int deleteAll() throws FileSystemException;
{code}
And to {{AbstractFileObject}}:
{code:java}
/**
* Deletes this file, and all children.
*
* @return the number of deleted files.
* @throws FileSystemException if an error occurs.
*/
public int deleteAllDescendents() throws FileSystemException
{
return this.delete(Selectors.SELECT_ALL);
}
{code}
Thoughts?
Attaching patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-380) FTP connect.error message used instead of SFTP connect.error message
[
https://issues.apache.org/jira/browse/VFS-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-380.
-
Resolution: Fixed
Committed revision 1197120.
FTP connect.error message used instead of SFTP connect.error message
Key: VFS-380
URL: https://issues.apache.org/jira/browse/VFS-380
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
If connecting to SFTP fails, the code uses the message key
{{vfs.provider.ftp/connect.error}} but the resource file defines the SFTP
specific message {{vfs.provider.sftp/connect.error}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-375) Upgrade to Apache Commons Compress 1.3 from 1.2.
[ https://issues.apache.org/jira/browse/VFS-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-375. - Resolution: Fixed Committed revision 1196555. Upgrade to Apache Commons Compress 1.3 from 1.2. Key: VFS-375 URL: https://issues.apache.org/jira/browse/VFS-375 Project: Commons VFS Issue Type: Task Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Fix For: Nightly Builds Upgrade to Apache Commons Compress 1.3 from 1.2. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-377) Replace custom TAR code with Apache Commons Compress 1.3
[
https://issues.apache.org/jira/browse/VFS-377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-377.
-
Resolution: Fixed
Committed revision 1196613.
Replace custom TAR code with Apache Commons Compress 1.3
Key: VFS-377
URL: https://issues.apache.org/jira/browse/VFS-377
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
Replace custom TAR code with Apache Commons Compress 1.3 in
{{org.apache.commons.vfs2.provider.tar}} with
{{org.apache.commons.compress.archivers.tar}}
Remove the package private code in {{org.apache.commons.vfs2.provider.tar}},
it is now public in Commons Compress 1.3
{{org.apache.commons.compress.archivers.tar}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-378) Tar error message are missing from resource file
[
https://issues.apache.org/jira/browse/VFS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-378.
-
Resolution: Fixed
Committed revision 1196638.
Tar error message are missing from resource file
Key: VFS-378
URL: https://issues.apache.org/jira/browse/VFS-378
Project: Commons VFS
Issue Type: Bug
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
Right you get:
{noformat}
Unknown message with code vfs.provider.tar/open-tar-file.error.
{noformat}
Instead of:
{noformat}
Could not open Tar file C:\some\path\to\a\file..
{noformat}
The following are missing from
{{core/bin/org/apache/commons/vfs2/Resources.properties}}:
{noformat}
vfs.provider.tar/open-tar-file.error=Could not open Tar file {0}.
vfs.provider.tar/close-tar-file.error=Could not close Tar file {0}.
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-379) Replace custom BZIP2 code with Apache Commons Compress 1.3.
[ https://issues.apache.org/jira/browse/VFS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-379. - Resolution: Fixed commit -m [VFS-379] Replace custom BZIP2 code with Apache Commons Compress 1.3. (7 paths specified) Sending C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/impl/providers.xml Deleting C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/BZip2Constants.java Sending C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/Bzip2FileObject.java Deleting C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/CBZip2InputStream.java Deleting C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/CBZip2OutputStream.java Deleting C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/provider/bzip2/CRC.java Sending C:/svn/org/apache/commons/trunks-proper/vfs/src/changes/changes.xml Transmitting file data ... Committed revision 1196670. Replace custom BZIP2 code with Apache Commons Compress 1.3. --- Key: VFS-379 URL: https://issues.apache.org/jira/browse/VFS-379 Project: Commons VFS Issue Type: Improvement Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: Nightly Builds Replace custom TAR code with Apache Commons Compress 1.3 in org.apache.commons.vfs2.provider.bzip2 with org.apache.commons.compress.compressors.bzip2 Remove the package private code in org.apache.commons.vfs2.provider.bzip2 , similar versions are public in Commons Compress 1.3 org.apache.commons.compress.compressors.bzip2 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-372) Add constructors FileDepthSelector() and FileDepthSelector(int)
[
https://issues.apache.org/jira/browse/VFS-372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-372.
-
Resolution: Fixed
Fix Version/s: Nightly Builds
Committed revision 1195438.
Add constructors FileDepthSelector() and FileDepthSelector(int)
---
Key: VFS-372
URL: https://issues.apache.org/jira/browse/VFS-372
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 1.0, 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.7.0_01, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_01\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: Nightly Builds
Original Estimate: 0h
Remaining Estimate: 0h
Add constructors:
{code:java}
/**
* Creates a selector with the same minimum and maximum depths of 0.
*/
public FileDepthSelector()
{
this(0, 0);
}
/**
* Creates a selector with the same minimum and maximum depths.
*
* @param minMaxDepth
*minimum and maximum depth
*/
public FileDepthSelector(int minMaxDepth)
{
this(minMaxDepth, minMaxDepth);
}
{code}
Refactor Selectors to match.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-374) Incorrect lazy initialization of static field org.apache.commons.vfs2.util.Messages.resources in org.apache.commons.vfs2.util.Messages.findMessage(String)
[ https://issues.apache.org/jira/browse/VFS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-374. - Resolution: Fixed Committed revision 1195775. Incorrect lazy initialization of static field org.apache.commons.vfs2.util.Messages.resources in org.apache.commons.vfs2.util.Messages.findMessage(String) -- Key: VFS-374 URL: https://issues.apache.org/jira/browse/VFS-374 Project: Commons VFS Issue Type: Bug Affects Versions: 2.0 Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Fix For: Nightly Builds FindBugs Eclipse plugin reports: Bug: Incorrect lazy initialization of static field org.apache.commons.vfs2.util.Messages.resources in org.apache.commons.vfs2.util.Messages.findMessage(String) This method contains an unsynchronized lazy initialization of a non-volatile static field. Because the compiler or processor may reorder instructions, threads are not guaranteed to see a completely initialized object, if the method can be called by multiple threads. You can make the field volatile to correct the problem. For more information, see the Java Memory Model web site. Confidence: Normal, Rank: Troubling (14) Pattern: LI_LAZY_INIT_STATIC Type: LI, Category: MT_CORRECTNESS (Multithreaded correctness) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (COLLECTIONS-384) Inconsistent Javadoc comment and code for synchronizedMap(Map) in org.apache.commons.collections.MapUtils
[
https://issues.apache.org/jira/browse/COLLECTIONS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved COLLECTIONS-384.
-
Resolution: Fixed
Committed revision 1195031.
Inconsistent Javadoc comment and code for synchronizedMap(Map) in
org.apache.commons.collections.MapUtils
-
Key: COLLECTIONS-384
URL: https://issues.apache.org/jira/browse/COLLECTIONS-384
Project: Commons Collections
Issue Type: Bug
Components: Collection
Affects Versions: 3.0, 3.1, 3.2
Environment: Platform independent
Reporter: SHIN HWEI TAN
Labels: code, javadoc, synchronizedMap
Original Estimate: 5m
Remaining Estimate: 5m
The Javadoc comment below states that the method throws
IllegalArgumentException if the map is null:
/**
...
* @param map the map to synchronize, must not be null
* @return a synchronized map backed by the given map
* @throws IllegalArgumentException if the map is null
*/
public static Map synchronizedMap(Map map) {
return Collections.synchronizedMap(map);
}
However, the method throws NullPointerException instead of
IllegalArgumentException when called with null.
Suggested Fixes:
1. Add code if (map == null) throw IllegalArgumentException(); at the
beginning of the method body.
or
2. Change @throws IllegalArgumentException if the map is null to @throws
NullPointerException if the map is null.
or
3. Remove the entire @throws IllegalArgumentException if the map is null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-370) Add a FileExtensionSelector class
[
https://issues.apache.org/jira/browse/VFS-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-370.
-
Resolution: Fixed
In SVN.
Add a FileExtensionSelector class
-
Key: VFS-370
URL: https://issues.apache.org/jira/browse/VFS-370
Project: Commons VFS
Issue Type: New Feature
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_29, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_29\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: 2.1
Add a {{FileExtensionSelector}} class, a {{FileSelector}} that selects based
on file extensions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (LANG-760) Add API StringUtils.toString(byte[] intput, String charsetName)
[ https://issues.apache.org/jira/browse/LANG-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-760. -- Resolution: Fixed Fix Version/s: (was: 3.0.2) In SVN. Add API StringUtils.toString(byte[] intput, String charsetName) --- Key: LANG-760 URL: https://issues.apache.org/jira/browse/LANG-760 Project: Commons Lang Issue Type: New Feature Components: lang.* Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500) Maven home: C:\Java\apache-maven-3.0.3\bin\.. Java version: 1.6.0_24, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_24\jre Default locale: en_US, platform encoding: Cp1252 OS name: windows 7, version: 6.1, arch: amd64, family: windows Reporter: Gary D. Gregory Assignee: Gary D. Gregory Add API StringUtils.toString(byte[] intput, String charsetName) where charsetName may be null. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-367) Add APIs FileObject isFile(), FileObject isFolder(), and FileName isFile()
[
https://issues.apache.org/jira/browse/VFS-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-367.
-
Resolution: Fixed
In SVN.
Add APIs FileObject isFile(), FileObject isFolder(), and FileName isFile()
--
Key: VFS-367
URL: https://issues.apache.org/jira/browse/VFS-367
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 1.0, 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_24\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: 2.1
As a call site, I want to say {{fileObject.isFile()}}, not
{{FileType.FILE.equals(fileObject.getType())}} or {{fileObject.getType() ==
FileType.FILE}}
It turns out this {{equals()/==}} pattern is repeated internally quit a bit.
Refactor that to use the new API.
Same idea for FileName isFile (but there are fewer call sites to refactor.)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VFS-366) Can't sort a List of FileObject's, FileObject to implement ComparableFileObject
[
https://issues.apache.org/jira/browse/VFS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory resolved VFS-366.
-
Resolution: Fixed
Fix Version/s: 2.1
Assignee: Gary D. Gregory
In SVN.
Can't sort a List of FileObject's, FileObject to implement
ComparableFileObject
-
Key: VFS-366
URL: https://issues.apache.org/jira/browse/VFS-366
Project: Commons VFS
Issue Type: Improvement
Affects Versions: 2.0
Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 12:31:09-0500)
Maven home: C:\Java\apache-maven-3.0.3\bin\..
Java version: 1.6.0_24, vendor: Sun Microsystems Inc.
Java home: C:\Program Files\Java\jdk1.6.0_24\jre
Default locale: en_US, platform encoding: Cp1252
OS name: windows 7, version: 6.1, arch: amd64, family: windows
Reporter: Gary D. Gregory
Assignee: Gary D. Gregory
Fix For: 2.1
I'd like to be able to say:
{code:java}
ListFileObject list = ...
Collections.sort(list);
{code}
and have the list sort the same way I can sort a {{File}}, by name.
{{FileObject}} should implement {{ComparableFileObject}}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (LANG-759) Add Support in SystemUtils for Windows Server 2003 and Windows Server 2008
[ https://issues.apache.org/jira/browse/LANG-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved LANG-759. -- Resolution: Fixed Assignee: Gary D. Gregory In SVN @since 3.1. Add Support in SystemUtils for Windows Server 2003 and Windows Server 2008 -- Key: LANG-759 URL: https://issues.apache.org/jira/browse/LANG-759 Project: Commons Lang Issue Type: Bug Components: lang.* Reporter: Dominik Stadler Assignee: Gary D. Gregory Priority: Critical Attachments: LANG-759.patch SystemUtils currently only knows about the consumer versions of Windows, however there are also the Server-Variants, which can be detected separatedely. E.g. in my case I would like to detect a Windows Server 2003 instance, but cannot, as it is not detected by any of the existing IS_OS_WINDOWS_xxx variants. I extracted the following values that can be used to detect these versions: * Windows Server 2003 R2: os.name=Windows 2003, os.version=5.2 * Windows Server 2008 R2: os.name=Windows Server 2008 R2, os.version=6.1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
