[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 @PascalSchumacher , sorry for my bad decisions. Again I thought I should keep it public to provide same functionality for someone who needs in future :) Now, I removed it to MethodUtils as a private method. I also added @since tag and mentioned interfaces in @return java doc. Thanks a lot! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 > Sorry for the delay, other open source projects and vacations interfered. You're welcome, I understand and as an open source fun contributor, I'm patient enough :) > I'm not sure if the priority parameter is necessary? No, is not. I just thought I should make it more general with more options to prevent future needs for other user's PRs. Now, with thanks to your recommendations I remove it :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 Thank you @Abrasha , I signed up with [coveralls.io](http://coveralls.io) and see that all of this PR's changes are covered with unit tests: [MethodUtils](https://coveralls.io/jobs/24310263/source_files/797094203#L845) , [ClassUtils](https://coveralls.io/jobs/24310263/source_files/797094115#L477). Also these files show enhancement in coverage at [COVERAGE CHANGED](https://coveralls.io/jobs/24310263) :thinking: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 @PascalSchumacher , I made it better ð thanks a lot! Please feel free to make any recommendation if you think I can make it better. > Coverage decreased (-0.03%) to 94.571% ð Do you know why? ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 ð I am working on a new commit. thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue:
https://github.com/apache/commons-lang/pull/261
Another bad thing is that `getMethodsWithAnnotation(cls, annotationCls,
false, false)` will be a duplicate for `getMethodsWithAnnotation(cls,
annotationCls)`.
Another solution is to keep my current changes not modified but add
following javadoc:
```
*
* To lookup annotations on the given class level only choose {@code
get*()} methods
* and to lookup in the entire inheritance hierarchy of the given class and
ignore
* accessibility, choose {@code find*()} methods
*
* @since 2.5
*/
public class MethodUtils {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #261: LANG-1317: Add findAnnotation and findMethodsWithAn...
Github user yasserzamani commented on the issue: https://github.com/apache/commons-lang/pull/261 @PascalSchumacher , thank you! I was overloaded by another job and forgot that I also can use method overloads. Yes, strongly I agree. Just I have some doubts about name `ignoreAccessiblitiy` because the new method is not only about accessibility, but also about traverse super classes and implemented interface and super interfaces while the annotation maybe is not present on the given class but is present on lower layers. Maybe we should also add another param named `searchSupers` for example. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] commons-lang pull request #261: LANG-1317: Add findAnnotation and findMethod...
GitHub user yasserzamani opened a pull request: https://github.com/apache/commons-lang/pull/261 LANG-1317: Add findAnnotation and findMethodsWithAnnotation In order to fix [WW-4744](https://issues.apache.org/jira/browse/WW-4744) , findAnnotation will be an extension for Method.getAnnotation that also searches interfaces and super classes. findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation that also supports non public methods, super class and interface methods. NOTES: To keep changes simple, currently no cache provided. Let's do that when needed ð You can merge this pull request into a Git repository by running: $ git pull https://github.com/yasserzamani/commons-lang LANG-1317 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/commons-lang/pull/261.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #261 commit 74241a7cd79f2dda723f07948c7925f9b6511989 Author: Yasser Zamani <yasser.zam...@live.com> Date: 2017-03-25T21:19:46Z LANG-1317: Add findAnnotation and findMethodsWithAnnotation to MethodUtils --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
