[jira] [Commented] (BCEL-343) Improve assertions

2020-10-07 Thread Allon Mureinik (Jira)


[ 
https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209463#comment-17209463
 ] 

Allon Mureinik commented on BCEL-343:
-

PR posted here:
[https://github.com/apache/commons-bcel/pull/69]

> Improve assertions
> --
>
> Key: BCEL-343
> URL: https://issues.apache.org/jira/browse/BCEL-343
> Project: Commons BCEL
>  Issue Type: Task
>  Components: Build
>Reporter: Allon Mureinik
>Priority: Major
>
> Followup to BCEL-342, based on the discussion in the PR 
> ([https://github.com/apache/commons-bcel/pull/68#issuecomment-703671353)] - 
> now that the project used JUnit Jupiter, it's worth checking if the 
> assertions can be improved to use String suppliers instead of string methods 
> and improve performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BCEL-343) Improve assertions

2020-10-05 Thread Gary D. Gregory (Jira)


[ 
https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208436#comment-17208436
 ] 

Gary D. Gregory commented on BCEL-343:
--

Go for it! 

> Improve assertions
> --
>
> Key: BCEL-343
> URL: https://issues.apache.org/jira/browse/BCEL-343
> Project: Commons BCEL
>  Issue Type: Task
>  Components: Build
>Reporter: Allon Mureinik
>Priority: Major
>
> Followup to BCEL-342, based on the discussion in the PR 
> ([https://github.com/apache/commons-bcel/pull/68#issuecomment-703671353)] - 
> now that the project used JUnit Jupiter, it's worth checking if the 
> assertions can be improved to use String suppliers instead of string methods 
> and improve performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (BCEL-343) Improve assertions

2020-10-05 Thread Allon Mureinik (Jira)


[ 
https://issues.apache.org/jira/browse/BCEL-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208341#comment-17208341
 ] 

Allon Mureinik commented on BCEL-343:
-

I'm looking into this.

Not quite sure what the rules about the assignment of issues are, and aren't 
sure if the "Assignee" field is reserved for maintainers, but I'm on it.

> Improve assertions
> --
>
> Key: BCEL-343
> URL: https://issues.apache.org/jira/browse/BCEL-343
> Project: Commons BCEL
>  Issue Type: Task
>  Components: Build
>Reporter: Allon Mureinik
>Priority: Major
>
> Followup to BCEL-342, based on the discussion in the PR 
> ([https://github.com/apache/commons-bcel/pull/68#issuecomment-703671353)] - 
> now that the project used JUnit Jupiter, it's worth checking if the 
> assertions can be improved to use String suppliers instead of string methods 
> and improve performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)