[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828473#comment-17828473 ] Basil Crow commented on COMPRESS-669: - bq. Brotli support that currently depend on another jar (which is declared "optional" in Maven but is not optional if you want to use the feature). Proving that https://github.com/apache/commons-compress/pull/489 (which was closed without any reasoning other than "We are moving away from using Maven optional dependencies") is in line with the current status quo. > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824126#comment-17824126 ] Michael Osipov commented on COMPRESS-669: - I agree with Gary > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824122#comment-17824122 ] Gary D. Gregory commented on COMPRESS-669: -- My preferred longer-term plan is to separate pack200 support into a Maven module. It is a large code base that is likely seldom used. IMO, we should also split out packages like Brotli support that currently depend on another jar (which is declared "optional" in Maven but is not optional if you want to use the feature). The big picture I like is a Commons Compress without optional Maven dependencies and more Maven modules. > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823359#comment-17823359 ] Basil Crow commented on COMPRESS-669: - I agree. I would be willing to review a PR as well. > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823355#comment-17823355 ] Michael Osipov commented on COMPRESS-669: - Nope, but as said if the code isn't too complex it could be inlined and problem solved. I'd be willing to review a PR > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823349#comment-17823349 ] Basil Crow commented on COMPRESS-669: - I have not. Have you? > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823347#comment-17823347 ] Michael Osipov commented on COMPRESS-669: - Have you tried to change that spot? > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823320#comment-17823320 ] Basil Crow commented on COMPRESS-669: - Yes, that is the problematic usage. > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (COMPRESS-669) Allow usage of non-Pack200 features without Commons Lang 3
[ https://issues.apache.org/jira/browse/COMPRESS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823310#comment-17823310 ] Michael Osipov commented on COMPRESS-669: - Are we talking about: https://github.com/apache/commons-compress/blob/10a5787cc0aa89f4036e5f1af1aa3c04f673f466/src/main/java/org/apache/commons/compress/harmony/unpack200/Pack200UnpackerAdapter.java#L123? I guess if it is only this one the code could be imported and Commons Lang 3 moved to a test scope dependency. > Allow usage of non-Pack200 features without Commons Lang 3 > -- > > Key: COMPRESS-669 > URL: https://issues.apache.org/jira/browse/COMPRESS-669 > Project: Commons Compress > Issue Type: Bug >Affects Versions: 1.26.0 >Reporter: Basil Crow >Priority: Major > > Commons Compress 1.26.0 has sprouted a dependency on Commons Lang 3, which is > problematic for the Jenkins project, which wishes to use Commons Compress in > Jenkins core without exposing Commons Lang 3 to all Jenkins plugins. > The Commons Lang 3 dependency is only used in Pack200 features, which we > don't care about, so in [https://github.com/jenkinsci/jenkins/pull/8997] we > have excluded the dependency. But this is merely a short-term solution, > because this places the burden on consumers to monitor future updates to > ensure that Commons Compress doesn't start relying on Commons Lang 3 for > features other than Pack200. > Some ideas for long-term solutions: > * Find a way to do without the runtime dependency on Commons Lang 3 and turn > the dependency back into a test-scoped dependency. > * Make the Commons Lang 3 dependency optional as in > [https://github.com/apache/commons-compress/pull/489] which was rejected > without any reasoning other than "We are moving away from using Maven > optional dependencies." > * [https://github.com/apache/commons-compress/pull/490] proposes to > modularize Commons Compress, which would solve this problem more generally. -- This message was sent by Atlassian Jira (v8.20.10#820010)
