[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694268#comment-15694268
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
No problem. :)

When I started contributing to Open Source and using git and github I also 
had a lot of questions.


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Assignee: Pascal Schumacher
>Priority: Minor
>  Labels: beginner, test
> Fix For: 3.6
>
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694263#comment-15694263
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user Abrasha commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
@PascalSchumacher, thanks, of course everything is ok.
I just wanted to understand the workflow.
(I am quiet new to Open Source)


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Assignee: Pascal Schumacher
>Priority: Minor
>  Labels: beginner, test
> Fix For: 3.6
>
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694261#comment-15694261
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
It's the same for the other commit, see:

https://github.com/apache/commons-lang/commits/master


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Assignee: Pascal Schumacher
>Priority: Minor
>  Labels: beginner, test
> Fix For: 3.6
>
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694259#comment-15694259
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
Yes, the changes have been merged: 51b2cab

I think the commit is marked as unmerged, because I changed the commit 
message. But you are still listed as the author, so I guess everything is ok?





> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Assignee: Pascal Schumacher
>Priority: Minor
>  Labels: beginner, test
> Fix For: 3.6
>
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694249#comment-15694249
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user Abrasha commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
@PascalSchumacher sorry, just for ensure, have changed been merged? 
Status is: _Closed with unmerged commits_. It is a way of using patches, 
yes?

Thanks.


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694235#comment-15694235
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
Thanks!  


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694233#comment-15694233
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user asfgit closed the pull request at:

https://github.com/apache/commons-lang/pull/217


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694190#comment-15694190
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/217
  

[![Coverage 
Status](https://coveralls.io/builds/8989909/badge)](https://coveralls.io/builds/8989909)

Coverage increased (+0.6%) to 94.294% when pulling 
**6362660b3bfb4fb41719496f1037dc3acb0597ea on 
Abrasha:improvement/array-util-tests** into 
**41bc4cd029fc486b5570ec344cdeae049bbca860 on apache:master**.



> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694177#comment-15694177
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user Abrasha commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
@PascalSchumacher, thanks for note. I will separate it.


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694175#comment-15694175
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
Great find!  Thanks for the detailed explanation. :)
 
As this change is unrelated to improving the test coverage of ArrayUtils, 
it would be nice if you could move it to a separate commit.




> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694046#comment-15694046
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user Abrasha commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
@PascalSchumacher, no problem!

```
@Test
public void testAnnotationsOfDifferingTypes() {

assertFalse(AnnotationUtils.equals(field1.getAnnotation(TestAnnotation.class), 
field4.getAnnotation(NestAnnotation.class)));

assertFalse(AnnotationUtils.equals(field4.getAnnotation(NestAnnotation.class), 
field1.getAnnotation(TestAnnotation.class)));
}
```

This test is successful, but checks a different behaviour than expected.

`field4.getAnnotation(NestAnnotation.class)` is expected to return an 
annotation of type `NestAnnotation`, but actually it returns `null` because the 
Retention of annotation is set to default.

As a result, test did not cover quite important case.


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15694034#comment-15694034
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user PascalSchumacher commented on the issue:

https://github.com/apache/commons-lang/pull/217
  
Thanks for the pull request!  

>fix an issue with not getting Annotation in AnnotaionUtilsTest

Not sure what you fixed there. What is the reason of this change? Thanks!


> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691788#comment-15691788
 ] 

ASF GitHub Bot commented on LANG-1290:
--

Github user coveralls commented on the issue:

https://github.com/apache/commons-lang/pull/217
  

[![Coverage 
Status](https://coveralls.io/builds/8976810/badge)](https://coveralls.io/builds/8976810)

Coverage increased (+0.6%) to 94.274% when pulling 
**874b18d561dedc6f109ff0355d0588282045 on 
Abrasha:improvement/array-util-tests** into 
**41bc4cd029fc486b5570ec344cdeae049bbca860 on apache:master**.



> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-23 Thread Andrii Abramov (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691785#comment-15691785
 ] 

Andrii Abramov commented on LANG-1290:
--

Created Pull Request: [#217|https://github.com/apache/commons-lang/pull/217].
Attaching new locally generated coverage report.

> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html, ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691781#comment-15691781
 ] 

ASF GitHub Bot commented on LANG-1290:
--

GitHub user Abrasha opened a pull request:

https://github.com/apache/commons-lang/pull/217

LANG-1290: Increase test coverage of org.apache.commons.lang3.ArrayUtils 
class

- fix an issue with not getting Annotation in AnnotaionUtilsTest
- add tests to cover ArrayUtils

Increased coverage to ~98% lines of code and 100% methods.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Abrasha/commons-lang 
improvement/array-util-tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/217.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #217


commit 874b18d561dedc6f109ff0355d0588282045
Author: Andrii 
Date:   2016-11-24T00:31:06Z

add tests to cover ArrayUtils
fix an issue with not getting Annotation




> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
> Attachments: ArrayUtils.html
>
>
> There are methods that are not completely covered by tests.
> * swap
> * shift
> * toPrimitive
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LANG-1290) Increase test coverage of org.apache.commons.lang3.ArrayUtils class

2016-11-23 Thread Andrii Abramov (JIRA) 

[ 
https://issues.apache.org/jira/browse/LANG-1290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15691477#comment-15691477
 ] 

Andrii Abramov commented on LANG-1290:
--

I would like to take this ticket.
Currently, I am preparing Change List with additional tests.

> Increase test coverage of org.apache.commons.lang3.ArrayUtils class
> ---
>
> Key: LANG-1290
> URL: https://issues.apache.org/jira/browse/LANG-1290
> Project: Commons Lang
>  Issue Type: Improvement
>  Components: lang.*
>Reporter: Andrii Abramov
>Priority: Minor
>  Labels: beginner, test
>
> There are methods that are not completely covered by tests.
> * swap
> * removeAllOccurences
> * addAll
> * toPrimitive
> * add
> * copyArrayGrow1
> * remove
> * removeElement
> * removeElements
> * removeAll
> The coverage of these methods should be closely to 100%.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)