[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-30 Thread Rob Spoor (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727575#comment-17727575
 ] 

Rob Spoor commented on VFS-838:
---

[~christiangfk], I know it's an outdated SSH server. Like I said, updating the 
SSH test server fixed it for my own project. However, I couldn't quite get the 
updated dependency to work for VFS in the short time I spent on it.

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-30 Thread Christian Wissel (GfK) (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727411#comment-17727411
 ] 

Christian Wissel (GfK) commented on VFS-838:


[~Spoor], that seems less like an error than an outdated SSH server. SHA1-based 
signature algorithms have been deprecated in (Open)SSH for a couple of years 
now.

The JSCH-fork disabled them by default in 2021: 
https://github.com/mwiede/jsch/issues/75

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726839#comment-17726839
 ] 

Michael Osipov commented on VFS-838:


I prefer first 3, then 4.

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-27 Thread Rob Spoor (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726803#comment-17726803
 ] 

Rob Spoor commented on VFS-838:
---

A quick attempt to simply replace the dependency gives the following error 
during testing:
{code}Caused by: com.jcraft.jsch.JSchAlgoNegoFailException: Algorithm 
negotiation fail: algorithmName="kex" 
jschProposal="ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256,ext-info-c"
 serverProposal="diffie-hellman-group14-sha1,diffie-hellman-group1-sha1"
at com.jcraft.jsch.KeyExchange.guess(KeyExchange.java:155)
at com.jcraft.jsch.Session.receive_kexinit(Session.java:569)
at com.jcraft.jsch.Session.connect(Session.java:320)
at com.jcraft.jsch.Session.connect(Session.java:187)
at 
org.apache.commons.vfs2.provider.sftp.SftpClientFactory.createConnection(SftpClientFactory.java:235){code}

I have solved similar issues for my own project by changing sshd-core to 
sshd-sftp with a newer version, but that comes with its own (quite large) set 
of compiler errors.
An alternative could be to change the JSch configuration to add either 
{{diffie-hellman-group14-sha1}} or {{diffie-hellman-group1-sha1}} as supported 
algorithm.

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-27 Thread Rob Spoor (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726799#comment-17726799
 ] 

Rob Spoor commented on VFS-838:
---

I tihnk option 2 is actually the best option. Its 
[license|https://github.com/mwiede/jsch/blob/master/LICENSE.txt] is no longer 
LGPL but BSD:
{quote}JSch 0.0.* was released under the GNU LGPL license.  Later, we have 
switched 
over to a BSD-style license. 

--
Copyright (c) 2002-2015 Atsuhiko Yamanaka, JCraft,Inc. 
All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice,
 this list of conditions and the following disclaimer.

  2. Redistributions in binary form must reproduce the above copyright 
 notice, this list of conditions and the following disclaimer in 
 the documentation and/or other materials provided with the distribution.

  3. The names of the authors may not be used to endorse or promote products
 derived from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESSED OR IMPLIED WARRANTIES,
INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL JCRAFT,
INC. OR ANY CONTRIBUTORS TO THIS SOFTWARE BE LIABLE FOR ANY DIRECT, INDIRECT,
INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA,
OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE,
EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.{quote}

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-27 Thread Rob Spoor (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726797#comment-17726797
 ] 

Rob Spoor commented on VFS-838:
---

I had a quick look at this, but I found some references to JSch in the API. For 
instance, in public interface {{IdentityProvider}} there is method {{void 
addIdentity(JSch jsch) throws JSchException}}, and in public class 
{{SftpClientFactory}} there's method {{createConnection}} that returns a JSch 
{{Session}}.

I see three possibilities:
# Switch to https://github.com/mwiede/jsch. However, its license (LGPL) is an 
issue.
# Create a second package for a Mina-backed file system implementation, and 
deprecate everything from the existing package.
# Break stuff and go for a new major version.

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (VFS-838) Port from Jsch to Apache Mina

2023-05-25 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/VFS-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17726184#comment-17726184
 ] 

Michael Osipov commented on VFS-838:


Strongly support this. I have expressed the same for the Wagon SSH Provider, 
but lack the time to do so. I will remove JSch based provider in the next major 
version.

> Port from Jsch to Apache Mina
> -
>
> Key: VFS-838
> URL: https://issues.apache.org/jira/browse/VFS-838
> Project: Commons VFS
>  Issue Type: Bug
>Reporter: Gary D. Gregory
>Priority: Major
>
> Port from Jsch to Apache Mina
> JSch seems unmaintained.
> https://mina.apache.org/downloads-sshd.html



--
This message was sent by Atlassian Jira
(v8.20.10#820010)