[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches debugger update
[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12749166#action_12749166
]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:37 AM:
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger
can regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of
JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and
maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809316view=rev
Log:
Refactored BitwiseOperator to use asserter.
Removed main methods from tests (use JexlTestCase instead).
Added parenthesized expression tests further Debugger checking.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/ArithmeticTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BitwiseOperatorTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BlockTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809317view=rev
Log:
Implementation moved to ExpressionImpl.java
Removed:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/ScriptImpl.java
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches debugger update
[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12749166#action_12749166
]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:35 AM:
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger
can regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of
JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and
maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809316view=rev
Log:
Refactored BitwiseOperator to use asserter.
Removed main methods from tests (use JexlTestCase instead).
Added parenthesized expression tests further Debugger checking.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/ArithmeticTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BitwiseOperatorTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/BlockTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IssuesTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches debugger update
[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12749166#action_12749166
]
Henri Biestro edited comment on JEXL-85 at 8/30/09 4:11 AM:
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger
can regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of
JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/IfTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTestCase.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/MethodTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809312view=rev
Log:
No functional change, just a reordering to make grammar easier to follow and
maintain.
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger
can regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
URL: http://svn.apache.org/viewvc?rev=809169view=rev
Log:
Modified tests to check the Debugger on tearDown.
Main change in JexlTestCase in the form of methods that check the equality of
JexlNode.
Modified:
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/CacheTest.java
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches debugger update
[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12749166#action_12749166
]
Henri Biestro edited comment on JEXL-85 at 8/29/09 10:11 AM:
-
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
*Debugger.java*: made debugger expression-AST roundtrip enabled; the Debugger
can regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
*JexlEngine.java*: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
was (Author: henrib):
URL: http://svn.apache.org/viewvc?rev=809099view=rev
Log:
added Unicode escape sequence to String literal handling; fixed non-escapable
character handling; added $ as escapable character in UnifiedJEXL
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/UnifiedJEXL.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/StringParser.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/JexlTest.java
commons/proper/jexl/branches/2.0/src/test/java/org/apache/commons/jexl/UnifiedJEXLTest.java
URL: http://svn.apache.org/viewvc?rev=809160view=rev
Log:
*Parser.jjt*: modified grammar to make last statement terminator (aka ';')
optional.
This implied a change in AdditiveOperation and the introduction of
AdditiveOperator to break conflicts.
*Interpreter.java*: modified according to grammar ({Add,Subtract}Node replaced
by AdditiveNode.
Debugger.java: made debugger expression-AST roundtrip enabled; the Debugger can
regenerate an expression from AST that when parsed, will give back an
equivalent AST (fixes JEXL-86).
JexlEngine.java: modified because StatementExpression are no longer creating
nodes (#void)
Modified:
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Debugger.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/Interpreter.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/JexlEngine.java
commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl/parser/Parser.jjt
2.0 grammar finishing touches debugger update
---
Key: JEXL-85
URL: https://issues.apache.org/jira/browse/JEXL-85
Project: Commons JEXL
Issue Type: Improvement
Reporter: Henri Biestro
Fix For: 2.0
Attachments: JEXL-85.patch, JEXL-85.patch
Original Estimate: 0h
Remaining Estimate: 0h
The Parser.jjt carries some extras that are not (longer) necessary (the
debug field, NODE_USES_PARSER option).
Tthe {Expression,Statement,Reference}Expression dont need to create real
nodes.
There are a few places where the LOOKAHEAD can be reduced or more explicit.
Some expressions (Reference) are really hard to read partly due to formatting.
The Debugger is also out of sync with the latest grammar updates (Map
literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JEXL-85) 2.0 grammar finishing touches debugger update
[
https://issues.apache.org/jira/browse/JEXL-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12743504#action_12743504
]
Henri Biestro edited comment on JEXL-85 at 8/14/09 5:42 PM:
Fixing JEXL-86 is dependant upon grammar which changes in JEXL-85.
was (Author: henrib):
Fix is dependant upon grammar which changes in JEXL-85.
2.0 grammar finishing touches debugger update
---
Key: JEXL-85
URL: https://issues.apache.org/jira/browse/JEXL-85
Project: Commons JEXL
Issue Type: Improvement
Reporter: Henri Biestro
Fix For: 2.0
Attachments: JEXL-85.patch, JEXL-85.patch
The Parser.jjt carries some extras that are not (longer) necessary (the
debug field, NODE_USES_PARSER option).
Tthe {Expression,Statement,Reference}Expression dont need to create real
nodes.
There are a few places where the LOOKAHEAD can be reduced or more explicit.
Some expressions (Reference) are really hard to read partly due to formatting.
The Debugger is also out of sync with the latest grammar updates (Map
literals, for).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
