Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

garydgregory merged PR #232:
URL: https://github.com/apache/commons-beanutils/pull/232


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

doublep commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2131229026

   @garydgregory I just pushed some Javadoc changes. Feel free to rewrite or 
adjust as you prefer, easier this way than negotiating in advance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

garydgregory commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129429158

   @doublep Do you want to update the Javadoc as part of this PR or a separate 
PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

doublep commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2129000279

   I'd say keep all four `getReadMethod()` and `getWriteMethod()` overloads 
public. As these method names are very common, searching in publicly available 
code doesn't yield useful results (too many unrelated hits), but suppose 
someone somewhere has a valid usecase to access one of these methods. (I can't 
think of one myself, but I don't rule out the possibility that there might be.)
   
   If you now lower the visibility, you will break someone's code for no 
particularly good reason, forcing them to look for workarounds. E.g. 
subclassing, making the methods public and then explicitly downcasting to the 
created class when using from "outside". Basically, a lot of hassle for 
virtually nothing. It's not like `PropertyUtilsBean` is a high-level class 
where having a nice compact interface is a lot of value.
   
   So, I'd leave them all `public`, but add a "disclaimer" in the documentation 
that these methods are lower-level than the rest (e.g. `get*Property()`) and 
should generally not be needed outside of some special usecases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

garydgregory commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2127934355

   @doublep 
   We can break BC in a major release like 2.0.0. The question really is: What 
is the best design? WDYT?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

doublep commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2043202797

   I just checked the source code history and this is the commit where 
`getWriteMethod(Class, PropertyDescriptor)` was made public:
   
   8f77bd63 [BEANUTILS-456] Provide another method for querying a write 
method.
   Author: Oliver Heger 
   AuthorDate: 2014-01-03 19:38:03 +
   
   So, changing it back (or to `protected`) after ten years would be a bit 
backward-incompatible. So, instead I suggest to follow suit and do _the same_ 
for `getReadMethod(Class, PropertyDescriptor)`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

doublep commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2042372937

   For consistency with getWriteMethod(Class, PropertyDesciptor). But I don't
   mind if it is made protected, just not package-private as now.
   
   Paul
   
   On Mon, 8 Apr 2024 at 12:11, Gary Gregory ***@***.***> wrote:
   
   > If you intend to use it in a subclass, why is it public and not protected?
   >
   > —
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   > You are receiving this because you authored the thread.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Change visibility of PropertyUtilsBean.getReadMethod(Class, PropertyDescriptor) [commons-beanutils]

[via GitHub]

garydgregory commented on PR #232:
URL: 
https://github.com/apache/commons-beanutils/pull/232#issuecomment-2042363716

   If you intend to use it in a subclass, why is it public and not protected? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org