Re: [PR] Fix CI only running on Ubuntu & improve OS-specific tests [commons-exec]

2024-02-04 Thread via GitHub 


garydgregory merged PR #143:
URL: https://github.com/apache/commons-exec/pull/143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix CI only running on Ubuntu & improve OS-specific tests [commons-exec]

2024-02-03 Thread via GitHub 


Marcono1234 commented on code in PR #143:
URL: https://github.com/apache/commons-exec/pull/143#discussion_r1477098978


##
.github/workflows/maven.yml:
##
@@ -35,17 +35,17 @@ jobs:
 #experimental: true
 
 steps:
-- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-  with:
-persist-credentials: false
-- uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
+- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+  with:
+persist-credentials: false
+- uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
   with:
 path: ~/.m2/repository
 key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
 restore-keys: |
   ${{ runner.os }}-maven-
 - name: Set up JDK ${{ matrix.java }}
-  uses: actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93 # 
v4.0.0
+  uses: actions/setup-java@387ac29b308b003ca37ba93a6cab5eb57c8f5f93 # 
v4.0.0

Review Comment:
   These are only whitespace changes; this file seems to have mixed LF and CRLF.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix CI only running on Ubuntu & improve OS-specific tests [commons-exec]

2024-02-03 Thread via GitHub 


Marcono1234 commented on PR #143:
URL: https://github.com/apache/commons-exec/pull/143#issuecomment-1925395950

   @garydgregory, can you please have a look? The current CI workflow gives a 
false sense of security.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org