[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted
[
https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737558#comment-17737558
]
Junhan Yang commented on FLINK-30719:
-
Looks like there is still no any proposed fix in this open issue:
[https://github.com/eirslett/frontend-maven-plugin/issues/882] . The cause
seems like a recognized behavior in the maven-frontend-plugin, and all we can
do is to retry the CI process.
> flink-runtime-web failed due to a corrupted
>
>
> Key: FLINK-30719
> URL: https://issues.apache.org/jira/browse/FLINK-30719
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend, Test Infrastructure, Tests
>Affects Versions: 1.16.0, 1.17.0, 1.18.0
>Reporter: Matthias Pohl
>Priority: Critical
> Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=44954=logs=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5=54421a62-0c80-5aad-3319-094ff69180bb=12550
> The build failed due to a corrupted nodejs dependency:
> {code}
> [ERROR] The archive file
> /__w/1/.m2/repository/com/github/eirslett/node/16.13.2/node-16.13.2-linux-x64.tar.gz
> is corrupted and will be deleted. Please try the build again.
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-31110) Web UI shows "User Configuration" preserving lines and whitespaces
[
https://issues.apache.org/jira/browse/FLINK-31110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719135#comment-17719135
]
Junhan Yang commented on FLINK-31110:
-
master: 246c17b8aeb75e66057d3d663d0c1a127108bc2e
> Web UI shows "User Configuration" preserving lines and whitespaces
> --
>
> Key: FLINK-31110
> URL: https://issues.apache.org/jira/browse/FLINK-31110
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.16.1
>Reporter: Mingliang Liu
>Priority: Minor
> Labels: pull-request-available
> Attachments: Screenshot 2023-02-18 at 1.24.20 AM.png
>
>
> Currently one can use \{{env.getConfig().setGlobalJobParameters(...)}} for
> setting user configurations. It will also show up in the Web UI > Running
> Jobs > Job Configuration > User Configuration section. This is nice so users
> can confirm the user configuration (key/value pair) gets populated.
> However, it does not preserves whitespaces and line breaks in HTML page. For
> example, we have some prettified JSON configuration and sometimes formatted
> SQL statements in those configurations, and it's showing in a compacted HTML
> format - not human readable original formatted string.
> I propose we keep the whitespaces and lines for this "User Configuration"
> section in the Web UI. The implementation can be as simple as adding
> {{style="white-space: pre-wrap;"}} to the rows in that section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (FLINK-31110) Web UI shows "User Configuration" preserving lines and whitespaces
[
https://issues.apache.org/jira/browse/FLINK-31110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junhan Yang resolved FLINK-31110.
-
Assignee: Mingliang Liu
Resolution: Fixed
> Web UI shows "User Configuration" preserving lines and whitespaces
> --
>
> Key: FLINK-31110
> URL: https://issues.apache.org/jira/browse/FLINK-31110
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Web Frontend
>Affects Versions: 1.16.1
>Reporter: Mingliang Liu
>Assignee: Mingliang Liu
>Priority: Minor
> Labels: pull-request-available
> Attachments: Screenshot 2023-02-18 at 1.24.20 AM.png
>
>
> Currently one can use \{{env.getConfig().setGlobalJobParameters(...)}} for
> setting user configurations. It will also show up in the Web UI > Running
> Jobs > Job Configuration > User Configuration section. This is nice so users
> can confirm the user configuration (key/value pair) gets populated.
> However, it does not preserves whitespaces and line breaks in HTML page. For
> example, we have some prettified JSON configuration and sometimes formatted
> SQL statements in those configurations, and it's showing in a compacted HTML
> format - not human readable original formatted string.
> I propose we keep the whitespaces and lines for this "User Configuration"
> section in the Web UI. The implementation can be as simple as adding
> {{style="white-space: pre-wrap;"}} to the rows in that section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted
[
https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703016#comment-17703016
]
Junhan Yang commented on FLINK-30719:
-
Hi, I spent a while investigating on this, and I still speculate that this is
caused by the unstable network.
The frontend-mave-plugin "install node and npm" execution was the root of this
problem. It tries to download node and npm from the default downloadRoot
[https://nodejs.org/dist/]
My suggestion is to set up a stable proxy downloadRoot for this download. Do we
have a mirror for the default downloadRoot?
> flink-runtime-web failed due to a corrupted
>
>
> Key: FLINK-30719
> URL: https://issues.apache.org/jira/browse/FLINK-30719
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend, Test Infrastructure, Tests
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Matthias Pohl
>Priority: Critical
> Labels: test-stability
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=44954=logs=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5=54421a62-0c80-5aad-3319-094ff69180bb=12550
> The build failed due to a corrupted nodejs dependency:
> {code}
> [ERROR] The archive file
> /__w/1/.m2/repository/com/github/eirslett/node/16.13.2/node-16.13.2-linux-x64.tar.gz
> is corrupted and will be deleted. Please try the build again.
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (FLINK-29125) Placeholder in Apache Flink Web Frontend to display some "tags" to distinguish between frontends of different clusters
[ https://issues.apache.org/jira/browse/FLINK-29125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17651485#comment-17651485 ] Junhan Yang commented on FLINK-29125: - [~dkrovi] You want to have a cluster identification tag in the web UI, but displaying port number in the browser location bar (I believe you are referring to the routers) is not a good way. Besides, I am not sure if the Front-end have any information about the current cluster through any REST apis. > Placeholder in Apache Flink Web Frontend to display some "tags" to > distinguish between frontends of different clusters > -- > > Key: FLINK-29125 > URL: https://issues.apache.org/jira/browse/FLINK-29125 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Durga Krovi >Priority: Major > > When there are several Apache Flink clusters running and the corresponding > Web Frontend is opened in browser tabs, it would be great if these UIs can be > distinguished in a visible way. Port number in the browser location bar might > be useful. > In our use case, we switch among multiple clusters, connect to only one > cluster at a time and use the same port for forwarding. In such a case, there > is no visible cue to identify the cluster of the UI being accessed on the > browser. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-30250) The flame graph type is wrong
[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645897#comment-17645897 ] Junhan Yang commented on FLINK-30250: - master: 6af92a3eda4d243f765f6ea0c8c548ca70ca423a > The flame graph type is wrong > - > > Key: FLINK-30250 > URL: https://issues.apache.org/jira/browse/FLINK-30250 > Project: Flink > Issue Type: Bug > Components: Runtime / REST, Runtime / Web Frontend >Affects Versions: 1.15.0, 1.16.0, 1.17.0 >Reporter: Rui Fan >Assignee: Rui Fan >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-11-30-19-08-42-067.png > > > When the flame graph type is switched from On-CPU to Mixed. It still show the > graph of On-CPU. > h2. Root cause: > When click the other types, the web frontend will call the requestFlameGraph > and update the graphType. However, the graphType is the old type during > requestFlameGraph. So the graph type show the new type, but the flame graph > is the result of old type. > [code link > |https://github.com/apache/flink/blob/8bbf52688758bbede45df060a4c11e5fa228b6f0/flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts#L82] > !image-2022-11-30-19-08-42-067.png|width=1026,height=389! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (FLINK-30250) The flame graph type is wrong
[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang resolved FLINK-30250. - Resolution: Fixed > The flame graph type is wrong > - > > Key: FLINK-30250 > URL: https://issues.apache.org/jira/browse/FLINK-30250 > Project: Flink > Issue Type: Bug > Components: Runtime / REST, Runtime / Web Frontend >Affects Versions: 1.15.0, 1.16.0, 1.17.0 >Reporter: Rui Fan >Assignee: Rui Fan >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-11-30-19-08-42-067.png > > > When the flame graph type is switched from On-CPU to Mixed. It still show the > graph of On-CPU. > h2. Root cause: > When click the other types, the web frontend will call the requestFlameGraph > and update the graphType. However, the graphType is the old type during > requestFlameGraph. So the graph type show the new type, but the flame graph > is the result of old type. > [code link > |https://github.com/apache/flink/blob/8bbf52688758bbede45df060a4c11e5fa228b6f0/flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts#L82] > !image-2022-11-30-19-08-42-067.png|width=1026,height=389! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29925) table ui of configure value is strange
[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645896#comment-17645896 ] Junhan Yang commented on FLINK-29925: - master: 4e1e1a81ededd86199fcb43c933a198fcbdbe55b > table ui of configure value is strange > -- > > Key: FLINK-29925 > URL: https://issues.apache.org/jira/browse/FLINK-29925 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.15.3 >Reporter: jiadong.lu >Assignee: Junhan Yang >Priority: Minor > Labels: pull-request-available > Attachments: 截屏2022-11-08 15.37.04.png > > > As shown in the figure below, when the configure value is very large, the ui > of the table is a bit strange !截屏2022-11-08 > 15.37.04.png|width=856,height=496! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (FLINK-29925) table ui of configure value is strange
[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang resolved FLINK-29925. - Resolution: Fixed > table ui of configure value is strange > -- > > Key: FLINK-29925 > URL: https://issues.apache.org/jira/browse/FLINK-29925 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.15.3 >Reporter: jiadong.lu >Assignee: Junhan Yang >Priority: Minor > Labels: pull-request-available > Attachments: 截屏2022-11-08 15.37.04.png > > > As shown in the figure below, when the configure value is very large, the ui > of the table is a bit strange !截屏2022-11-08 > 15.37.04.png|width=856,height=496! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-30250) The flame graph type is wrong
[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645055#comment-17645055 ] Junhan Yang commented on FLINK-30250: - [~fanrui] I left some comments in the PR :) > The flame graph type is wrong > - > > Key: FLINK-30250 > URL: https://issues.apache.org/jira/browse/FLINK-30250 > Project: Flink > Issue Type: Bug > Components: Runtime / REST, Runtime / Web Frontend >Affects Versions: 1.15.0, 1.16.0, 1.17.0 >Reporter: Rui Fan >Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-11-30-19-08-42-067.png > > > When the flame graph type is switched from On-CPU to Mixed. It still show the > graph of On-CPU. > h2. Root cause: > When click the other types, the web frontend will call the requestFlameGraph > and update the graphType. However, the graphType is the old type during > requestFlameGraph. So the graph type show the new type, but the flame graph > is the result of old type. > [code link > |https://github.com/apache/flink/blob/8bbf52688758bbede45df060a4c11e5fa228b6f0/flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts#L82] > !image-2022-11-30-19-08-42-067.png|width=1026,height=389! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29925) table ui of configure value is strange
[ https://issues.apache.org/jira/browse/FLINK-29925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645054#comment-17645054 ] Junhan Yang commented on FLINK-29925: - No worries, I will take care of this UI problem :) > table ui of configure value is strange > -- > > Key: FLINK-29925 > URL: https://issues.apache.org/jira/browse/FLINK-29925 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.15.3 >Reporter: jiadong.lu >Priority: Minor > Attachments: 截屏2022-11-08 15.37.04.png > > > As shown in the figure below, when the configure value is very large, the ui > of the table is a bit strange !截屏2022-11-08 > 15.37.04.png|width=856,height=496! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components
[ https://issues.apache.org/jira/browse/FLINK-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang closed FLINK-29747. --- Resolution: Fixed > [UI] Refactor runtime web from module-based to standalone components > > > Key: FLINK-29747 > URL: https://issues.apache.org/jira/browse/FLINK-29747 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available > > From v14 onwards, Angular provides a capability of standalone components that > can be independently bootstrapping. This is a powerful feature in terms of > refactoring the application to be less-heavy and structurally clean. It also > enables the component-level lazy loading in routes, improving the web > performance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components
[ https://issues.apache.org/jira/browse/FLINK-29747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624817#comment-17624817 ] Junhan Yang commented on FLINK-29747: - master: 77204ff7b92da132c1033a356344d8ccd6b443f2 > [UI] Refactor runtime web from module-based to standalone components > > > Key: FLINK-29747 > URL: https://issues.apache.org/jira/browse/FLINK-29747 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available > > From v14 onwards, Angular provides a capability of standalone components that > can be independently bootstrapping. This is a powerful feature in terms of > refactoring the application to be less-heavy and structurally clean. It also > enables the component-level lazy loading in routes, improving the web > performance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-29747) [UI] Refactor runtime web from module-based to standalone components
Junhan Yang created FLINK-29747: --- Summary: [UI] Refactor runtime web from module-based to standalone components Key: FLINK-29747 URL: https://issues.apache.org/jira/browse/FLINK-29747 Project: Flink Issue Type: Improvement Components: Runtime / Web Frontend Reporter: Junhan Yang Assignee: Junhan Yang >From v14 onwards, Angular provides a capability of standalone components that >can be independently bootstrapping. This is a powerful feature in terms of >refactoring the application to be less-heavy and structurally clean. It also >enables the component-level lazy loading in routes, improving the web >performance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (FLINK-29684) [UI] Upgrade runtime web Angular framework and associated deps to v14
[ https://issues.apache.org/jira/browse/FLINK-29684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang closed FLINK-29684. --- Resolution: Fixed > [UI] Upgrade runtime web Angular framework and associated deps to v14 > - > > Key: FLINK-29684 > URL: https://issues.apache.org/jira/browse/FLINK-29684 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available > > Angular framework and NG-ZORRO both have released their stable v14 versions. > It is a good time to bump them to the latest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29684) [UI] Upgrade runtime web Angular framework and associated deps to v14
[ https://issues.apache.org/jira/browse/FLINK-29684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17621467#comment-17621467 ] Junhan Yang commented on FLINK-29684: - master: 97bc331f84285117dc4c30bc583cc2df45196356 > [UI] Upgrade runtime web Angular framework and associated deps to v14 > - > > Key: FLINK-29684 > URL: https://issues.apache.org/jira/browse/FLINK-29684 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available > > Angular framework and NG-ZORRO both have released their stable v14 versions. > It is a good time to bump them to the latest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-29684) [UI] Upgrade runtime web Angular framework and associated deps to v14
[ https://issues.apache.org/jira/browse/FLINK-29684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-29684: Description: Angular framework and NG-ZORRO both have released their stable v14 versions. It is a good time to bump them to the latest. > [UI] Upgrade runtime web Angular framework and associated deps to v14 > - > > Key: FLINK-29684 > URL: https://issues.apache.org/jira/browse/FLINK-29684 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > > Angular framework and NG-ZORRO both have released their stable v14 versions. > It is a good time to bump them to the latest. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-29684) [UI] Upgrade runtime web Angular framework and associated deps to v14
Junhan Yang created FLINK-29684: --- Summary: [UI] Upgrade runtime web Angular framework and associated deps to v14 Key: FLINK-29684 URL: https://issues.apache.org/jira/browse/FLINK-29684 Project: Flink Issue Type: Improvement Components: Runtime / Web Frontend Reporter: Junhan Yang Assignee: Junhan Yang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (FLINK-29180) Show subtask metrics as default in vertex detail
[ https://issues.apache.org/jira/browse/FLINK-29180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang closed FLINK-29180. --- Fix Version/s: 1.16.0 Resolution: Fixed > Show subtask metrics as default in vertex detail > > > Key: FLINK-29180 > URL: https://issues.apache.org/jira/browse/FLINK-29180 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available, ui, user_experience > Fix For: 1.16.0 > > Attachments: image-2022-09-02-11-00-25-312.png > > > Switch the order of the following tabs and show subtask metrics as default. > !image-2022-09-02-11-00-25-312.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-29180) Show subtask metrics as default in vertex detail
[ https://issues.apache.org/jira/browse/FLINK-29180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17599351#comment-17599351 ] Junhan Yang commented on FLINK-29180: - master (1.16): 121e63e8702e449559dc548fc29b4e9c4ce535e4 > Show subtask metrics as default in vertex detail > > > Key: FLINK-29180 > URL: https://issues.apache.org/jira/browse/FLINK-29180 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available, ui, user_experience > Attachments: image-2022-09-02-11-00-25-312.png > > > Switch the order of the following tabs and show subtask metrics as default. > !image-2022-09-02-11-00-25-312.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-29180) Show subtask metrics as default in vertex detail
Junhan Yang created FLINK-29180: --- Summary: Show subtask metrics as default in vertex detail Key: FLINK-29180 URL: https://issues.apache.org/jira/browse/FLINK-29180 Project: Flink Issue Type: Improvement Components: Runtime / Web Frontend Reporter: Junhan Yang Assignee: Junhan Yang Attachments: image-2022-09-02-11-00-25-312.png Switch the order of the following tabs and show subtask metrics as default. !image-2022-09-02-11-00-25-312.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-28945) Several task IO metrics not displayed on web ui
[ https://issues.apache.org/jira/browse/FLINK-28945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17579484#comment-17579484 ] Junhan Yang commented on FLINK-28945: - >From the web UI's perspective, the metrics displayed in the table is totally >based on the REST API 'jobs/:jobId'. I suggest we should double-check the >back-end computation logic behind this API. >!image-2022-08-15-10-22-59-964.png|width=361,height=295! > Several task IO metrics not displayed on web ui > --- > > Key: FLINK-28945 > URL: https://issues.apache.org/jira/browse/FLINK-28945 > Project: Flink > Issue Type: Bug >Reporter: lincoln lee >Priority: Major > Attachments: image-2022-08-15-10-22-59-964.png > > > There is feedback from the community user that neither the receive nor the > sent metric is displayed when source sink tasks are chained together. > !https://intranetproxy.alipay.com/skylark/lark/0/2022/png/13414/1658998667672-44c5f68e-27d7-4bc7-b187-97a7c58271b0.png! > Also, the received and sent metrics never displayed for source task > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-28945) Several task IO metrics not displayed on web ui
[ https://issues.apache.org/jira/browse/FLINK-28945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-28945: Attachment: image-2022-08-15-10-22-59-964.png > Several task IO metrics not displayed on web ui > --- > > Key: FLINK-28945 > URL: https://issues.apache.org/jira/browse/FLINK-28945 > Project: Flink > Issue Type: Bug >Reporter: lincoln lee >Priority: Major > Attachments: image-2022-08-15-10-22-59-964.png > > > There is feedback from the community user that neither the receive nor the > sent metric is displayed when source sink tasks are chained together. > !https://intranetproxy.alipay.com/skylark/lark/0/2022/png/13414/1658998667672-44c5f68e-27d7-4bc7-b187-97a7c58271b0.png! > Also, the received and sent metrics never displayed for source task > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-28316) [UI] add external JM and TM log links under history server
[ https://issues.apache.org/jira/browse/FLINK-28316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-28316: Summary: [UI] add external JM and TM log links under history server (was: [UI] add external taskmanager log links in the vertex drawer under history server) > [UI] add external JM and TM log links under history server > -- > > Key: FLINK-28316 > URL: https://issues.apache.org/jira/browse/FLINK-28316 > Project: Flink > Issue Type: Sub-task >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-28316) [UI] add external taskmanager log links in the vertex drawer under history server
Junhan Yang created FLINK-28316: --- Summary: [UI] add external taskmanager log links in the vertex drawer under history server Key: FLINK-28316 URL: https://issues.apache.org/jira/browse/FLINK-28316 Project: Flink Issue Type: Sub-task Reporter: Junhan Yang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (FLINK-28314) [UI] Introduce "Cluster Environment" tab under history server
[ https://issues.apache.org/jira/browse/FLINK-28314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-28314: Summary: [UI] Introduce "Cluster Environment" tab under history server (was: Introduce "Cluster Environment" tab under history server Web UI) > [UI] Introduce "Cluster Environment" tab under history server > - > > Key: FLINK-28314 > URL: https://issues.apache.org/jira/browse/FLINK-28314 > Project: Flink > Issue Type: Sub-task >Affects Versions: 1.16.0 >Reporter: Junhan Yang >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-28315) [UI] Introduce aggregate stats in tables of the subtasks and taskmanagers
Junhan Yang created FLINK-28315: --- Summary: [UI] Introduce aggregate stats in tables of the subtasks and taskmanagers Key: FLINK-28315 URL: https://issues.apache.org/jira/browse/FLINK-28315 Project: Flink Issue Type: Sub-task Affects Versions: 1.16.0 Reporter: Junhan Yang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (FLINK-28314) Introduce "Cluster Environment" tab under history server Web UI
Junhan Yang created FLINK-28314: --- Summary: Introduce "Cluster Environment" tab under history server Web UI Key: FLINK-28314 URL: https://issues.apache.org/jira/browse/FLINK-28314 Project: Flink Issue Type: Sub-task Affects Versions: 1.16.0 Reporter: Junhan Yang -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (FLINK-27734) Not showing checkpoint interval properly in WebUI when checkpoint is disabled
[ https://issues.apache.org/jira/browse/FLINK-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551913#comment-17551913 ] Junhan Yang commented on FLINK-27734: - Hi [~Feifan Wang] . Thank you for fixing this. I left some comments in the PR. > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > -- > > Key: FLINK-27734 > URL: https://issues.apache.org/jira/browse/FLINK-27734 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 1.15.0 >Reporter: Feifan Wang >Priority: Major > Labels: pull-request-available > Attachments: image-2022-05-22-23-42-46-365.png > > > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > !image-2022-05-22-23-42-46-365.png|width=1019,height=362! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] (FLINK-27734) Not showing checkpoint interval properly in WebUI when checkpoint is disabled
[ https://issues.apache.org/jira/browse/FLINK-27734 ] Junhan Yang deleted comment on FLINK-27734: - was (Author: junhany): Hi [~Feifan Wang] , the change LGTM overall, but please make sure you have run command line `npm run lint --fix` to double check if the new lint works. You also need to fix all other abstract equality operator (==) if exists. > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > -- > > Key: FLINK-27734 > URL: https://issues.apache.org/jira/browse/FLINK-27734 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 1.15.0 >Reporter: Feifan Wang >Priority: Major > Labels: pull-request-available > Attachments: image-2022-05-22-23-42-46-365.png > > > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > !image-2022-05-22-23-42-46-365.png|width=1019,height=362! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (FLINK-27734) Not showing checkpoint interval properly in WebUI when checkpoint is disabled
[ https://issues.apache.org/jira/browse/FLINK-27734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551896#comment-17551896 ] Junhan Yang commented on FLINK-27734: - Hi [~Feifan Wang] , the change LGTM overall, but please make sure you have run command line `npm run lint --fix` to double check if the new lint works. You also need to fix all other abstract equality operator (==) if exists. > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > -- > > Key: FLINK-27734 > URL: https://issues.apache.org/jira/browse/FLINK-27734 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 1.15.0 >Reporter: Feifan Wang >Priority: Major > Labels: pull-request-available > Attachments: image-2022-05-22-23-42-46-365.png > > > Not showing checkpoint interval properly in WebUI when checkpoint is disabled > !image-2022-05-22-23-42-46-365.png|width=1019,height=362! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (FLINK-26245) flink-runtime-web submit showPlan not working
[
https://issues.apache.org/jira/browse/FLINK-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junhan Yang updated FLINK-26245:
Description:
The viewchild `DagreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DagreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png|width=212,height=272!
was:
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png|width=212,height=272!
> flink-runtime-web submit showPlan not working
> -
>
> Key: FLINK-26245
> URL: https://issues.apache.org/jira/browse/FLINK-26245
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend
>Reporter: Junhan Yang
>Priority: Major
> Attachments: image-2022-02-18-16-35-04-834.png
>
>
> The viewchild `DagreComponent` is incorrectly defined as `\{ static: true }`
> (should be false since the component is not rendered if showPlan button is
> not clicked yet) .
> On the other note, a better practice to control the state of `DagreComponent`
> is through @Input/@Output rather than viewchild.
> !image-2022-02-18-16-35-04-834.png|width=212,height=272!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FLINK-26245) flink-runtime-web submit showPlan not working
[
https://issues.apache.org/jira/browse/FLINK-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junhan Yang updated FLINK-26245:
Description:
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png|width=212,height=272!
was:
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png!
> flink-runtime-web submit showPlan not working
> -
>
> Key: FLINK-26245
> URL: https://issues.apache.org/jira/browse/FLINK-26245
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend
>Reporter: Junhan Yang
>Priority: Major
> Attachments: image-2022-02-18-16-35-04-834.png
>
>
> The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
> (should be false since the component is not rendered if showPlan button is
> not clicked yet) .
>
> On the other note, a better practice to control the state of `DegreComponent`
> is through @Input/@Output rather than viewchild.
> !image-2022-02-18-16-35-04-834.png|width=212,height=272!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (FLINK-26245) flink-runtime-web submit showPlan not working
[
https://issues.apache.org/jira/browse/FLINK-26245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junhan Yang updated FLINK-26245:
Description:
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png|width=212,height=272!
was:
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png|width=212,height=272!
> flink-runtime-web submit showPlan not working
> -
>
> Key: FLINK-26245
> URL: https://issues.apache.org/jira/browse/FLINK-26245
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Web Frontend
>Reporter: Junhan Yang
>Priority: Major
> Attachments: image-2022-02-18-16-35-04-834.png
>
>
> The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
> (should be false since the component is not rendered if showPlan button is
> not clicked yet) .
> On the other note, a better practice to control the state of `DegreComponent`
> is through @Input/@Output rather than viewchild.
> !image-2022-02-18-16-35-04-834.png|width=212,height=272!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (FLINK-26245) flink-runtime-web submit showPlan not working
Junhan Yang created FLINK-26245:
---
Summary: flink-runtime-web submit showPlan not working
Key: FLINK-26245
URL: https://issues.apache.org/jira/browse/FLINK-26245
Project: Flink
Issue Type: Bug
Components: Runtime / Web Frontend
Reporter: Junhan Yang
Attachments: image-2022-02-18-16-35-04-834.png
The viewchild `DegreComponent` is incorrectly defined as `\{ static: true }`
(should be false since the component is not rendered if showPlan button is not
clicked yet) .
On the other note, a better practice to control the state of `DegreComponent`
is through @Input/@Output rather than viewchild.
!image-2022-02-18-16-35-04-834.png!
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (FLINK-26207) refactor web ui's components to depend on module's injected config object
Junhan Yang created FLINK-26207: --- Summary: refactor web ui's components to depend on module's injected config object Key: FLINK-26207 URL: https://issues.apache.org/jira/browse/FLINK-26207 Project: Flink Issue Type: Sub-task Components: Runtime / Web Frontend Reporter: Junhan Yang By making components depend on injected config object, one is able to config corresponding module's view, styles and/or business logic. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FLINK-26206) refactor web ui's service layer and app config
Junhan Yang created FLINK-26206: --- Summary: refactor web ui's service layer and app config Key: FLINK-26206 URL: https://issues.apache.org/jira/browse/FLINK-26206 Project: Flink Issue Type: Sub-task Components: Runtime / Web Frontend Reporter: Junhan Yang Add abstractions for api service layer and refactor app.config.ts to a config service. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (FLINK-24629) Sorting start-time/duration/end-time not working under pages of vertex taskManagers and sub-tasks
[ https://issues.apache.org/jira/browse/FLINK-24629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang closed FLINK-24629. --- Resolution: Fixed > Sorting start-time/duration/end-time not working under pages of vertex > taskManagers and sub-tasks > - > > Key: FLINK-24629 > URL: https://issues.apache.org/jira/browse/FLINK-24629 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Assignee: Junhan Yang >Priority: Major > Labels: pull-request-available, stale-assigned > Attachments: image-2021-10-25-16-23-55-894.png > > > Based on the definitions of `VertexTaskManagerDetailInterface` and > `JobSubTaskInterface` interfaces, the sorting functions of start-time, > duration and end-time are incorrectly stated as `details.XXX`. > !image-2021-10-25-16-23-55-894.png|width=552,height=73! -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Agile configurable modules in web ui
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Summary: Agile configurable modules in web ui (was: Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability) > Agile configurable modules in web ui > > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > Labels: improvement > > Use a fractal folder structure: > * routers > * services (services that are only provided in current module) > * layouts (components for layout purpose only) > * modules (modules that are not relevant to routing) > All services of apis should be located at "src/app/services/" and provided in > root. Other non-api services should be located and provided in the > corresponding module scope. > For modules like task-manager and job-manager, use an injection token to > allow a configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the token), increasing these modules' reusability (also a better DI > practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Agile configurable modules in web ui
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Description: For modules like task-manager and job-manager, use an injection token to allow a configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the token), increasing these modules' reusability (also a better DI practice). (was: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow a configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the token), increasing these modules' reusability (also a better DI practice).) > Agile configurable modules in web ui > > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > Labels: improvement > > For modules like task-manager and job-manager, use an injection token to > allow a configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the token), increasing these modules' reusability (also a better DI > practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Labels: improvement (was: ) > Refactor web-dashboard's folder structure and use Angular DI injection token > for better reusability > --- > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > Labels: improvement > > Use a fractal folder structure: > * routers > * services (services that are only provided in current module) > * layouts (components for layout purpose only) > * modules (modules that are not relevant to routing) > All services of apis should be located at "src/app/services/" and provided in > root. Other non-api services should be located and provided in the > corresponding module scope. > For modules like task-manager and job-manager, use an injection token to > allow a configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the token), increasing these modules' reusability (also a better DI > practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Description: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow a configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the token), increasing these modules' reusability (also a better DI practice). was: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow a configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). > Refactor web-dashboard's folder structure and use Angular DI injection token > for better reusability > --- > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > > Use a fractal folder structure: > * routers > * services (services that are only provided in current module) > * layouts (components for layout purpose only) > * modules (modules that are not relevant to routing) > All services of apis should be located at "src/app/services/" and provided in > root. Other non-api services should be located and provided in the > corresponding module scope. > For modules like task-manager and job-manager, use an injection token to > allow a configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the token), increasing these modules' reusability (also a better DI > practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Description: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow a configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). was: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow potential configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). > Refactor web-dashboard's folder structure and use Angular DI injection token > for better reusability > --- > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > > Use a fractal folder structure: > * routers > * services (services that are only provided in current module) > * layouts (components for layout purpose only) > * modules (modules that are not relevant to routing) > All services of apis should be located at "src/app/services/" and provided in > root. Other non-api services should be located and provided in the > corresponding module scope. > For modules like task-manager and job-manager, use an injection token to > allow a configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the injection token), increasing these modules' reusability (also a > better DI practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25725) Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability
[ https://issues.apache.org/jira/browse/FLINK-25725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-25725: Description: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to allow potential configuration object customizing/overriding individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). was: Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to enable potential configuration object customizing/overriding of individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). > Refactor web-dashboard's folder structure and use Angular DI injection token > for better reusability > --- > > Key: FLINK-25725 > URL: https://issues.apache.org/jira/browse/FLINK-25725 > Project: Flink > Issue Type: Technical Debt > Components: Runtime / Web Frontend >Reporter: Junhan Yang >Priority: Major > > Use a fractal folder structure: > * routers > * services (services that are only provided in current module) > * layouts (components for layout purpose only) > * modules (modules that are not relevant to routing) > All services of apis should be located at "src/app/services/" and provided in > root. Other non-api services should be located and provided in the > corresponding module scope. > For modules like task-manager and job-manager, use an injection token to > allow potential configuration object customizing/overriding individual > component/variable (e.g. rewrite a new chart node component and inject it > through the injection token), increasing these modules' reusability (also a > better DI practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (FLINK-25725) Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability
Junhan Yang created FLINK-25725: --- Summary: Refactor web-dashboard's folder structure and use Angular DI injection token for better reusability Key: FLINK-25725 URL: https://issues.apache.org/jira/browse/FLINK-25725 Project: Flink Issue Type: Technical Debt Components: Runtime / Web Frontend Reporter: Junhan Yang Use a fractal folder structure: * routers * services (services that are only provided in current module) * layouts (components for layout purpose only) * modules (modules that are not relevant to routing) All services of apis should be located at "src/app/services/" and provided in root. Other non-api services should be located and provided in the corresponding module scope. For modules like task-manager and job-manager, use an injection token to enable potential configuration object customizing/overriding of individual component/variable (e.g. rewrite a new chart node component and inject it through the injection token), increasing these modules' reusability (also a better DI practice). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (FLINK-25714) Remove @ant-design/icons-angular dependency once NG-ZORRO supports node v16.X
[
https://issues.apache.org/jira/browse/FLINK-25714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junhan Yang updated FLINK-25714:
Description:
{{@ant-design/icons-angular}} is a dependency for NG-ZORRO.
When I ran {{npm install}} under node v14.18.X, everything worked fine. But if
I ran the former command under node v16.10.X, {{@ant-design/icons-angular}} did
not install as expected. This may be caused by the fact that NG-ZORRO's
package.json engines field still uses {{{}^12.20.0 || ^14.0.0{}}}, missing
{{^16.0.0}} (according to [angular version
guide|https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3]).
We should remove this explicit dependency once NG-ZORRO fixes it.
Tracking issue: [https://github.com/NG-ZORRO/ng-zorro-antd/issues/7177]
was:
{{@ant-design/icons-angular}} is a dependency for NG-ZORRO.
When I ran {{npm install}} under node v14.18.X, everything worked fine. But if
I ran the former command under node v16.10.X, {{@ant-design/icons-angular}} did
not install as expected. This may be caused by the fact that NG-ZORRO's
package.json engines field still uses {{{}^12.20.0 || ^14.0.0{}}}, missing
{{^16.0.0}} (according to [angular version
guide|https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3]).
We should remove this explicit dependency once NG-ZORRO fixes it.
Tracking issue: https://github.com/NG-ZORRO/ng-zorro-antd/issues/7225
> Remove @ant-design/icons-angular dependency once NG-ZORRO supports node v16.X
> -
>
> Key: FLINK-25714
> URL: https://issues.apache.org/jira/browse/FLINK-25714
> Project: Flink
> Issue Type: Technical Debt
> Components: Runtime / Web Frontend
>Reporter: Junhan Yang
>Priority: Minor
>
> {{@ant-design/icons-angular}} is a dependency for NG-ZORRO.
> When I ran {{npm install}} under node v14.18.X, everything worked fine. But
> if I ran the former command under node v16.10.X,
> {{@ant-design/icons-angular}} did not install as expected. This may be caused
> by the fact that NG-ZORRO's package.json engines field still uses
> {{{}^12.20.0 || ^14.0.0{}}}, missing {{^16.0.0}} (according to [angular
> version
> guide|https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3]).
> We should remove this explicit dependency once NG-ZORRO fixes it.
>
> Tracking issue: [https://github.com/NG-ZORRO/ng-zorro-antd/issues/7177]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (FLINK-25714) Remove @ant-design/icons-angular dependency once NG-ZORRO supports node v16.X
Junhan Yang created FLINK-25714:
---
Summary: Remove @ant-design/icons-angular dependency once NG-ZORRO
supports node v16.X
Key: FLINK-25714
URL: https://issues.apache.org/jira/browse/FLINK-25714
Project: Flink
Issue Type: Technical Debt
Components: Runtime / Web Frontend
Reporter: Junhan Yang
{{@ant-design/icons-angular}} is a dependency for NG-ZORRO.
When I ran {{npm install}} under node v14.18.X, everything worked fine. But if
I ran the former command under node v16.10.X, {{@ant-design/icons-angular}} did
not install as expected. This may be caused by the fact that NG-ZORRO's
package.json engines field still uses {{{}^12.20.0 || ^14.0.0{}}}, missing
{{^16.0.0}} (according to [angular version
guide|https://gist.github.com/LayZeeDK/c822cc812f75bb07b7c55d07ba2719b3]).
We should remove this explicit dependency once NG-ZORRO fixes it.
Tracking issue: https://github.com/NG-ZORRO/ng-zorro-antd/issues/7225
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-25660) Failed to build flink-runtime-web
[
https://issues.apache.org/jira/browse/FLINK-25660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17476943#comment-17476943
]
Junhan Yang commented on FLINK-25660:
-
Please try remove flink-runtime-web/web-dashboard/node-modules folder, and run
`npm install` to install all dependencies all over again.
> Failed to build flink-runtime-web
> -
>
> Key: FLINK-25660
> URL: https://issues.apache.org/jira/browse/FLINK-25660
> Project: Flink
> Issue Type: Bug
>Reporter: Aitozi
>Priority: Major
>
> I clean up the local repo for org.apache.flink and rebuild the project. It
> fails at {{flink-runtime-web}}
> {code:java}
> Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:npm
> (npm install) on project flink-runtime-web: Failed to run task: 'npm ci
> --cache-max=0 --no-save' failed. org.apache.commons.exec.ExecuteException:
> Process exited with an error: 1 (Exit value: 1) -> [Help 1]{code}
> The debug log for it :
>
> {code:java}
> 166 verbose stack TypeError: Cannot read property 'resolve' of undefined166
> verbose stack at regFetch
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/npm-registry-fetch/index.js:76:23)166
> verbose stack at fromManifest
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/pacote/lib/fetchers/registry/tarball.js:55:3)166
> verbose stack at
> /Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/pacote/lib/fetchers/registry/tarball.js:38:25166
> verbose stack at tryCatcher
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/util.js:16:23)166
> verbose stack at Promise._settlePromiseFromHandler
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/promise.js:517:31)166
> verbose stack at Promise._settlePromise
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/promise.js:574:18)166
> verbose stack at Promise._settlePromiseCtx
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/promise.js:611:10)166
> verbose stack at _drainQueueStep
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/async.js:142:12)166
> verbose stack at _drainQueue
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/async.js:131:9)166
> verbose stack at Async._drainQueues
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/async.js:147:5)166
> verbose stack at Immediate.Async.drainQueues [as _onImmediate]
> (/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/node_modules/bluebird/js/release/async.js:17:14)166
> verbose stack at processImmediate (internal/timers.js:439:21)167 verbose
> cwd
> /Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard168
> verbose Darwin 20.6.0169 verbose argv
> "/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node"
>
> "/Users/aitozi/ant/work/code/community/flink-aitozi/flink/flink-runtime-web/web-dashboard/node/node_modules/npm/bin/npm-cli.js"
> "ci" "--cache-max=0" "--no-save"170 verbose node v12.14.1171 verbose npm
> v6.13.4172 error Cannot read property 'resolve' of undefined173 verbose exit
> [ 1, true ] {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (FLINK-24884) flink flame graph webui bug
[ https://issues.apache.org/jira/browse/FLINK-24884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442642#comment-17442642 ] Junhan Yang commented on FLINK-24884: - [~jackylau] [~airblader] , I believe this `tip` type is indeed a bug that causes the compiling failure. The reason we did not reproduce it was probably due to different tsconfig settings. > flink flame graph webui bug > --- > > Key: FLINK-24884 > URL: https://issues.apache.org/jira/browse/FLINK-24884 > Project: Flink > Issue Type: Bug > Components: Runtime / Web Frontend >Affects Versions: 1.14.0, 1.13.3 >Reporter: jackylau >Priority: Minor > Labels: pull-request-available > Attachments: image-2021-11-12-15-48-08-140.png > > > i can not compile success when i port the flame graph feature to our low > version of flink. > but it is success in the high version of flink > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438593#comment-17438593 ] Junhan Yang commented on FLINK-24737: - [~MartijnVisser] Unfortunately, I guess we have to wait until NG-Zorro to release their v13 to be compatible with Angular v13 :(. There are a few break changes in this recent Angular release. Therefore, I think I will update the dependencies to the latest safe versions for now. We can create an issue once NG-Zorro announces their release. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438578#comment-17438578 ] Junhan Yang commented on FLINK-24737: - [~MartijnVisser] By the way, Angular recently released their v13 which should make a significant improvement on building (68% according to their doc). Should I include this upgrade in this pull request as well? I am also happy to create another PR if you feel like this should be regarded as a separate issue. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-24737: Comment: was deleted (was: [~MartijnVisser] I am also happy to bump the Angular to v13 in a separate commit.) > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438561#comment-17438561 ] Junhan Yang edited comment on FLINK-24737 at 11/4/21, 9:14 AM: --- [~MartijnVisser] Sure, I will work on this as soon as I can. was (Author: junhany): [~MartijnVisser] Sure, I will work on this as soon as I can. By the way, Angular recently released their v13 which should make a significant improvement on building (68% according to their doc). Should I include this upgrade in this pull request as well? > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438575#comment-17438575 ] Junhan Yang edited comment on FLINK-24737 at 11/4/21, 9:10 AM: --- [~MartijnVisser] I am also happy to bump the Angular to v13 in a separate commit. was (Author: junhany): [~MartijnVisser] I am also happen to bump the Angular to v13 in a separate commit. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438575#comment-17438575 ] Junhan Yang commented on FLINK-24737: - [~MartijnVisser] I am also happen to bump the Angular to v13 in a separate commit. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438561#comment-17438561 ] Junhan Yang edited comment on FLINK-24737 at 11/4/21, 9:09 AM: --- [~MartijnVisser] Sure, I will work on this as soon as I can. By the way, Angular recently released their v13 which should make a significant improvement on building (68% according to their doc). Should I include this upgrade in this pull request as well? was (Author: junhany): [~MartijnVisser] Sure, I will work on this as soon as I can. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24737) Update outdated web dependencies in flink-runtime-web
[ https://issues.apache.org/jira/browse/FLINK-24737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438561#comment-17438561 ] Junhan Yang commented on FLINK-24737: - [~MartijnVisser] Sure, I will work on this as soon as I can. > Update outdated web dependencies in flink-runtime-web > - > > Key: FLINK-24737 > URL: https://issues.apache.org/jira/browse/FLINK-24737 > Project: Flink > Issue Type: Technical Debt >Affects Versions: 1.14.0 >Reporter: Martijn Visser >Priority: Major > Fix For: 1.15.0 > > > The flink-runtime-web/web-dashboard uses quite a number of outdated > dependencies. Some of them have reported vulnerabilities and it would be good > to resolve them. > Output of `ncu` at this moment on master: > | @angular-devkit/build-angular | ~12.1.3 | -> | 12.2.12 | > | @angular-eslint/builder| 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/eslint-plugin-template | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/schematics | 12.3.1 | -> | 12.6.1 | > | @angular-eslint/template-parser| 12.3.1 | -> | 12.6.1 | > | @angular/cli | ~12.1.3 | -> | 12.2.12 | > | @angular/compiler-cli | ~12.1.3 | -> | 12.2.12 | > | @angular/language-service | ~12.1.3 | -> | 12.2.12 | > | @types/d3 | ^5.7.1 | -> | ^7.1.0 | > | @types/dagre | ^0.7.41 | -> | ^0.7.46 | > | @types/jasmine | ~3.6.0 | -> | ~3.10.1 | > | @types/jasminewd2 | ~2.0.3 | -> | ~2.0.10 | > | @types/node| ^12.11.1 | -> | 16.11.6 | > | @typescript-eslint/eslint-plugin | 4.28.2 | -> | 5.3.0 | > | @typescript-eslint/parser | 4.28.2 | -> | 5.3.0 | > | eslint | ^7.26.0 | -> | ^8.1.0 | > | eslint-plugin-prettier | ^3.4.0 | -> | ^4.0.0 | > | eslint-plugin-unused-imports | ^1.1.4 | -> | ^1.1.5 | > | husky | ^1.3.1 | -> | ^7.0.4 | > | jasmine-core | ~3.8.0 | -> | ~3.10.1 | > | jasmine-spec-reporter | ~5.0.0 | -> | ~7.0.0 | > | karma | ~6.3.4 | -> | ~6.3.7 | > | karma-jasmine | ~4.0.0 | -> | ~4.0.1 | > | karma-jasmine-html-reporter| ^1.5.0 | -> | ^1.7.0 | > | lint-staged| ^11.1.2 | -> | ^11.2.6 | > | prettier | ^1.16.4 | -> | ^2.4.1 | > | stylelint | ^13.13.1 | -> | ^14.0.1 | > | stylelint-config-hudochenkov | ^5.0.0 | -> | ^6.0.1 | > | stylelint-config-prettier | ^8.0.2 | -> | ^9.0.3 | > | stylelint-config-standard | ^22.0.0 | -> | ^23.0.0 | > | stylelint-order| ^4.1.0 | -> | ^5.0.0 | > | ts-node| ~7.0.0 | -> | ~10.4.0 | > | typescript | ~4.3.5 | -> | ~4.4.4 | > | @angular/animations| ~12.1.3 | -> | 12.2.12 | > | @angular/common| ~12.1.3 | -> | 12.2.12 | > | @angular/compiler | ~12.1.3 | -> | 12.2.12 | > | @angular/core | ~12.1.3 | -> | 12.2.12 | > | @angular/forms | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser | ~12.1.3 | -> | 12.2.12 | > | @angular/platform-browser-dynamic | ~12.1.3 | -> | 12.2.12 | > | @angular/router| ~12.1.3 | -> | 12.2.12 | > | core-js| ^2.5.4 | -> | ^3.19.0 | > | d3 | ^5.9.1 | -> | ^7.1.1 | > | d3-flame-graph | ^4.0.6 | -> | ^4.1.1 | > | dagre | ^0.8.4 | -> | ^0.8.5 | > | monaco-editor | ^0.20.0 | -> | ^0.29.1 | > | rxjs | ^6.6.7 | -> | ^7.4.0 | > | tslib | ^2.0.0 | -> | ^2.3.1 | -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23990) Replace custom monaco editor component
[ https://issues.apache.org/jira/browse/FLINK-23990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17436726#comment-17436726 ] Junhan Yang commented on FLINK-23990: - Hey, [~airblader]. As we discussed earlier, I have replaced the old custom editor component with the one shipped in NG-Zorro. Some existing stylesheets are a bit messy and hard to maintain (not to mention unresponsive), so I have to re-define some of those to make the new editor work. With that being said, we may need an individual PR to improve the whole app's styles to make it more elegant and maintainable. > Replace custom monaco editor component > -- > > Key: FLINK-23990 > URL: https://issues.apache.org/jira/browse/FLINK-23990 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Affects Versions: 1.14.0 >Reporter: Ingo Bürk >Priority: Minor > Labels: pull-request-available > > After the upgrade to Angular 12 we should investigate if we can't replace the > custom flink-monaco-editor component by the one shipped with ng-zorro. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24629) Sorting start-time/duration/end-time not working under pages of vertex taskManagers and sub-tasks
[ https://issues.apache.org/jira/browse/FLINK-24629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433697#comment-17433697 ] Junhan Yang commented on FLINK-24629: - Hi, [~airblader]. I found a small bug regarding the Frontend Web after those PRs of bumping Angular & NG-Zorro. Nevertheless, the bug only affects the capability of sorting three columns, i.e. 'start-time', 'end-time' and 'duration'. > Sorting start-time/duration/end-time not working under pages of vertex > taskManagers and sub-tasks > - > > Key: FLINK-24629 > URL: https://issues.apache.org/jira/browse/FLINK-24629 > Project: Flink > Issue Type: Bug >Reporter: Junhan Yang >Priority: Major > Labels: pull-request-available > Attachments: image-2021-10-25-16-23-55-894.png > > > Based on the definitions of `VertexTaskManagerDetailInterface` and > `JobSubTaskInterface` interfaces, the sorting functions of start-time, > duration and end-time are incorrectly stated as `details.XXX`. > !image-2021-10-25-16-23-55-894.png|width=552,height=73! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-24629) Sorting start-time/duration/end-time not working under pages of vertex taskManagers and sub-tasks
Junhan Yang created FLINK-24629: --- Summary: Sorting start-time/duration/end-time not working under pages of vertex taskManagers and sub-tasks Key: FLINK-24629 URL: https://issues.apache.org/jira/browse/FLINK-24629 Project: Flink Issue Type: Bug Reporter: Junhan Yang Attachments: image-2021-10-25-16-23-55-894.png Based on the definitions of `VertexTaskManagerDetailInterface` and `JobSubTaskInterface` interfaces, the sorting functions of start-time, duration and end-time are incorrectly stated as `details.XXX`. !image-2021-10-25-16-23-55-894.png|width=552,height=73! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (FLINK-24320) Show in the Job / Checkpoints / Configuration if checkpoints are incremental
[ https://issues.apache.org/jira/browse/FLINK-24320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419530#comment-17419530 ] Junhan Yang edited comment on FLINK-24320 at 9/24/21, 2:50 AM: --- [~rmetzger] Hi, I found this request a little bit confusing. Do you mean putting the additional piece of information under `Job / Checkpoints / Configuration` or `Job / Checkpoints / Overview`(as mentioned in Description section)? Moreover, which value should we use from the 'config' API response? !image-2021-09-24-10-49-53-657.png|width=507,height=208! was (Author: junhany): [~rmetzger] Hi, I found this request a little bit confusing. Do you mean putting the additional piece of information under `Job / Checkpoints / Configuration` or `Job / Checkpoints / Overview`(as mentioned in Description section)? > Show in the Job / Checkpoints / Configuration if checkpoints are incremental > > > Key: FLINK-24320 > URL: https://issues.apache.org/jira/browse/FLINK-24320 > Project: Flink > Issue Type: Improvement > Components: Runtime / Checkpointing, Runtime / Web Frontend >Affects Versions: 1.13.2 >Reporter: Robert Metzger >Priority: Major > Labels: beginner-friendly > Attachments: image-2021-09-17-13-31-02-148.png, > image-2021-09-24-10-49-53-657.png > > > It would be nice if the overview would also show if incremental checkpoints > are enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24320) Show in the Job / Checkpoints / Configuration if checkpoints are incremental
[ https://issues.apache.org/jira/browse/FLINK-24320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17419530#comment-17419530 ] Junhan Yang commented on FLINK-24320: - [~rmetzger] Hi, I found this request a little bit confusing. Do you mean putting the additional piece of information under `Job / Checkpoints / Configuration` or `Job / Checkpoints / Overview`(as mentioned in Description section)? > Show in the Job / Checkpoints / Configuration if checkpoints are incremental > > > Key: FLINK-24320 > URL: https://issues.apache.org/jira/browse/FLINK-24320 > Project: Flink > Issue Type: Improvement > Components: Runtime / Checkpointing, Runtime / Web Frontend >Affects Versions: 1.13.2 >Reporter: Robert Metzger >Priority: Major > Labels: beginner-friendly > Attachments: image-2021-09-17-13-31-02-148.png > > > It would be nice if the overview would also show if incremental checkpoints > are enabled. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-24171) Formatting should be enforced for Flink UI
[ https://issues.apache.org/jira/browse/FLINK-24171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17418993#comment-17418993 ] Junhan Yang commented on FLINK-24171: - [~MartijnVisser] I'd love to. However, could you elaborate what exactly this tasking aims for? I previously added ESLint in combination with Prettier, so running "eslint --fix" (a mandatory pre-commit step) should format the TypeScript and HTML files accordingly. > Formatting should be enforced for Flink UI > -- > > Key: FLINK-24171 > URL: https://issues.apache.org/jira/browse/FLINK-24171 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Web Frontend >Reporter: Ingo Bürk >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23111) Update Angular
[ https://issues.apache.org/jira/browse/FLINK-23111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17387880#comment-17387880 ] Junhan Yang commented on FLINK-23111: - Hi, [~airblader]. I have created a [PR|https://github.com/apache/flink/pull/16603] which bumps Flink UI to v8 for both Angular and NG-Zorro. Please check it out and add your reviews when you have spare time. > Update Angular > -- > > Key: FLINK-23111 > URL: https://issues.apache.org/jira/browse/FLINK-23111 > Project: Flink > Issue Type: Sub-task > Components: Runtime / Web Frontend >Reporter: Ingo Bürk >Priority: Major > > Angular 7 (currently used by Flink UI) is already EOL. In order to stay up to > date with improvements to the framework, browser support, security and > dependencies, we need to update it to the latest version. > This also involves updating various dependencies like node, ng-zorro, > TypeScript, RxJs, … > > Note that updating across several major versions is not recommended. We > should do the update one-by-one for each version (e.g. one commit for each > update). Due to the lack of tests we need to make sure the UI works in all > areas afterwards, also visually. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23110) Modernize Flink UI
[ https://issues.apache.org/jira/browse/FLINK-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17385318#comment-17385318 ] Junhan Yang commented on FLINK-23110: - Sure thing. I will start working on this step-by-step upgrade as soon as I can. > Modernize Flink UI > -- > > Key: FLINK-23110 > URL: https://issues.apache.org/jira/browse/FLINK-23110 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Ingo Bürk >Priority: Major > > The current Flink UI has fallen out of a little bit into disrepair. It is > using Angular 7 (current version as of writing is 12) which has been EOL for > a while. With it, other dependencies (node, ng-zorro) have become out of date > as well, which also introduces vulnerabilities in various dependencies. > This issue is an umbrella issue to collect various tasks which should be done > in order to modernize Flink UI (again). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23110) Modernize Flink UI
[ https://issues.apache.org/jira/browse/FLINK-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367949#comment-17367949 ] Junhan Yang commented on FLINK-23110: - [~airblader] It would be better to wait for NG-ZORRO v12 in my opinion (since it will release soon), we can then complete the upgrade in one go. By the way, are you going to personally take part in this task? I can see there is quite a lot work to be done (especially e.g. migrating to eslint). > Modernize Flink UI > -- > > Key: FLINK-23110 > URL: https://issues.apache.org/jira/browse/FLINK-23110 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Ingo Bürk >Priority: Major > > The current Flink UI has fallen out of a little bit into disrepair. It is > using Angular 7 (current version as of writing is 12) which has been EOL for > a while. With it, other dependencies (node, ng-zorro) have become out of date > as well, which also introduces vulnerabilities in various dependencies. > This issue is an umbrella issue to collect various tasks which should be done > in order to modernize Flink UI (again). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-23110) Modernize Flink UI
[ https://issues.apache.org/jira/browse/FLINK-23110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367919#comment-17367919 ] Junhan Yang commented on FLINK-23110: - Hi, [~airblader], I am Junhan (Bruce), currently an active contributor of NG_ZORRO project, and I would like to offer my help for this task. As far as I know, NG_ZORRO dev team is planning to upgrade to v12 around Mid July. That would be a great opportunity to modernize Flink UI to the latest version. Anyway, please feel free to contact me if there are any sub-tasks unassigned. > Modernize Flink UI > -- > > Key: FLINK-23110 > URL: https://issues.apache.org/jira/browse/FLINK-23110 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Ingo Bürk >Priority: Major > > The current Flink UI has fallen out of a little bit into disrepair. It is > using Angular 7 (current version as of writing is 12) which has been EOL for > a while. With it, other dependencies (node, ng-zorro) have become out of date > as well, which also introduces vulnerabilities in various dependencies. > This issue is an umbrella issue to collect various tasks which should be done > in order to modernize Flink UI (again). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (FLINK-23056) flink docs sql builtin functions out of date
[ https://issues.apache.org/jira/browse/FLINK-23056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junhan Yang updated FLINK-23056: Description: !image-2021-06-21-16-44-27-117.png! Link: https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/functions/systemfunctions/ Functions `LAST_VALUE` and `FIRST_VALUE` should support multiple expressions as parameters was: !image-2021-06-21-16-44-27-117.png! Functions `LAST_VALUE` and `FIRST_VALUE` should support multiple expressions as parameters > flink docs sql builtin functions out of date > > > Key: FLINK-23056 > URL: https://issues.apache.org/jira/browse/FLINK-23056 > Project: Flink > Issue Type: Bug > Components: Documentation >Reporter: Junhan Yang >Priority: Minor > Attachments: image-2021-06-21-16-44-27-117.png > > > !image-2021-06-21-16-44-27-117.png! > Link: > https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/functions/systemfunctions/ > Functions `LAST_VALUE` and `FIRST_VALUE` should support multiple expressions > as parameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (FLINK-23056) flink docs sql builtin functions out of date
Junhan Yang created FLINK-23056: --- Summary: flink docs sql builtin functions out of date Key: FLINK-23056 URL: https://issues.apache.org/jira/browse/FLINK-23056 Project: Flink Issue Type: Bug Components: Documentation Reporter: Junhan Yang Attachments: image-2021-06-21-16-44-27-117.png !image-2021-06-21-16-44-27-117.png! Functions `LAST_VALUE` and `FIRST_VALUE` should support multiple expressions as parameters -- This message was sent by Atlassian Jira (v8.3.4#803005)
