[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724434#comment-17724434
 ] 

ASF GitHub Bot commented on MNG-7787:
-

rmannibucau commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1555335416

   Lets drop this code and mive it to help plugin
   Promise to be an issue in core happent so this impl failed, let's assume it




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] rmannibucau commented on pull request #1116: [MNG-7787] Introduce new options for plugin validation report

2023-05-19 Thread via GitHub


rmannibucau commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1555335416

   Lets drop this code and mive it to help plugin
   Promise to be an issue in core happent so this impl failed, let's assume it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724426#comment-17724426
 ] 

ASF GitHub Bot commented on MNG-7787:
-

hgschmie commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1555302832

   I very much disagree with your "my way or the highway" approach. There is a 
lot of criticism with the approach to "the purpose". Of course, you can just 
ram your approach through and hope for the best. It will not work, as the 
changes *will* break older builds that people do not update and you cause 
continuing pain for developers. People will be stuck on 3.9 forever because "it 
is the last version that supports that unmaintained foo plugin that I need for 
my build and can not move off" and grind their teeth. The answer will be "we 
move off maven", not "we fix that plugin". 




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724400#comment-17724400
 ] 

ASF GitHub Bot commented on MNG-7787:
-

cstamas commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1555194878

   -1 since, as nicely said on ML, it "defies the purpose".
   
   Stick to 3.8.x, if this is no go for you for any reason. 
   
   Goal is to fix issues all way down the pipe (like use of broken 
maven-plugin-plugin), and yes, not all core plugins are fixed, yet. Give us a 
bit more time, or hop in, never enough help in this area.




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] hgschmie opened a new pull request, #1116: [MNG-7787] Introduce new options for plugin validation report

2023-05-19 Thread via GitHub


hgschmie opened a new pull request, #1116:
URL: https://github.com/apache/maven/pull/1116

   - Make the default not emit any warnings.
   - replace the current default behavior with "SUMMARY"
   
   This restores the old pre-3.9.0 behavior re: deprecation warnings
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed
  for the change (usually before you start working on it).  Trivial 
changes like typos do not
  require a JIRA issue. Your pull request should address just this 
issue, without
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MNG-XXX] SUMMARY`,
  where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA 
issue.
- [X] Also format the first line of the commit message like `[MNG-XXX] 
SUMMARY`.
  Best practice is to use the JIRA issue title in both the pull request 
title and in the first line of the commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will
  be performed on your pull request automatically.
- [X] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] cstamas merged pull request #261: [MNG-7788] Fix for IT MavenITmng6562WarnDefaultBindings

2023-05-19 Thread via GitHub


cstamas merged PR #261:
URL: https://github.com/apache/maven-integration-testing/pull/261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] michael-o opened a new pull request, #635: Backport

2023-05-19 Thread via GitHub


michael-o opened a new pull request, #635:
URL: https://github.com/apache/maven-surefire/pull/635

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] cstamas opened a new pull request, #261: [MNG-7788] Fix for IT MavenITmng6562WarnDefaultBindings

2023-05-19 Thread via GitHub


cstamas opened a new pull request, #261:
URL: https://github.com/apache/maven-integration-testing/pull/261

   The MavenITmng6562WarnDefaultBindings IT tests new Maven4 feature "fail on 
severity" (for WARN level).
   
   The stub core plugin maven-resources-plugin depends on maven-compat, and it 
emits plugin validation warning.
   
   BEFORE MNG-7788 was merged, the warnings were logged AFTER build summary and 
was not picked up by "-fail on severity".
   
   AFTER MNG-7788 merged, it causes that warnings breaks the build, as "fail on 
severity" is set to WARN level.
   
   Fix:
   The stub maven-resources-plugin does NOT need to depend on maven-compat, 
what it really needs is maven-core (for MavenProject).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shared-utils] elharo merged pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

2023-05-19 Thread via GitHub


elharo merged PR #143:
URL: https://github.com/apache/maven-shared-utils/pull/143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shared-utils] elharo commented on pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

2023-05-19 Thread via GitHub


elharo commented on PR #143:
URL: 
https://github.com/apache/maven-shared-utils/pull/143#issuecomment-1554997552

   See https://hamcrest.org/JavaHamcrest/distributables for the detailed 
explanation.
   
   This is a weird case that crops up when using JUnit 4 with Hamcrest 2 
because Hamcrest moved classes around between artifacts in version 2. Without 
this JUnit 4 will pull hamcrest-core 1.4.x into the tree, which contains some 
of the same classes as org.hamcrest:hamcrest:2.2. This can cause split package 
issues. In 2.2 hamcrest-core is an empty jar to override this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] cstamas commented on pull request #1115: [MNG-7789] Dependency validation rules used wrong data

2023-05-19 Thread via GitHub


cstamas commented on PR #1115:
URL: https://github.com/apache/maven/pull/1115#issuecomment-1554993253

   This resolves my personal problem as well in really natural way: "plugin 
dependencies" are validated per-plugin level, while "plugin descriptor 
dependencies" were validated (and reported) per Mojo level, while it is plugin 
POM (so applicable to all Mojos within plugin) that may contains dependency 
problems, not standalone Mojos...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-417) Bump maven-source-plugin from 3.2.1 to 3.3.0

2023-05-19 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MPOM-417:


 Summary: Bump maven-source-plugin from 3.2.1 to 3.3.0
 Key: MPOM-417
 URL: https://issues.apache.org/jira/browse/MPOM-417
 Project: Maven POMs
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: ASF-30






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-417) Bump maven-source-plugin from 3.2.1 to 3.3.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-417:
-
Component/s: asf

> Bump maven-source-plugin from 3.2.1 to 3.3.0
> 
>
> Key: MPOM-417
> URL: https://issues.apache.org/jira/browse/MPOM-417
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-404) Bump maven-scm-plugin from 1.13.0 to 2.0.1

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-404:
-
Summary: Bump maven-scm-plugin from 1.13.0 to 2.0.1  (was: Bump 
maven-scm-plugin from 1.13.0 to 2.0.0)

> Bump maven-scm-plugin from 1.13.0 to 2.0.1
> --
>
> Key: MPOM-404
> URL: https://issues.apache.org/jira/browse/MPOM-404
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (MPOM-404) Bump maven-scm-plugin from 1.13.0 to 2.0.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reopened MPOM-404:
--

> Bump maven-scm-plugin from 1.13.0 to 2.0.0
> --
>
> Key: MPOM-404
> URL: https://issues.apache.org/jira/browse/MPOM-404
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas opened a new pull request, #1115: [MNG-7789] Dependency validation rules used wrong data

2023-05-19 Thread via GitHub


cstamas opened a new pull request, #1115:
URL: https://github.com/apache/maven/pull/1115

   Refactored and now split, we have "plugin dependency" (using POM) and 
"plugin descriptor" (using PluginDescriptor/dependencies) to perform validation.
   
   Also, two "inlined" validation from plugin dependencies resolver factored 
out to components, along with 3 existing moved to newly added (moved) 
validators.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Assigned] (MPOM-344) Update maven-remote-resources-plugin to 3.1.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MPOM-344:


Assignee: Slawomir Jaranowski

> Update maven-remote-resources-plugin to 3.1.0
> -
>
> Key: MPOM-344
> URL: https://issues.apache.org/jira/browse/MPOM-344
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Sylwester Lachiewicz
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-405) Bump maven.plugin.tools.version from 3.7.0 to 3.9.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-405:
-
Summary: Bump maven.plugin.tools.version from 3.7.0 to 3.9.0  (was: Bump 
maven.plugin.tools.version from 3.7.0 to 3.8.2)

> Bump maven.plugin.tools.version from 3.7.0 to 3.9.0
> ---
>
> Key: MPOM-405
> URL: https://issues.apache.org/jira/browse/MPOM-405
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (MPOM-405) Bump maven.plugin.tools.version from 3.7.0 to 3.8.2

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reopened MPOM-405:
--

> Bump maven.plugin.tools.version from 3.7.0 to 3.8.2
> ---
>
> Key: MPOM-405
> URL: https://issues.apache.org/jira/browse/MPOM-405
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-406) Bump surefire/failsafe version from 2.22.2 to 3.1.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-406:
-
Summary: Bump surefire/failsafe version from 2.22.2 to 3.1.0  (was: Bump 
surefire/failsafe version from 2.22.2 to 3.0.0)

> Bump surefire/failsafe version from 2.22.2 to 3.1.0
> ---
>
> Key: MPOM-406
> URL: https://issues.apache.org/jira/browse/MPOM-406
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (MPOM-388) Upgrade Maven Dependency Plugin from 3.4.0 to 3.6.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reopened MPOM-388:
--

> Upgrade Maven Dependency Plugin from 3.4.0 to 3.6.0
> ---
>
> Key: MPOM-388
> URL: https://issues.apache.org/jira/browse/MPOM-388
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-388) Upgrade Maven Dependency Plugin from 3.4.0 to 3.6.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-388:
-
Summary: Upgrade Maven Dependency Plugin from 3.4.0 to 3.6.0  (was: Upgrade 
Maven Dependency Plugin from 3.6.0)

> Upgrade Maven Dependency Plugin from 3.4.0 to 3.6.0
> ---
>
> Key: MPOM-388
> URL: https://issues.apache.org/jira/browse/MPOM-388
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-388) Upgrade Maven Dependency Plugin from 3.6.0

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-388:
-
Summary: Upgrade Maven Dependency Plugin from 3.6.0  (was: Upgrade to Maven 
Dependency Plugin 3.5.0)

> Upgrade Maven Dependency Plugin from 3.6.0
> --
>
> Key: MPOM-388
> URL: https://issues.apache.org/jira/browse/MPOM-388
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MNG-7789) Plugin Dependency Validations use wrong data set

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7789:


Assignee: Tamas Cservenak

> Plugin Dependency Validations use wrong data set
> 
>
> Key: MNG-7789
> URL: https://issues.apache.org/jira/browse/MNG-7789
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> They all use pluginDescriptor/dependencies, that are NOT used to calculate 
> plugin dependencies, POM is. Except for one new check (the one added in 
> MNG-7786) the others should be refactored to use POM instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas merged pull request #1114: [MNG-7788] Plugin Validation Report logged before summary

2023-05-19 Thread via GitHub


cstamas merged PR #1114:
URL: https://github.com/apache/maven/pull/1114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7789) Plugin Dependency Validations use wrong data set

2023-05-19 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7789:


 Summary: Plugin Dependency Validations use wrong data set
 Key: MNG-7789
 URL: https://issues.apache.org/jira/browse/MNG-7789
 Project: Maven
  Issue Type: Improvement
  Components: Plugins and Lifecycle
Affects Versions: 3.9.2
Reporter: Tamas Cservenak
 Fix For: 3.9.3


They all use pluginDescriptor/dependencies, that are NOT used to calculate 
plugin dependencies, POM is. Except for one new check (the one added in 
MNG-7786) the others should be refactored to use POM instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas merged pull request #1112: [MNG-7786] Fix plugin validation misleading message

2023-05-19 Thread via GitHub


cstamas merged PR #1112:
URL: https://github.com/apache/maven/pull/1112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (SUREFIRE-2163) customBundle properly not subject to basedir alignment

2023-05-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed SUREFIRE-2163.

Resolution: Fixed

Fixed with 
[f9592108a83bff52b94e6455ce732fb2fad2600a|https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=f9592108a83bff52b94e6455ce732fb2fad2600a].

> customBundle properly not subject to basedir alignment
> --
>
> Key: SUREFIRE-2163
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2163
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Report Plugin
>Affects Versions: 3.1.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.1.1
>
>
> With SUREFIRE-2160 {{customBundle}} has been introduced, but the value refers 
> to a relative value which is in many situations in correct. It is never 
> aligned to the project's basedir. This value must b absolute with the 
> {{basedir}} property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (SUREFIRE-2163) customBundle properly not subject to basedir alignment

2023-05-19 Thread Michael Osipov (Jira)
Michael Osipov created SUREFIRE-2163:


 Summary: customBundle properly not subject to basedir alignment
 Key: SUREFIRE-2163
 URL: https://issues.apache.org/jira/browse/SUREFIRE-2163
 Project: Maven Surefire
  Issue Type: Bug
  Components: Maven Surefire Report Plugin
Affects Versions: 3.1.0
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.1.1


With SUREFIRE-2160 {{customBundle}} has been introduced, but the value refers 
to a relative value which is in many situations in correct. It is never aligned 
to the project's basedir. This value must b absolute with the {{basedir}} 
property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-checkstyle-plugin] gmshake commented on pull request #76: [MCHECKSTYLE-412] - Exclude generated sources / test-sources from defau…

2023-05-19 Thread via GitHub


gmshake commented on PR #76:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/76#issuecomment-1554682430

   > Anyone want to resolve conflicts and merge? This would be useful. 
   
   I'll rebase it at this weekend.
   
   I do not have write access to the Apache repository so I'll leave the merge 
to someone who's capable to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEP-862) warns about depending on plexus-container-default

2023-05-19 Thread Tamas Cservenak (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724290#comment-17724290
 ] 

Tamas Cservenak commented on MDEP-862:
--

Fixed by change:

https://github.com/apache/maven-dependency-plugin/commit/2992497b4fdce17c55a51ee8a47419e2925d962f

> warns about depending on plexus-container-default
> -
>
> Key: MDEP-862
> URL: https://issues.apache.org/jira/browse/MDEP-862
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.9.2 
> (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c)
> Maven home: /mnt/c/users/sellersj/Downloads/apache-maven-3.9.2
> Java version: 17.0.6, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-17-openjdk-amd64
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "5.10.16.3-microsoft-standard-wsl2", arch: 
> "amd64", family: "unix"
>Reporter: Jim Sellers
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.0
>
>
> When using 3.9.2 it warns about using plexus-container-default
> {code:title=sample command, path to maven specific}
> ~/Downloads/apache-maven-3.9.2/bin/mvn -V -B --lax-checksums 
> org.apache.maven.plugins:maven-dependency-plugin:RELEASE:unpack
> -Dtransitive=false -DoutputDirectory=. -Dmdep.stripVersion=true 
> -Dartifact="org.apache.maven:apache-maven:3.9.2:zip:bin" 
> -Dmaven.plugin.validation=VERBOSE
> {code}
> {code:title=sample warning}
> [WARNING]
> [WARNING] Plugin validation issues were detected in 1 plugin(s)
> [WARNING]
> [WARNING]  * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
> [WARNING]   Declared at location(s):
> [WARNING]* unknown
> [WARNING]   Used in module(s):
> [WARNING]* org.apache.maven:standalone-pom:1
> [WARNING]   Plugin issue(s):
> [WARNING]* Plugin depends on plexus-container-default, which is EOL
> [WARNING]
> [WARNING]
> [WARNING] Fix reported issues by adjusting plugin configuration or by 
> upgrading above listed plugins. If no upgrade available, please notify plugin 
> maintainers about reported issues.
> [WARNING] For more or less details, use 'maven.plugin.validation' property 
> with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
> [WARNING]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MDEP-867) Upgrade plugins in ITs

2023-05-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MDEP-867.
---
Resolution: Fixed

Fixed with 
[6ccca01bfbf634796d243227da3b0f09ef257240|https://gitbox.apache.org/repos/asf?p=maven-dependency-plugin.git;a=commit;h=6ccca01bfbf634796d243227da3b0f09ef257240].

> Upgrade plugins in ITs
> --
>
> Key: MDEP-867
> URL: https://issues.apache.org/jira/browse/MDEP-867
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.0
>
>
> * Upgrade to Maven Compiler Plugin 3.11.0
> * Upgrade to Maven Enforcer Plugin 3.3.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7787:
-
Fix Version/s: 4.0.0-alpha-6
   4.0.0

> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7788) Plugin Validation Report should be printed before build summary

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7788:
-
Fix Version/s: 4.0.0-alpha-6
   4.0.0

> Plugin Validation Report should be printed before build summary
> ---
>
> Key: MNG-7788
> URL: https://issues.apache.org/jira/browse/MNG-7788
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> The (possibly lengthy) plugin validation report is logged out AFTER the build 
> result, and it makes it hard to figure did build succeed or not (as verbose 
> report may be several pages).
> Make the report output happen BEFORE the build result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7786) Maven Plugin Validation message is misleading

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7786:
-
Fix Version/s: 4.0.0-alpha-6
   4.0.0

> Maven Plugin Validation message is misleading
> -
>
> Key: MNG-7786
> URL: https://issues.apache.org/jira/browse/MNG-7786
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>
> The Maven artifact scope validation is misleading, it claims "... should 
> declare in provided scope", and this may happen in this case:
>  * perfectly valid POM (does declare Maven artifacts in provided scope)
>  * but plugin developer uses problematic maven-plugin-plugin (ie. 3.6.2 that 
> suffers from descriptor generation bug)
> Proposal:
>  * reword the message, to clearly point at "plugin descriptor contains bad 
> entries..."
>  * add new check that _actually checks plugin dependencies_ (and not 
> "derived" descriptor dependencies that may differ from POM declared ones due 
> m-p-p bug)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MNG-7788) Plugin Validation Report should be printed before build summary

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7788:


Assignee: Tamas Cservenak

> Plugin Validation Report should be printed before build summary
> ---
>
> Key: MNG-7788
> URL: https://issues.apache.org/jira/browse/MNG-7788
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> The (possibly lengthy) plugin validation report is logged out AFTER the build 
> result, and it makes it hard to figure did build succeed or not (as verbose 
> report may be several pages).
> Make the report output happen BEFORE the build result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7787:


Assignee: Tamas Cservenak

> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas commented on pull request #1114: [MNG-7788] Plugin Validation Report logged before summary

2023-05-19 Thread via GitHub


cstamas commented on PR #1114:
URL: https://github.com/apache/maven/pull/1114#issuecomment-1554616650

   Example of "before" and "after" outputs: 
https://gist.github.com/cstamas/7c9bddbf4e8d96cdd9b73670d878e997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7788) Plugin Validation Report should be printed before build summary

2023-05-19 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7788:


 Summary: Plugin Validation Report should be printed before build 
summary
 Key: MNG-7788
 URL: https://issues.apache.org/jira/browse/MNG-7788
 Project: Maven
  Issue Type: Improvement
  Components: Plugins and Lifecycle
Affects Versions: 3.9.2
Reporter: Tamas Cservenak
 Fix For: 3.9.3


The (possibly lengthy) plugin validation report is logged out AFTER the build 
result, and it makes it hard to figure did build succeed or not (as verbose 
report may be several pages).

Make the report output happen BEFORE the build result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-867) Upgrade plugins in ITs

2023-05-19 Thread Michael Osipov (Jira)
Michael Osipov created MDEP-867:
---

 Summary: Upgrade plugins in ITs
 Key: MDEP-867
 URL: https://issues.apache.org/jira/browse/MDEP-867
 Project: Maven Dependency Plugin
  Issue Type: Dependency upgrade
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.6.0


* Upgrade to Maven Compiler Plugin 3.11.0
* Upgrade to Maven Enforcer Plugin 3.3.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MDEP-866) Refresh download page

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MDEP-866.

Resolution: Fixed

> Refresh download page
> -
>
> Key: MDEP-866
> URL: https://issues.apache.org/jira/browse/MDEP-866
> Project: Maven Dependency Plugin
>  Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MDEP-862) warns about depending on plexus-container-default

2023-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MDEP-862.

Resolution: Fixed

> warns about depending on plexus-container-default
> -
>
> Key: MDEP-862
> URL: https://issues.apache.org/jira/browse/MDEP-862
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.9.2 
> (c9616018c7a021c1c39be70fb2843d6f5f9b8a1c)
> Maven home: /mnt/c/users/sellersj/Downloads/apache-maven-3.9.2
> Java version: 17.0.6, vendor: Private Build, runtime: 
> /usr/lib/jvm/java-17-openjdk-amd64
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "5.10.16.3-microsoft-standard-wsl2", arch: 
> "amd64", family: "unix"
>Reporter: Jim Sellers
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.0
>
>
> When using 3.9.2 it warns about using plexus-container-default
> {code:title=sample command, path to maven specific}
> ~/Downloads/apache-maven-3.9.2/bin/mvn -V -B --lax-checksums 
> org.apache.maven.plugins:maven-dependency-plugin:RELEASE:unpack
> -Dtransitive=false -DoutputDirectory=. -Dmdep.stripVersion=true 
> -Dartifact="org.apache.maven:apache-maven:3.9.2:zip:bin" 
> -Dmaven.plugin.validation=VERBOSE
> {code}
> {code:title=sample warning}
> [WARNING]
> [WARNING] Plugin validation issues were detected in 1 plugin(s)
> [WARNING]
> [WARNING]  * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
> [WARNING]   Declared at location(s):
> [WARNING]* unknown
> [WARNING]   Used in module(s):
> [WARNING]* org.apache.maven:standalone-pom:1
> [WARNING]   Plugin issue(s):
> [WARNING]* Plugin depends on plexus-container-default, which is EOL
> [WARNING]
> [WARNING]
> [WARNING] Fix reported issues by adjusting plugin configuration or by 
> upgrading above listed plugins. If no upgrade available, please notify plugin 
> maintainers about reported issues.
> [WARNING] For more or less details, use 'maven.plugin.validation' property 
> with one of the values (case insensitive): [BRIEF, DEFAULT, VERBOSE]
> [WARNING]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #320: [MDEP-862] Get rid of plexus-container-default from dependencies

2023-05-19 Thread via GitHub


slawekjaranowski merged PR #320:
URL: https://github.com/apache/maven-dependency-plugin/pull/320


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOURCES-298) Resources Mojo implements Contextuilizable from Plexus Container which ist EOL

2023-05-19 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOURCES-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724283#comment-17724283
 ] 

Slawomir Jaranowski commented on MRESOURCES-298:


Please use the latest version of plugin - was fixed in MRESOURCES-295

> Resources Mojo implements Contextuilizable from Plexus Container which ist EOL
> --
>
> Key: MRESOURCES-298
> URL: https://issues.apache.org/jira/browse/MRESOURCES-298
> Project: Maven Resources Plugin
>  Issue Type: Dependency upgrade
>Reporter: Manuel s
>Priority: Major
>
> Using maven-resources-plugin:3.3.0 with latest maven 3.9.2 and calling in a 
> consele with "mvn -Dmaven.plugin.validation=VERBOSE" produces next warnings 
> and seems like ist not ready for next Maven 4:
>  
> org.apache.maven.plugins:maven-resources-plugin:3.3.0
> [WARNING]   Declared at location(s):
> [WARNING]    * org.apache.maven:maven-core:3.9.2:default-lifecycle-bindings @ 
> line -1
> [WARNING]   Used in module(s):
> [WARNING]    * -SNAPSHOT (XX\pom.xml)
> [WARNING]    * XX-SNAPSHOT (XX\pom.xml)
> [WARNING]    * YY-SNAPSHOT (YY\pom.xml)
> [WARNING]    * ZZ-SNAPSHOT (ZZ\pom.xml)
> [WARNING]    * ZZ-SNAPSHOT (ZZ\pom.xml)
> [WARNING]   Mojo issue(s):
> [WARNING]    * Mojo resources:resources 
> (org.apache.maven.plugins.resources.ResourcesMojo)
> [WARNING]      - Implements `Contextualizable` interface from Plexus 
> Container, which is EOL.
> [WARNING]    * Mojo resources:testResources 
> (org.apache.maven.plugins.resources.TestResourcesMojo)
> [WARNING]      - Implements `Contextualizable` interface from Plexus 
> Container, which is EOL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-shared-utils] michael-o commented on pull request #143: [MSHARED-1255] use dependencyManagement to set hamcrest-core version

2023-05-19 Thread via GitHub


michael-o commented on PR #143:
URL: 
https://github.com/apache/maven-shared-utils/pull/143#issuecomment-1554589464

   I don't understand this. If a direct dep uses the wrong version then there 
is the place to fix? Or do we have a conflict in trans deps here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSHARED-1255) Do something about Hamcrest

2023-05-19 Thread Elliotte Rusty Harold (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliotte Rusty Harold updated MSHARED-1255:
---
Component/s: maven-shared-utils

> Do something about Hamcrest
> ---
>
> Key: MSHARED-1255
> URL: https://issues.apache.org/jira/browse/MSHARED-1255
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer, maven-shared-utils
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> Currently there's a weird situation with Hamcrest deps that the dependency 
> analyzer doesn't truly grok and which leads to false positive warnings like:
> [WARNING] Unused declared dependencies found:
> [WARNING]org.hamcrest:hamcrest-core:jar:2.2:test
> This happens in maven-shared-utils for intance.
> This is a result of moving classes between artifacts from version 1 to 2, and 
> appears when JUnit 4 is used and thus an older version of hamcrest-core gets 
> pulled in unless the empty org.hamcrest:hamcrest-core:jar:2.2 is added:
> https://hamcrest.org/JavaHamcrest/distributables 
> Options:
> 1. special case this one
> 2. Notice when a dependency appears unused but does upgrade a version lower 
> in the tree
> 3. use dependency management instead to upgrade hamcrest-core?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] michael-o commented on pull request #186: [MRELEASE-1123] Fix for Maven 4

2023-05-19 Thread via GitHub


michael-o commented on PR #186:
URL: https://github.com/apache/maven-release/pull/186#issuecomment-1554577536

   > > @nielsbasjes, can you verify this on your end as well?
   > 
   > I installed Apache Maven 4.0.0-alpha-5. I installed this branch of the 
maven-release plugin locally (using maven 4). I then updated the dependency of 
maven-release-plugin in my project 
https://github.com/nielsbasjes/conventional-commits-maven-release and ran all 
the tests and integration tests.
   > 
   > All of this worked fine for me (except for my project having a few minor 
things that are not maven 4 compatible).
   > 
   > So from my end this all looks good.
   
   Thanks, this is good news!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MRESOURCES-298) Resources Mojo implements Contextuilizable from Plexus Container which ist EOL

2023-05-19 Thread Manuel s (Jira)
Manuel s created MRESOURCES-298:
---

 Summary: Resources Mojo implements Contextuilizable from Plexus 
Container which ist EOL
 Key: MRESOURCES-298
 URL: https://issues.apache.org/jira/browse/MRESOURCES-298
 Project: Maven Resources Plugin
  Issue Type: Dependency upgrade
Reporter: Manuel s


Using maven-resources-plugin:3.3.0 with latest maven 3.9.2 and calling in a 
consele with "mvn -Dmaven.plugin.validation=VERBOSE" produces next warnings and 
seems like ist not ready for next Maven 4:

 

org.apache.maven.plugins:maven-resources-plugin:3.3.0
[WARNING]   Declared at location(s):
[WARNING]    * org.apache.maven:maven-core:3.9.2:default-lifecycle-bindings @ 
line -1
[WARNING]   Used in module(s):
[WARNING]    * -SNAPSHOT (XX\pom.xml)
[WARNING]    * XX-SNAPSHOT (XX\pom.xml)
[WARNING]    * YY-SNAPSHOT (YY\pom.xml)
[WARNING]    * ZZ-SNAPSHOT (ZZ\pom.xml)
[WARNING]    * ZZ-SNAPSHOT (ZZ\pom.xml)
[WARNING]   Mojo issue(s):
[WARNING]    * Mojo resources:resources 
(org.apache.maven.plugins.resources.ResourcesMojo)
[WARNING]      - Implements `Contextualizable` interface from Plexus Container, 
which is EOL.
[WARNING]    * Mojo resources:testResources 
(org.apache.maven.plugins.resources.TestResourcesMojo)
[WARNING]      - Implements `Contextualizable` interface from Plexus Container, 
which is EOL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] nielsbasjes commented on pull request #186: [MRELEASE-1123] Fix for Maven 4

2023-05-19 Thread via GitHub


nielsbasjes commented on PR #186:
URL: https://github.com/apache/maven-release/pull/186#issuecomment-1554556174

   > @nielsbasjes, can you verify this on your end as well?
   
   I installed Apache Maven 4.0.0-alpha-5.
   I installed this branch of the maven-release plugin locally (using maven 4).
   I then updated the dependency of maven-release-plugin  in my project 
https://github.com/nielsbasjes/conventional-commits-maven-release and ran all 
the tests and integration tests.
   
   All of this worked fine for me (except for my project having a few minor 
things that are not maven 4 compatible).
   
   So from my end this all looks good.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPMD-379) Support PMD 7.0.0

2023-05-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724267#comment-17724267
 ] 

Michael Osipov commented on MPMD-379:
-

If this is not a compatible change it should wait for the next major which I 
want to release in the summer.

> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
>  Issue Type: Improvement
>  Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.21.1
>
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7 
> most likely means, that only PMD 7 will be supported onwards (no backwards 
> compatibility supported).
> wip branch: https://github.com/apache/maven-pmd-plugin/compare/master...pmd7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-19 Thread via GitHub


michael-o commented on PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1554537755

   > > I will fix and simplify the javaVersionFormat variable. It does not 
print versions "1.0" and "1.1".
   > > 
https://github.com/apache/maven-project-info-reports-plugin/blob/9209a7a175041ba1b2e6902f6f2dbb247a96529d/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java#L94
   > 
   > This confuses me:
   > 
   > * There is no Java 1.0 here: 
https://github.com/apache/maven-shared-jar/blob/3cd1e4d7060bba0b378c2f3bcb5bd00037b299dc/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java#L59-L81
   > 
   > * Looking at the output of the `full-pom` IT it prints 1.1 as expected.
   > 
   > 
   > Can you elaborate?
   > 
   > PS: I will double check.
   
   @belingueres, you were partially right. Though, I tested with a loop, still 
missed. Fixed with `1.1` by making the range inclusive. 1.0 is not printed as 
noted in the link. Does this resolve the issue for you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MPMD-367) Verify / ubuntu-latest jdk-11-temurin 3.9.1 broken at head in MPMD-270-325-JDK11

2023-05-19 Thread Andreas Dangel (Jira)


 [ 
https://issues.apache.org/jira/browse/MPMD-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel updated MPMD-367:

Fix Version/s: 3.21.0

> Verify / ubuntu-latest jdk-11-temurin 3.9.1 broken at head in 
> MPMD-270-325-JDK11
> 
>
> Key: MPMD-367
> URL: https://issues.apache.org/jira/browse/MPMD-367
> Project: Maven PMD Plugin
>  Issue Type: Task
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.21.0
>
>
> Problem seems to be that this test produces a WARNING on this platform (and 
> only this platform?) that fails the build
> {noformat}
> 317 kB at 5.4 MB/s)
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 2 source files to 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/target/classes
> [INFO] 
> [INFO] --- resources:3.3.0:testResources (default-testResources) @ 
> MPMD-270-325-JDK11 ---
> [INFO] skip non existing resourceDirectory 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/src/test/resources
> [INFO] 
> [INFO] --- compiler:3.8.0:testCompile (default-testCompile) @ 
> MPMD-270-325-JDK11 ---
> [INFO] No sources to compile
> [INFO] 
> [INFO] --- surefire:3.0.0:test (default-test) @ MPMD-270-325-JDK11 ---
> [INFO] No tests to run.
> [INFO] 
> [INFO] --- jar:3.3.0:jar (default-jar) @ MPMD-270-325-JDK11 ---
> [INFO] Building jar: 
> /home/runner/work/maven-pmd-plugin/maven-pmd-plugin/target/it/MPMD-270-325-JDK11/target/MPMD-270-325-JDK11-1.0-SNAPSHOT.jar
> [INFO] 
> [INFO] >>> pmd:3.21.0-SNAPSHOT:check (default) > :pmd @ MPMD-270-325-JDK11 >>>
> [INFO] 
> [INFO] --- pmd:3.21.0-SNAPSHOT:pmd (pmd) @ MPMD-270-325-JDK11 ---
> [WARNING] Parameter \'localRepository\' is deprecated core expression; Avoid 
> use of ArtifactRepository type. If you need access to local repository, 
> switch to \'${repositorySystemSession}\' expression and get LRM from it 
> instead.
> [INFO] PMD version: 6.55.0
> [INFO] Rendering content with 
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [INFO] 
> [INFO] <<< pmd:3.21.0-SNAPSHOT:check (default) < :pmd @ MPMD-270-325-JDK11 <<<
> [INFO] 
> [INFO] 
> [INFO] --- pmd:3.21.0-SNAPSHOT:check (default) @ MPMD-270-325-JDK11 ---
> [INFO] PMD version: 6.55.0
> [INFO] PMD Failure: com.mycompany.app.Foo:26 Rule:UnusedFormalParameter 
> Priority:3 Avoid unused constructor parameters such as \'foo\'..
> [INFO] 
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPMD-366) Update parent pom to 39

2023-05-19 Thread Andreas Dangel (Jira)


 [ 
https://issues.apache.org/jira/browse/MPMD-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel updated MPMD-366:

Fix Version/s: 3.21.0

> Update parent pom to 39
> ---
>
> Key: MPMD-366
> URL: https://issues.apache.org/jira/browse/MPMD-366
> Project: Maven PMD Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.21.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-19 Thread via GitHub


michael-o commented on PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1554517512

   > I will fix and simplify the javaVersionFormat variable. It does not print 
versions "1.0" and "1.1".
   > 
   > 
https://github.com/apache/maven-project-info-reports-plugin/blob/9209a7a175041ba1b2e6902f6f2dbb247a96529d/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java#L94
   
   This confuses me:
   * There is no Java 1.0 here: 
https://github.com/apache/maven-shared-jar/blob/3cd1e4d7060bba0b378c2f3bcb5bd00037b299dc/src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java#L59-L81
   * Looking at the output of the `full-pom` IT it prints 1.1 as expected.
   
   Can you elaborate?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724240#comment-17724240
 ] 

Slawomir Jaranowski commented on MNG-7787:
--

Something between DEFAULT and VERBOSE will be useful, list plugin and problems 
but without locations.


> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas opened a new pull request, #1113: [MNG-7787] Introduce new options for plugin validation report

2023-05-19 Thread via GitHub


cstamas opened a new pull request, #1113:
URL: https://github.com/apache/maven/pull/1113

   Added NONE and INLINE modes.
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7787
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-7785) Clean usage of SessionData

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7785:
-
Component/s: Core

> Clean usage of SessionData
> --
>
> Key: MNG-7785
> URL: https://issues.apache.org/jira/browse/MNG-7785
> Project: Maven
>  Issue Type: Improvement
>  Components: Core
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.0-alpha-6, 4.0.0, 3.9.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7787:
-
Component/s: Plugins and Lifecycle
 (was: Core)

> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7786) Maven Plugin Validation message is misleading

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak updated MNG-7786:
-
Component/s: Plugins and Lifecycle
 (was: Core)

> Maven Plugin Validation message is misleading
> -
>
> Key: MNG-7786
> URL: https://issues.apache.org/jira/browse/MNG-7786
> Project: Maven
>  Issue Type: Bug
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> The Maven artifact scope validation is misleading, it claims "... should 
> declare in provided scope", and this may happen in this case:
>  * perfectly valid POM (does declare Maven artifacts in provided scope)
>  * but plugin developer uses problematic maven-plugin-plugin (ie. 3.6.2 that 
> suffers from descriptor generation bug)
> Proposal:
>  * reword the message, to clearly point at "plugin descriptor contains bad 
> entries..."
>  * add new check that _actually checks plugin dependencies_ (and not 
> "derived" descriptor dependencies that may differ from POM declared ones due 
> m-p-p bug)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7787) Introduce new options for plugin validation

2023-05-19 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7787:


 Summary: Introduce new options for plugin validation
 Key: MNG-7787
 URL: https://issues.apache.org/jira/browse/MNG-7787
 Project: Maven
  Issue Type: Improvement
  Components: Core
Affects Versions: 3.9.2
Reporter: Tamas Cservenak
 Fix For: 3.9.3


Currently we offer following values for maven.plugin.validation:
 * BRIEF - emits one liner WARN with count of plugins having validation issues 
(IF count > 0)
 * DEFAULT - emits one line for each plugin GAV having validation issues
 * VERBOSE - emits detailed report for each plugin (declaration, use and 
problems) for each plugin having validation issue

We should introduce more:
 * NONE - mute validation (usable on CI where plethora of WARNING lines could 
lead to falsely detect build as unhealthy)
 * INLINE - produce validation WARNs inline, as 3.9.1 did

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MPMD-379) Support PMD 7.0.0

2023-05-19 Thread Andreas Dangel (Jira)
Andreas Dangel created MPMD-379:
---

 Summary: Support PMD 7.0.0
 Key: MPMD-379
 URL: https://issues.apache.org/jira/browse/MPMD-379
 Project: Maven PMD Plugin
  Issue Type: Improvement
  Components: CPD, PMD
Reporter: Andreas Dangel
Assignee: Andreas Dangel
 Fix For: 3.21.1


Add support for the new major version of PMD.

This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7 most 
likely means, that only PMD 7 will be supported onwards (no backwards 
compatibility supported).

wip branch: https://github.com/apache/maven-pmd-plugin/compare/master...pmd7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MNG-7786) Maven Plugin Validation message is misleading

2023-05-19 Thread Tamas Cservenak (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tamas Cservenak reassigned MNG-7786:


Assignee: Tamas Cservenak

> Maven Plugin Validation message is misleading
> -
>
> Key: MNG-7786
> URL: https://issues.apache.org/jira/browse/MNG-7786
> Project: Maven
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3
>
>
> The Maven artifact scope validation is misleading, it claims "... should 
> declare in provided scope", and this may happen in this case:
>  * perfectly valid POM (does declare Maven artifacts in provided scope)
>  * but plugin developer uses problematic maven-plugin-plugin (ie. 3.6.2 that 
> suffers from descriptor generation bug)
> Proposal:
>  * reword the message, to clearly point at "plugin descriptor contains bad 
> entries..."
>  * add new check that _actually checks plugin dependencies_ (and not 
> "derived" descriptor dependencies that may differ from POM declared ones due 
> m-p-p bug)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] cstamas opened a new pull request, #1112: [MNG-7786] Fix plugin validation misleading message

2023-05-19 Thread via GitHub


cstamas opened a new pull request, #1112:
URL: https://github.com/apache/maven/pull/1112

   Reword the validation warning and add new check for real plugin dependencies 
in wrong scopes (do not rely on build-time derived descriptor, but on real data 
instead).
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7786
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7786) Maven Plugin Validation message is misleading

2023-05-19 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-7786:


 Summary: Maven Plugin Validation message is misleading
 Key: MNG-7786
 URL: https://issues.apache.org/jira/browse/MNG-7786
 Project: Maven
  Issue Type: Bug
  Components: Core
Affects Versions: 3.9.2
Reporter: Tamas Cservenak
 Fix For: 3.9.3


The Maven artifact scope validation is misleading, it claims "... should 
declare in provided scope", and this may happen in this case:
 * perfectly valid POM (does declare Maven artifacts in provided scope)
 * but plugin developer uses problematic maven-plugin-plugin (ie. 3.6.2 that 
suffers from descriptor generation bug)

Proposal:
 * reword the message, to clearly point at "plugin descriptor contains bad 
entries..."
 * add new check that _actually checks plugin dependencies_ (and not "derived" 
descriptor dependencies that may differ from POM declared ones due m-p-p bug)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MRELEASE-1114) Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6

2023-05-19 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724152#comment-17724152
 ] 

Herve Boutemy edited comment on MRELEASE-1114 at 5/19/23 6:52 AM:
--

FTR MRELEASE-1091 reverted

I confirm it works perfectly: thanks [~sjaranowski] , both for the fix and for 
the easy to use reproducer command that permits checking any released or 
not-released m-release-p


was (Author: hboutemy):
FTR MRELEASE-1091 reverted

> Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
> 
>
> Key: MRELEASE-1114
> URL: https://issues.apache.org/jira/browse/MRELEASE-1114
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6, 3.0.0-M7, 3.0.0
>Reporter: Falko Modler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.1
>
>
> Before [https://github.com/apache/maven-release/pull/125], when gpg-plugin 
> runs, it triggered the cert password prompt window of Kleopatra but now it 
> fails right away with {{{}no pinentry{}}}.
> {noformat}
> [INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
> [INFO] gpg: signing failed: No pinentry
> [INFO] gpg: signing failed: No pinentry
> [INFO] [INFO] 
> 
> [INFO] [INFO] BUILD FAILURE
> [INFO] [INFO] 
> 
> [INFO] [INFO] Total time:  1.130 s
> [INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
> [INFO] [INFO] 
> 
> [INFO] [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts) 
> on project mrelease-1114: Exit code: 2 -> [Help 1]
> [INFO] [ERROR] 
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with 
> the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR] 
> [INFO] [ERROR] For more information about the errors and possible solutions, 
> please read the following articles:
> [INFO] [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.622 s
> [INFO] Finished at: 2023-05-03T02:54:16+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on 
> project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
> {noformat}
> See also 
> [https://github.com/apache/maven-release/pull/125#issuecomment-1160398620] 
> and the following comments.
> h2. WORKAROUND
> init the GPG agent:
> - with Maven: {{mvn gpg:sign}}
> - or more basically in pure shell: {{echo "test" | gpg --clearsign}}
> then you can run {{mvn release:perform}} again and it will be successful 
> (it's perfectly supported by maven-release-plugin to retry the perform step)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] slawekjaranowski commented on pull request #189: [MRELEASE-1114] Restore interactive mode for forked process

2023-05-19 Thread via GitHub


slawekjaranowski commented on PR #189:
URL: https://github.com/apache/maven-release/pull/189#issuecomment-1554089525

   > FTR: this reverts #125 / 
https://issues.apache.org/jira/browse/MRELEASE-1091
   
   exactly - after fix in m-shared-utils we can revert #125 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRELEASE-1114) Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6

2023-05-19 Thread Herve Boutemy (Jira)


[ 
https://issues.apache.org/jira/browse/MRELEASE-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724152#comment-17724152
 ] 

Herve Boutemy commented on MRELEASE-1114:
-

FTR MRELEASE-1091 reverted

> Broken interaction of maven-gpg-plugin with Gpg4win Kleopatra since 3.0.0-M6
> 
>
> Key: MRELEASE-1114
> URL: https://issues.apache.org/jira/browse/MRELEASE-1114
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6, 3.0.0-M7, 3.0.0
>Reporter: Falko Modler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.1
>
>
> Before [https://github.com/apache/maven-release/pull/125], when gpg-plugin 
> runs, it triggered the cert password prompt window of Kleopatra but now it 
> fails right away with {{{}no pinentry{}}}.
> {noformat}
> [INFO] [INFO] --- gpg:3.0.1:sign (sign-release-artifacts) @ mrelease-1114 ---
> [INFO] gpg: signing failed: No pinentry
> [INFO] gpg: signing failed: No pinentry
> [INFO] [INFO] 
> 
> [INFO] [INFO] BUILD FAILURE
> [INFO] [INFO] 
> 
> [INFO] [INFO] Total time:  1.130 s
> [INFO] [INFO] Finished at: 2023-05-03T02:47:31+02:00
> [INFO] [INFO] 
> 
> [INFO] [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-gpg-plugin:3.0.1:sign (sign-release-artifacts) 
> on project mrelease-1114: Exit code: 2 -> [Help 1]
> [INFO] [ERROR] 
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with 
> the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR] 
> [INFO] [ERROR] For more information about the errors and possible solutions, 
> please read the following articles:
> [INFO] [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.622 s
> [INFO] Finished at: 2023-05-03T02:54:16+02:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-release-plugin:3.0.0:perform (default-cli) on 
> project mrelease-1114: Maven execution failed, exit code: 1 -> [Help 1]
> {noformat}
> See also 
> [https://github.com/apache/maven-release/pull/125#issuecomment-1160398620] 
> and the following comments.
> h2. WORKAROUND
> init the GPG agent:
> - with Maven: {{mvn gpg:sign}}
> - or more basically in pure shell: {{echo "test" | gpg --clearsign}}
> then you can run {{mvn release:perform}} again and it will be successful 
> (it's perfectly supported by maven-release-plugin to retry the perform step)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] hboutemy commented on pull request #189: [MRELEASE-1114] Restore interactive mode for forked process

2023-05-19 Thread via GitHub


hboutemy commented on PR #189:
URL: https://github.com/apache/maven-release/pull/189#issuecomment-1554085590

   FTR: this reverts #125 / https://issues.apache.org/jira/browse/MRELEASE-1091
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MENFORCER-426) DependencyConvergence in 3.1.0 fails when using version ranges

2023-05-19 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MENFORCER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724136#comment-17724136
 ] 

Slawomir Jaranowski commented on MENFORCER-426:
---

I fixed my reproduce test to execute only on Maven 3.9.2 and we see that is ok.

> DependencyConvergence in 3.1.0 fails when using version ranges
> --
>
> Key: MENFORCER-426
> URL: https://issues.apache.org/jira/browse/MENFORCER-426
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Standard Rules
>Affects Versions: 3.0.0, 3.1.0
>Reporter: Joe Barnett
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> In our project, using version 3.0.0-M3 of the maven-enforcer-plugin's 
> DependencyConvergence rule passes.  Using version 3.1.0 starts to show 
> convergence errors that I believe may be related to using version ranges to 
> declare dependencies:
> {code:java}
> [WARNING] 
> Dependency convergence error for com.trib3:graphql:jar:1.32.3279:compile 
> paths to dependency are:
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
>   +-com.joe.quizzy:graphql:jar:1.0-SNAPSHOT:compile
> +-com.trib3:graphql:jar:1.32.3279:compile
> and
> +-com.joe.quizzy:server:jar:1.0-SNAPSHOT
>   +-com.trib3:graphql:jar:1.32.3324:compile
> {code}
> both {{com.joe.quizzy:server}} and {{com.joe.quizzy:graphql}} declare a 
> dependency on {{com.trib3:graphql}}, with a version of 
> {{[1.32.1,1.33-SNAPSHOT)}}.  that version range should (currently) resolve to 
> 1.32.3324 in both usages, but in enforcer 3.1.0's DependencyConvergence check 
> does not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)