date:20230521

[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request, #146: Bump zstd-jni from 1.5.5-2 to 1.5.5-3

2023-05-21 Thread via GitHub



dependabot[bot] opened a new pull request, #146:
URL: https://github.com/apache/maven-assembly-plugin/pull/146

   Bumps [zstd-jni](https://github.com/luben/zstd-jni) from 1.5.5-2 to 1.5.5-3.
   
   Commits
   
   https://github.com/luben/zstd-jni/commit/709ffb54352a27e6e731d0adb11585c808552bfb;>709ffb5
 v1.5.5-3
   https://github.com/luben/zstd-jni/commit/253adafe345917b1221b2b285bb92def1e38d2af;>253adaf
 Take another approach for the dict trainer min samples
   https://github.com/luben/zstd-jni/commit/8b24ff0b23819ad9b15a22464a810431e8243882;>8b24ff0
 Throw exception if the dict trainer was called with low number of samples
   https://github.com/luben/zstd-jni/commit/d0997dbed982499c923ee68e48cb49a63a53f334;>d0997db
 Add support for multiple dictionary references in streaming decompression.
   https://github.com/luben/zstd-jni/commit/100c434dfcec17a865ca2c2b844afe1046ce1b10;>100c434
 Relax the requirement for source and target ByteBuffer in 
ZstdBufferDecompres...
   See full diff in https://github.com/luben/zstd-jni/compare/v1.5.5-2...v1.5.5-3;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.luben:zstd-jni=maven=1.5.5-2=1.5.5-3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-surefire] michael-o opened a new pull request, #637: Use simple String#valueOf() to convert a float to a string

2023-05-21 Thread via GitHub



michael-o opened a new pull request, #637:
URL: https://github.com/apache/maven-surefire/pull/637

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
install`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724729#comment-17724729
 ] 

ASF GitHub Bot commented on MPIR-431:
-

belingueres commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199875668


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
 }
 } else {
 tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(), 
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""

Review Comment:
   I'll fix it



##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
 private void createExceptionInfoTableRow(Artifact artifact, File 
artifactFile, Exception e, boolean hasSealed) {
 tableRow(
 hasSealed,
-new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});

Review Comment:
   I'll fix it





> Dependency file details section: segregate Java version column into execution 
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
>  Issue Type: Improvement
>  Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution 
> versus the minimum java version for building the project, divide the "Java 
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime, 
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-project-info-reports-plugin] belingueres commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-21 Thread via GitHub



belingueres commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199875668


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
 }
 } else {
 tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(), 
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""

Review Comment:
   I'll fix it



##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
 private void createExceptionInfoTableRow(Artifact artifact, File 
artifactFile, Exception e, boolean hasSealed) {
 tableRow(
 hasSealed,
-new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});

Review Comment:
   I'll fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724724#comment-17724724
 ] 

ASF GitHub Bot commented on MNG-7787:
-

hgschmie commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556327009

   @slawekjaranowski This is all about warnings being actionable.
   
   this is what the Jdbi build tells me right now:
   
   ```
   [WARNING] Plugin validation issues were detected in 11 plugin(s)
   [WARNING]
   [WARNING]  * org.apache.maven.plugins:maven-source-plugin:3.2.1
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 865
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-settings-builder:3.0, 
org.apache.maven:maven-repository-metadata:3.0, 
org.apache.maven:maven-artifact:3.0, org.apache.maven:maven-plugin-api:3.0, 
org.apache.maven:maven-settings:3.0, org.apache.maven:maven-aether-p
   rovider:3.0, org.apache.maven:maven-model:3.0, 
org.apache.maven:maven-core:3.0, org.apache.maven:maven-model-builder:3.0]
   [WARNING]
   [WARNING]  * io.github.git-commit-id:git-commit-id-maven-plugin:5.0.0
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 812
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-aether-provider:3.1.0-alpha-1, 
org.apache.maven:maven-settings:3.1.0-alpha-1, 
org.apache.maven:maven-settings-builder:3.1.0-alpha-1, 
org.apache.maven:maven-core:3.1.0-alpha-1, 
org.apache.maven:maven-model-builder:3
   .1.0-alpha-1, org.apache.maven:maven-model:3.1.0-alpha-1, 
org.apache.maven:maven-artifact:3.1.0-alpha-1, 
org.apache.maven:maven-repository-metadata:3.1.0-alpha-1, 
org.apache.maven:maven-plugin-api:3.1.0-alpha-1]
   [WARNING]
   [WARNING]  * org.jacoco:jacoco-maven-plugin:0.8.10
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 1013
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin is a Maven 2.x plugin, which will be not supported in 
Maven 4.x
   [WARNING]* Plugin mixes multiple Maven versions: [3.0, 2.0.2]
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-repository-metadata:3.0, 
org.apache.maven:maven-artifact:3.0]
   [WARNING]* Plugin depends on plexus-container-default, which is EOL
   [WARNING]
   [WARNING]  * com.hubspot.maven.plugins:dependency-scope-maven-plugin:0.10
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 943
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-core:3.3.3, 
org.apache.maven:maven-model-builder:3.3.3, 
org.apache.maven:maven-plugin-api:3.3.3, org.apache.maven:maven-model:3.3.3, 
org.apache.maven:maven-builder-support:3.3.3, 
org.apache.maven:maven-settings:3.3.3, 
org.apache.maven:maven-aether-provider:3.3.3, 
org.apache.maven:maven-settings-builder:3.3.3, 
org.apache.maven:maven-repository-metadata:3.3.3, 
org.apache.maven:maven-artifact:3.3.3]
   [WARNING]
   [WARNING]  * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 899
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin depends on plexus-container-default, which is EOL
   [WARNING]   Mojo issue(s):
   [WARNING]* Mojo dependency:analyze-only 
(org.apache.maven.plugins.dependency.analyze.AnalyzeOnlyMojo)
   [WARNING]  - Implements `Contextualizable`

[GitHub] [maven] hgschmie commented on pull request #1116: [MNG-7787] Introduce new options for plugin validation report

2023-05-21 Thread via GitHub



hgschmie commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556327009

   @slawekjaranowski This is all about warnings being actionable.
   
   this is what the Jdbi build tells me right now:
   
   ```
   [WARNING] Plugin validation issues were detected in 11 plugin(s)
   [WARNING]
   [WARNING]  * org.apache.maven.plugins:maven-source-plugin:3.2.1
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 865
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-settings-builder:3.0, 
org.apache.maven:maven-repository-metadata:3.0, 
org.apache.maven:maven-artifact:3.0, org.apache.maven:maven-plugin-api:3.0, 
org.apache.maven:maven-settings:3.0, org.apache.maven:maven-aether-p
   rovider:3.0, org.apache.maven:maven-model:3.0, 
org.apache.maven:maven-core:3.0, org.apache.maven:maven-model-builder:3.0]
   [WARNING]
   [WARNING]  * io.github.git-commit-id:git-commit-id-maven-plugin:5.0.0
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 812
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-aether-provider:3.1.0-alpha-1, 
org.apache.maven:maven-settings:3.1.0-alpha-1, 
org.apache.maven:maven-settings-builder:3.1.0-alpha-1, 
org.apache.maven:maven-core:3.1.0-alpha-1, 
org.apache.maven:maven-model-builder:3
   .1.0-alpha-1, org.apache.maven:maven-model:3.1.0-alpha-1, 
org.apache.maven:maven-artifact:3.1.0-alpha-1, 
org.apache.maven:maven-repository-metadata:3.1.0-alpha-1, 
org.apache.maven:maven-plugin-api:3.1.0-alpha-1]
   [WARNING]
   [WARNING]  * org.jacoco:jacoco-maven-plugin:0.8.10
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 1013
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (pom.xml)
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin is a Maven 2.x plugin, which will be not supported in 
Maven 4.x
   [WARNING]* Plugin mixes multiple Maven versions: [3.0, 2.0.2]
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-repository-metadata:3.0, 
org.apache.maven:maven-artifact:3.0]
   [WARNING]* Plugin depends on plexus-container-default, which is EOL
   [WARNING]
   [WARNING]  * com.hubspot.maven.plugins:dependency-scope-maven-plugin:0.10
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 943
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin should declare these Maven artifacts in `provided` 
scope: [org.apache.maven:maven-core:3.3.3, 
org.apache.maven:maven-model-builder:3.3.3, 
org.apache.maven:maven-plugin-api:3.3.3, org.apache.maven:maven-model:3.3.3, 
org.apache.maven:maven-builder-support:3.3.3, 
org.apache.maven:maven-settings:3.3.3, 
org.apache.maven:maven-aether-provider:3.3.3, 
org.apache.maven:maven-settings-builder:3.3.3, 
org.apache.maven:maven-repository-metadata:3.3.3, 
org.apache.maven:maven-artifact:3.3.3]
   [WARNING]
   [WARNING]  * org.apache.maven.plugins:maven-dependency-plugin:3.5.0
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT 
(/Users/henning/.m2/repository/org/basepom/basepom-foundation/54-SNAPSHOT/basepom-foundation-54-SNAPSHOT.pom)
 @ line 899
   [WARNING]   Used in module(s):
   [WARNING]* org.jdbi:jdbi3-core:3.38.3-SNAPSHOT (target/new-pom.xml)
   [WARNING]   Plugin issue(s):
   [WARNING]* Plugin depends on plexus-container-default, which is EOL
   [WARNING]   Mojo issue(s):
   [WARNING]* Mojo dependency:analyze-only 
(org.apache.maven.plugins.dependency.analyze.AnalyzeOnlyMojo)
   [WARNING]  - Implements `Contextualizable` interface from Plexus 
Container, which is EOL.
   [WARNING]
   [WARNING]  * org.basepom.maven:property-helper-maven-plugin:3.0
   [WARNING]   Declared at location(s):
   [WARNING]* org.basepom:basepom-foundation:54-SNAPSHOT

[jira] [Commented] (MCHECKSTYLE-407) Maven Site + Surefire + Checkstyle fails to build

2023-05-21 Thread Nas Kavian (Jira)



[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724718#comment-17724718
 ] 

Nas Kavian commented on MCHECKSTYLE-407:


Thanks for following up.

I figured out today one of the issues. I changed 

 
{code:java}
                        
                            **/*IntegrationTest.java
                        
                        
                            **/*Test.java
                         {code}
to

 

 
{code:java}
                        **/*IntegrationTest.java
                        **/*Test.java {code}
Although this configuration change was in the checkstyle section, it was 
contingent on the surefire version.

 

Apparently this was okay in maven-surefire-plugin 2.22.1 but the behavior 
changed when upgrading to 3.X.

The last remaining issue is about code coverage. Version 3.0.0-M4 of the plugin 
produces the expected output in the coverage report, but version 3.0.0-M5 shows 
all code coverage as 0%. I tried to spend time trimming down the project but 
it's a challenge. Are you able to debug between versions M4 and M5 or are you 
blocked without a sample project?

> Maven Site + Surefire + Checkstyle fails to build
> -
>
> Key: MCHECKSTYLE-407
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-407
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>  Components: checkstyle:check
>Affects Versions: 3.1.2
> Environment: Apache Maven 3.8.1 
> (05c21c65bdfed0f71a2f2ada8b84da59348c4c5d)
> Maven home: /usr/local/Cellar/maven/3.8.1/libexec
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime: 
> /Library/Java/JavaVirtualMachines/jdk1.8.0_241.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.14.6", arch: "x86_64", family: "mac"
>Reporter: Nas Kavian
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Summary:
>  * when I use checkstyle with phase=validate, `mvn site` works.
>  * when I use checkstyle with phase=test, `mvn site` fails with an error:
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on 
> project payments-web: failed to get report for 
> org.apache.maven.plugins:maven-surefire-report-plugin: Failed to execute goal 
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (default) on 
> project payments-web: Unable to parse configuration of mojo 
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check: Basic element 
> 'excludes' must not contain child elements
> The checkstyle configuration looks like this:
>                 
>                     org.apache.maven.plugins
>                     maven-checkstyle-plugin
>                     3.1.2
>                     
>                         
>                             test
>                             
>                                 check
>                             
>                         
>                     
>                 
>  
> The surefire configuration looks like this:
>                 
>                     org.apache.maven.plugins
>                     maven-surefire-plugin
>                     3.0.0-M5
>                     
>                         
>                             ${exclude.tests}
>                         
>                         ${tests}
>                         
>                             **/*Test.java
>                         
>                     
>                 
>  
> The error about "excludes" is referring to the "excludes" in the surefire 
> plugin.
>  
> This is a partial stacktrace:
>  
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-site-plugin:3.9.1:site (default-site) on 
> project payments-web: failed to get report for 
> org.apache.maven.plugins:maven-surefire-report-plugin
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
>     at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> ...
> ...
> Caused by: org.apache.maven.plugin.MojoExecutionException: failed to get 
> report for org.apache.maven.plugins:maven-surefire-report-plugin
>     at 
> org.apache.maven.reporting.exec.DefaultMavenReportExecutor.buildMavenReports 
> (DefaultMavenReportExecutor.java:159)
>     at 
> org.apache.maven.plugins.site.render.AbstractSiteRenderingMojo.getReports 
> (AbstractSiteRenderingMojo.java:226)
> ...
> ...
> Caused by: org.apache.maven.lifecycle.LifecycleExecutionException: Failed to 
> execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check 
> (default) on project payments-web: Unable to parse configuration of mojo 
>

[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724712#comment-17724712
 ] 

ASF GitHub Bot commented on MPIR-431:
-

michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199821656


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -607,25 +608,76 @@ private void renderSectionDependencyFileDetails() {
 justification[0] = Sink.JUSTIFY_RIGHT;
 justification[6] = Sink.JUSTIFY_RIGHT;
 
-for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
-if (totaldeps.getTotal(i) > 0) {
-tableRow(hasSealed, new String[] {
-totaldeps.getTotalString(i),
-totaldepsize.getTotalString(i),
-totalentries.getTotalString(i),
-totalclasses.getTotalString(i),
-totalpackages.getTotalString(i),
-(i < 0) ? javaVersionFormat.format(new Object[] 
{highestJavaVersion}) : "",
-totalDebugInformation.getTotalString(i),
-totalsealed.getTotalString(i)
-});
+// calculate rowspan attr
+int rowspan = computeRowspan(totaldeps);
+
+if (rowspan > 1) {
+boolean insertRowspanAttr = false;
+int column = 5; // Java Version's column
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+boolean alreadyInsertedRowspanAttr = insertRowspanAttr && 
(0 < i && i < 4);
+insertRowspanAttr = (0 <= i && i < 4);
+justification[column] = (insertRowspanAttr && 
alreadyInsertedRowspanAttr)
+? justification[column + 1]
+: Sink.JUSTIFY_CENTER;
+tableRowWithRowspan(
+hasSealed, insertRowspanAttr, 
alreadyInsertedRowspanAttr, column, rowspan, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i, 
highestTestJavaVersion, highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
+}
+} else {
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+tableRow(hasSealed, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i, highestTestJavaVersion, 
highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
 }
 }
 
 endTable();
 endSection();
 }
 
+private int computeRowspan(TotalCell totaldeps) {
+int rowspan = 0;
+for (int i = 0; i < TotalCell.SCOPES_COUNT - 1; i++) {
+if (totaldeps.getTotal(i) > 0) {
+rowspan++;
+}
+}
+return rowspan;
+}
+
+private String formatMaxVersionForScope(

Review Comment:
   Let's make this `formatMaxJavaVersionForScope`





> Dependency file details section: segregate Java version column into execution 
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
>  Issue Type: Improvement
>  Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution 
> versus the minimum java version for building the project, divide the "Java 
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime, 
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.



--
This message was sent by Atlassian Jira

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-21 Thread via GitHub



michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199821656


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -607,25 +608,76 @@ private void renderSectionDependencyFileDetails() {
 justification[0] = Sink.JUSTIFY_RIGHT;
 justification[6] = Sink.JUSTIFY_RIGHT;
 
-for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
-if (totaldeps.getTotal(i) > 0) {
-tableRow(hasSealed, new String[] {
-totaldeps.getTotalString(i),
-totaldepsize.getTotalString(i),
-totalentries.getTotalString(i),
-totalclasses.getTotalString(i),
-totalpackages.getTotalString(i),
-(i < 0) ? javaVersionFormat.format(new Object[] 
{highestJavaVersion}) : "",
-totalDebugInformation.getTotalString(i),
-totalsealed.getTotalString(i)
-});
+// calculate rowspan attr
+int rowspan = computeRowspan(totaldeps);
+
+if (rowspan > 1) {
+boolean insertRowspanAttr = false;
+int column = 5; // Java Version's column
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+boolean alreadyInsertedRowspanAttr = insertRowspanAttr && 
(0 < i && i < 4);
+insertRowspanAttr = (0 <= i && i < 4);
+justification[column] = (insertRowspanAttr && 
alreadyInsertedRowspanAttr)
+? justification[column + 1]
+: Sink.JUSTIFY_CENTER;
+tableRowWithRowspan(
+hasSealed, insertRowspanAttr, 
alreadyInsertedRowspanAttr, column, rowspan, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i, 
highestTestJavaVersion, highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
+}
+} else {
+for (int i = -1; i < TotalCell.SCOPES_COUNT; i++) {
+if (totaldeps.getTotal(i) > 0) {
+tableRow(hasSealed, new String[] {
+totaldeps.getTotalString(i),
+totaldepsize.getTotalString(i),
+totalentries.getTotalString(i),
+totalclasses.getTotalString(i),
+totalpackages.getTotalString(i),
+formatMaxVersionForScope(i, highestTestJavaVersion, 
highestNonTestJavaVersion),
+totalDebugInformation.getTotalString(i),
+totalsealed.getTotalString(i)
+});
+}
 }
 }
 
 endTable();
 endSection();
 }
 
+private int computeRowspan(TotalCell totaldeps) {
+int rowspan = 0;
+for (int i = 0; i < TotalCell.SCOPES_COUNT - 1; i++) {
+if (totaldeps.getTotal(i) > 0) {
+rowspan++;
+}
+}
+return rowspan;
+}
+
+private String formatMaxVersionForScope(

Review Comment:
   Let's make this `formatMaxJavaVersionForScope`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724710#comment-17724710
 ] 

ASF GitHub Bot commented on MPIR-431:
-

michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820872


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
 private void createExceptionInfoTableRow(Artifact artifact, File 
artifactFile, Exception e, boolean hasSealed) {
 tableRow(
 hasSealed,
-new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});

Review Comment:
   Here as well





> Dependency file details section: segregate Java version column into execution 
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
>  Issue Type: Improvement
>  Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution 
> versus the minimum java version for building the project, divide the "Java 
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime, 
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-21 Thread via GitHub



michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820872


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -674,7 +750,7 @@ private void tableRow(boolean fullRow, String[] content) {
 private void createExceptionInfoTableRow(Artifact artifact, File 
artifactFile, Exception e, boolean hasSealed) {
 tableRow(
 hasSealed,
-new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", "", ""});
+new String[] {artifact.getId(), 
artifactFile.getAbsolutePath(), e.getMessage(), "", "", "", ""});

Review Comment:
   Here as well



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MPIR-431) Dependency file details section: segregate Java version column into execution and test versions

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MPIR-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724709#comment-17724709
 ] 

ASF GitHub Bot commented on MPIR-431:
-

michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820627


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
 }
 } else {
 tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(), 
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""

Review Comment:
   Why is one column gone here?





> Dependency file details section: segregate Java version column into execution 
> and test versions
> ---
>
> Key: MPIR-431
> URL: https://issues.apache.org/jira/browse/MPIR-431
> Project: Maven Project Info Reports Plugin
>  Issue Type: Improvement
>  Components: dependencies
>Reporter: Gabriel Belingueres
>Assignee: Michael Osipov
>Priority: Minor
>
> In order to easily spot which is the minimum java version for execution 
> versus the minimum java version for building the project, divide the "Java 
> version" column into two columns:
> Java version: max version between dependencies with scopes: compile, runtime, 
> provided, system.
> Test Java version: max java version between all the test scoped dependencies.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-project-info-reports-plugin] michael-o commented on a diff in pull request #47: [MPIR-431] Dependency file details section: segregate Java version

2023-05-21 Thread via GitHub



michael-o commented on code in PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#discussion_r1199820627


##
src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java:
##
@@ -588,14 +596,7 @@ private void renderSectionDependencyFileDetails() {
 }
 } else {
 tableRow(hasSealed, new String[] {
-artifactFile.getName(),
-fileLengthDecimalFormat.format(artifactFile.length()),
-"",
-"",
-"",
-"",
-"",
-""
+artifactFile.getName(), 
fileLengthDecimalFormat.format(artifactFile.length()), "", "", "", "", ""

Review Comment:
   Why is one column gone here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-mvnd] ppalaga opened a new pull request, #850: {@link } JavaDoc refs missing in the output of mvnd --help

2023-05-21 Thread via GitHub



ppalaga opened a new pull request, #850:
URL: https://github.com/apache/maven-mvnd/pull/850

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (MNG-7790) Update lifecycle plugins

2023-05-21 Thread Tamas Cservenak (Jira)

Tamas Cservenak created MNG-7790:


 Summary: Update lifecycle plugins
 Key: MNG-7790
 URL: https://issues.apache.org/jira/browse/MNG-7790
 Project: Maven
  Issue Type: Task
  Components: Plugins and Lifecycle
Reporter: Tamas Cservenak
 Fix For: 3.9.3






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Closed] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MWAR-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MWAR-463.

Resolution: Fixed

> Upgrade Parent to 39
> 
>
> Key: MWAR-463
> URL: https://issues.apache.org/jira/browse/MWAR-463
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWAR-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724704#comment-17724704
 ] 

ASF GitHub Bot commented on MWAR-463:
-

slawekjaranowski merged PR #50:
URL: https://github.com/apache/maven-war-plugin/pull/50




> Upgrade Parent to 39
> 
>
> Key: MWAR-463
> URL: https://issues.apache.org/jira/browse/MWAR-463
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-site] hboutemy merged pull request #421: add documentation on additional content published in repositories

2023-05-21 Thread via GitHub



hboutemy merged PR #421:
URL: https://github.com/apache/maven-site/pull/421


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gpg-plugin] elharo commented on pull request #51: javadoc nits

2023-05-21 Thread via GitHub



elharo commented on PR #51:
URL: https://github.com/apache/maven-gpg-plugin/pull/51#issuecomment-1556169482

   Verify / Verify / windows-latest jdk-8-temurin 3.9.2 (push)  is broken:
   
   ```
   Error:  Failures: 
   Error:GpgSignArtifactIT.testPlacementOfArtifactInOutputDirectory:98 
   Expected: ["sign-release-in-default-dir-1.0.jar.asc"] in any order
but: no item matches: "sign-release-in-default-dir-1.0.jar.asc" in []
   Error:GpgSignArtifactIT.testPlacementOfArtifactInOutputDirectory:98 
   Expected: ["sign-release-in-output-dir-1.0.jar.asc"] in any order
but: no item matches: "sign-release-in-output-dir-1.0.jar.asc" in []
   Error:GpgSignArtifactIT.testPlacementOfArtifactInOutputDirectory:98 
   Expected: ["sign-release-in-root-dir-1.0.jar.asc"] in any order
but: no item matches: "sign-release-in-root-dir-1.0.jar.asc" in []
   Error:GpgSignArtifactIT.testPlacementOfArtifactInOutputDirectory:98 
   Expected: ["sign-release-in-same-dir-1.0.jar", 
"sign-release-in-same-dir-1.0.jar.asc"] in any order
but: no item matches: "sign-release-in-same-dir-1.0.jar.asc" in 
["sign-release-in-same-dir-1.0.jar"]
   Error:GpgSignAttachedMojoIT.testInteractiveWithoutPassphrase:64 Maven 
execution failed because no pinentry program is available
   Expected: a string containing "[GNUPG:] FAILURE sign 67108949"
but: was "[DEBUG] Using maven.home of: 
'C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.2-bin\3238cb54\apache-maven-3.9.2'.
   [DEBUG] Executing: cmd.exe /X /C 
"C:\Users\runneradmin\.m2\wrapper\dists\apache-maven-3.9.2-bin\3238cb54\apache-maven-3.9.2\bin\mvn.cmd
 -X -V -D 
maven.repo.local=D:\a\maven-gpg-plugin\maven-gpg-plugin\target\local-repo -s 
D:\a\maven-gpg-plugin\maven-gpg-plugin\target\test-classes\it\settings.xml -D 
gpg.homedir=D:\a\maven-gpg-plugin\maven-gpg-plugin\target\test-classes\gnupg 
clean install"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2023-05-21 Thread Tilman Hausherr (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724638#comment-17724638
 ] 

Tilman Hausherr commented on MENFORCER-393:
---

The problem I mentioned in January 2022 no longer happens with 3.3.0.

> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories 
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Assignee: Slawomir Jaranowski
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an 
> error like 
> {code:java}
> Could not build dependency tree Could not collect dependencies: 
> {jarname}{code}
> happens.
>  
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the 
> output) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MENFORCER-479) Version enforcer rules print single versions when a range is expected

2023-05-21 Thread Elliotte Rusty Harold (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724637#comment-17724637
 ] 

Elliotte Rusty Harold commented on MENFORCER-479:
-

Haven't personally verified this, but assuming the messages are now of the form 
`is not in the allowed range [3.10.1,).` instead of `is not in the allowed 
range 3.10.1.` this is better and at least not wrong.

It would still be better to provide a clearer message here like "Version: 3.9.1 
is less than the minimum version 3.10.1."


> Version enforcer rules print single versions when a range is expected
> -
>
> Key: MENFORCER-479
> URL: https://issues.apache.org/jira/browse/MENFORCER-479
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Rule API
>Reporter: Elliotte Rusty Harold
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> AbstractStandardEnforcerRule incorrectly assumes that the toString method of 
> a VersionRange will be a version range. However it can be just a single 
> version rather than the entire range. E.g. 3.8.4 instead [3.8.0, 3.9)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-gpg-plugin] dependabot[bot] closed pull request #49: Bump maven-resolver-util from 1.4.1 to 1.9.10

2023-05-21 Thread via GitHub



dependabot[bot] closed pull request #49: Bump maven-resolver-util from 1.4.1 to 
1.9.10
URL: https://github.com/apache/maven-gpg-plugin/pull/49


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-gpg-plugin] dependabot[bot] commented on pull request #49: Bump maven-resolver-util from 1.4.1 to 1.9.10

2023-05-21 Thread via GitHub



dependabot[bot] commented on PR #49:
URL: https://github.com/apache/maven-gpg-plugin/pull/49#issuecomment-1556161642

   Looks like org.apache.maven.resolver:maven-resolver-util is no longer 
updatable, so this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-checkstyle-plugin] elharo commented on pull request #119: remove unnecessary I/O indirections

2023-05-21 Thread via GitHub



elharo commented on PR #119:
URL: 
https://github.com/apache/maven-checkstyle-plugin/pull/119#issuecomment-1556160776

   If you build with Maven, which this project does, they are. Possibly 
getBaseDir might be more useful if a project were setup using ant or something 
else that didn't follow Maven's source layout conventions. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MENFORCER-393:
-

Assignee: Slawomir Jaranowski

> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories 
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Assignee: Slawomir Jaranowski
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an 
> error like 
> {code:java}
> Could not build dependency tree Could not collect dependencies: 
> {jarname}{code}
> happens.
>  
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the 
> output) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2023-05-21 Thread Slawomir Jaranowski (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724635#comment-17724635
 ] 

Slawomir Jaranowski commented on MENFORCER-393:
---

I added {{org.jruby:jruby-stdlib}} to IT - and looks like test pass.

Please retest with 3.3.0 version

> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories 
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an 
> error like 
> {code:java}
> Could not build dependency tree Could not collect dependencies: 
> {jarname}{code}
> happens.
>  
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the 
> output) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724634#comment-17724634
 ] 

ASF GitHub Bot commented on MENFORCER-393:
--

slawekjaranowski opened a new pull request, #271:
URL: https://github.com/apache/maven-enforcer/pull/271

   
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MENFORCER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MENFORCER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories 
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an 
> error like 
> {code:java}
> Could not build dependency tree Could not collect dependencies: 
> {jarname}{code}
> happens.
>  
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the 
> output) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #271: [MENFORCER-393] Extend IT for dependencyConvergence and no standard protocol in repository

2023-05-21 Thread via GitHub



slawekjaranowski opened a new pull request, #271:
URL: https://github.com/apache/maven-enforcer/pull/271

   
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MENFORCER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MENFORCER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MDEP-868) maven-shared-utils to 3.4.2

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MDEP-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724632#comment-17724632
 ] 

ASF GitHub Bot commented on MDEP-868:
-

elharo merged PR #322:
URL: https://github.com/apache/maven-dependency-plugin/pull/322




> maven-shared-utils to 3.4.2
> ---
>
> Key: MDEP-868
> URL: https://issues.apache.org/jira/browse/MDEP-868
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MDEP-869) commons-collections to 4.4

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MDEP-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724631#comment-17724631
 ] 

ASF GitHub Bot commented on MDEP-869:
-

elharo merged PR #324:
URL: https://github.com/apache/maven-dependency-plugin/pull/324




> commons-collections to 4.4
> --
>
> Key: MDEP-869
> URL: https://issues.apache.org/jira/browse/MDEP-869
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-dependency-plugin] elharo merged pull request #324: [MDEP-869] update commons-collections to 4.4

2023-05-21 Thread via GitHub



elharo merged PR #324:
URL: https://github.com/apache/maven-dependency-plugin/pull/324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MENFORCER-393) Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories some unknown protocol

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MENFORCER-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MENFORCER-393:
--
Component/s: dependencyConvergence

> Upgrading to 3.0.0 causes `Could not build dependency tree` with repositories 
> some unknown protocol
> ---
>
> Key: MENFORCER-393
> URL: https://issues.apache.org/jira/browse/MENFORCER-393
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: dependencyConvergence, Plugin
>Affects Versions: 3.0.0
>Reporter: johnny willer gasperi goncalves
>Priority: Major
> Attachments: enforcer_output
>
>
> After upgrading to 3.0.0, it's not possible to validate the POM anymore, an 
> error like 
> {code:java}
> Could not build dependency tree Could not collect dependencies: 
> {jarname}{code}
> happens.
>  
> I'm attaching the `mvn validate -X` dump (i have omitted some jars from the 
> output) 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MENFORCER-479) Version enforcer rules print single versions when a range is expected

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MENFORCER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MENFORCER-479:
--
Fix Version/s: waiting-for-feedback

> Version enforcer rules print single versions when a range is expected
> -
>
> Key: MENFORCER-479
> URL: https://issues.apache.org/jira/browse/MENFORCER-479
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Rule API
>Reporter: Elliotte Rusty Harold
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> AbstractStandardEnforcerRule incorrectly assumes that the toString method of 
> a VersionRange will be a version range. However it can be just a single 
> version rather than the entire range. E.g. 3.8.4 instead [3.8.0, 3.9)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MENFORCER-482) enforcer:enforce is unable to find rules but works when installing

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MENFORCER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MENFORCER-482:
--
Fix Version/s: wontfix-candidate

> enforcer:enforce is unable to find rules but works when installing
> --
>
> Key: MENFORCER-482
> URL: https://issues.apache.org/jira/browse/MENFORCER-482
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.3.0
>Reporter: Javier A. Ortiz
>Priority: Major
> Fix For: wontfix-candidate
>
>
> I have a normal project configured as follows:
> {code:java}
> 
>         org.apache.maven.plugins
>         maven-enforcer-plugin
>3.3.0
>         
>           
>             enforce-versions
>             
>               enforce
>             
>             
>               
>                 
>                 
>                   [3.9.0,)
>                 
>                 
>                   11
>                 
>               
>             
>           
>         
>       {code}
> Running _mvn install_ runs the plugin as expected but doing mvn 
> enforcer:enforce leads to:
> {code}
> Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (default-cli) on 
> project p14c-api-tests: No rules are configured. Use the skip flag if you 
> want to disable execution. -> [Help 1]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MENFORCER-479) Version enforcer rules print single versions when a range is expected

2023-05-21 Thread Slawomir Jaranowski (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724625#comment-17724625
 ] 

Slawomir Jaranowski commented on MENFORCER-479:
---

[~elharo] - does your issue with message was resolved? If no what is your 
proposition?

> Version enforcer rules print single versions when a range is expected
> -
>
> Key: MENFORCER-479
> URL: https://issues.apache.org/jira/browse/MENFORCER-479
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Rule API
>Reporter: Elliotte Rusty Harold
>Priority: Major
>
> AbstractStandardEnforcerRule incorrectly assumes that the toString method of 
> a VersionRange will be a version range. However it can be just a single 
> version rather than the entire range. E.g. 3.8.4 instead [3.8.0, 3.9)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MENFORCER-482) enforcer:enforce is unable to find rules but works when installing

2023-05-21 Thread Slawomir Jaranowski (Jira)



[ 
https://issues.apache.org/jira/browse/MENFORCER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724624#comment-17724624
 ] 

Slawomir Jaranowski commented on MENFORCER-482:
---

Your example has not connection with enforcer plugin, simply it is Maven 
specific.

You can have configuration in plugin/configuration or in 
plugin/executions/execution.
Maven configure plugin during execution - depends on where you put 
configuration and how you execute plugin by -  Maven phase build or by cli call.

Please read:

https://maven.apache.org/guides/mini/guide-configuring-plugins.html#configuring-build-plugins

> enforcer:enforce is unable to find rules but works when installing
> --
>
> Key: MENFORCER-482
> URL: https://issues.apache.org/jira/browse/MENFORCER-482
> Project: Maven Enforcer Plugin
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.3.0
>Reporter: Javier A. Ortiz
>Priority: Major
>
> I have a normal project configured as follows:
> {code:java}
> 
>         org.apache.maven.plugins
>         maven-enforcer-plugin
>3.3.0
>         
>           
>             enforce-versions
>             
>               enforce
>             
>             
>               
>                 
>                 
>                   [3.9.0,)
>                 
>                 
>                   11
>                 
>               
>             
>           
>         
>       {code}
> Running _mvn install_ runs the plugin as expected but doing mvn 
> enforcer:enforce leads to:
> {code}
> Failed to execute goal 
> org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (default-cli) on 
> project p14c-api-tests: No rules are configured. Use the skip flag if you 
> want to disable execution. -> [Help 1]
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWAR-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724617#comment-17724617
 ] 

ASF GitHub Bot commented on MWAR-463:
-

slawekjaranowski opened a new pull request, #50:
URL: https://github.com/apache/maven-war-plugin/pull/50

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWAR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MWAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MWAR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   




> Upgrade Parent to 39
> 
>
> Key: MWAR-463
> URL: https://issues.apache.org/jira/browse/MWAR-463
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-war-plugin] slawekjaranowski opened a new pull request, #50: [MWAR-463] Upgrade Parent to 39

2023-05-21 Thread via GitHub



slawekjaranowski opened a new pull request, #50:
URL: https://github.com/apache/maven-war-plugin/pull/50

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWAR) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MWAR-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MWAR-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MWAR-458) Update maven-filtering to version 3.3.1

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWAR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724611#comment-17724611
 ] 

ASF GitHub Bot commented on MWAR-458:
-

slawekjaranowski merged PR #46:
URL: https://github.com/apache/maven-war-plugin/pull/46




> Update maven-filtering to version 3.3.1
> ---
>
> Key: MWAR-458
> URL: https://issues.apache.org/jira/browse/MWAR-458
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MWAR-458) Update maven-filtering to version 3.3.1

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MWAR-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MWAR-458:
-
Summary: Update maven-filtering to version 3.3.1  (was: Update 
maven-filtering to version 3.3.0)

> Update maven-filtering to version 3.3.1
> ---
>
> Key: MWAR-458
> URL: https://issues.apache.org/jira/browse/MWAR-458
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread Slawomir Jaranowski (Jira)

Slawomir Jaranowski created MWAR-463:


 Summary: Upgrade Parent to 39
 Key: MWAR-463
 URL: https://issues.apache.org/jira/browse/MWAR-463
 Project: Maven WAR Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MWAR-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MWAR-463:


Assignee: Slawomir Jaranowski

> Upgrade Parent to 39
> 
>
> Key: MWAR-463
> URL: https://issues.apache.org/jira/browse/MWAR-463
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MWAR-463) Upgrade Parent to 39

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MWAR-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MWAR-463:
-
Fix Version/s: 3.4.0

> Upgrade Parent to 39
> 
>
> Key: MWAR-463
> URL: https://issues.apache.org/jira/browse/MWAR-463
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven-war-plugin] dependabot[bot] commented on pull request #40: Bump maven-plugins from 36 to 39

2023-05-21 Thread via GitHub



dependabot[bot] commented on PR #40:
URL: https://github.com/apache/maven-war-plugin/pull/40#issuecomment-1556139482

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Closed] (MWAR-462) Bump plexus-utils from 3.3.0 to 3.5.1

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MWAR-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MWAR-462.

Resolution: Fixed

> Bump plexus-utils from 3.3.0 to 3.5.1
> -
>
> Key: MWAR-462
> URL: https://issues.apache.org/jira/browse/MWAR-462
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MWAR-462) Bump plexus-utils from 3.3.0 to 3.5.1

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MWAR-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724609#comment-17724609
 ] 

ASF GitHub Bot commented on MWAR-462:
-

slawekjaranowski merged PR #37:
URL: https://github.com/apache/maven-war-plugin/pull/37




> Bump plexus-utils from 3.3.0 to 3.5.1
> -
>
> Key: MWAR-462
> URL: https://issues.apache.org/jira/browse/MWAR-462
> Project: Maven WAR Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (MWAR-462) Bump plexus-utils from 3.3.0 to 3.5.1

2023-05-21 Thread Slawomir Jaranowski (Jira)

Slawomir Jaranowski created MWAR-462:


 Summary: Bump plexus-utils from 3.3.0 to 3.5.1
 Key: MWAR-462
 URL: https://issues.apache.org/jira/browse/MWAR-462
 Project: Maven WAR Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.4.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MPMD-379) Support PMD 7.0.0

2023-05-21 Thread Michael Osipov (Jira)



[ 
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724606#comment-17724606
 ] 

Michael Osipov commented on MPMD-379:
-

I checked {{src/main/java/org/apache/maven/plugins/pmd/exec/Executor.java}}. 
Why is this entire logging pain necessary? I mean SLF4J logger and done. The 
rest is up to the client, no?

> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
>  Issue Type: Improvement
>  Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7 
> most likely means, that only PMD 7 will be supported onwards (no backwards 
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>  
> A snapshot version that is compatible with the current 7.0.0 release 
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
> 
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
> 
> false
> 
> 
> true
> 
>  {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724602#comment-17724602
 ] 

ASF GitHub Bot commented on MNG-7787:
-

rmannibucau commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556127323

   @slawekjaranowski a misconfiguration should be reported indeed, but the 
point is: why at each run? it is a static analyzis thing and should either be 
done at request (help:validate-project for ex) and then forgotten cause if user 
intend this usage (some deprecation have no replacement and are intended to be 
used temporarly). So for me we address a very good usage but with a wrong 
solution.




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MPOM-394) Upgrade Maven Project Info Reports Plugin to 3.4.3

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MPOM-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-394:
-
Issue Type: Dependency upgrade  (was: Task)

> Upgrade Maven Project Info Reports Plugin to 3.4.3
> --
>
> Key: MPOM-394
> URL: https://issues.apache.org/jira/browse/MPOM-394
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Herve Boutemy
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>
> to benefit from MPIR-429



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (MPOM-395) upgrade Maven Compiler Plugin to 3.11.0

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MPOM-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-395:
-
Issue Type: Dependency upgrade  (was: Task)

> upgrade Maven Compiler Plugin to 3.11.0
> ---
>
> Key: MPOM-395
> URL: https://issues.apache.org/jira/browse/MPOM-395
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Herve Boutemy
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [maven] rmannibucau commented on pull request #1116: [MNG-7787] Introduce new options for plugin validation report

2023-05-21 Thread via GitHub



rmannibucau commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556127323

   @slawekjaranowski a misconfiguration should be reported indeed, but the 
point is: why at each run? it is a static analyzis thing and should either be 
done at request (help:validate-project for ex) and then forgotten cause if user 
intend this usage (some deprecation have no replacement and are intended to be 
used temporarly). So for me we address a very good usage but with a wrong 
solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (MPOM-396) upgrade Maven Assembly Plugin to 3.6.0

2023-05-21 Thread Slawomir Jaranowski (Jira)



 [ 
https://issues.apache.org/jira/browse/MPOM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MPOM-396:
-
Issue Type: Dependency upgrade  (was: Task)

> upgrade Maven Assembly Plugin to 3.6.0
> --
>
> Key: MPOM-396
> URL: https://issues.apache.org/jira/browse/MPOM-396
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Affects Versions: ASF-29
>Reporter: Herve Boutemy
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-30
>
>
> to benefit from MASSEMBLY-941



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724601#comment-17724601
 ] 

ASF GitHub Bot commented on MNG-7787:
-

slawekjaranowski commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556124874

   @rmannibucau - I agree if user can not do anything with some of issue such 
warning should be minimized
   
   But do you also want to hide eg when user use parameter of plugin which is 
not exist? 
   In such case user can and should do something.
   




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724598#comment-17724598
 ] 

ASF GitHub Bot commented on MNG-7787:
-

rmannibucau commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556116622

   @slawekjaranowski basic user interaction rule is to not show anything user 
dont care or cant do anything to fix it so it is fully inacurrate as of today, 
we'd better helo plugin dev with a live checker (ci/cd) and users with help 
plugin. Doing it at build time with maven does not reach original goal nor is 
relzvant since new versions will await user adoption (too late by design).
   Let s provide the right tool and not bother users (n) instead lf dev (1).




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (MNG-7787) Introduce new options for plugin validation

2023-05-21 Thread ASF GitHub Bot (Jira)



[ 
https://issues.apache.org/jira/browse/MNG-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724597#comment-17724597
 ] 

ASF GitHub Bot commented on MNG-7787:
-

slawekjaranowski commented on PR #1116:
URL: https://github.com/apache/maven/pull/1116#issuecomment-1556115743

   -1 for me for
   
   As I wrote on ML - we have two group of issues 
   - wrong using of plugin, like deprecated, not existed parameters 
   - and wrong implementation of inside plugin
   
   We should not hide problems which user should fix in theirs projects.
   
   I can agree to less talkative about wrong plugin implementations - but I 
think that is useful.
   




> Introduce new options for plugin validation
> ---
>
> Key: MNG-7787
> URL: https://issues.apache.org/jira/browse/MNG-7787
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.9.2
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.3, 4.0.0-alpha-6, 4.0.0
>
>
> Currently we offer following values for maven.plugin.validation:
>  * BRIEF - emits one liner WARN with count of plugins having validation 
> issues (IF count > 0)
>  * DEFAULT - emits one line for each plugin GAV having validation issues
>  * VERBOSE - emits detailed report for each plugin (declaration, use and 
> problems) for each plugin having validation issue
> We should introduce more:
>  * NONE - mute validation (usable on CI where plethora of WARNING lines could 
> lead to falsely detect build as unhealthy)
>  * INLINE - produce validation WARNs inline, as 3.9.1 did
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

56 matches

Mail list logo