Re: [PR] Batch update to plugin [maven-invoker-plugin]
slawekjaranowski commented on code in PR #207: URL: https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1438496545 ## pom.xml: ## @@ -62,12 +62,13 @@ under the License. 8 -3.2.5 +3.2.5 +3.9.6 Review Comment: I'm not still sure about such way. We open way to use newer API/methods in plugin which can be only detected in runtime. I'm for switch to 3.6.3 as minimal and in dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Batch update to plugin [maven-invoker-plugin]
slawekjaranowski commented on code in PR #207: URL: https://github.com/apache/maven-invoker-plugin/pull/207#discussion_r1438493924 ## pom.xml: ## @@ -369,6 +389,16 @@ under the License. + +org.apache.maven.plugins +maven-compiler-plugin + + none + +-Xlint:deprecation + Review Comment: We have a param `showDeprecation` for m-compiler-p -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRESOLVER-458) Update to Maven 4.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MRESOLVER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MRESOLVER-458. - Resolution: Fixed > Update to Maven 4.0.0-alpha-10 > -- > > Key: MRESOLVER-458 > URL: https://issues.apache.org/jira/browse/MRESOLVER-458 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-458) Update to Maven 4.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MRESOLVER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801266#comment-17801266 ] ASF GitHub Bot commented on MRESOLVER-458: -- cstamas merged PR #399: URL: https://github.com/apache/maven-resolver/pull/399 > Update to Maven 4.0.0-alpha-10 > -- > > Key: MRESOLVER-458 > URL: https://issues.apache.org/jira/browse/MRESOLVER-458 > Project: Maven Resolver > Issue Type: Dependency upgrade > Components: Resolver >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 2.0.0, 2.0.0-alpha-6 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-458] Update to Maven 4.0.0-alpha-10 [maven-resolver]
cstamas merged PR #399: URL: https://github.com/apache/maven-resolver/pull/399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #361: URL: https://github.com/apache/maven-dependency-plugin/pull/361 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.17.1 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's releases. jsoup Java HTML Parser release 1.17.2 Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an extraneous CData section added, causing script execution errors. Now, the data content is emitted in a HTML/XML/XHTML polyglot format, if the data is not already within a CData section. https://redirect.github.com/jhy/jsoup/issues/2078;>2078 Thread safety: The :has evaluator held a non-thread-safe Iterator, and so if an Evaluator object was shared across multiple concurrent threads, a NoSuchElement exception may be thrown, and the selected results may be incorrect. Now, the iterator object is a thread-local. https://redirect.github.com/jhy/jsoup/issues/2088;>2088 Changelog Sourced from https://github.com/jhy/jsoup/blob/master/CHANGES.md;>org.jsoup:jsoup's changelog. 1.17.2 (2023-Dec-29) Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an extraneous CData section added, causing
[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801262#comment-17801262 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872333258 @slachiewicz I have added a temporary fix. This requires https://github.com/apache/maven-doxia/pull/187 to be merged first. > Upgrade htmlunit 2.x to 3.9 > --- > > Key: DOXIASITETOOLS-321 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: version-next > > > https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPMD-379) Support PMD 7.0.0
[
https://issues.apache.org/jira/browse/MPMD-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801261#comment-17801261
]
Charles Honton commented on MPMD-379:
-
[PMD
7.0.0-rc4|https://repo1.maven.org/maven2/net/sourceforge/pmd/pmd/7.0.0-rc4/]
has been
[released|https://docs.pmd-code.org/pmd-doc-7.0.0-rc4/pmd_release_notes_pmd7.html].
Is anything blocking release of this support?
(I really want to get onto Java21)
> Support PMD 7.0.0
> -
>
> Key: MPMD-379
> URL: https://issues.apache.org/jira/browse/MPMD-379
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: CPD, PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> Add support for the new major version of PMD.
> This has some non-backward compatible changes. Upgrading m-pmd-p to PMD 7
> most likely means, that only PMD 7 will be supported onwards (no backwards
> compatibility supported).
> wip branch: [https://github.com/apache/maven-pmd-plugin/compare/master...pmd7]
>
> A snapshot version that is compatible with the current 7.0.0 release
> candidates is available here as version {*}3.21.1-pmd-7-SNAPSHOT{*}:
> {code:java}
>
> apache.snapshots
> Apache Snapshot Repository
> https://repository.apache.org/snapshots
>
> false
>
>
> true
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872333258 @slachiewicz I have added a temporary fix. This requires https://github.com/apache/maven-doxia/pull/187 to be merged first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801259#comment-17801259
]
ASF GitHub Bot commented on DOXIA-716:
--
michael-o opened a new pull request, #187:
URL: https://github.com/apache/maven-doxia/pull/187
This closes #187
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-716) Update and unify XMLReader creation/configuration
Michael Osipov created DOXIA-716:
Summary: Update and unify XMLReader creation/configuration
Key: DOXIA-716
URL: https://issues.apache.org/jira/browse/DOXIA-716
Project: Maven Doxia
Issue Type: Improvement
Components: Core
Affects Versions: 2.0.0-M8
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0-M9
* {{XMLReaderFactory}} is deprecated from Java 9
* Force XML Schema as main language if both DTD and XSD are provided
* Force {{Locale#ROOT}} for portability
* Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-716:
-
Summary: Update and unify XMLReader creation and configuration (was:
Update and unify XMLReader creation/configuration)
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (DOXIA-714) MarkdownSink: Fix table justification and figures
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIA-714. --- Fix Version/s: 2.0.0 2.0.0-M9 Resolution: Fixed Fixed in https://github.com/apache/maven-doxia/commit/7fc56190e58715022c9b3967e79517d387ac9b27. > MarkdownSink: Fix table justification and figures > - > > Key: DOXIA-714 > URL: https://issues.apache.org/jira/browse/DOXIA-714 > Project: Maven Doxia > Issue Type: Bug > Components: Module - Markdown >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0, 2.0.0-M9 > > > Table justification is currently not implemented at all (i.e. all table > columns have default alignment) and figures are using the XHTML markup > instead of the native Markdown markup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801253#comment-17801253 ] ASF GitHub Bot commented on DOXIA-714: -- kwin merged PR #185: URL: https://github.com/apache/maven-doxia/pull/185 > MarkdownSink: Fix table justification and figures > - > > Key: DOXIA-714 > URL: https://issues.apache.org/jira/browse/DOXIA-714 > Project: Maven Doxia > Issue Type: Bug > Components: Module - Markdown >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Table justification is currently not implemented at all (i.e. all table > columns have default alignment) and figures are using the XHTML markup > instead of the native Markdown markup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin merged PR #185: URL: https://github.com/apache/maven-doxia/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801252#comment-17801252
]
ASF GitHub Bot commented on DOXIA-714:
--
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438393908
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This content of this buffer is already escaped. */
Review Comment:
The content...
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438393908
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This content of this buffer is already escaped. */
Review Comment:
The content...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_() when using both and
[
https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801251#comment-17801251
]
ASF GitHub Bot commented on DOXIA-699:
--
kwin commented on PR #152:
URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1872305375
Superseded by #162.
> Xhtml5Parser may emit sectionX() without sectionX_() when using both and
>
> ---
>
> Key: DOXIA-699
> URL: https://issues.apache.org/jira/browse/DOXIA-699
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M5
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M9
>
> Attachments: test.xhtml5
>
>
> Due to the logic in
> https://github.com/apache/maven-doxia/blob/37173794270ee68894aac0e252dcb87545770952/doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java#L631
> there may calls of {{Sink.sectionX()}} without the according call of
> {{Sink.sectionX_()}}.
> The attached XHTML5 being parsed and then converted back through the Sink to
> XHTML5 is invalid (lacks one closing section tag).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-699) Xhtml5Parser may emit sectionX() without sectionX_() when using both and
[
https://issues.apache.org/jira/browse/DOXIA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801250#comment-17801250
]
ASF GitHub Bot commented on DOXIA-699:
--
kwin closed pull request #152: [DOXIA-699] Add failing test case
URL: https://github.com/apache/maven-doxia/pull/152
> Xhtml5Parser may emit sectionX() without sectionX_() when using both and
>
> ---
>
> Key: DOXIA-699
> URL: https://issues.apache.org/jira/browse/DOXIA-699
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M5
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M9
>
> Attachments: test.xhtml5
>
>
> Due to the logic in
> https://github.com/apache/maven-doxia/blob/37173794270ee68894aac0e252dcb87545770952/doxia-core/src/main/java/org/apache/maven/doxia/parser/Xhtml5BaseParser.java#L631
> there may calls of {{Sink.sectionX()}} without the according call of
> {{Sink.sectionX_()}}.
> The attached XHTML5 being parsed and then converted back through the Sink to
> XHTML5 is invalid (lacks one closing section tag).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-699] Add failing test case [maven-doxia]
kwin closed pull request #152: [DOXIA-699] Add failing test case URL: https://github.com/apache/maven-doxia/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIA-699] Add failing test case [maven-doxia]
kwin commented on PR #152: URL: https://github.com/apache/maven-doxia/pull/152#issuecomment-1872305375 Superseded by #162. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801249#comment-17801249
]
ASF GitHub Bot commented on DOXIA-714:
--
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438391211
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This value of this buffer is already escaped. */
Review Comment:
Fixed.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
Review Comment:
Fixed
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438391211
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This value of this buffer is already escaped. */
Review Comment:
Fixed.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved DOXIA-715.
---
Fix Version/s: 2.0.0
2.0.0-M9
Resolution: Fixed
Fixed in
https://github.com/apache/maven-doxia/commit/3bebd9b3407f3f3b6c4e883703ad57952a85fb67.
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M9
>
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801247#comment-17801247
]
ASF GitHub Bot commented on DOXIA-715:
--
kwin merged PR #186:
URL: https://github.com/apache/maven-doxia/pull/186
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-715] Consider attributes for text(...) in AptSink and [maven-doxia]
kwin merged PR #186: URL: https://github.com/apache/maven-doxia/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801242#comment-17801242
]
ASF GitHub Bot commented on DOXIASITETOOLS-321:
---
michael-o commented on PR #124:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872274339
Doxia is broken: `xmlReader =
XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");`
Let me fix/evaluate this before we continue...
> Upgrade htmlunit 2.x to 3.9
> ---
>
> Key: DOXIASITETOOLS-321
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Priority: Minor
> Fix For: version-next
>
>
> https://github.com/advisories/GHSA-3xrr-7m6p-p7xh
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]
michael-o commented on PR #124:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872274339
Doxia is broken: `xmlReader =
XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");`
Let me fix/evaluate this before we continue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801241#comment-17801241
]
ASF GitHub Bot commented on DOXIA-714:
--
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438369940
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Ok -> https://issues.apache.org/jira/browse/DOXIA-715
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438369940
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Ok -> https://issues.apache.org/jira/browse/DOXIA-715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801240#comment-17801240
]
ASF GitHub Bot commented on DOXIA-715:
--
kwin opened a new pull request, #186:
URL: https://github.com/apache/maven-doxia/pull/186
MarkdownSink
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-715:
--
Fix Version/s: (was: 2.0.0-M8)
(was: 2.0.0)
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M7
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-715:
--
Description:
All attributes passed as second argument to {{Sink.text(String,
SinkEventAttributes)}} are just silently disregarded in
*
https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
and
*
https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
Instead attributes like Semantics.STRONG should be supported also here (i.e.
its semantics should be similar to {{inline(SinkEventAttributes)}}
was:
All attributes passed as second argument to {{Sink.text(String,
SinkEventAttributes)}} are just silently disregarded in
https://github.com/apache/maven-doxia/blob/336a9a4030980809814783ce30197acc5f42c9a2/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1802.
Instead attributes like Semantics.STRONG should be supported also here (i.e.
its semantics should be similar to {{inline(SinkEventAttributes)}}
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M7
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 2.0.0-M8, 2.0.0
>
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
[
https://issues.apache.org/jira/browse/DOXIA-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated DOXIA-715:
--
Affects Version/s: 2.0.0-M8
(was: 2.0.0-M7)
> Sink.text(String, SinkEventAttributes) not properly supported by AptSink and
> MarkdownSink
> -
>
> Key: DOXIA-715
> URL: https://issues.apache.org/jira/browse/DOXIA-715
> Project: Maven Doxia
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> All attributes passed as second argument to {{Sink.text(String,
> SinkEventAttributes)}} are just silently disregarded in
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java#L810
> and
> *
> https://github.com/apache/maven-doxia/blob/ef41ffaa282ba5ff19548f09979bcc3febf0feaa/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java#L688
> Instead attributes like Semantics.STRONG should be supported also here (i.e.
> its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-715) Sink.text(String, SinkEventAttributes) not properly supported by AptSink and MarkdownSink
Konrad Windszus created DOXIA-715:
-
Summary: Sink.text(String, SinkEventAttributes) not properly
supported by AptSink and MarkdownSink
Key: DOXIA-715
URL: https://issues.apache.org/jira/browse/DOXIA-715
Project: Maven Doxia
Issue Type: Bug
Components: Core
Affects Versions: 2.0.0-M7
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: 2.0.0-M8, 2.0.0
All attributes passed as second argument to {{Sink.text(String,
SinkEventAttributes)}} are just silently disregarded in
https://github.com/apache/maven-doxia/blob/336a9a4030980809814783ce30197acc5f42c9a2/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1802.
Instead attributes like Semantics.STRONG should be supported also here (i.e.
its semantics should be similar to {{inline(SinkEventAttributes)}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801239#comment-17801239
]
ASF GitHub Bot commented on MPLUGIN-495:
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872263806
> Parameter list can be null ... we also need a fix like:
>
> ```diff
> -
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
michael-o commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872263806
> Parameter list can be null ... we also need a fix like:
>
> ```diff
> ---
a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
> +++
b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
> @@ -21,9 +21,11 @@ package org.apache.maven.plugins.plugin.descriptor;
> import java.io.Reader;
> import java.net.URI;
> import java.util.ArrayList;
> +import java.util.Collections;
> import java.util.LinkedHashMap;
> import java.util.List;
> import java.util.Map;
> +import java.util.Optional;
>
> import org.apache.maven.plugin.descriptor.MojoDescriptor;
> import org.apache.maven.plugin.descriptor.Parameter;
> @@ -87,7 +89,8 @@ public class EnhancedPluginDescriptorBuilder extends
PluginDescriptorBuilder {
>
> PlexusConfiguration[] parameterConfigurations =
c.getChild("parameters").getChildren("parameter");
>
> -List parameters = new
ArrayList<>(mojoDescriptor.getParameters());
> +List parameters = new ArrayList<>(
> +
Optional.ofNullable(mojoDescriptor.getParameters()).orElseGet(Collections::emptyList));
> Map parameterMap = new
LinkedHashMap<>(mojoDescriptor.getParameterMap());
>
> for (PlexusConfiguration d : parameterConfigurations) {
> @@ -108,7 +111,9 @@ public class EnhancedPluginDescriptorBuilder extends
PluginDescriptorBuilder {
> }
>
> // clear() is required for maven < 3.6.2
> -mojoDescriptor.getParameters().clear();
> +if (mojoDescriptor.getParameters() != null) {
> +mojoDescriptor.getParameters().clear();
> +}
> ```
Thanks, working on this.
I consider
`org.apache.maven.plugin.descriptor.MojoDescriptor.setParameters(List)`
to be misdesigned. This method uses `#addParameter()` instead of replacing the
entire list. Or the method should be
`org.apache.maven.plugin.descriptor.MojoDescriptor.addParameters(List)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872256364 @slawekjaranowski This is fantastic work, **thank you**. Your change must go with the upgrade of MPLUGIN with every modified plugin as well as this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801236#comment-17801236
]
ASF GitHub Bot commented on DOXIA-714:
--
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360736
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Shouldn't this be separate then?
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801237#comment-17801237
]
ASF GitHub Bot commented on DOXIA-714:
--
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360834
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
Alright, let's leave as-is.
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360834
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
Alright, let's leave as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438360736
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Shouldn't this be separate then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801234#comment-17801234
]
ASF GitHub Bot commented on DOXIA-714:
--
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438356143
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
This is just what is emitted currently for the newly added test in the
`AbstractParserTest`. Fixing the output should be done separately if you
consider it wrong.
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438356143
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
This is just what is emitted currently for the newly added test in the
`AbstractParserTest`. Fixing the output should be done separately if you
consider it wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801233#comment-17801233
]
ASF GitHub Bot commented on DOXIA-714:
--
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438355892
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Yes, similar to https://issues.apache.org/jira/browse/DOXIA-706
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438355892
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
attributes) {
} else {
content(text);
}
+if (attributes != null) {
+inline_();
+}
Review Comment:
Yes, similar to https://issues.apache.org/jira/browse/DOXIA-706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r143838
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
Review Comment:
No, sorry, too much effort for just fixing a glitch in a test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801232#comment-17801232
]
ASF GitHub Bot commented on DOXIA-714:
--
kwin commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r143838
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
Review Comment:
No, sorry, too much effort for just fixing a glitch in a test class.
> MarkdownSink: Fix table justification and figures
> -
>
> Key: DOXIA-714
> URL: https://issues.apache.org/jira/browse/DOXIA-714
> Project: Maven Doxia
> Issue Type: Bug
> Components: Module - Markdown
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Table justification is currently not implemented at all (i.e. all table
> columns have default alignment) and figures are using the XHTML markup
> instead of the native Markdown markup.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801231#comment-17801231 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872244289 Checking... > Upgrade htmlunit 2.x to 3.9 > --- > > Key: DOXIASITETOOLS-321 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: version-next > > > https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1872244289 Checking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[
https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801230#comment-17801230
]
ASF GitHub Bot commented on DOXIA-714:
--
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438352084
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
+}
+}
+
+/**
+ * Checks that the sequence [table(),
+ * tableRows(Sink.JUSTIFY_CENTER, false), tableRow(), tableCell(),
+ * text(cell), tableCell_(), tableRow_(), tableRows_(), tableCaption(),
+ * text(caption), tableCaption_(), table_()],
+ * invoked on the current sink, produces the same result as
+ * {@link #getTableBlock getTableBlock}(cell, caption).
+ */
+@Test
+public void testTableWithHeader() {
+int[] justify = {Sink.JUSTIFY_LEFT, Sink.JUSTIFY_RIGHT,
Sink.JUSTIFY_CENTER};
+sink.table();
+sink.tableRows(justify, false);
+try (IntStream cellStream = getCellStreamForNewRow(3)) {
+cellStream.forEach(col -> {
+sink.tableHeaderCell();
+sink.text("header" + col);
Review Comment:
`"header"` should end with an underscope, just like the rows.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
private boolean tableCellFlag;
+/** tableRowHeaderFlag, set to true for table rows containing at least one
table header cell */
+private boolean tableHeaderCellFlag;
+
/** headerFlag. */
private boolean headerFlag;
-/** bufferFlag. */
+/** bufferFlag, set to true in certain elements to prevent direct writing
during {@link #text(String, SinkEventAttributes)} */
Review Comment:
Same here
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
Review Comment:
Can you move these to a separate PR? Good catch, BTW.
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
That border attribute should already be code by now. Is it still emitted? It
is deprecated and one should use CSS.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This value of this buffer is already escaped. */
Review Comment:
The content of this buffer...
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
private boolean tableCellFlag;
+/** tableRowHeaderFlag, set to true for table rows containing at least one
table header cell */
Review Comment:
Same here
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header)
Re: [PR] [DOXIA-714] Emit proper markdown for table alignment and figures [maven-doxia]
michael-o commented on code in PR #185:
URL: https://github.com/apache/maven-doxia/pull/185#discussion_r1438352084
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
+}
+}
+
+/**
+ * Checks that the sequence [table(),
+ * tableRows(Sink.JUSTIFY_CENTER, false), tableRow(), tableCell(),
+ * text(cell), tableCell_(), tableRow_(), tableRows_(), tableCaption(),
+ * text(caption), tableCaption_(), table_()],
+ * invoked on the current sink, produces the same result as
+ * {@link #getTableBlock getTableBlock}(cell, caption).
+ */
+@Test
+public void testTableWithHeader() {
+int[] justify = {Sink.JUSTIFY_LEFT, Sink.JUSTIFY_RIGHT,
Sink.JUSTIFY_CENTER};
+sink.table();
+sink.tableRows(justify, false);
+try (IntStream cellStream = getCellStreamForNewRow(3)) {
+cellStream.forEach(col -> {
+sink.tableHeaderCell();
+sink.text("header" + col);
Review Comment:
`"header"` should end with an underscope, just like the rows.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
private boolean tableCellFlag;
+/** tableRowHeaderFlag, set to true for table rows containing at least one
table header cell */
+private boolean tableHeaderCellFlag;
+
/** headerFlag. */
private boolean headerFlag;
-/** bufferFlag. */
+/** bufferFlag, set to true in certain elements to prevent direct writing
during {@link #text(String, SinkEventAttributes)} */
Review Comment:
Same here
##
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java:
##
@@ -644,10 +645,65 @@ public void testTable() {
if (isXmlSink()) {
assertThat(wrapXml(actual), isIdenticalTo(wrapXml(expected)));
} else {
-assertEquals(actual, expected);
+assertEquals(expected, actual);
Review Comment:
Can you move these to a separate PR? Good catch, BTW.
##
doxia-modules/doxia-module-xdoc/src/test/java/org/apache/maven/doxia/module/xdoc/XdocSinkTest.java:
##
@@ -208,6 +208,19 @@ protected String getTableBlock(String cell, String
caption) {
+ "";
}
+@Override
+protected String getTableWithHeaderBlock(String... rowPrefixes) {
+return "\n\n" + rowPrefixes[0] +
"0\n" + rowPrefixes[0] + "1\n"
Review Comment:
That border attribute should already be code by now. Is it still emitted? It
is deprecated and one should use CSS.
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -45,12 +48,9 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
// Instance fields
// --
-/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. This value of this buffer is already escaped. */
Review Comment:
The content of this buffer...
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
private boolean tableCellFlag;
+/** tableRowHeaderFlag, set to true for table rows containing at least one
table header cell */
Review Comment:
Same here
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -69,24 +69,21 @@ public class MarkdownSink extends AbstractTextSink
implements MarkdownMarkup {
/** tableCaptionFlag. */
private boolean tableCaptionFlag;
-/** tableCellFlag. */
+/** tableCellFlag, set to true inside table (header) cells */
Review Comment:
`{@code true}`
##
doxia-modules/doxia-module-apt/src/main/java/org/apache/maven/doxia/module/apt/AptSink.java:
##
@@ -817,6 +820,9 @@ public void text(String text, SinkEventAttributes
[PR] Extend info about cleanups after retirement [maven-site]
slawekjaranowski opened a new pull request, #481: URL: https://github.com/apache/maven-site/pull/481 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-714) MarkdownSink: Fix table justification and figures
[ https://issues.apache.org/jira/browse/DOXIA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801192#comment-17801192 ] ASF GitHub Bot commented on DOXIA-714: -- kwin opened a new pull request, #185: URL: https://github.com/apache/maven-doxia/pull/185 Fix markup for inline styles for "em" and "strong" > MarkdownSink: Fix table justification and figures > - > > Key: DOXIA-714 > URL: https://issues.apache.org/jira/browse/DOXIA-714 > Project: Maven Doxia > Issue Type: Bug > Components: Module - Markdown >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Table justification is currently not implemented at all (i.e. all table > columns have default alignment) and figures are using the XHTML markup > instead of the native Markdown markup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file
[ https://issues.apache.org/jira/browse/MINDEXER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-214. Resolution: Fixed > ArtifactContext should not log warnings if artifact is not zip file > --- > > Key: MINDEXER-214 > URL: https://issues.apache.org/jira/browse/MINDEXER-214 > Project: Maven Indexer > Issue Type: Bug >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > > It should merely just silently skip it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file
[ https://issues.apache.org/jira/browse/MINDEXER-214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-214: Assignee: Tamas Cservenak > ArtifactContext should not log warnings if artifact is not zip file > --- > > Key: MINDEXER-214 > URL: https://issues.apache.org/jira/browse/MINDEXER-214 > Project: Maven Indexer > Issue Type: Bug >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > > It should merely just silently skip it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] ArtifactContext should not log warnings if artifacts are no zip files. [maven-indexer]
cstamas merged PR #347: URL: https://github.com/apache/maven-indexer/pull/347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-213) Update Lucene to 9.9.1
[ https://issues.apache.org/jira/browse/MINDEXER-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-213: Assignee: Tamas Cservenak > Update Lucene to 9.9.1 > -- > > Key: MINDEXER-213 > URL: https://issues.apache.org/jira/browse/MINDEXER-213 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-213) Update Lucene to 9.9.1
[ https://issues.apache.org/jira/browse/MINDEXER-213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-213. Resolution: Fixed > Update Lucene to 9.9.1 > -- > > Key: MINDEXER-213 > URL: https://issues.apache.org/jira/browse/MINDEXER-213 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MINDEXER-212) Update jsoup to 1.17.2
[ https://issues.apache.org/jira/browse/MINDEXER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MINDEXER-212. Resolution: Fixed > Update jsoup to 1.17.2 > -- > > Key: MINDEXER-212 > URL: https://issues.apache.org/jira/browse/MINDEXER-212 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump lucene.version from 9.9.0 to 9.9.1 [maven-indexer]
cstamas merged PR #348: URL: https://github.com/apache/maven-indexer/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-212) Update jsoup to 1.17.2
[ https://issues.apache.org/jira/browse/MINDEXER-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MINDEXER-212: Assignee: Tamas Cservenak > Update jsoup to 1.17.2 > -- > > Key: MINDEXER-212 > URL: https://issues.apache.org/jira/browse/MINDEXER-212 > Project: Maven Indexer > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 7.1.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-indexer]
cstamas merged PR #350: URL: https://github.com/apache/maven-indexer/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINDEXER-206) Search Backend SMO and RR handle different Artifact.extension
[ https://issues.apache.org/jira/browse/MINDEXER-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MINDEXER-206: - Fix Version/s: 7.1.3 (was: 7.1.2) > Search Backend SMO and RR handle different Artifact.extension > - > > Key: MINDEXER-206 > URL: https://issues.apache.org/jira/browse/MINDEXER-206 > Project: Maven Indexer > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 7.1.3 > > > The two backends should not force caller to construct Query differently, but > handle their own implementation specifics silently. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-214) ArtifactContext should not log warnings if artifact is not zip file
Tamas Cservenak created MINDEXER-214: Summary: ArtifactContext should not log warnings if artifact is not zip file Key: MINDEXER-214 URL: https://issues.apache.org/jira/browse/MINDEXER-214 Project: Maven Indexer Issue Type: Bug Reporter: Tamas Cservenak Fix For: 7.1.2 It should merely just silently skip it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-213) Update Lucene to 9.9.1
Tamas Cservenak created MINDEXER-213: Summary: Update Lucene to 9.9.1 Key: MINDEXER-213 URL: https://issues.apache.org/jira/browse/MINDEXER-213 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MINDEXER-212) Update jsoup to 1.17.2
Tamas Cservenak created MINDEXER-212: Summary: Update jsoup to 1.17.2 Key: MINDEXER-212 URL: https://issues.apache.org/jira/browse/MINDEXER-212 Project: Maven Indexer Issue Type: Dependency upgrade Reporter: Tamas Cservenak Fix For: 7.1.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #254: URL: https://github.com/apache/maven-plugin-tools/pull/254 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.17.1 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's releases. jsoup Java HTML Parser release 1.17.2 Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an extraneous CData section added, causing script execution errors. Now, the data content is emitted in a HTML/XML/XHTML polyglot format, if the data is not already within a CData section. https://redirect.github.com/jhy/jsoup/issues/2078;>2078 Thread safety: The :has evaluator held a non-thread-safe Iterator, and so if an Evaluator object was shared across multiple concurrent threads, a NoSuchElement exception may be thrown, and the selected results may be incorrect. Now, the iterator object is a thread-local. https://redirect.github.com/jhy/jsoup/issues/2088;>2088 Changelog Sourced from https://github.com/jhy/jsoup/blob/master/CHANGES.md;>org.jsoup:jsoup's changelog. 1.17.2 (2023-Dec-29) Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an extraneous CData section added, causing script
Re: [PR] ArtifactContext should not log warnings if artifacts are no zip files. [maven-indexer]
cstamas commented on code in PR #347:
URL: https://github.com/apache/maven-indexer/pull/347#discussion_r1438260247
##
indexer-core/src/main/java/org/apache/maven/index/ArtifactContext.java:
##
@@ -104,7 +107,11 @@ else if (getArtifact() != null && getArtifact().isFile()) {
}
}
} catch (IOException | XmlPullParserException e) {
-LOGGER.warn("skip error reading pom withing artifact:" +
artifact, e);
+if (e instanceof ZipException && !isZip) {
+// ZipFile constructor threw ZipException which means this
is no zip file -> ignore
+} else {
+LOGGER.warn("skip error reading pom withing artifact:" +
artifact, e);
Review Comment:
```suggestion
LOGGER.warn("skip error reading pom within artifact:" +
artifact, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801172#comment-17801172
]
ASF GitHub Bot commented on MPLUGIN-495:
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872082488
Parameter list can be null ... we also need a fix like:
```diff
-
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1872082488
Parameter list can be null ... we also need a fix like:
```diff
---
a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
+++
b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
@@ -21,9 +21,11 @@ package org.apache.maven.plugins.plugin.descriptor;
import java.io.Reader;
import java.net.URI;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
import org.apache.maven.plugin.descriptor.MojoDescriptor;
import org.apache.maven.plugin.descriptor.Parameter;
@@ -87,7 +89,8 @@ public class EnhancedPluginDescriptorBuilder extends
PluginDescriptorBuilder {
PlexusConfiguration[] parameterConfigurations =
c.getChild("parameters").getChildren("parameter");
-List parameters = new
ArrayList<>(mojoDescriptor.getParameters());
+List parameters = new ArrayList<>(
+
Optional.ofNullable(mojoDescriptor.getParameters()).orElseGet(Collections::emptyList));
Map parameterMap = new
LinkedHashMap<>(mojoDescriptor.getParameterMap());
for (PlexusConfiguration d : parameterConfigurations) {
@@ -108,7 +111,9 @@ public class EnhancedPluginDescriptorBuilder extends
PluginDescriptorBuilder {
}
// clear() is required for maven < 3.6.2
-mojoDescriptor.getParameters().clear();
+if (mojoDescriptor.getParameters() != null) {
+mojoDescriptor.getParameters().clear();
+}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872079561 Unit test pass. Site build due to parameters list can be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre [maven-indexer]
cstamas commented on PR #349: URL: https://github.com/apache/maven-indexer/pull/349#issuecomment-1872076261 Am on hold with this one for now... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 [maven-dist-tool]
dependabot[bot] commented on PR #39: URL: https://github.com/apache/maven-dist-tool/pull/39#issuecomment-1872061053 Superseded by #48. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 [maven-dist-tool]
dependabot[bot] closed pull request #39: Bump org.jsoup:jsoup from 1.15.3 to 1.17.1 URL: https://github.com/apache/maven-dist-tool/pull/39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.jsoup:jsoup from 1.15.3 to 1.17.2 [maven-dist-tool]
dependabot[bot] opened a new pull request, #48: URL: https://github.com/apache/maven-dist-tool/pull/48 Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.15.3 to 1.17.2. Release notes Sourced from https://github.com/jhy/jsoup/releases;>org.jsoup:jsoup's releases. jsoup Java HTML Parser release 1.17.2 Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an extraneous CData section added, causing script execution errors. Now, the data content is emitted in a HTML/XML/XHTML polyglot format, if the data is not already within a CData section. https://redirect.github.com/jhy/jsoup/issues/2078;>2078 Thread safety: The :has evaluator held a non-thread-safe Iterator, and so if an Evaluator object was shared across multiple concurrent threads, a NoSuchElement exception may be thrown, and the selected results may be incorrect. Now, the iterator object is a thread-local. https://redirect.github.com/jhy/jsoup/issues/2088;>2088 jsoup 1.17.1 ... (truncated) Changelog Sourced from https://github.com/jhy/jsoup/blob/master/CHANGES.md;>org.jsoup:jsoup's changelog. 1.17.2 (2023-Dec-29) Improvements Attribute object accessors: Added Element.attribute(String) and Attributes.attribute(String) to more simply obtain an Attribute object. https://redirect.github.com/jhy/jsoup/issues/2069;>2069 Attribute source tracking: If source tracking is on, and an Attribute's key is changed ( via Attribute.setKey(String)), the source range is now still tracked in Attribute.sourceRange(). https://redirect.github.com/jhy/jsoup/issues/2070;>2070 Wildcard attribute selector: Added support for the [*] element with any attribute selector. And also restored support for selecting by an empty attribute name prefix ([^]). https://redirect.github.com/jhy/jsoup/issues/2079;>2079 Bug Fixes Mixed-cased source position: When tracking the source position of attributes, if the source attribute name was mix-cased but the parser was lower-case normalizing attribute names, the source position for that attribute was not tracked correctly. https://redirect.github.com/jhy/jsoup/issues/2067;>2067 Source position NPE: When tracking the source position of a body fragment parse, a null pointer exception was thrown. https://redirect.github.com/jhy/jsoup/issues/2068;>2068 Multi-point emoji entity: A multi-point encoded emoji entity may be incorrectly decoded to the replacement character. https://redirect.github.com/jhy/jsoup/issues/2074;>2074 Selector sub-expressions: (Regression) in a selector like parent [attr=va], other, the , OR was binding to [attr=va] instead of parent [attr=va], causing incorrect selections. The fix includes a EvaluatorDebug class that generates a sexpr to represent the query, allowing simpler and more thorough query parse tests. https://redirect.github.com/jhy/jsoup/issues/2073;>2073 XML CData output: When generating XML-syntax output from parsed HTML, script nodes containing (pseudo) CData sections would have an
[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801160#comment-17801160 ] Tamas Cservenak commented on MNG-7976: -- Just look at CI history on master (gh)... > Investigate MNG-6127 IT instability > --- > > Key: MNG-7976 > URL: https://issues.apache.org/jira/browse/MNG-7976 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > The MNG-6127 IT quite often fails, and passes when CI job rebuilt, seems > unstable. > Look into it why (lurking concurrency bug somewhere? or just the IT is > flakey?) and fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801159#comment-17801159 ] Tamas Cservenak commented on MNG-7976: -- The related IT regularly fails, seems like something is unstable, maybe the IT or maybe the fix for it... > Investigate MNG-6127 IT instability > --- > > Key: MNG-7976 > URL: https://issues.apache.org/jira/browse/MNG-7976 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > The MNG-6127 IT quite often fails, and passes when CI job rebuilt, seems > unstable. > Look into it why (lurking concurrency bug somewhere? or just the IT is > flakey?) and fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801144#comment-17801144
]
ASF GitHub Bot commented on MPLUGIN-495:
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871973607
We can remove
`org.apache.maven.tools.plugin.util.PluginUtils#MAVEN_COMPONENTS`
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871973607 We can remove `org.apache.maven.tools.plugin.util.PluginUtils#MAVEN_COMPONENTS` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871964145 @michael-o @cstamas please look at my commit ... I fix one test by adding mock MavenProject and MavenSession as component in test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801137#comment-17801137
]
ASF GitHub Bot commented on MPLUGIN-495:
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871963058
https://github.com/apache/maven-dependency-plugin/pull/360
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-495) WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter
[
https://issues.apache.org/jira/browse/MPLUGIN-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801135#comment-17801135
]
ASF GitHub Bot commented on MPLUGIN-495:
slawekjaranowski commented on PR #253:
URL:
https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871962667
> > hm, nope, i assumed this PR fails to build
>
> It works, but not the subsequent use in tests. ITs do work, actually. So I
guessed that some dep is missing during tests.
Or unit test simply try to lookup Mojo without calling
`org.apache.maven.execution.scope.internal.MojoExecutionScope#enter`
> WARNINGs based on usage of @Component for MavenSession/MavenProject instead
> of @Parameter
> -
>
> Key: MPLUGIN-495
> URL: https://issues.apache.org/jira/browse/MPLUGIN-495
> Project: Maven Plugin Tools
> Issue Type: Improvement
>Affects Versions: 3.10.2
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: 3.11.0
>
>
> A change of parameters like this:
> {code:java}
> @Parameter(defaultValue = "${project}", readonly = true, required = true)
> {code}
> into:
> {code:java}
> @Component
> {code}
> This will result in WARNINGs like this:
> {code}
> Warning: Deprecated @Component annotation for 'session' field in
> org.apache.maven.plugins.dependency.GetMojo: replace with @Parameter(
> defaultValue = "${session}", readonly = true )
> {code}
> The shown deprecation message is wrong. It is fine to use that for components
> to be injected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871963058 https://github.com/apache/maven-dependency-plugin/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter [maven-plugin-tools]
slawekjaranowski commented on PR #253: URL: https://github.com/apache/maven-plugin-tools/pull/253#issuecomment-1871962667 > > hm, nope, i assumed this PR fails to build > > It works, but not the subsequent use in tests. ITs do work, actually. So I guessed that some dep is missing during tests. Or unit test simply try to lookup Mojo without calling `org.apache.maven.execution.scope.internal.MojoExecutionScope#enter` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871955789 > Unit tests still fail for me But executing ITs are ok ... Yes, that's the point. A misconfig or dep is missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use @Component only [maven-dependency-plugin]
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871946562 Unit tests still fail for me But executing ITs are ok ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-321) Upgrade htmlunit 2.x to 3.9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801122#comment-17801122 ] ASF GitHub Bot commented on DOXIASITETOOLS-321: --- michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871876782 > If I understand correctly, I'll remove here dependency to Xerces and then wait until it will not be needed by Doxia core. I cannot see where Doxia Core uses Xerces. Nekohtml did integrate it, something is fishy. > Upgrade htmlunit 2.x to 3.9 > --- > > Key: DOXIASITETOOLS-321 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-321 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: version-next > > > https://github.com/advisories/GHSA-3xrr-7m6p-p7xh -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-321] Upgrade htmlunit 2.x to 3.9 migration [maven-doxia-sitetools]
michael-o commented on PR #124: URL: https://github.com/apache/maven-doxia-sitetools/pull/124#issuecomment-1871876782 > If I understand correctly, I'll remove here dependency to Xerces and then wait until it will not be needed by Doxia core. I cannot see where Doxia Core uses Xerces. Nekohtml did integrate it, something is fishy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Use @Component only [maven-dependency-plugin]
michael-o opened a new pull request, #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360 This should depict the failing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
